1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 02:12:41 +01:00
phorge-phorge/src
epriestley f68d67530a Fix an issue with pulling Subversion blame data
Summary:
Fixes T4067. The way `DiffusionCommitQuery` works prevents it from loading SVN identifiers in some cases without additional constraints, since "12345" might be an SVN revision 12345, or it might be the first 5 characters of a Git commit hash.

Introduce `withRepository()` as a shorthand for `withDefaultRepository()` + `withRepositoryIDs()`. This tells the query to:

  - Only look in the given repository; and
  - use the more liberal identifier resolution rules while doing so.

The practical impact this has is that blame tooltips in SVN work again. The other queries which are fixed here were never run in SVN (which doesn't have first-class branches or tags); I've cleaned them up only for completeness.

Test Plan:
  - Viewed blame in SVN, saw information again instead of empty tooltip.
  - Viewed brnaches/tags in Mercurial and Git.

{F79226}

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4067

Differential Revision: https://secure.phabricator.com/D7523
2013-11-07 12:10:43 -08:00
..
aphront Return HTTP 500, not HTTP 200, on exception pages 2013-11-05 15:25:12 -08:00
applications Fix an issue with pulling Subversion blame data 2013-11-07 12:10:43 -08:00
docs Update install documentation to include FreeBSD 2013-10-25 08:58:42 -07:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Nuance - get some scaffolding up there 2013-11-06 17:00:09 -08:00
view Add Fluid-ish view to AphrontMultiColumnView 2013-11-05 18:57:52 -08:00
__celerity_resource_map__.php Remove workboard shadow, slightly nicer mobile view 2013-11-06 10:18:29 -08:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:51 -08:00
__phutil_library_map__.php Allow Phabricator to serve Mercurial repositories over HTTP 2013-11-06 18:00:42 -08:00