revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley f7b1ed7221 Fix two registration errors for unusual provider emails 
Summary:
See <https://github.com/facebook/phabricator/issues/541>.

  - If a provider returns the email `""` or `"0"`, we currently don't let the user edit it and thus don't let them register.
  - If a provider returns an invalid email like `"!!!"` (permitted by GitHub, e.g.), we show them a nonsense error message.

Instead:

  - Pretend we didn't get an address if we get an invalid address.
  - Test the address strictly against `null`.

Test Plan: Registered on Phabricator with my GitHub email set to `""` (empty string) and `"!!!"` (bang bang bang).

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: aran, epriestley

Differential Revision: https://secure.phabricator.com/D8528
2014-03-13 19:03:12 -07:00
..
arcanist/conduit Move Conduit methods inside applications 2012-12-21 12:21:59 -08:00
audit Adding author information to AuditListView 2014-03-07 08:40:35 -08:00
auth Fix two registration errors for unusual provider emails 2014-03-13 19:03:12 -07:00
base Whitelist controllers which can receive a 'code' parameter 2014-03-12 11:30:04 -07:00
cache Minor, mark SERIALIZATION_PHP fields as BINARY in Lisk 2014-02-23 16:35:51 -08:00
calendar Make "My Events" default on Calendar 2014-03-05 08:24:45 -08:00
chatlog Various linter fixes. 2014-02-26 12:44:58 -08:00
conduit Added some additional assertion methods. 2014-03-08 19:16:21 -08:00
config Remove DifferentialFieldSelector 2014-03-11 13:02:13 -07:00
conpherence Fix three minor edge case behaviors in Conpherence 2014-03-10 16:21:28 -07:00
countdown [Countdown] fix undefined variable errors 2014-02-05 05:33:31 -08:00
daemon Do not perform write in PhabricatorDaemonLogQuery by default 2014-01-21 14:04:12 -08:00
dashboard Add edit/view plumbing for dashboards and panels 2014-02-03 10:52:15 -08:00
differential Fix parsing of "Reviewed By" field 2014-03-12 18:11:09 -07:00
diffusion Use "\z" instead of "$" to anchor validating regular expressions 2014-03-13 12:42:41 -07:00
diviner Use "\z" instead of "$" to anchor validating regular expressions 2014-03-13 12:42:41 -07:00
doorkeeper Move PhabricatorTagView to PHUITagView 2014-01-14 14:09:52 -08:00
draft/storage Differential - add DifferentialDraft to track whether revisions have draft feedback or not 2014-02-18 16:25:16 -08:00
drydock Various linter fixes. 2014-02-26 12:44:58 -08:00
fact Extend all "ManagementWorkflow" classes from a base class 2013-12-27 13:15:40 -08:00
feed Include objectPHID in feed.query text view 2014-03-13 17:56:25 -07:00
files Use "\z" instead of "$" to anchor validating regular expressions 2014-03-13 12:42:41 -07:00
flag Various linter fixes. 2014-02-26 12:44:58 -08:00
harbormaster Added 'method' field to the HTTP request build step. 2014-03-13 15:51:05 -07:00
help/controller Make Differential views capability-sensitive 2013-09-26 18:45:04 -07:00
herald Fix a small typo when creating a Herald rule 2014-03-12 16:12:43 -07:00
home Remove field selector on Diff view and Revision List View 2014-03-11 13:02:10 -07:00
legalpad Maniphest Tasks + Project Boards - some polish 2014-03-04 17:01:33 -08:00
lipsum Use DifferentialRevisionEditor in lipsum 2014-03-11 13:02:00 -07:00
macro Use "\z" instead of "$" to anchor validating regular expressions 2014-03-13 12:42:41 -07:00
mailinglists Extract textual object list parsing from Differential 2014-03-07 17:44:44 -08:00
maniphest Tweak application and maniphest editors to handle policy corner cases better 2014-03-13 13:50:08 -07:00
meta Various linter fixes. 2014-02-26 12:44:58 -08:00
metamta Port Differential mail features forward to transactions 2014-03-11 13:02:06 -07:00
notification Add a "Send Test Notification" button to make testing the server easier 2014-02-17 16:00:33 -08:00
nuance Various linter fixes. 2014-02-26 12:44:58 -08:00
oauthserver Fix an anchor redirect issue with OAuth server, plus modernize the application a bit 2014-03-13 12:59:10 -07:00
owners Various linter fixes. 2014-02-26 12:44:58 -08:00
passphrase Fix some collateral damage from SSH Keypair generation 2014-03-13 07:31:45 -07:00
paste Maniphest Tasks + Project Boards - some polish 2014-03-04 17:01:33 -08:00
people Use "\z" instead of "$" to anchor validating regular expressions 2014-03-13 12:42:41 -07:00
phame Reject Phame domains which include a port number 2014-03-11 15:53:15 -07:00
phid Added some additional assertion methods. 2014-03-08 19:16:21 -08:00
phlux Use "\z" instead of "$" to anchor validating regular expressions 2014-03-13 12:42:41 -07:00
pholio Let Herald activation depend on which transactions are being applied, and generate transactions 2014-03-05 12:06:59 -08:00
phortune Added some additional assertion methods. 2014-03-08 19:16:21 -08:00
phpast Remove phpast.* Conduit methods 2014-03-12 11:30:22 -07:00
phragment Various linter fixes. 2014-02-26 12:44:58 -08:00
phrequent Various linter fixes. 2014-02-26 12:44:58 -08:00
phriction Added some additional assertion methods. 2014-03-08 19:16:21 -08:00
policy Added some additional assertion methods. 2014-03-08 19:16:21 -08:00
ponder Maniphest Tasks + Project Boards - some polish 2014-03-04 17:01:33 -08:00
project Hovercard - add project images 2014-03-10 17:10:32 -07:00
releeph Clean up various pieces of dead/obsolete Differential code 2014-03-11 13:02:19 -07:00
remarkup/conduit Support processing Remarkup in bulk with remarkup.processbulk Conduit method 2013-11-02 16:30:11 -07:00
repository Fix issue with ref/fixes in commit messages 2014-03-13 17:47:11 -07:00
search Extract textual object list parsing from Differential 2014-03-07 17:44:44 -08:00
settings Add a "Generate Keypair" option on the SSH Keys panel 2014-03-12 18:17:11 -07:00
slowvote Various linter fixes. 2014-02-26 12:44:58 -08:00
subscriptions Various linter fixes. 2014-02-26 12:44:58 -08:00
system Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
tokens Wrap the feed text rendering stuff with htmlspecialchars_decode 2014-02-03 17:05:30 -08:00
transactions Tweak application and maniphest editors to handle policy corner cases better 2014-03-13 13:50:08 -07:00
typeahead Various linter fixes. 2014-02-26 12:44:58 -08:00
uiexample PHUITimelineView 2014-02-12 09:02:05 -08:00
xhprof Use JSON, not PHP serialization, for XHProf profiles. 2014-02-24 04:16:52 -08:00