1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/doorkeeper
epriestley 943c62d1e9 Add missing expected keys and uniqueness
Summary:
Ref T1191.

  - Adds definitions for missing keys and keys with wrong uniqueness. Generally, I defined these before fixing the key query to actually pull all keys and support uniqueness.
  - Moves "key uniqueness" to note severity; this is fixable (probably?) and there are no remaining issues.
  - Moves "Missing Key" to note severity; missing keys are fixable and all remaining missing keys are really missing (either missing edge keys, or missing PHID keys):

{F210089}

  - Moves "Surplus Key" to note seveirty; surplus keys are fixable all remaining surplus keys are really surplus (duplicate key in Harbormaster, key on unused column in Worker):

{F210090}

Test Plan:
  - Vetted missing/surplus/unique messages.
  - 146 issues remaining.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10590
2014-10-01 07:53:50 -07:00
..
application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
bridge Fix broken references to auth adapters 2014-07-22 21:20:45 +10:00
controller Move PhabricatorTagView to PHUITagView 2014-01-14 14:09:52 -08:00
engine Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
option Fix broken references to auth adapters 2014-07-22 21:20:45 +10:00
query Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
storage Add missing expected keys and uniqueness 2014-10-01 07:53:50 -07:00
view Move PhabricatorTagView to PHUITagView 2014-01-14 14:09:52 -08:00
worker Fix broken references to auth adapters 2014-07-22 21:20:45 +10:00