1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 08:20:57 +01:00
phorge-phorge/src/applications/differential
epriestley ff4e965c90 Don't try to download diffs-of-diffs
Summary:
Ref T1715. When the user clicks "Download Raw Diff" in Differential, we try to build a diff of exactly what they're seeing. However:

  - This doesn't work if any of the changes have multiple hunks, and fixing it seems hard.
  - I suspect this diff is never actually useful anyway? And probably kind of confusing in the best case. You can't really apply it to anyhting, since you'd have to apply another diff first.

Instead, just build the right-side diff, which should align well with user expectation and doesn't suffer from the multi-hunk bug.

Some day, we could maybe add some of the fancy options in T1715.

See: <https://github.com/facebook/phabricator/issues/461>

Test Plan: Downloaded a multi-hunk diff, got the original back and applied it cleanly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1715

Differential Revision: https://secure.phabricator.com/D7694
2013-12-04 14:39:07 -08:00
..
__tests__ Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
application Land Revision button for hosted git repos 2013-11-05 13:00:13 -08:00
capability Allow "Default View" policies to be set to Public 2013-10-09 15:06:18 -07:00
conduit Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
config Add a config flag to treat "Accepted" revisions as "Closed" 2013-11-25 17:40:01 -08:00
constants Add a config flag to treat "Accepted" revisions as "Closed" 2013-11-25 17:40:01 -08:00
controller Don't try to download diffs-of-diffs 2013-12-04 14:39:07 -08:00
doorkeeper Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
editor Use herald to trigger builds of revisions and commits. 2013-11-08 16:58:39 -08:00
event Make event-triggered actions more aware of application access 2013-10-21 17:00:50 -07:00
exception Delete license headers from files 2012-11-05 11:16:51 -08:00
field Render linked JIRA issues with a Doorkeeper tag 2013-11-25 14:54:35 -08:00
landing Land to GitHub + support stuff 2013-11-13 17:25:24 -08:00
lipsum Add a "default view" policy to Differential 2013-10-09 13:58:00 -07:00
mail Fix "Manage herald rules" link by removing it 2013-10-21 16:58:56 -07:00
parser Make most file reads policy-aware 2013-09-30 09:38:13 -07:00
phid Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
query Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
remarkup Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
render Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
search Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
storage Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
view Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
DifferentialGetWorkingCopy.php Add support for landing to hosted Mercurial repos. 2013-11-08 11:39:32 -08:00
DifferentialTasksAttacher.php Delete license headers from files 2012-11-05 11:16:51 -08:00