1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 02:02:41 +01:00
phorge-phorge/src/applications/differential/constants
Bob Trahan e8985fc9e7 Differential - change "closed by commit" comment to real transaction
Summary:
Implements a new transaction - still TYPE_ACTION - but using a new DifferentialAction::ACTION_COMMIT_CLOSE. Augment rendering as necessary to display this new transaction. Saves enough information so T3686 is possible but stops short of implementing a popup to display this information. Fixes T5875. Ref T3686.

One small display oddity - this new transaction now renders at the top of the transaction group whereas when it was a comment it was on the bottom. I think this is basically okay but if not how fix? (Playing with the "strength" of these actions will mess up the email too?)

Test Plan: made a diff X that fixed task Y. committed. checked diff X, task Y, and the commit pages for proper transactions and all looked good.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T3686, T5875

Differential Revision: https://secure.phabricator.com/D10485
2014-09-12 10:12:52 -07:00
..
DifferentialAction.php Differential - change "closed by commit" comment to real transaction 2014-09-12 10:12:52 -07:00
DifferentialChangeType.php PHT's for Differential. 2013-01-24 10:46:47 -08:00
DifferentialLintStatus.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialReviewerStatus.php Make updates of rejected revisions behave correctly again 2014-03-05 10:47:29 -08:00
DifferentialRevisionControlSystem.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialRevisionStatus.php Convert rest of SPRITE_STATUS to FontAwesome 2014-05-18 16:10:54 -07:00
DifferentialUnitStatus.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialUnitTestResult.php Delete license headers from files 2012-11-05 11:16:51 -08:00