revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 01:32:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley ffcfc04652 Add some delivery diagnostic headers to outbound mail 
Summary:
Fixes T13087. Ref T13090. An install ran into a situation where mail was being double-delivered, and it wasn't immediately clear where in the pipeline the issue lay.

This change adds some headers which should rule out (or, at least, render very unlikely) some possible causes if we encounter similar issues in the future.

The `X-Phabricator-Mail-ID` header stores the ID of the `MetaMTAMail` storage object so we can distinguish between two messages sent to two different targets and one message which may have been split or re-sent. It also makes it easier to know what to `bin/mail show-outbound --id <id>` and where to find the message in the web UI for additional information.

The `X-Phabricator-Send-Attempt` is a unique value per attempt. If two mail messages are delivered with the same attempt value, the split is probably downstream from Phabricator. If they have different attempt values, the split is probably in Phabricator.

(In this case, the split was somewhere downstream from us, since sending mail with `/usr/bin/mail` also resulted in duplicates.)

Test Plan: Send some mail, inspected it with `bin/mail show-outbound --id <id>`, saw new headers with sensible/expected values.

Maniphest Tasks: T13090, T13087

Differential Revision: https://secure.phabricator.com/D19124
2018-02-22 12:47:20 -08:00
..
almanac Purge ssh-auth key cache after trust/untrust 2018-02-09 14:58:45 -08:00
aphlict Discard stdout/stderr from the aphlict subprocess when running in daemon (normal) mode 2016-11-13 16:43:42 -08:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Make sure auditors are attached to commits on new pathways 2018-02-09 17:09:00 -08:00
auth Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
badges Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
base Support basic export of user accounts 2018-01-26 11:17:44 -08:00
cache Add "persistence" types (data, cache, or index) to tables, and tweak what "storage dump" dumps 2017-10-04 12:09:33 -07:00
calendar Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
celerity Add a red button to PHUIButtonView 2017-08-06 08:09:40 -07:00
chatlog Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
conduit Add a bin/conduit call support binary 2018-02-05 12:20:49 -08:00
config Make "phabricator.silent" disable build steps which rely on external services 2018-02-14 11:41:47 -08:00
conpherence Read lock all transaction edits 2018-02-10 20:07:46 -08:00
console Separate button CSS classes 2017-06-05 20:14:34 +00:00
countdown Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
daemon When exporting more than 1,000 records, export in the background 2018-01-29 16:08:02 -08:00
dashboard Make dashboard arrange actions (move, add, remove) work again after read locking from "chaos reduction" 2018-02-20 17:23:24 -08:00
differential Make Facts more modern, DRY, and dimensional 2018-02-19 12:05:19 -08:00
diffusion Make Facts more modern, DRY, and dimensional 2018-02-19 12:05:19 -08:00
diviner Fix a constant typo in Diviner ("DECLARATAION" -> "TION") 2017-03-04 09:54:10 -08:00
doorkeeper Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
draft/storage When purging drafts after a transaction edit, purge all drafts 2018-02-11 06:01:09 -08:00
drydock Render Drydock logs in text from "bin/drydock lease"; in HTML in web views 2018-02-15 17:25:34 -08:00
fact Fix some of the most obvious bugs in fact generation from Maniphest tasks 2018-02-19 12:07:28 -08:00
favorites Add some style to label in Favorites Menu 2017-02-01 07:20:31 -08:00
feed Fix a minor/harmless race with feed publishers in certain draft states 2018-01-04 08:14:55 -08:00
files Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
flag Remove counts from home navigation 2017-01-21 13:55:40 -08:00
fund Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
guides Make "simple" a "button type", not a "color" 2017-05-30 17:59:37 -07:00
harbormaster Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
help Redesign header menus and search 2017-01-17 12:13:06 -08:00
herald When "phabricator.silent" is enabled, don't call webhooks 2018-02-14 11:40:19 -08:00
home Update menu item names for Applications -> Favorites 2017-09-05 19:05:03 -07:00
legalpad Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Allow a wider range of characters in macro names, including emoji 2018-02-09 14:34:30 -08:00
maniphest Allow tasks to be filtered and ordered by closed date 2018-02-08 15:42:26 -08:00
meta Rename "QuickSearch" Engine/EngineExtension to "Datasource" 2018-02-14 18:03:03 -08:00
metamta Add some delivery diagnostic headers to outbound mail 2018-02-22 12:47:20 -08:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Make "No Notifications" setting less broad, and fix a bug with default display behavior 2017-09-13 15:32:46 -07:00
nuance Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
oauthserver Update Settings for WHITE_CONFIG style boxes 2017-09-05 19:42:34 -07:00
owners Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
packages Fixing copy/paste mistake 2017-04-19 15:48:59 -07:00
passphrase Fix spelling 2017-10-09 10:48:04 -07:00
paste Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
people Modularize the "jump nav" behaviors in global search 2018-02-14 18:08:07 -08:00
phame Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
phid Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self-actor, self-mention 2018-02-06 04:04:52 -08:00
phlux Update Phlux edit UI 2017-09-07 12:47:36 -07:00
pholio Remove all "originalTitle"/"originalName" fields from objects 2018-02-08 06:22:03 -08:00
phortune Fix a Phortune billing issue where subscription autopay could charge disabled cards 2018-02-08 06:30:59 -08:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Remove PhabricatorFile::buildFromFileDataOrHash() 2017-04-04 16:18:00 -07:00
phrequent Fix spelling 2017-10-09 10:48:04 -07:00
phriction Provide the document content as a context object when rendering Phriction documents 2018-02-16 12:42:41 -08:00
phurl Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
policy Fix spelling 2017-10-09 10:48:04 -07:00
ponder Make Facts more modern, DRY, and dimensional 2018-02-19 12:05:19 -08:00
project Modularize the "jump nav" behaviors in global search 2018-02-14 18:08:07 -08:00
releeph Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Make sure auditors are attached to commits on new pathways 2018-02-09 17:09:00 -08:00
search Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
settings Add Owners Package support for "Commit Hook: Content" Herald rules 2018-02-16 09:49:24 -08:00
slowvote Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
spaces Add more mail stamps: tasks, subscribers, projects, spaces 2018-02-06 04:05:46 -08:00
subscriptions Add "Mute/Unmute" for subscribable objects 2018-02-08 11:06:22 -08:00
support/application
system When destorying a repository, print a notification about removing the working copy 2017-08-01 08:57:39 -07:00
tokens Property list view on Diffusion commits should show build status but not Subscriptions, Projects, or Tokens 2017-12-01 18:16:26 +00:00
transactions Extract count/point data from tasks in Fact engines 2018-02-19 12:06:03 -08:00
typeahead Allow third-party code to extend upstream datasources via EngineExtension 2018-02-14 18:11:51 -08:00
uiexample Fix spelling 2017-10-09 10:48:04 -07:00
xhprof Allow XHProf profiles to be drag-and-dropped to upload them 2017-02-23 11:16:19 -08:00