Commit graph

88 commits

Author SHA1 Message Date
59f6ff9855
CI: fix (CodeQL|yamllint) rules
Summary:
- run CodeQL on js/ts file edits.
- yamllint rule modified to respect my styling decision (1 space
  before comment).

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc lint`, wait for codeql run next time.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D475
2024-06-30 17:24:15 +09:00
24c3fe7517
CI(GitHub Actions): rename workflow name/exclude tags
Summary:
Don't run php check on npm tag push.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: land it and watch when next tagbis uploaded.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D448
2024-06-30 17:18:07 +09:00
44bf31948f
CI(renovate): init
Summary:
Renovate has automerge, dependabot does not (I have to issue a
command via comment box).

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm run lint:renovate`, and land and wait for renovate to catch up

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D474
2024-06-30 17:09:51 +09:00
1cceb76236
npm(prettier-config): add xml, alphabetical sort
Summary:
Add xml linter, and bump version to 0.1.0 with changelog rules.

(and types w/ version bump & `.node_version`)

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: not really testable?

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D473
2024-06-30 16:56:39 +09:00
f556f313d7
npm: update email address
Summary:
Update email address to dedicated mailbox.

No new version bump because cosmetic changes.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Not really test-able thing.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Tags: #npm

Differential Revision: https://issuetracker.revi.xyz/D461
2024-06-30 16:46:06 +09:00
dependabot[bot]
532dbe4df0
build(deps): bump docker/build-push-action from 5.4.0 to 6.2.0 (#10) 2024-06-27 13:44:18 +00:00
359bcd4451
npm(eslint-config): move peerDep to dep
Summary:
ESlint flat config blog says [ref] to use dependencies not
peerDependencies (for plugins).

Also add tsc for types as some tools complain about it.

Ref: https://eslint.org/blog/2023/10/flat-config-rollout-plans/
Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm ci`

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D435
2024-06-27 20:12:15 +09:00
4e98e27115
CI(typescript): add typescript stuff
Summary:
Add them as `package.json` deps. Also remove `--fund=false` in
GitHub Actions workflows where it's obsoleted by `.npmrc` file.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm ci`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D429
2024-06-25 17:20:02 +09:00
ab283848b8
CI(npm): Refer local directory as file path
Summary:
Avoid updating local pkgs.

Also add `prefer-dedupe=true` on `.npmrc`.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm ci`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D428
2024-06-25 16:09:48 +09:00
f0fb5d1812
npm(eslint-config): add bugs entry
Summary:
Well, it's unlikely someone will need file a bug for this pkg but tools
are referring to GitHub issues which are disabled.

Not bumping the version because trivial.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: When new version is published, go to deps.dev and verify issues label is set to `revi.xyz/new`

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D416
2024-06-24 16:58:54 +09:00
09d55a76c5
npm(prettier-config): add .devcontainer/*.json as jsonc.
Summary:
[devcontainer.json](https://containers.dev/implementors/spec/#devcontainerjson)
is a "JSON with Comments" file.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Watch how prettier behaves with rWEBXYZ `.devcontainer/devcontainer.json`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D400
2024-06-22 17:38:06 +09:00
bfab2ea75c
CI(npm): pin npm package version
Summary:
Ref T176.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm ci`

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Maniphest Tasks: T176

Differential Revision: https://issuetracker.revi.xyz/D393
2024-06-21 16:15:24 +09:00
9c85bcb30d
CI(NPM): .npmrc audit=false, fund=false
Summary:
Handled by dependabot.

Ref D375.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: land it, do npm ci or watch GitHub Actions log without audit/fund data.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D384
2024-06-21 16:09:14 +09:00
387440faf8
Phorge(robots.txt): add trailing slashes to phorge lines
Summary:
Entries with(out) slashes.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Deploy it.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D385
2024-06-21 16:09:12 +09:00
88f952d4cd
npm(prettier-config): add homepage
Summary:
link to directory. No version bump for this.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: verify the homepage when the new release is cut

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D387
2024-06-21 16:09:10 +09:00
a287bd06ca
npm(eslint-config): version bump with deps update
Summary:
add @types, --save-exact for prettier(-config), add homepage.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: No visible changes.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D378
2024-06-20 15:01:11 +09:00
b189fe62aa
npm(prettier-config): add tsconfig to jsonc
Summary:
`tsconfig.json` has comments, so it is jsonc.

Cf. https://aka.ms/tsconfig.json

Also add tsconfig.json in rootdir and update arclint to ignore
`tsconfig.json`.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Try prettier checks on `tsconfig.json` after merging.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D376
2024-06-20 14:54:14 +09:00
122113d958
meta: add badges to root dir README
Summary:
Sort of a QuickView.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: preview.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D371
2024-06-19 16:04:31 +09:00
a1117fa7c1
phorge(robots.txt): add more domains
Summary:
Almost complete copy of rWEBXYZ. cookie unset didn't work as hoped,
comment it out.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: deploy it.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D370
2024-06-19 15:17:40 +09:00
ba384f8349
meta(.vscode): add directory
Summary:
Add extensions and settings, and gitattributes.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: land it.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D367
2024-06-19 14:40:02 +09:00
c079c483f8
npm(prettier-config): trailingComma: 'none' for jsonc
Summary:
Seems like prettier wants to put trailingComma to JSONc.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`, push new release, test.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D366
2024-06-19 14:32:59 +09:00
dependabot[bot]
816443f2ef
build(deps): bump docker/build-push-action from 5.3.0 to 5.4.0 (#8) 2024-06-18 15:19:39 +00:00
cbfa3411b3
CI(GitHub Actions): fix npm-pub.yml to publish correctly
Summary:
Fix P185 failure.

Also fix L1 (`npm pkg fix`) for (eslint|prettier)-config.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc lint`, and push tag again

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D358
2024-06-18 19:26:34 +09:00
0b10676c4f
CI(GitHub Actions): Fix syntax if: statement
Summary:
Forgot there's contains() logic.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`, and make a new tag and push.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D357
2024-06-18 19:19:03 +09:00
351abd6425
CI(GitHub Actions): add npm autopublishing script
Summary:
Handles (eslint|prettier)-config in one script.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land` and push a tag for testing.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D356
2024-06-18 19:08:38 +09:00
5c16c87f8d
npm(prettier-config): add prettier plugins, add rules, consolidate
Summary:
And run `npm run p:w .` for that, and add .prettierignore so `sh` plugin ignores them.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm run p:c .` and `npm publish`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D355
2024-06-18 18:46:30 +09:00
679378baa3
CI(GitHub Actions): add codeql
Summary:
CodeQL just for... CodeQL.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D343
2024-06-17 13:06:55 +09:00
959705258e
npm(eslint-config): correct wrong peerDependency
Summary:
eslint-config-prettier should have been peerDependency not devDependency.
Correct them by moving it.

(Also do some yml cleanups.)

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm ci`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D342
2024-06-17 12:53:55 +09:00
68f2133e9c
PhabExt(robots.txt): add more rules, ...
Summary:
setClientIDCookie none to return Response, more rules, todo:

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: deploy?

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D338
2024-06-17 12:46:53 +09:00
9afee876a5
npm(README): add shields.io badges
Summary:
Not worthy of new release though.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Browse the markdown in editor's preview mode

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D337
2024-06-17 12:46:50 +09:00
0f4b7c97e3
CI: add eslint
Summary:
Signed-off-by: Yongmin Hong <revi@omglol.email>

npm: use @revi/eslint-config

Also change eslint format, and publish `v0.0.2`.
Also prepare for eslint-config-wikimedia when they have eslint9 support.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm run eslint`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D332
2024-06-16 15:50:44 +09:00
be3db3c067
npm(eslint-config): eslint shard config
Summary:
Yet another shared config for consolidation.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`, `npm publish`, and install it.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D331
2024-06-16 14:49:55 +09:00
b1740bd0cd
CI(.arclint): use Pinterest Arcanist Linter
Summary:
Thanks pinterest!

Also fix some GitHub Actions error.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: run `arc lint`?

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D325
2024-06-16 14:45:56 +09:00
41b70cb468
npm(prettier-config): add README/author data, make prettier peerDependency
Summary:
Bump to 0.0.2.

For easier browsing...

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`, and `npm publish`

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D310
2024-06-14 19:49:11 +09:00
01e6487932
npm: use shared prettier config
Summary:
Shared config testbed, yeah.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm run p:c .` should run as it is.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D305
2024-06-14 17:24:13 +09:00
8865e172f9
npm(prettier-config): add new sharable config
Summary:
Docs: https://prettier.io/docs/en/configuration#sharing-configurations

To be published @ npm and imported elsewhere.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: no test can be performed at this time; needs to be landed, published to npm, and then we can test from other tepo importing this.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D302
2024-06-14 17:18:03 +09:00
1a8f2aaccf
meta: gitattributes
Summary:
Better markdown/css diff handling and binary handling

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: not really?

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D271
2024-06-12 11:51:02 +09:00
55ce2b96ac
gitignore: add wikiploy config file
Summary:
For D22 and D229, so those doesn't need conflicting `.gitignore` entry.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `touch wmf.bot.config.mjs`, verify `git status` has no pending files to commit.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D230
2024-06-09 22:47:45 +09:00
04798b45fd
style: npm run p:w .
Summary:
Which is essentially `npx prettier --write .`

Also fix `jshint` (possible) FP, wrong chars.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm run p:w .` and verify no changes made.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D217
2024-06-09 22:11:33 +09:00
aca8c5967b
CI: new package and configs
Summary:
add following npm packages:

 - jshint
 - prettier

Add `prettier` configs and `.arclint` accordingly.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `npm run pcheck`, `npm run pwrite`.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D216
2024-06-08 19:04:29 +09:00
ffae464265
CI(GitHub Actions): change actions versioning
Summary:
commit hash is not my preferred solution, Just use tags.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`?

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D194
2024-06-08 12:06:24 +09:00
fecb9204c1
gitignore: remove OS-specific entries
Summary:
There's better solution for this: `~/.gitignore`.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: No test needed.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D137
2024-06-08 12:06:22 +09:00
609068524b
CI(GitHub Actions): run builds on workflow yml file edit
Summary:
different ci config might render jobs to fail.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: Verify test run after `arc land`

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D139
2024-05-26 15:03:13 +09:00
50a7eeb582
CI(GitHub Actions): fix php -l script
Summary:
Was not calling from the repo rootdir. Fix it.

Signed-off-by: Yongmin Hong <revi@omglol.email>

Test Plan: `arc land`. Wait for GitHub Actions to run.

Reviewers: O1 revi & automations, revi

Reviewed By: O1 revi & automations, revi

Differential Revision: https://issuetracker.revi.xyz/D149
2024-05-26 15:03:11 +09:00
dependabot[bot]
b28b636f0a
Merge pull request #3 from revi/dependabot/github_actions/master/docker/metadata-action-f7b4ed12385588c3f9bc252f0a2b520d83b52d48 2024-05-23 14:51:38 +00:00
dependabot[bot]
1d28b2e49b
Merge pull request #2 from revi/dependabot/github_actions/master/docker/build-push-action-2a53c6ccda456d31fb62eedc658aae06e238b7bd 2024-05-23 14:50:36 +00:00
dependabot[bot]
2a04b984dc
Merge pull request #4 from revi/dependabot/github_actions/master/docker/login-action-70fccc794acd729b2b22dd6a326895f286447728 2024-05-23 14:46:09 +00:00
dependabot[bot]
4fe96f7469
Merge pull request #5 from revi/dependabot/npm_and_yarn/container/lighthouse-ci-server/npm_and_yarn-d4732a2d37 2024-05-23 07:37:07 +00:00
dependabot[bot]
ef42bb9254
build(deps): bump mysql2
Bumps the npm_and_yarn group with 1 update in the /container/lighthouse-ci-server directory: [mysql2](https://github.com/sidorares/node-mysql2).


Updates `mysql2` from 2.3.3 to 3.9.7
- [Release notes](https://github.com/sidorares/node-mysql2/releases)
- [Changelog](https://github.com/sidorares/node-mysql2/blob/master/Changelog.md)
- [Commits](https://github.com/sidorares/node-mysql2/compare/v2.3.3...v3.9.7)

---
updated-dependencies:
- dependency-name: mysql2
  dependency-type: direct:production
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-23 07:34:11 +00:00
dependabot[bot]
adbe151bf2
build(deps): bump docker/login-action
Bumps [docker/login-action](https://github.com/docker/login-action) from 65b78e6e13532edd9afa3aa52ac7964289d1a9c1 to 70fccc794acd729b2b22dd6a326895f286447728.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](65b78e6e13...70fccc794a)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-23 07:33:28 +00:00