Summary:
- run CodeQL on js/ts file edits.
- yamllint rule modified to respect my styling decision (1 space
before comment).
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `arc lint`, wait for codeql run next time.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D475
Summary:
Don't run php check on npm tag push.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: land it and watch when next tagbis uploaded.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D448
Summary:
Renovate has automerge, dependabot does not (I have to issue a
command via comment box).
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `npm run lint:renovate`, and land and wait for renovate to catch up
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D474
Summary:
Add xml linter, and bump version to 0.1.0 with changelog rules.
(and types w/ version bump & `.node_version`)
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: not really testable?
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D473
Summary:
ESlint flat config blog says [ref] to use dependencies not
peerDependencies (for plugins).
Also add tsc for types as some tools complain about it.
Ref: https://eslint.org/blog/2023/10/flat-config-rollout-plans/
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `npm ci`
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D435
Summary:
Well, it's unlikely someone will need file a bug for this pkg but tools
are referring to GitHub issues which are disabled.
Not bumping the version because trivial.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: When new version is published, go to deps.dev and verify issues label is set to `revi.xyz/new`
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D416
Summary:
link to directory. No version bump for this.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: verify the homepage when the new release is cut
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D387
Summary:
`tsconfig.json` has comments, so it is jsonc.
Cf. https://aka.ms/tsconfig.json
Also add tsconfig.json in rootdir and update arclint to ignore
`tsconfig.json`.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: Try prettier checks on `tsconfig.json` after merging.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D376
Summary:
Almost complete copy of rWEBXYZ. cookie unset didn't work as hoped,
comment it out.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: deploy it.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D370
Summary:
Forgot there's contains() logic.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `arc land`, and make a new tag and push.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D357
Summary:
Handles (eslint|prettier)-config in one script.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `arc land` and push a tag for testing.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D356
Summary:
And run `npm run p:w .` for that, and add .prettierignore so `sh` plugin ignores them.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `npm run p:c .` and `npm publish`.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D355
Summary:
eslint-config-prettier should have been peerDependency not devDependency.
Correct them by moving it.
(Also do some yml cleanups.)
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `npm ci`.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D342
Summary:
Signed-off-by: Yongmin Hong <revi@omglol.email>
npm: use @revi/eslint-config
Also change eslint format, and publish `v0.0.2`.
Also prepare for eslint-config-wikimedia when they have eslint9 support.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `npm run eslint`.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D332
Summary:
Shared config testbed, yeah.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `npm run p:c .` should run as it is.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D305
Summary:
Docs: https://prettier.io/docs/en/configuration#sharing-configurations
To be published @ npm and imported elsewhere.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: no test can be performed at this time; needs to be landed, published to npm, and then we can test from other tepo importing this.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D302
Summary:
For D22 and D229, so those doesn't need conflicting `.gitignore` entry.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `touch wmf.bot.config.mjs`, verify `git status` has no pending files to commit.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D230
Summary:
commit hash is not my preferred solution, Just use tags.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `arc land`?
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D194
Summary:
different ci config might render jobs to fail.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: Verify test run after `arc land`
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D139
Summary:
Was not calling from the repo rootdir. Fix it.
Signed-off-by: Yongmin Hong <revi@omglol.email>
Test Plan: `arc land`. Wait for GitHub Actions to run.
Reviewers: O1 revi & automations, revi
Reviewed By: O1 revi & automations, revi
Differential Revision: https://issuetracker.revi.xyz/D149
