Document some variables in func_dependencies

Better document the $seen global variable used in path_to,
also at places where "path_to" is called.
Document p and b flags in the loop over "after" deps.
Document lr variable in the loop over "first" deps.
This commit is contained in:
Pierre Labastie 2021-12-19 14:32:51 +01:00
parent bbabe74e15
commit e0bbc6e6ac

View file

@ -220,7 +220,8 @@ path_to() { #
$2 contains the name of the node to reach $2 contains the name of the node to reach
$3 contains the weight above which we do not want to $3 contains the weight above which we do not want to
follow an edge follow an edge
"seen" (global) contains the list of already seen nodes $seen (global) contains the list of already seen nodes.
It must ve set to " " prior to calling the function
returns: 0 if the node has been found returns: 0 if the node has been found
1 if not 1 if not
on error: nothing on error: nothing
@ -301,11 +302,11 @@ for node in $(grep -l ' a ' *.dep); do
lines_to_remove= lines_to_remove=
echo Process "runtime" deps in $node echo Process "runtime" deps in $node
if ! [ -e ${node%.dep}groupxx.dep ]; then if ! [ -e ${node%.dep}groupxx.dep ]; then
b=0 b=0 # Nothing depends on <node>groupxx
for parent in $(grep -l ${node%.dep}\$ *); do for parent in $(grep -l ${node%.dep}\$ *); do
p=0 p=0 # No "after" dependency depends on this parent
for start in $(grep ' a ' $node | cut -d' ' -f3); do for start in $(grep ' a ' $node | cut -d' ' -f3); do
seen=" " seen=" " # global variable used in "path_to"
if path_to ${start}.dep ${parent%.dep} 3; then p=1; break; fi if path_to ${start}.dep ${parent%.dep} 3; then p=1; break; fi
done done
if test $p = 0; then if test $p = 0; then
@ -340,10 +341,10 @@ for node in $(grep -l ' f ' *); do
cp ${id_of_dep}{,-pass1}.dep; cp ${id_of_dep}{,-pass1}.dep;
fi fi
lines_to_change="$lines_to_change $id_of_dep" lines_to_change="$lines_to_change $id_of_dep"
unset lr unset lr # lines to remove in -pass1
{ {
while read p b start; do while read p b start; do
seen=" " seen=" " # global variable used in "path_to"
if path_to ${start}.dep ${node%.dep} $p; then if path_to ${start}.dep ${node%.dep} $p; then
lr="$lr $start" lr="$lr $start"
fi fi