GPU: Pass SpanOrArray for Texture SetData to avoid copy (#3745)
* GPU: Pass SpanOrArray for Texture SetData to avoid copy
Texture data is often converted before upload, meaning that an array was allocated to perform the conversion into. However, the backend SetData methods were being passed a Span of that data, and the Multithreaded layer does `ToArray()` on it so that it can be stored for later! This method can't extract the original array, so it creates a copy.
This PR changes the type passed for textures to a new ref struct called SpanOrArray, which is backed by either a ReadOnlySpan or an array. The benefit here is that we can have a ToArray method that doesn't copy if it is originally backed by an array.
This will also avoid a copy when running the ASTC decoder.
On NieR this was taking 38% of texture upload time, which it does a _lot_ of when you move between areas, so there should be a 1.6x performance boost when strictly uploading textures. No doubt this will also improve texture streaming performance in UE4 games, and maybe a small reduction with video playback.
From the numbers, it's probably possible to improve the upload rate by a further 1.6x by performing layout conversion on GPU. I'm not sure if we could improve it further than that - multithreading conversion on CPU would probably result in memory bottleneck.
This doesn't extend to buffers, since we don't convert their data on the GPU emulator side.
* Remove implicit cast to array.
2022-10-08 17:04:47 +02:00
|
|
|
using Ryujinx.Common.Memory;
|
2019-10-13 08:02:07 +02:00
|
|
|
|
|
|
|
|
namespace Ryujinx.Graphics.GAL
|
|
|
|
|
{
|
2020-09-10 21:44:04 +02:00
|
|
|
public interface ITexture
|
2019-10-13 08:02:07 +02:00
|
|
|
{
|
2020-07-07 04:41:07 +02:00
|
|
|
int Width { get; }
|
|
|
|
|
int Height { get; }
|
|
|
|
|
|
2019-10-31 00:45:01 +01:00
|
|
|
void CopyTo(ITexture destination, int firstLayer, int firstLevel);
|
2021-03-02 23:30:54 +01:00
|
|
|
void CopyTo(ITexture destination, int srcLayer, int dstLayer, int srcLevel, int dstLevel);
|
2019-10-13 08:02:07 +02:00
|
|
|
void CopyTo(ITexture destination, Extents2D srcRegion, Extents2D dstRegion, bool linearFilter);
|
2023-05-01 21:05:12 +02:00
|
|
|
void CopyTo(BufferRange range, int layer, int level, int stride);
|
2019-10-13 08:02:07 +02:00
|
|
|
|
|
|
|
|
ITexture CreateView(TextureCreateInfo info, int firstLayer, int firstLevel);
|
|
|
|
|
|
2023-03-19 21:56:48 +01:00
|
|
|
PinnedSpan<byte> GetData();
|
|
|
|
|
PinnedSpan<byte> GetData(int layer, int level);
|
2019-10-13 08:02:07 +02:00
|
|
|
|
GPU: Pass SpanOrArray for Texture SetData to avoid copy (#3745)
* GPU: Pass SpanOrArray for Texture SetData to avoid copy
Texture data is often converted before upload, meaning that an array was allocated to perform the conversion into. However, the backend SetData methods were being passed a Span of that data, and the Multithreaded layer does `ToArray()` on it so that it can be stored for later! This method can't extract the original array, so it creates a copy.
This PR changes the type passed for textures to a new ref struct called SpanOrArray, which is backed by either a ReadOnlySpan or an array. The benefit here is that we can have a ToArray method that doesn't copy if it is originally backed by an array.
This will also avoid a copy when running the ASTC decoder.
On NieR this was taking 38% of texture upload time, which it does a _lot_ of when you move between areas, so there should be a 1.6x performance boost when strictly uploading textures. No doubt this will also improve texture streaming performance in UE4 games, and maybe a small reduction with video playback.
From the numbers, it's probably possible to improve the upload rate by a further 1.6x by performing layout conversion on GPU. I'm not sure if we could improve it further than that - multithreading conversion on CPU would probably result in memory bottleneck.
This doesn't extend to buffers, since we don't convert their data on the GPU emulator side.
* Remove implicit cast to array.
2022-10-08 17:04:47 +02:00
|
|
|
void SetData(SpanOrArray<byte> data);
|
|
|
|
|
void SetData(SpanOrArray<byte> data, int layer, int level);
|
|
|
|
|
void SetData(SpanOrArray<byte> data, int layer, int level, Rectangle<int> region);
|
2020-04-25 15:02:18 +02:00
|
|
|
void SetStorage(BufferRange buffer);
|
2020-09-10 21:44:04 +02:00
|
|
|
void Release();
|
2019-10-13 08:02:07 +02:00
|
|
|
}
|
2023-06-28 20:20:10 +02:00
|
|
|
}
|
