revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

Remove the size limit on arc side

Browse source 
Summary:
remove the size check. The conduit call will fail later if the
size is too large, and we will get better error message.

Test Plan:
run arc diff with files smaller and larger than the size
limit.

Reviewed By: epriestley
Reviewers: epriestley
CC: aran, epriestley
Differential Revision: 729
This commit is contained in:
Jason Ge 2011-07-25 16:24:23 -07:00
parent eb98ab553e
commit 1bb2409d47
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/workflow/diff/ArcanistDiffWorkflow.php
View file

@ -819,12 +819,6 @@ EOTEXT
$mime_type = trim($mime_type); $mime_type = trim($mime_type);
$result['mime'] = $mime_type; $result['mime'] = $mime_type;
// TODO: Make this configurable.
$bin_limit = 1024 * 1024; // 1 MB limit
if (strlen($data) > $bin_limit) {
return $result;
}
$bytes = strlen($data); $bytes = strlen($data);
echo "Uploading {$desc} '{$name}' ({$mime_type}, {$bytes} bytes)...\n"; echo "Uploading {$desc} '{$name}' ({$mime_type}, {$bytes} bytes)...\n";