revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 23:02:41 +01:00
Code Issues Releases Wiki Activity

Require defining getWorkflowName()

Browse source 
Test Plan:
  $ arc help

Reviewers: epriestley, edward

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3742
This commit is contained in:
vrana 2012-10-19 11:02:46 -07:00
parent 522c35c1ed
commit 475a576fdc
2 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/configuration/ArcanistConfiguration.php
View file

@ -58,13 +58,6 @@ class ArcanistConfiguration {
foreach ($symbols as $symbol) { foreach ($symbols as $symbol) {
$class = $symbol['name']; $class = $symbol['name'];
$workflow = newv($class, array()); $workflow = newv($class, array());
// TODO: Delete after installations will update (2012-10-31).
if (!method_exists($workflow, 'getWorkflowName')) {
// This workflow was hopefully already built by our parent.
continue;
}
$name = $workflow->getWorkflowName(); $name = $workflow->getWorkflowName();
if (isset($workflows[$name])) { if (isset($workflows[$name])) {

3
src/workflow/ArcanistBaseWorkflow.php
View file

@ -89,8 +89,7 @@ abstract class ArcanistBaseWorkflow {
* *
* @return string The command a user types to invoke this workflow. * @return string The command a user types to invoke this workflow.
*/ */
// TODO: Uncomment after installations will update (2012-10-31). abstract public function getWorkflowName();
// abstract public function getWorkflowName();
/** /**
* Return console formatted string with all command synopses. * Return console formatted string with all command synopses.