revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
Code Issues Releases Wiki Activity

ArcanistGitAPI: document a git ls-files bug

Browse source 
When a submodule is ignored (ignore=all in .gitconfig),

  $ git ls-files -m

fails to exclude the submodule from the listing. Other commands like

  $ git diff-index --name-only HEAD

exclude it just fine.

See: <https://github.com/facebook/arcanist/pull/120>

Reviewed by: epriestley
This commit is contained in:
Ramkumar Ramachandra 2013-11-22 18:41:59 +05:30 committed by epriestley
parent 86eae809e0
commit e62b23e67d
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/repository/api/ArcanistGitAPI.php
View file

@ -474,6 +474,8 @@ final class ArcanistGitAPI extends ArcanistRepositoryAPI {
)); ));
// Unstaged changes // Unstaged changes
// TODO: This doesn't exclude ignored submodules.
// Upstream bug: http://thread.gmane.org/gmane.comp.version-control.git/238173
$unstaged_future = $this->buildLocalFuture( $unstaged_future = $this->buildLocalFuture(
array( array(
'ls-files -m', 'ls-files -m',