1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-03-28 12:08:12 +01:00
phorge-arcanist/src
John Allen aeb374b333 Fix cpplint message regex
Summary:
ref T8404

The issue is caused, not by the non-zero return code, but by the fact that
$messages is coming back empty due to the incorrect regex. tyhoff pointed out
that the regex matched correctly when we used STDIN, but now it is failing.

https://secure.phabricator.com/diffusion/ARC/browse/master/src/lint/linter/ArcanistExternalLinter.php;8c589f1f759f0913135b8cc6959a6c1589e14ae4$357

Test Plan:
arc lint cpp file containing lint error. run cpplint on the
file directly to confirm that there are errors and that the return code
is non-zero

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Maniphest Tasks: T8404

Differential Revision: https://secure.phabricator.com/D14960
2016-01-06 13:15:09 -08:00
..
__tests__ Use PhutilLibraryTestCase 2015-01-07 07:37:59 +11:00
configuration Fix an issue with "arc nrabch" 2015-09-15 11:14:07 -07:00
difference Extend from Phobject 2015-06-15 15:47:33 +10:00
differential Extend from Phobject 2015-06-15 15:47:33 +10:00
docs/book Minor documentation improvements 2015-06-08 11:31:35 +10:00
events/constant Remove @group annotations 2014-07-09 09:12:13 +10:00
exception pht all the things 2015-05-13 21:00:53 +10:00
extensions Changes to Arcanist for libphutil "extensions/" 2013-04-22 14:38:49 -07:00
hgdaemon Extend from Phobject 2015-06-15 15:47:33 +10:00
internationalization Various translation improvements 2015-11-02 21:31:04 +11:00
land Explain how to move forward or backward from arc land --hold 2015-12-13 08:19:04 -08:00
lint Fix cpplint message regex 2016-01-06 13:15:09 -08:00
parser Linter fixes 2015-12-07 21:35:34 +11:00
repository Don't use "-c" flag in "git:branch-unique()" revision range rule 2015-12-10 14:19:39 -08:00
unit Linter fixes 2015-12-07 21:35:34 +11:00
upload Various translation improvements 2015-11-02 21:31:04 +11:00
workflow Fix arc diff --raw with "onto" target properties 2016-01-05 10:16:39 -08:00
workingcopyidentity Extend from Phobject 2015-06-15 15:47:33 +10:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:24 -08:00
__phutil_library_map__.php Add a linter rule for use of is_a 2015-12-23 08:44:39 +11:00