revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-14 19:02:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/__celerity_resource_map__.php

4651 lines
137 KiB
PHP
Raw Normal View History

Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
<?php
/**
* This file is automatically generated. Use 'celerity_mapper.php' to rebuild
* it.
* @generated
*/
celerity_register_resource_map(array(
Conpherence CSS tweaks. Summary: Just a rough pass at the CSS on Conpherence. Need a second pass for the widgets. Test Plan: Reload Conpherence, Chrome, FF Reviewers: btrahan, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4661
2013-01-26 00:48:04 +01:00
'/rsrc/image/actions/edit.png' =>
array(
'hash' => 'ae90914d120ac3838ddc633b480343f3',
'uri' => '/res/ae90914d/rsrc/image/actions/edit.png',
'disk' => '/rsrc/image/actions/edit.png',
'type' => 'png',
),
Add Apple Touch Icon. Summary: Adds an icon if you add Phabricator as a web app on your iPhone. Test Plan: Test on simulator and in iOS. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5444
2013-03-25 19:24:17 +01:00
'/rsrc/image/apple-touch-icon.png' =>
array(
'hash' => '3380adf2dd4a5efa0885618bc5943640',
'uri' => '/res/3380adf2/rsrc/image/apple-touch-icon.png',
'disk' => '/rsrc/image/apple-touch-icon.png',
'type' => 'png',
),
Highlight copied/moved lines in Differential Summary: The color used for this feature is pretty important and I am bad with colors. Test Plan: View diff created by D2320 with some copied lines and one line changed: {F10604, size=full} Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2321
2012-04-26 09:18:42 +02:00
'/rsrc/image/avatar.png' =>
array(
'hash' => '1c5f255071537f05406adee86717ff27',
'uri' => '/res/1c5f2550/rsrc/image/avatar.png',
'disk' => '/rsrc/image/avatar.png',
'type' => 'png',
),
Change background for image views in Differential Summary: Many images in Differential changesets are icons designed for use on dark backgrounds. This makes them invisible on Differential's white background. This adds an option to use a darker background instead so you can see the images. Currently this behavior is triggered on hover. (Also, it's a rather garish fuchsia.) It seems fine UX-wise but I'm not totally sure of it. Test Plan: Load diff containing grippy_texture. Marvel at the grippy fuchsia. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3272
2012-08-14 02:21:16 +02:00
'/rsrc/image/checker_dark.png' =>
array(
'hash' => '640f795343df76ebe5409aae6187e57f',
'uri' => '/res/640f7953/rsrc/image/checker_dark.png',
'disk' => '/rsrc/image/checker_dark.png',
'type' => 'png',
),
'/rsrc/image/checker_light.png' =>
array(
'hash' => '7f8f3ef8beb0f2cc4cc69efb9e1c3308',
'uri' => '/res/7f8f3ef8/rsrc/image/checker_light.png',
'disk' => '/rsrc/image/checker_light.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/credit_cards.png' =>
array(
'hash' => '681448de424ea159b6ea68af04c046ae',
'uri' => '/res/681448de/rsrc/image/credit_cards.png',
'disk' => '/rsrc/image/credit_cards.png',
'type' => 'png',
),
DarkConsole: fix rendering, move request log, load over ajax Summary: This accomplishes three major goals: # Fixes phutil_render_tag -> phutil_tag callsites in DarkConsole. # Moves the Ajax request log to a new panel on the left. This panel (and the tabs panel) get scrollbars when they get large, instead of making the page constantly scroll down. # Loads the panel content over ajax, instead of dumping it into the page body / ajax response body. I've been planning to do this for about 3 years, which is why the plugins are architected the way they are. This should make debugging easier by making response bodies not be 50%+ darkconsole stuff. Additionally, load the plugins dynamically (the old method predates library maps and PhutilSymbolLoader). Test Plan: {F30675} - Switched between requests and tabs, reloaded page, saw same tab. - Used "analyze queries", "profile page", triggered errors. - Verified page does not load anything by default if dark console is closed with Charles. - Generally banged on it a bit. Reviewers: vrana, btrahan, chad Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4692
2013-01-29 03:45:32 +01:00
'/rsrc/image/darkload.gif' =>
array(
'hash' => '3a52cb7145d6e70f461fed21273117f2',
'uri' => '/res/3a52cb71/rsrc/image/darkload.gif',
'disk' => '/rsrc/image/darkload.gif',
'type' => 'gif',
),
Allow pages to use new "flexible" nav Summary: This allows the nav to be laid out with divs instead of tables and for the navigation column to be made flexible. Design is non-final, this is just a step toward reactive menus that work on tablets/phones and an application menu. I'm going to play around with flexible nav and document navigation and see if that goes anywhere. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3114
2012-08-01 21:31:33 +02:00
'/rsrc/image/divot.png' =>
array(
'hash' => '3be267bd11ea375bf68e808893718e0e',
'uri' => '/res/3be267bd/rsrc/image/divot.png',
'disk' => '/rsrc/image/divot.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/grippy_texture.png' =>
array(
'hash' => 'a8945e12ceeaddd5b491a8d81cfa19c1',
'uri' => '/res/a8945e12/rsrc/image/grippy_texture.png',
'disk' => '/rsrc/image/grippy_texture.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/arrow_branch.png' =>
array(
'hash' => 'f27b67520766e3d971722bcff703f3a8',
'uri' => '/res/f27b6752/rsrc/image/icon/fatcow/arrow_branch.png',
'disk' => '/rsrc/image/icon/fatcow/arrow_branch.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/arrow_merge.png' =>
array(
'hash' => 'c4bd97f3b1257439e2123ef69d2194d0',
'uri' => '/res/c4bd97f3/rsrc/image/icon/fatcow/arrow_merge.png',
'disk' => '/rsrc/image/icon/fatcow/arrow_merge.png',
'type' => 'png',
),
dark console - introduce "request log" section Summary: this section gets updated for each and every request. clicking a given entry updates the larger dark-console area to have the information from that request Test Plan: clicked around in maniphest and observed request log populating correctly. clicked a few entries in request log and saw it updated properly. clicked a different tab in the dark-console and it worked. clicked a different request log entry and it opened the dark console to the proper request on the proper tab. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1136 Differential Revision: https://secure.phabricator.com/D2574
2012-05-25 19:14:17 +02:00
'/rsrc/image/icon/fatcow/bullet_black.png' =>
array(
Update status icons Summary: Use standard colors. Test Plan: create status Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6701
2013-08-08 15:51:22 +02:00
'hash' => 'c148284c84aa02ba1190dcf7e31c8985',
'uri' => '/res/c148284c/rsrc/image/icon/fatcow/bullet_black.png',
dark console - introduce "request log" section Summary: this section gets updated for each and every request. clicking a given entry updates the larger dark-console area to have the information from that request Test Plan: clicked around in maniphest and observed request log populating correctly. clicked a few entries in request log and saw it updated properly. clicked a different tab in the dark-console and it worked. clicked a different request log entry and it opened the dark console to the proper request on the proper tab. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1136 Differential Revision: https://secure.phabricator.com/D2574
2012-05-25 19:14:17 +02:00
'disk' => '/rsrc/image/icon/fatcow/bullet_black.png',
'type' => 'png',
),
Highlight away status by bullet and display it everywhere Summary: D2484#13 Test Plan: Display revision list. Display revision detail. Reviewers: epriestley Reviewed By: epriestley CC: btrahan, aran, Koolvin Differential Revision: https://secure.phabricator.com/D2501
2012-05-19 18:18:34 +02:00
'/rsrc/image/icon/fatcow/bullet_orange.png' =>
array(
Update status icons Summary: Use standard colors. Test Plan: create status Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6701
2013-08-08 15:51:22 +02:00
'hash' => '397bd1c948d9aaac5e440a9270c3697a',
'uri' => '/res/397bd1c9/rsrc/image/icon/fatcow/bullet_orange.png',
Highlight away status by bullet and display it everywhere Summary: D2484#13 Test Plan: Display revision list. Display revision detail. Reviewers: epriestley Reviewed By: epriestley CC: btrahan, aran, Koolvin Differential Revision: https://secure.phabricator.com/D2501
2012-05-19 18:18:34 +02:00
'disk' => '/rsrc/image/icon/fatcow/bullet_orange.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/bullet_red.png' =>
array(
Update status icons Summary: Use standard colors. Test Plan: create status Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6701
2013-08-08 15:51:22 +02:00
'hash' => '470e3b2c2ca84ebdd476271b681f421b',
'uri' => '/res/470e3b2c/rsrc/image/icon/fatcow/bullet_red.png',
Highlight away status by bullet and display it everywhere Summary: D2484#13 Test Plan: Display revision list. Display revision detail. Reviewers: epriestley Reviewed By: epriestley CC: btrahan, aran, Koolvin Differential Revision: https://secure.phabricator.com/D2501
2012-05-19 18:18:34 +02:00
'disk' => '/rsrc/image/icon/fatcow/bullet_red.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/icon/fatcow/calendar_edit.png' =>
array(
'hash' => 'de249c0f4f37bf5b2c69ff39ec5573fb',
'uri' => '/res/de249c0f/rsrc/image/icon/fatcow/calendar_edit.png',
'disk' => '/rsrc/image/icon/fatcow/calendar_edit.png',
'type' => 'png',
),
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
'/rsrc/image/icon/fatcow/document_black.png' =>
array(
'hash' => '44d65a7f05a9c921719deedc160d68f7',
'uri' => '/res/44d65a7f/rsrc/image/icon/fatcow/document_black.png',
'disk' => '/rsrc/image/icon/fatcow/document_black.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/icon/fatcow/flag_blue.png' =>
array(
'hash' => '75a080492f900fbe489e4b27e403962b',
'uri' => '/res/75a08049/rsrc/image/icon/fatcow/flag_blue.png',
'disk' => '/rsrc/image/icon/fatcow/flag_blue.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_finish.png' =>
array(
'hash' => '4af11fc7fab8e4610cbc3c88a02d4f78',
'uri' => '/res/4af11fc7/rsrc/image/icon/fatcow/flag_finish.png',
'disk' => '/rsrc/image/icon/fatcow/flag_finish.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_ghost.png' =>
array(
'hash' => '14c9f30a37b43f276f27a27a924bf02d',
'uri' => '/res/14c9f30a/rsrc/image/icon/fatcow/flag_ghost.png',
'disk' => '/rsrc/image/icon/fatcow/flag_ghost.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_green.png' =>
array(
'hash' => 'fed01374cd396cb774872762dcc447e1',
'uri' => '/res/fed01374/rsrc/image/icon/fatcow/flag_green.png',
'disk' => '/rsrc/image/icon/fatcow/flag_green.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_orange.png' =>
array(
'hash' => '88008cb8bb99761a37e5a743e2455aeb',
'uri' => '/res/88008cb8/rsrc/image/icon/fatcow/flag_orange.png',
'disk' => '/rsrc/image/icon/fatcow/flag_orange.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_pink.png' =>
array(
'hash' => '2f199f06ffc3dfc81b7561a057e0bc33',
'uri' => '/res/2f199f06/rsrc/image/icon/fatcow/flag_pink.png',
'disk' => '/rsrc/image/icon/fatcow/flag_pink.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_purple.png' =>
array(
'hash' => '16358629dc86c39550b575586eb5df80',
'uri' => '/res/16358629/rsrc/image/icon/fatcow/flag_purple.png',
'disk' => '/rsrc/image/icon/fatcow/flag_purple.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_red.png' =>
array(
'hash' => '210c28b4d93c439a499f5814f5e05772',
'uri' => '/res/210c28b4/rsrc/image/icon/fatcow/flag_red.png',
'disk' => '/rsrc/image/icon/fatcow/flag_red.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_yellow.png' =>
array(
'hash' => 'bdfd73744a80bb80329ae50bc8a5f962',
'uri' => '/res/bdfd7374/rsrc/image/icon/fatcow/flag_yellow.png',
'disk' => '/rsrc/image/icon/fatcow/flag_yellow.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/folder.png' =>
array(
'hash' => '25e46cf9d210dde2242332296f79938c',
'uri' => '/res/25e46cf9/rsrc/image/icon/fatcow/folder.png',
'disk' => '/rsrc/image/icon/fatcow/folder.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/folder_go.png' =>
array(
'hash' => 'ba922ff7959309f51a14cb7ed5124d8b',
'uri' => '/res/ba922ff7/rsrc/image/icon/fatcow/folder_go.png',
'disk' => '/rsrc/image/icon/fatcow/folder_go.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/key_question.png' =>
array(
'hash' => '530a6448a4b91edec091a9292ccfd3d9',
'uri' => '/res/530a6448/rsrc/image/icon/fatcow/key_question.png',
'disk' => '/rsrc/image/icon/fatcow/key_question.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/link.png' =>
array(
'hash' => 'be1bea49b216548433014f3324902928',
'uri' => '/res/be1bea49/rsrc/image/icon/fatcow/link.png',
'disk' => '/rsrc/image/icon/fatcow/link.png',
'type' => 'png',
),
Display flag in Flag dialog Summary: I had no idea what checkered is. Test Plan: Flagged revision, flagged task. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3346
2012-08-21 06:47:44 +02:00
'/rsrc/image/icon/fatcow/page_white_edit.png' =>
array(
'hash' => 'e7b7e7f2d9730bc80bc5c9eac1f3e36d',
'uri' => '/res/e7b7e7f2/rsrc/image/icon/fatcow/page_white_edit.png',
'disk' => '/rsrc/image/icon/fatcow/page_white_edit.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/icon/fatcow/page_white_link.png' =>
array(
'hash' => '1cfbad14412bda6c6f132dcc7c8725fd',
'uri' => '/res/1cfbad14/rsrc/image/icon/fatcow/page_white_link.png',
'disk' => '/rsrc/image/icon/fatcow/page_white_link.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/page_white_put.png' =>
array(
'hash' => 'bb7308aa5ac40137a8262da395a267fd',
'uri' => '/res/bb7308aa/rsrc/image/icon/fatcow/page_white_put.png',
'disk' => '/rsrc/image/icon/fatcow/page_white_put.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/page_white_text.png' =>
array(
'hash' => 'e47d590b626f617fb7d1d44e96e8fd11',
'uri' => '/res/e47d590b/rsrc/image/icon/fatcow/page_white_text.png',
'disk' => '/rsrc/image/icon/fatcow/page_white_text.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/conduit.png' =>
array(
'hash' => '1cae0656580aa3cd0b54b9d98306b1b9',
'uri' => '/res/1cae0656/rsrc/image/icon/fatcow/source/conduit.png',
'disk' => '/rsrc/image/icon/fatcow/source/conduit.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/email.png' =>
array(
'hash' => '93bdb3e168da1ed68f50c42125729d4e',
'uri' => '/res/93bdb3e1/rsrc/image/icon/fatcow/source/email.png',
'disk' => '/rsrc/image/icon/fatcow/source/email.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/fax.png' =>
array(
'hash' => 'd7dedf229841f2d041b347afd881596f',
'uri' => '/res/d7dedf22/rsrc/image/icon/fatcow/source/fax.png',
'disk' => '/rsrc/image/icon/fatcow/source/fax.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/mobile.png' =>
array(
'hash' => '786e7146d1e7d7318baf76c9d2baad97',
'uri' => '/res/786e7146/rsrc/image/icon/fatcow/source/mobile.png',
'disk' => '/rsrc/image/icon/fatcow/source/mobile.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/tablet.png' =>
array(
'hash' => '374cd40e4965be6b2fbdef4059d0ca05',
'uri' => '/res/374cd40e/rsrc/image/icon/fatcow/source/tablet.png',
'disk' => '/rsrc/image/icon/fatcow/source/tablet.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/web.png' =>
array(
'hash' => 'f4882a8f5619ba505ca033f72a340635',
'uri' => '/res/f4882a8f/rsrc/image/icon/fatcow/source/web.png',
'disk' => '/rsrc/image/icon/fatcow/source/web.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/default160x120.png' =>
array(
'hash' => '1b52ebd1fe0eee3ed0abfc382991b265',
'uri' => '/res/1b52ebd1/rsrc/image/icon/fatcow/thumbnails/default160x120.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/default160x120.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/default60x45.png' =>
array(
'hash' => '048d851d8d1daad4754e891e734c1899',
'uri' => '/res/048d851d/rsrc/image/icon/fatcow/thumbnails/default60x45.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/default60x45.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/image160x120.png' =>
array(
'hash' => '434acbd8dbbc2da9f09f6205a396eba1',
'uri' => '/res/434acbd8/rsrc/image/icon/fatcow/thumbnails/image160x120.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/image160x120.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/image60x45.png' =>
array(
'hash' => '29f7872dc53588fe0b8f0b330c7ee23a',
'uri' => '/res/29f7872d/rsrc/image/icon/fatcow/thumbnails/image60x45.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/image60x45.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/pdf160x120.png' =>
array(
'hash' => '39d2e22541658a3472ba41ae2fa548e5',
'uri' => '/res/39d2e225/rsrc/image/icon/fatcow/thumbnails/pdf160x120.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/pdf160x120.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/pdf60x45.png' =>
array(
'hash' => 'b3572e9317cbed5184d12bdfabed2727',
'uri' => '/res/b3572e93/rsrc/image/icon/fatcow/thumbnails/pdf60x45.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/pdf60x45.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/zip160x120.png' =>
array(
'hash' => 'e505108688a903b5cfb674707a289bcc',
'uri' => '/res/e5051086/rsrc/image/icon/fatcow/thumbnails/zip160x120.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/zip160x120.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/zip60x45.png' =>
array(
'hash' => 'f00716f4e8f7a95e70d43504f06be0a6',
'uri' => '/res/f00716f4/rsrc/image/icon/fatcow/thumbnails/zip60x45.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/zip60x45.png',
'type' => 'png',
),
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
'/rsrc/image/icon/lightbox/close-2.png' =>
array(
'hash' => '72ff3ddcc1ed5d19a715ed6242114b53',
'uri' => '/res/72ff3ddc/rsrc/image/icon/lightbox/close-2.png',
'disk' => '/rsrc/image/icon/lightbox/close-2.png',
'type' => 'png',
),
'/rsrc/image/icon/lightbox/close-hover-2.png' =>
array(
'hash' => '6ad4bd4a7820547a1d9041752546ba16',
'uri' => '/res/6ad4bd4a/rsrc/image/icon/lightbox/close-hover-2.png',
'disk' => '/rsrc/image/icon/lightbox/close-hover-2.png',
'type' => 'png',
),
'/rsrc/image/icon/lightbox/left-arrow-2.png' =>
array(
'hash' => 'd84cbb0d42739f87b8f25b2f1d2f1153',
'uri' => '/res/d84cbb0d/rsrc/image/icon/lightbox/left-arrow-2.png',
'disk' => '/rsrc/image/icon/lightbox/left-arrow-2.png',
'type' => 'png',
),
'/rsrc/image/icon/lightbox/left-arrow-hover-2.png' =>
array(
'hash' => 'cdf05f98fff3f390cd8df0c89894a3e1',
'uri' => '/res/cdf05f98/rsrc/image/icon/lightbox/left-arrow-hover-2.png',
'disk' => '/rsrc/image/icon/lightbox/left-arrow-hover-2.png',
'type' => 'png',
),
'/rsrc/image/icon/lightbox/right-arrow-2.png' =>
array(
'hash' => '52021038cb6995c71f62a804bc2d420d',
'uri' => '/res/52021038/rsrc/image/icon/lightbox/right-arrow-2.png',
'disk' => '/rsrc/image/icon/lightbox/right-arrow-2.png',
'type' => 'png',
),
'/rsrc/image/icon/lightbox/right-arrow-hover-2.png' =>
array(
'hash' => '65d5756b7b9cfcdeb2eb197a9aa6bbd2',
'uri' => '/res/65d5756b/rsrc/image/icon/lightbox/right-arrow-hover-2.png',
'disk' => '/rsrc/image/icon/lightbox/right-arrow-hover-2.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/icon/subscribe.png' =>
array(
'hash' => '5f47a4b17de245af39a4e7a097e40623',
'uri' => '/res/5f47a4b1/rsrc/image/icon/subscribe.png',
'disk' => '/rsrc/image/icon/subscribe.png',
'type' => 'png',
),
'/rsrc/image/icon/tango/attachment.png' =>
array(
'hash' => '776fed2de89803fd8a0ba4b9deede230',
'uri' => '/res/776fed2d/rsrc/image/icon/tango/attachment.png',
'disk' => '/rsrc/image/icon/tango/attachment.png',
'type' => 'png',
),
'/rsrc/image/icon/tango/edit.png' =>
array(
'hash' => 'c0028d99dcf4e9559bbf3c88ce2d8a8d',
'uri' => '/res/c0028d99/rsrc/image/icon/tango/edit.png',
'disk' => '/rsrc/image/icon/tango/edit.png',
'type' => 'png',
),
Open files in very large diffs inline Summary: This allows writing inline comments and reduces different behavior between normal and very large diffs. Test Plan: Verify that normal diff works. Verify that very large diff works. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2361
2012-05-01 21:09:50 +02:00
'/rsrc/image/icon/tango/go-down.png' =>
array(
'hash' => '96862812cbb0445573c264dc057b8300',
'uri' => '/res/96862812/rsrc/image/icon/tango/go-down.png',
'disk' => '/rsrc/image/icon/tango/go-down.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/icon/tango/log.png' =>
array(
'hash' => 'a6f72499bef279ff6807a7dbc5148f1e',
'uri' => '/res/a6f72499/rsrc/image/icon/tango/log.png',
'disk' => '/rsrc/image/icon/tango/log.png',
'type' => 'png',
),
'/rsrc/image/icon/tango/upload.png' =>
array(
'hash' => '8c11b63d6d99db3d7159c5d9a94e3062',
'uri' => '/res/8c11b63d/rsrc/image/icon/tango/upload.png',
'disk' => '/rsrc/image/icon/tango/upload.png',
'type' => 'png',
),
'/rsrc/image/icon/unsubscribe.png' =>
array(
'hash' => '29429ad65aa3af50b072b32087057361',
'uri' => '/res/29429ad6/rsrc/image/icon/unsubscribe.png',
'disk' => '/rsrc/image/icon/unsubscribe.png',
'type' => 'png',
),
Simplify lightboxing and fix a few things Summary: Minor tweaks to lightboxes. - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it. - Make the lightbox go over the menu bar -- was it intentional that it wasn't? - Make 'jx-mask' use "position: fixed;" too. - Add a loading indicator. - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area. I'm going to do a couple of other tweaks here but need to update JX.Mask. Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3795
2012-10-24 02:34:43 +02:00
'/rsrc/image/loading.gif' =>
array(
'hash' => '664297671941142f37d8c89e717ff2ce',
'uri' => '/res/66429767/rsrc/image/loading.gif',
'disk' => '/rsrc/image/loading.gif',
'type' => 'gif',
),
Fix full width form layouts Summary: Fixes T3473, mostly reverts previous changes to clean up required field text, will have to redesign that in general for responsiveness. Test Plan: use logout form, use new conpherence form Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3473 Differential Revision: https://secure.phabricator.com/D6371
2013-07-04 05:24:28 +02:00
'/rsrc/image/loading/boating_24.gif' =>
array(
'hash' => '2cd349ded48d698ebe886ba97b2db0f7',
'uri' => '/res/2cd349de/rsrc/image/loading/boating_24.gif',
'disk' => '/rsrc/image/loading/boating_24.gif',
'type' => 'gif',
),
'/rsrc/image/loading/compass_24.gif' =>
array(
'hash' => '726c1ed4bf23446e044d6b9d28250a07',
'uri' => '/res/726c1ed4/rsrc/image/loading/compass_24.gif',
'disk' => '/rsrc/image/loading/compass_24.gif',
'type' => 'gif',
),
Add 24px and 48 loading graphics. Summary: Fixes T3156 - Adds nautical loading indicators. Test Plan: Photoshop Reviewers: epriestley, btrahan Reviewed By: btrahan CC: aran, Korvin Maniphest Tasks: T3156 Differential Revision: https://secure.phabricator.com/D5905
2013-05-14 20:28:39 +02:00
'/rsrc/image/loading/loading_24.gif' =>
array(
'hash' => 'd6dcc5e6111a44fb9a160fc27b19d85c',
'uri' => '/res/d6dcc5e6/rsrc/image/loading/loading_24.gif',
'disk' => '/rsrc/image/loading/loading_24.gif',
'type' => 'gif',
),
'/rsrc/image/loading/loading_48.gif' =>
array(
'hash' => 'cb6fc6eb9c0a0efaf589978029080c58',
'uri' => '/res/cb6fc6eb/rsrc/image/loading/loading_48.gif',
'disk' => '/rsrc/image/loading/loading_48.gif',
'type' => 'gif',
),
Fix full width form layouts Summary: Fixes T3473, mostly reverts previous changes to clean up required field text, will have to redesign that in general for responsiveness. Test Plan: use logout form, use new conpherence form Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3473 Differential Revision: https://secure.phabricator.com/D6371
2013-07-04 05:24:28 +02:00
'/rsrc/image/loading/loading_d48.gif' =>
array(
'hash' => 'c5181f5e0ac8125ad9beda73fdf18e91',
'uri' => '/res/c5181f5e/rsrc/image/loading/loading_d48.gif',
'disk' => '/rsrc/image/loading/loading_d48.gif',
'type' => 'gif',
),
'/rsrc/image/loading/loading_w24.gif' =>
array(
'hash' => '231857d68736e9bdda6bdbaaf924b8da',
'uri' => '/res/231857d6/rsrc/image/loading/loading_w24.gif',
'disk' => '/rsrc/image/loading/loading_w24.gif',
'type' => 'gif',
),
Minor, updates from @chad: - Use a gradient on the main menu. - Slightly darken the application menu. - Use kerned logo text. - Use cleaner logo image. - Adjust search input colors to fit the darker scheme better.
2012-08-21 01:02:36 +02:00
'/rsrc/image/main_texture.png' =>
array(
'hash' => 'e34d8143384721be73ec9b7532a977ab',
'uri' => '/res/e34d8143/rsrc/image/main_texture.png',
'disk' => '/rsrc/image/main_texture.png',
'type' => 'png',
),
Fix various app nav issues Summary: - Fix width, corresponding to wider sprites. - Sprite the "Audit" icon. - Mark the meta-application as device-ready. - Fix some collapse/expand bugs with the draggable local navs. - Add texture to local nav. - Darken the application nav to make it more cohesive with the main nav. I think this is an improvement? Test Plan: See screenshots. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran, netfoxcity Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3338
2012-08-20 23:13:15 +02:00
'/rsrc/image/menu_texture.png' =>
array(
Dark sidebar everywhere Summary: First pass at testing out a dark sidebar everywhere. Wanting feedback with real test time before implementing before commiting. Thoughts - Aligns with Mobile, Tablet UI experience. - Creates 'application' feel on Desktop. - Begins to make Phabricator feel like a branded UI. Cons - Probably contensious visually. TODO: - Update diff view sidebar. - Make breadcrumbs appear above content area, not above nav. - Change background texture on crumbs to match table headers. Test Plan: Testing Nav with fellow co-workers. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4427
2013-01-14 22:40:51 +01:00
'hash' => 'ad020b1529b3a3b3480ca9de1d5f1e40',
'uri' => '/res/ad020b15/rsrc/image/menu_texture.png',
Fix various app nav issues Summary: - Fix width, corresponding to wider sprites. - Sprite the "Audit" icon. - Mark the meta-application as device-ready. - Fix some collapse/expand bugs with the draggable local navs. - Add texture to local nav. - Darken the application nav to make it more cohesive with the main nav. I think this is an improvement? Test Plan: See screenshots. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran, netfoxcity Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3338
2012-08-20 23:13:15 +02:00
'disk' => '/rsrc/image/menu_texture.png',
'type' => 'png',
),
Minor, fix celerity map.
2013-04-01 05:07:47 +02:00
'/rsrc/image/people/harding.png' =>
array(
'hash' => '818b035ace2c480aa8df7b7f11cef58b',
'uri' => '/res/818b035a/rsrc/image/people/harding.png',
'disk' => '/rsrc/image/people/harding.png',
'type' => 'png',
),
'/rsrc/image/people/jefferson.png' =>
array(
'hash' => '55fe807ff02f9320e595fb59442e2038',
'uri' => '/res/55fe807f/rsrc/image/people/jefferson.png',
'disk' => '/rsrc/image/people/jefferson.png',
'type' => 'png',
),
'/rsrc/image/people/lincoln.png' =>
array(
'hash' => '2363337947ab52fd5fda79e4a004e930',
'uri' => '/res/23633379/rsrc/image/people/lincoln.png',
'disk' => '/rsrc/image/people/lincoln.png',
'type' => 'png',
),
'/rsrc/image/people/mckinley.png' =>
array(
'hash' => '0b7b05dd47c49a0874670e5e8200bba8',
'uri' => '/res/0b7b05dd/rsrc/image/people/mckinley.png',
'disk' => '/rsrc/image/people/mckinley.png',
'type' => 'png',
),
'/rsrc/image/people/taft.png' =>
array(
'hash' => 'f3e47d45b59b0b009fd536dabae9a151',
'uri' => '/res/f3e47d45/rsrc/image/people/taft.png',
'disk' => '/rsrc/image/people/taft.png',
'type' => 'png',
),
'/rsrc/image/people/washington.png' =>
array(
'hash' => '01412761cab769f7993d69eba986d949',
'uri' => '/res/01412761/rsrc/image/people/washington.png',
'disk' => '/rsrc/image/people/washington.png',
'type' => 'png',
),
'/rsrc/image/phrequent_active.png' =>
array(
'hash' => '716cddc08630eaa33934b2008723cac0',
'uri' => '/res/716cddc0/rsrc/image/phrequent_active.png',
'disk' => '/rsrc/image/phrequent_active.png',
'type' => 'png',
),
'/rsrc/image/phrequent_inactive.png' =>
array(
'hash' => 'f9099683873c01c5de1dc6650bd668fe',
'uri' => '/res/f9099683/rsrc/image/phrequent_inactive.png',
'disk' => '/rsrc/image/phrequent_inactive.png',
'type' => 'png',
),
Switch to new menubar Summary: - Looks better (can probably still use some tweaks), especially search. - Moves logout from weird footer location to main menu. - Reactive: on tablets and phones, the menu adjusts to remain useful. - Fixed position on desktops for future side nav changes. - Adds an icon header thing that's currently hard-coded but will be application-driven soon. Test Plan: Used menu on desktop, tablet, phone, logged in / logged out, toggled darkconsole. Will add some screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3105
2012-07-31 01:09:14 +02:00
'/rsrc/image/search.png' =>
array(
Minor, reduce prominence of main menu icons.
2012-08-06 00:07:12 +02:00
'hash' => 'ff7da044e6f923b8f569dec11f97e5e5',
'uri' => '/res/ff7da044/rsrc/image/search.png',
Switch to new menubar Summary: - Looks better (can probably still use some tweaks), especially search. - Moves logout from weird footer location to main menu. - Reactive: on tablets and phones, the menu adjusts to remain useful. - Fixed position on desktops for future side nav changes. - Adds an icon header thing that's currently hard-coded but will be application-driven soon. Test Plan: Used menu on desktop, tablet, phone, logged in / logged out, toggled darkconsole. Will add some screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3105
2012-07-31 01:09:14 +02:00
'disk' => '/rsrc/image/search.png',
'type' => 'png',
),
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'/rsrc/image/sprite-actions-X2.png' =>
array(
Add up, down, and token action icons. Summary: Will use these in feed, other places. Test Plan: Photoshop, uiexamples. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5746
2013-04-22 20:21:00 +02:00
'hash' => '06962a5e8bea98ba7418d1d6cabcd7dc',
'uri' => '/res/06962a5e/rsrc/image/sprite-actions-X2.png',
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'disk' => '/rsrc/image/sprite-actions-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-actions.png' =>
array(
Add up, down, and token action icons. Summary: Will use these in feed, other places. Test Plan: Photoshop, uiexamples. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5746
2013-04-22 20:21:00 +02:00
'hash' => 'd5dda5fab1e61b00538c9a4fa1ee94c8',
'uri' => '/res/d5dda5fa/rsrc/image/sprite-actions.png',
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'disk' => '/rsrc/image/sprite-actions.png',
'type' => 'png',
),
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'/rsrc/image/sprite-apps-X2.png' =>
array(
Celery!
2013-07-29 21:07:35 +02:00
'hash' => 'd12f41da14b7f0b5a364a59a65fc67cd',
'uri' => '/res/d12f41da/rsrc/image/sprite-apps-X2.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/sprite-apps-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-apps-large-X2.png' =>
array(
Celery!
2013-07-29 21:07:35 +02:00
'hash' => '0ad432a9b02c2a9228389e71c3f2b590',
'uri' => '/res/0ad432a9/rsrc/image/sprite-apps-large-X2.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/sprite-apps-large-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-apps-large.png' =>
array(
Celery!
2013-07-29 21:07:35 +02:00
'hash' => 'a3addc473c11d6597a922a4c7d943357',
'uri' => '/res/a3addc47/rsrc/image/sprite-apps-large.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/sprite-apps-large.png',
'type' => 'png',
),
'/rsrc/image/sprite-apps-xlarge.png' =>
array(
Added Feed icons. Summary: Adds a feed icon for feed applications. Test Plan: Photoshop Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4388
2013-01-10 19:00:18 +01:00
'hash' => '992d2c278b6a22c0fa874d457a252fbd',
'uri' => '/res/992d2c27/rsrc/image/sprite-apps-xlarge.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/sprite-apps-xlarge.png',
'type' => 'png',
),
'/rsrc/image/sprite-apps.png' =>
array(
Celery!
2013-07-29 21:07:35 +02:00
'hash' => 'c801a581ebbb0db851cd6623d7b8f175',
'uri' => '/res/c801a581/rsrc/image/sprite-apps.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/sprite-apps.png',
'type' => 'png',
),
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'/rsrc/image/sprite-conpherence-X2.png' =>
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
array(
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'hash' => '5e47868b00933a9afb6c844e464e6b23',
'uri' => '/res/5e47868b/rsrc/image/sprite-conpherence-X2.png',
'disk' => '/rsrc/image/sprite-conpherence-X2.png',
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
'type' => 'png',
),
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'/rsrc/image/sprite-conpherence.png' =>
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
array(
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'hash' => 'ca51f1be25213262d68e626e4cab7f0f',
'uri' => '/res/ca51f1be/rsrc/image/sprite-conpherence.png',
'disk' => '/rsrc/image/sprite-conpherence.png',
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
'type' => 'png',
),
Document icons sprite sheet. Summary: Adds 32 and 64 px images to represent basic documents. Test Plan: Differential Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5317
2013-03-10 22:16:16 +01:00
'/rsrc/image/sprite-docs-X2.png' =>
array(
'hash' => '57d3286ce88133f3ec9240e35f6bb897',
'uri' => '/res/57d3286c/rsrc/image/sprite-docs-X2.png',
'disk' => '/rsrc/image/sprite-docs-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-docs.png' =>
array(
'hash' => 'b2b089072d6eddd831402a77c02b5736',
'uri' => '/res/b2b08907/rsrc/image/sprite-docs.png',
'disk' => '/rsrc/image/sprite-docs.png',
'type' => 'png',
),
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'/rsrc/image/sprite-gradient.png' =>
array(
Add objectheaders to new View Summary: This adds the 'PHUIObjectBox' to nearly every place that should get it. I need to comb through Diffusion a little more. I've left Differential mostly alone, but may decide to do it anyways this weekend. I'm sure I missed something else, but these are easy enough to update. Test Plan: tested each new layout. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7162
2013-09-29 00:55:38 +02:00
'hash' => '1f0306b0ca281b1e5b96de0096269f1d',
'uri' => '/res/1f0306b0/rsrc/image/sprite-gradient.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/sprite-gradient.png',
'type' => 'png',
),
Add action icons to object list views Summary: We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well. Instead, provide first-class actions: {F42978} They produce targets which my meaty ham-fists can plausibly hit on mobile, too: {F42979} (We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?) Test Plan: Added UIExamples. Checked desktop/mobile. Reviewers: chad, btrahan, edward Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
'/rsrc/image/sprite-icons-X2.png' =>
Generate an icon sprite map with new sprites and 2x retina graphics Summary: - The filesystem is now the authority for which sprites are available. If you add new icons, the generation process will pick them up. - I broke out icon generation and added retina support. App icon generation still uses the old method. - Update ActionList and RemarkupControl to use the new sheet. - Use white icons on hover. - Also fixed a couple of minor issues with some stuff in Firefox/Chrome. Test Plan: {F25750} {F25751} {F25752} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2013 Differential Revision: https://secure.phabricator.com/D4027
2012-11-24 01:35:39 +01:00
array(
New icons for Maniphest Summary: Fixes 2x white icons, adds 'user' and 'project' icons. Test Plan: tested new states in Maniphest Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7176
2013-09-30 02:53:37 +02:00
'hash' => '73be48fb682888800fd17511814c14cc',
'uri' => '/res/73be48fb/rsrc/image/sprite-icons-X2.png',
Add action icons to object list views Summary: We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well. Instead, provide first-class actions: {F42978} They produce targets which my meaty ham-fists can plausibly hit on mobile, too: {F42979} (We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?) Test Plan: Added UIExamples. Checked desktop/mobile. Reviewers: chad, btrahan, edward Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
'disk' => '/rsrc/image/sprite-icons-X2.png',
Generate an icon sprite map with new sprites and 2x retina graphics Summary: - The filesystem is now the authority for which sprites are available. If you add new icons, the generation process will pick them up. - I broke out icon generation and added retina support. App icon generation still uses the old method. - Update ActionList and RemarkupControl to use the new sheet. - Use white icons on hover. - Also fixed a couple of minor issues with some stuff in Firefox/Chrome. Test Plan: {F25750} {F25751} {F25752} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2013 Differential Revision: https://secure.phabricator.com/D4027
2012-11-24 01:35:39 +01:00
'type' => 'png',
),
Add action icons to object list views Summary: We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well. Instead, provide first-class actions: {F42978} They produce targets which my meaty ham-fists can plausibly hit on mobile, too: {F42979} (We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?) Test Plan: Added UIExamples. Checked desktop/mobile. Reviewers: chad, btrahan, edward Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
'/rsrc/image/sprite-icons.png' =>
Generate an icon sprite map with new sprites and 2x retina graphics Summary: - The filesystem is now the authority for which sprites are available. If you add new icons, the generation process will pick them up. - I broke out icon generation and added retina support. App icon generation still uses the old method. - Update ActionList and RemarkupControl to use the new sheet. - Use white icons on hover. - Also fixed a couple of minor issues with some stuff in Firefox/Chrome. Test Plan: {F25750} {F25751} {F25752} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2013 Differential Revision: https://secure.phabricator.com/D4027
2012-11-24 01:35:39 +01:00
array(
New icons for Maniphest Summary: Fixes 2x white icons, adds 'user' and 'project' icons. Test Plan: tested new states in Maniphest Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7176
2013-09-30 02:53:37 +02:00
'hash' => '2059f27be8339fe752ed99c29ef9ae1c',
'uri' => '/res/2059f27b/rsrc/image/sprite-icons.png',
Add action icons to object list views Summary: We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well. Instead, provide first-class actions: {F42978} They produce targets which my meaty ham-fists can plausibly hit on mobile, too: {F42979} (We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?) Test Plan: Added UIExamples. Checked desktop/mobile. Reviewers: chad, btrahan, edward Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
'disk' => '/rsrc/image/sprite-icons.png',
Generate an icon sprite map with new sprites and 2x retina graphics Summary: - The filesystem is now the authority for which sprites are available. If you add new icons, the generation process will pick them up. - I broke out icon generation and added retina support. App icon generation still uses the old method. - Update ActionList and RemarkupControl to use the new sheet. - Use white icons on hover. - Also fixed a couple of minor issues with some stuff in Firefox/Chrome. Test Plan: {F25750} {F25751} {F25752} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2013 Differential Revision: https://secure.phabricator.com/D4027
2012-11-24 01:35:39 +01:00
'type' => 'png',
),
Login icons Summary: Took a stab at some login icons for buttons. Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6174
2013-06-11 19:22:09 +02:00
'/rsrc/image/sprite-login-X2.png' =>
array(
Jira, TwitchTV login icons Summary: icons Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6716
2013-08-11 20:00:38 +02:00
'hash' => 'cd7eb19a0428c6be90c48cd2329a35fc',
'uri' => '/res/cd7eb19a/rsrc/image/sprite-login-X2.png',
Login icons Summary: Took a stab at some login icons for buttons. Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6174
2013-06-11 19:22:09 +02:00
'disk' => '/rsrc/image/sprite-login-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-login.png' =>
array(
Jira, TwitchTV login icons Summary: icons Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6716
2013-08-11 20:00:38 +02:00
'hash' => '788be2fd8e1f80b9faec9f5cf4bd5f4b',
'uri' => '/res/788be2fd/rsrc/image/sprite-login.png',
Login icons Summary: Took a stab at some login icons for buttons. Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6174
2013-06-11 19:22:09 +02:00
'disk' => '/rsrc/image/sprite-login.png',
'type' => 'png',
),
Use "flame" notification icon and bubble instead of lightning bolt Summary: Switch to the final versions of these Test Plan: Will add screenshots... Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4032
2012-11-27 23:03:25 +01:00
'/rsrc/image/sprite-menu-X2.png' =>
array(
Mobile "quick create" icons. Summary: icons. Test Plan: for mobile. Reviewers: epriestley, tomo Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6599
2013-07-28 22:47:09 +02:00
'hash' => '63b649a6ccba7bf76bc9456dc5dfb12b',
'uri' => '/res/63b649a6/rsrc/image/sprite-menu-X2.png',
Use "flame" notification icon and bubble instead of lightning bolt Summary: Switch to the final versions of these Test Plan: Will add screenshots... Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4032
2012-11-27 23:03:25 +01:00
'disk' => '/rsrc/image/sprite-menu-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-menu.png' =>
array(
Mobile "quick create" icons. Summary: icons. Test Plan: for mobile. Reviewers: epriestley, tomo Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6599
2013-07-28 22:47:09 +02:00
'hash' => 'e0e16618691d2cffe64e9c57843828ff',
'uri' => '/res/e0e16618/rsrc/image/sprite-menu.png',
Use "flame" notification icon and bubble instead of lightning bolt Summary: Switch to the final versions of these Test Plan: Will add screenshots... Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4032
2012-11-27 23:03:25 +01:00
'disk' => '/rsrc/image/sprite-menu.png',
'type' => 'png',
),
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'/rsrc/image/sprite-minicons-X2.png' =>
array(
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'hash' => 'c420c6462f7e50ca9941ccc5dd9e3dec',
'uri' => '/res/c420c646/rsrc/image/sprite-minicons-X2.png',
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'disk' => '/rsrc/image/sprite-minicons-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-minicons.png' =>
array(
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'hash' => '168bb875933624b3080a1cc134e5b4ed',
'uri' => '/res/168bb875/rsrc/image/sprite-minicons.png',
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'disk' => '/rsrc/image/sprite-minicons.png',
'type' => 'png',
),
Payment sprite icons. Summary: Adds some icons for taking money. Test Plan: UIExamples Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5753
2013-04-23 01:41:00 +02:00
'/rsrc/image/sprite-payments.png' =>
array(
Leafy Summary: Yummy greens Test Plan: Celerity Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5755
2013-04-23 01:43:29 +02:00
'hash' => '5ce73fb580609e7cda16832e3577b147',
'uri' => '/res/5ce73fb5/rsrc/image/sprite-payments.png',
Payment sprite icons. Summary: Adds some icons for taking money. Test Plan: UIExamples Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5753
2013-04-23 01:41:00 +02:00
'disk' => '/rsrc/image/sprite-payments.png',
'type' => 'png',
),
Projects Icons Series 1 Summary: A set of random icons for use as project identifiers. 42, white. Test Plan: photoshop, epriestley Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7290
2013-10-13 04:15:38 +02:00
'/rsrc/image/sprite-projects-X2.png' =>
array(
'hash' => '3bd29905e197068a75ace63880a2b6eb',
'uri' => '/res/3bd29905/rsrc/image/sprite-projects-X2.png',
'disk' => '/rsrc/image/sprite-projects-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-projects.png' =>
array(
'hash' => 'd9ec3fa470e6523520726ef75b011a03',
'uri' => '/res/d9ec3fa4/rsrc/image/sprite-projects.png',
'disk' => '/rsrc/image/sprite-projects.png',
'type' => 'png',
),
Status Icons Summary: Status icons for next to people names Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2064 Differential Revision: https://secure.phabricator.com/D6479
2013-07-17 17:44:11 +02:00
'/rsrc/image/sprite-status-X2.png' =>
array(
Fix retina ObjectHeader status icons Summary: There are reversed on retina displays/ Test Plan: Review on retina Mac Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7257
2013-10-07 17:47:40 +02:00
'hash' => 'ba4921c45c4de3e624e549bef9465fd9',
'uri' => '/res/ba4921c4/rsrc/image/sprite-status-X2.png',
Status Icons Summary: Status icons for next to people names Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2064 Differential Revision: https://secure.phabricator.com/D6479
2013-07-17 17:44:11 +02:00
'disk' => '/rsrc/image/sprite-status-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-status.png' =>
array(
ObjectHeader Status icons Summary: Adds status icons and colors to Maniphest and Differential. Also minor tweaks to them in hovercards. Probably some other stuff too. Test Plan: Test many diff and task states. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7098
2013-09-24 17:42:04 +02:00
'hash' => '438db33426faa98f938b1ebabd196763',
'uri' => '/res/438db334/rsrc/image/sprite-status.png',
Status Icons Summary: Status icons for next to people names Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2064 Differential Revision: https://secure.phabricator.com/D6479
2013-07-17 17:44:11 +02:00
'disk' => '/rsrc/image/sprite-status.png',
'type' => 'png',
),
Tokens v1 Summary: Features! - Giving tokens. - Taking tokens back. - Not giving tokens. Test Plan: See screenshots. Reviewers: chad, vrana Reviewed By: chad CC: aran, btrahan Maniphest Tasks: T2541 Differential Revision: https://secure.phabricator.com/D4964
2013-02-15 16:47:14 +01:00
'/rsrc/image/sprite-tokens.png' =>
array(
'hash' => '67c46fd75c885b76ecbfe46e71a476cc',
'uri' => '/res/67c46fd7/rsrc/image/sprite-tokens.png',
'disk' => '/rsrc/image/sprite-tokens.png',
'type' => 'png',
),
Add gradient to object-list cards Summary: Adds a gradient, also re-ran sprite generator to attempt to sprite - for some reason all images were un-optimized. Test Plan: Test on UI Examples page Reviewers: epriestley, btrahan Reviewed By: btrahan CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5354
2013-03-16 01:15:57 +01:00
'/rsrc/image/texture/card-gradient.png' =>
array(
Lighten up gradient on cards Summary: Taller gradient, lighter at bottom. Also fixed right corners. Test Plan: Chrome, Photoshop Reviewers: epriestley, asherkin Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5437
2013-03-24 03:50:26 +01:00
'hash' => '268b7fdd758d4bf99db8de6770aae8af',
'uri' => '/res/268b7fdd/rsrc/image/texture/card-gradient.png',
Add gradient to object-list cards Summary: Adds a gradient, also re-ran sprite generator to attempt to sprite - for some reason all images were un-optimized. Test Plan: Test on UI Examples page Reviewers: epriestley, btrahan Reviewed By: btrahan CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5354
2013-03-16 01:15:57 +01:00
'disk' => '/rsrc/image/texture/card-gradient.png',
'type' => 'png',
),
Tweak hover blue on homepage. Summary: Yay more images? Also imageoptim'd them. Test Plan: Chrome, FF Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4455
2013-01-16 01:17:53 +01:00
'/rsrc/image/texture/dark-menu-hover.png' =>
array(
'hash' => 'a214a732644be34872e895b338b5d639',
'uri' => '/res/a214a732/rsrc/image/texture/dark-menu-hover.png',
'disk' => '/rsrc/image/texture/dark-menu-hover.png',
'type' => 'png',
),
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'/rsrc/image/texture/dark-menu.png' =>
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
array(
Tweak hover blue on homepage. Summary: Yay more images? Also imageoptim'd them. Test Plan: Chrome, FF Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4455
2013-01-16 01:17:53 +01:00
'hash' => '41ee673a762cec48a154b456ad5ac204',
'uri' => '/res/41ee673a/rsrc/image/texture/dark-menu.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/texture/dark-menu.png',
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'type' => 'png',
),
Fix some ObjectItemList issues Summary: Safari has a weird bug with `border-radius` plus border color: {F35865} Move the uncolored borders to an internal div to fix this. Also tweak some positioning on icons for cards, and add a "magenta" color. Test Plan: {F35866} Reviewers: chad, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5338
2013-03-23 22:37:18 +01:00
'/rsrc/image/texture/grip.png' =>
array(
'hash' => 'f11bc231d241f1335cfca2933ad234e0',
'uri' => '/res/f11bc231/rsrc/image/texture/grip.png',
'disk' => '/rsrc/image/texture/grip.png',
'type' => 'png',
),
Minor, fix celerity map.
2013-04-01 05:07:47 +02:00
'/rsrc/image/texture/panel-header-gradient.png' =>
array(
'hash' => 'ad9204dd3ef5b12b645d80677d8ccead',
'uri' => '/res/ad9204dd/rsrc/image/texture/panel-header-gradient.png',
'disk' => '/rsrc/image/texture/panel-header-gradient.png',
'type' => 'png',
),
Fancy new headers Summary: Updates to the gradient logo and hashed background. Minor pixel tweaks. Test Plan: Test desktop and mobile. Check photoshop for alignment. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6487
2013-07-18 00:53:26 +02:00
'/rsrc/image/texture/phlnx-bg.png' =>
array(
'hash' => 'a55a694da8b3874ca7a3105b7818f3a0',
'uri' => '/res/a55a694d/rsrc/image/texture/phlnx-bg.png',
'disk' => '/rsrc/image/texture/phlnx-bg.png',
'type' => 'png',
),
Update PholioMockView Styles. Summary: Less janky sidebar, new 'photoshop-like' texture for image background. Test Plan: Tested mocks with and without side comments, hover over marked squares. Tested small and large images. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5216
2013-03-05 01:01:27 +01:00
'/rsrc/image/texture/pholio-background.gif' =>
array(
'hash' => 'cf4561af116edf393dc583e5119fb412',
'uri' => '/res/cf4561af/rsrc/image/texture/pholio-background.gif',
'disk' => '/rsrc/image/texture/pholio-background.gif',
'type' => 'gif',
),
Update tables to table-kit view. Summary: Reskinning tables to table-kit mocks, which includes new textures, spacing, slightly larger fonts. Looking for early feedback before adding in new row colors and other items into the class. Test Plan: http://phab1.pushlabs.net/uiexample/view/PhabricatorSortTableExample/ Reviewers: btrahan, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4396
2013-01-11 20:24:35 +01:00
'/rsrc/image/texture/table_header.png' =>
array(
'hash' => '4ed3f56a30d3749e8f62052b9735a316',
'uri' => '/res/4ed3f56a/rsrc/image/texture/table_header.png',
'disk' => '/rsrc/image/texture/table_header.png',
'type' => 'png',
),
'/rsrc/image/texture/table_header_hover.png' =>
array(
'hash' => 'ea1f71a604e9b4859de1e25751540437',
'uri' => '/res/ea1f71a6/rsrc/image/texture/table_header_hover.png',
'disk' => '/rsrc/image/texture/table_header_hover.png',
'type' => 'png',
),
Don't add trailing slash to Search Owners link Test Plan: Clicked it. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4609
2013-01-24 03:00:22 +01:00
'/rsrc/image/texture/table_header_tall.png' =>
array(
'hash' => 'b05525601f78d759f1c5e47fd9c1a8aa',
'uri' => '/res/b0552560/rsrc/image/texture/table_header_tall.png',
'disk' => '/rsrc/image/texture/table_header_tall.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/swf/aphlict.swf' =>
array(
Minor, update celerity map.
2012-06-12 02:52:17 +02:00
'hash' => '4b9a9d83bebaf254f3790e87b45c1f92',
'uri' => '/res/4b9a9d83/rsrc/swf/aphlict.swf',
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'disk' => '/rsrc/swf/aphlict.swf',
'type' => 'swf',
),
Re-run celerity mapper Summary: D5226 nixed something I put in the celerity map. This diff adds it back, along with a bunch of other changes that `./scripts/celerity_mapper.php webroot/` decided were super important. Test Plan: Repeatedly place click actions into the HTML `document`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5253
2013-03-06 15:15:24 +01:00
'aphront-bars' =>
array(
Standard colors for progress bars Summary: Consilidate some of the bar colors, used in Releeph? Test Plan: UIExamples Reviewers: epriestley Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6974
2013-09-13 17:29:16 +02:00
'uri' => '/res/dc8fd846/rsrc/css/aphront/aphront-bars.css',
Re-run celerity mapper Summary: D5226 nixed something I put in the celerity map. This diff adds it back, along with a bunch of other changes that `./scripts/celerity_mapper.php webroot/` decided were super important. Test Plan: Repeatedly place click actions into the HTML `document`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5253
2013-03-06 15:15:24 +01:00
'type' => 'css',
'requires' =>
array(
),
Move Aphront bars and notes out of 'core' Summary: Don't seem to be core Test Plan: Reran celerity Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5641
2013-04-10 05:39:54 +02:00
'disk' => '/rsrc/css/aphront/aphront-bars.css',
Re-run celerity mapper Summary: D5226 nixed something I put in the celerity map. This diff adds it back, along with a bunch of other changes that `./scripts/celerity_mapper.php webroot/` decided were super important. Test Plan: Repeatedly place click actions into the HTML `document`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5253
2013-03-06 15:15:24 +01:00
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'aphront-calendar-view-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/d5a33deb/rsrc/css/aphront/calendar-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/calendar-view.css',
),
'aphront-contextbar-view-css' =>
array(
Misc CSS tweaks, timeline, mobile Summary: - Fixes line height when many long tasks are attached to a task. - Tightens up mobile layout of timeline and object box - Clean up aphront context bar Test Plan: Tested all the changes, made tasks, stared at pixels. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Maniphest Tasks: T3891 Differential Revision: https://secure.phabricator.com/D7169
2013-09-29 16:26:39 +02:00
'uri' => '/res/46c6248f/rsrc/css/aphront/context-bar.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/context-bar.css',
),
'aphront-dark-console-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/5c341863/rsrc/css/aphront/dark-console.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/dark-console.css',
),
'aphront-dialog-view-css' =>
array(
Allow applications to define new policy capabilities Summary: Ref T603. I want to let applications define new capabilities (like "can manage global rules" in Herald) and get full support for them, including reasonable error strings in the UI. Currently, this is difficult for a couple of reasons. Partly this is just a code organization issue, which is easy to fix. The bigger thing is that we have a bunch of strings which depend on both the policy and capability, like: "You must be an administrator to view this object." "Administrator" is the policy, and "view" is the capability. That means every new capability has to add a string for each policy, and every new policy (should we introduce any) needs to add a string for each capability. And we can't do any piecemeal "You must be a {$role} to {$action} this object" becuase it's impossible to translate. Instead, make all the strings depend on //only// the policy, //only// the capability, or //only// the object type. This makes the dialogs read a little more strangely, but I think it's still pretty easy to understand, and it makes adding new stuff way way easier. Also provide more context, and more useful exception messages. Test Plan: - See screenshots. - Also triggered a policy exception and verified it was dramatically more useful than it used to be. Reviewers: btrahan, chad Reviewed By: btrahan CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7260
2013-10-07 22:28:58 +02:00
'uri' => '/res/830fa2de/rsrc/css/aphront/dialog-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/dialog-view.css',
),
'aphront-error-view-css' =>
array(
Color tweaks for action list, headers Summary: Starting to roll out the standard colors and spacing to action list, headers, and property views. Also softened the grey borders a hex. Test Plan: Review Maniphest and Differential on desktop and mobile. Felt the flow of standardization waft over me. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6869
2013-09-03 16:00:06 +02:00
'uri' => '/res/07a74e07/rsrc/css/aphront/error-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/error-view.css',
),
'aphront-list-filter-view-css' =>
array(
Color tweaks for action list, headers Summary: Starting to roll out the standard colors and spacing to action list, headers, and property views. Also softened the grey borders a hex. Test Plan: Review Maniphest and Differential on desktop and mobile. Felt the flow of standardization waft over me. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6869
2013-09-03 16:00:06 +02:00
'uri' => '/res/b770e0da/rsrc/css/aphront/list-filter-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/list-filter-view.css',
),
Minor, celerity map. (I've removed my merge rule; I think it's no good after the arc land updates of a while ago.)
2013-04-02 20:28:33 +02:00
'aphront-multi-column-view-css' =>
array(
Layout, spacing tweaks for new auth. Summary: Touches a lot of little spacing things here and there, stuck to 4px grid when possible, checked mobile views. Test Plan: Mobile, Logging In, Multiple Providers. Reviewers: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6220
2013-06-18 07:02:16 +02:00
'uri' => '/res/f7f25fb7/rsrc/css/aphront/multi-column.css',
Minor, celerity map. (I've removed my merge rule; I think it's no good after the arc land updates of a while ago.)
2013-04-02 20:28:33 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/multi-column.css',
),
AphrontNoteView Summary: This is supposed to look a lot like the way Remarkup renders a block of code, so you can render some out of context message inside another container. For example in Releeph, it renders a message someone has associated with a Releeph request. Test Plan: I've added an abstract uiexample, but the use case in Releeph is more explanatory: {F33900} Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D5125
2013-02-26 20:28:50 +01:00
'aphront-notes' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/ac115367/rsrc/css/aphront/aphront-notes.css',
AphrontNoteView Summary: This is supposed to look a lot like the way Remarkup renders a block of code, so you can render some out of context message inside another container. For example in Releeph, it renders a message someone has associated with a Releeph request. Test Plan: I've added an abstract uiexample, but the use case in Releeph is more explanatory: {F33900} Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D5125
2013-02-26 20:28:50 +01:00
'type' => 'css',
'requires' =>
array(
),
Move Aphront bars and notes out of 'core' Summary: Don't seem to be core Test Plan: Reran celerity Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5641
2013-04-10 05:39:54 +02:00
'disk' => '/rsrc/css/aphront/aphront-notes.css',
AphrontNoteView Summary: This is supposed to look a lot like the way Remarkup renders a block of code, so you can render some out of context message inside another container. For example in Releeph, it renders a message someone has associated with a Releeph request. Test Plan: I've added an abstract uiexample, but the use case in Releeph is more explanatory: {F33900} Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D5125
2013-02-26 20:28:50 +01:00
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'aphront-pager-view-css' =>
array(
When pagers aren't connected to an ObjectItemListView, put them in a little box Summary: Pagers in Maniphest (and, to some degree, apps like Pholio) get lost a bit. Put them in a little box. Test Plan: Looked at Maniphest and Pholio, pager was more obvious and less un-designed-looking. Reviewers: chad, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6987
2013-09-13 23:43:33 +02:00
'uri' => '/res/ea81aec0/rsrc/css/aphront/pager-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/pager-view.css',
),
'aphront-panel-view-css' =>
array(
Add objectheaders to new View Summary: This adds the 'PHUIObjectBox' to nearly every place that should get it. I need to comb through Diffusion a little more. I've left Differential mostly alone, but may decide to do it anyways this weekend. I'm sure I missed something else, but these are easy enough to update. Test Plan: tested each new layout. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7162
2013-09-29 00:55:38 +02:00
'uri' => '/res/70d7011b/rsrc/css/aphront/panel-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/panel-view.css',
),
'aphront-request-failure-view-css' =>
array(
'uri' => '/res/c9a43002/rsrc/css/aphront/request-failure-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/request-failure-view.css',
),
'aphront-table-view-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/24f51f0b/rsrc/css/aphront/table-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/table-view.css',
),
'aphront-tokenizer-control-css' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/36192cf2/rsrc/css/aphront/tokenizer.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
0 => 'aphront-typeahead-control-css',
),
'disk' => '/rsrc/css/aphront/tokenizer.css',
),
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'aphront-tooltip-css' =>
array(
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'uri' => '/res/3a7d8e07/rsrc/css/aphront/tooltip.css',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/tooltip.css',
),
Apront Two Column View Summary: Wanted to pull this out in case we don't use it in Maniphest, still useful perhaps in the future. Creates a sidebar that wraps when on mobile. Test Plan: Tested UIExample Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5321
2013-03-11 03:20:01 +01:00
'aphront-two-column-view-css' =>
array(
Phriction Redesign Summary: This is mostly minor, but visually it makes the wiki feel more 'page like' and better separates the actual content from other data displayed. Test Plan: Tested Chrome, iPhone, and iPad. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2686 Differential Revision: https://secure.phabricator.com/D5366
2013-04-12 00:05:50 +02:00
'uri' => '/res/4263aa98/rsrc/css/aphront/two-column.css',
Apront Two Column View Summary: Wanted to pull this out in case we don't use it in Maniphest, still useful perhaps in the future. Creates a sidebar that wraps when on mobile. Test Plan: Tested UIExample Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5321
2013-03-11 03:20:01 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/two-column.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'aphront-typeahead-control-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/c6ad64bb/rsrc/css/aphront/typeahead.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/typeahead.css',
),
Add login buttons for button logins, fix LDAP form Summary: Ref T1536. Test Plan: {F46555} {F46556} Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T1536 Differential Revision: https://secure.phabricator.com/D6209
2013-06-17 01:31:57 +02:00
'auth-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/9e544d3c/rsrc/css/application/auth/auth.css',
Add login buttons for button logins, fix LDAP form Summary: Ref T1536. Test Plan: {F46555} {F46556} Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T1536 Differential Revision: https://secure.phabricator.com/D6209
2013-06-17 01:31:57 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/auth/auth.css',
),
Display examples when editing configuratoin Summary: Show example config values to the user when available. Test Plan: {F28465} {F28466} Reviewers: btrahan, codeblock Reviewed By: btrahan CC: aran Maniphest Tasks: T2221, T2255 Differential Revision: https://secure.phabricator.com/D4311
2013-01-01 23:09:59 +01:00
'config-options-css' =>
array(
Make Maniphest task priorites user-customizable Summary: Drive these purely out of configuration after removing behavioral hardcodes in D6981. Test Plan: Mucked around with them: {F58128} {F58129} {F58130} Reviewers: btrahan Reviewed By: btrahan CC: chad, aran Differential Revision: https://secure.phabricator.com/D6984
2013-09-13 20:11:05 +02:00
'uri' => '/res/4b5b6779/rsrc/css/application/config/config-options.css',
Display examples when editing configuratoin Summary: Show example config values to the user when available. Test Plan: {F28465} {F28466} Reviewers: btrahan, codeblock Reviewed By: btrahan CC: aran Maniphest Tasks: T2221, T2255 Differential Revision: https://secure.phabricator.com/D4311
2013-01-01 23:09:59 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/config/config-options.css',
),
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'conpherence-menu-css' =>
array(
Remove dust pattern for common bg color. Summary: Depends on D6769, removes 'dust' and uses a similar color background. Test Plan: Review colors in sandbox. Reviewers: epriestley Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6772
2013-08-20 03:15:52 +02:00
'uri' => '/res/cae40b18/rsrc/css/application/conpherence/menu.css',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/conpherence/menu.css',
),
'conpherence-message-pane-css' =>
array(
Color consolidation Summary: Another pass at consolidating colors Test Plan: Test various pages and UI elements Reviewers: epriestley Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6905
2013-09-07 18:13:55 +02:00
'uri' => '/res/150f96d4/rsrc/css/application/conpherence/message-pane.css',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/conpherence/message-pane.css',
),
Conpherence - add dropdown menu Summary: Fixes T3641. Probably needs some @chad love though on colors and what have you. Technique was to jam this into the existing notifications stuff as much as possible. I think its "okay" but if we were to add more stuff here (like a 3rd application) this could get a quality pass to consolidate even more code. Test Plan: played with it in Chrome and Safari - looks reasonable Reviewers: chad, epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3641 Differential Revision: https://secure.phabricator.com/D6708
2013-08-08 22:43:33 +02:00
'conpherence-notification-css' =>
array(
Tweak colors on Conpherence Notification Menu Summary: Fixes T3690. Uses standard colors, smaller borders. Test Plan: Review Menu with and without a notification Reviewers: epriestley, btrahan Reviewed By: btrahan CC: Korvin, aran Maniphest Tasks: T3690 Differential Revision: https://secure.phabricator.com/D6710
2013-08-09 21:47:31 +02:00
'uri' => '/res/232c8cdb/rsrc/css/application/conpherence/notification.css',
Conpherence - add dropdown menu Summary: Fixes T3641. Probably needs some @chad love though on colors and what have you. Technique was to jam this into the existing notifications stuff as much as possible. I think its "okay" but if we were to add more stuff here (like a 3rd application) this could get a quality pass to consolidate even more code. Test Plan: played with it in Chrome and Safari - looks reasonable Reviewers: chad, epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3641 Differential Revision: https://secure.phabricator.com/D6708
2013-08-08 22:43:33 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/conpherence/notification.css',
),
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'conpherence-update-css' =>
array(
Merge branch 'master' into phutil_tag (Sync.)
2013-02-07 17:08:01 +01:00
'uri' => '/res/92094ed7/rsrc/css/application/conpherence/update.css',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/conpherence/update.css',
),
'conpherence-widget-pane-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/13478b94/rsrc/css/application/conpherence/widget-pane.css',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/conpherence/widget-pane.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'differential-changeset-view-css' =>
array(
Add objectheaders to new View Summary: This adds the 'PHUIObjectBox' to nearly every place that should get it. I need to comb through Diffusion a little more. I've left Differential mostly alone, but may decide to do it anyways this weekend. I'm sure I missed something else, but these are easy enough to update. Test Plan: tested each new layout. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7162
2013-09-29 00:55:38 +02:00
'uri' => '/res/5fd9d5c0/rsrc/css/application/differential/changeset-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/changeset-view.css',
),
'differential-core-view-css' =>
array(
Add objectheaders to new View Summary: This adds the 'PHUIObjectBox' to nearly every place that should get it. I need to comb through Diffusion a little more. I've left Differential mostly alone, but may decide to do it anyways this weekend. I'm sure I missed something else, but these are easy enough to update. Test Plan: tested each new layout. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7162
2013-09-29 00:55:38 +02:00
'uri' => '/res/7db1595a/rsrc/css/application/differential/core.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/core.css',
),
'differential-inline-comment-editor' =>
array(
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'uri' => '/res/e952d210/rsrc/js/application/differential/DifferentialInlineCommentEditor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-dom',
Use an inline dialog element for inline comments in Differential Summary: The current approach of using a modal overlay dialog to create/edit inline comments is pretty silly. Use an inline textarea instead. This element isn't perfect and we have some mild modalness issues, but I think it's better than the silly thing we've got going on right now. We can keep poking it as people break it. Test Plan: - Created comments; submitted and undid them in empty and nonempty states. Used undo for nonempty states + cancel. - Edited comments; saved and canceled them. Used undo for changed state. - Replied to comments; yada yada as above. - Deleted comments. - Did various modal trickery where I clicked "Reply" on something else with a dialog already up, this very mildly glitches but I think it's not a big issue. Reviewers: vrana, btrahan, Makinde, nh Reviewed By: vrana CC: aran, epriestley Maniphest Tasks: T431 Differential Revision: https://secure.phabricator.com/D1716
2012-02-29 23:28:48 +01:00
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-install',
4 => 'javelin-request',
5 => 'javelin-workflow',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/differential/DifferentialInlineCommentEditor.js',
),
'differential-local-commits-view-css' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/43774c46/rsrc/css/application/differential/local-commits-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/local-commits-view.css',
),
Further improve unit/lint rendering Summary: I think this improves things, let me know if you have feedback. Also addresses T840. Test Plan: See screenshots... Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, zeeg Maniphest Tasks: T840 Differential Revision: https://secure.phabricator.com/D2357
2012-05-01 19:15:56 +02:00
'differential-results-table-css' =>
array(
Minor Results table CSS updates Summary: Missed these in the previous pass. Long term I'd like to move the results to tabs, will probably mock those up today and ask for your help coding. Test Plan: Tested the changes on a diff. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7256
2013-10-07 17:41:01 +02:00
'uri' => '/res/5e37cf75/rsrc/css/application/differential/results-table.css',
Further improve unit/lint rendering Summary: I think this improves things, let me know if you have feedback. Also addresses T840. Test Plan: See screenshots... Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, zeeg Maniphest Tasks: T840 Differential Revision: https://secure.phabricator.com/D2357
2012-05-01 19:15:56 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/results-table.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'differential-revision-add-comment-css' =>
array(
'uri' => '/res/849748d3/rsrc/css/application/differential/add-comment.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/add-comment.css',
),
'differential-revision-comment-css' =>
array(
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'uri' => '/res/42c222f4/rsrc/css/application/differential/revision-comment.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-comment.css',
),
'differential-revision-comment-list-css' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/034e1948/rsrc/css/application/differential/revision-comment-list.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-comment-list.css',
),
'differential-revision-history-css' =>
array(
More grey text updates Summary: More grey tweaks, breaking these up so I can test and tweak each as needed. Test Plan: Review pages. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6866
2013-09-02 22:57:48 +02:00
'uri' => '/res/bb29e0e8/rsrc/css/application/differential/revision-history.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-history.css',
),
Highlight update time in revision list Summary: This is another experiment for reducing reviewers response time. I stole the idea (and colors) from [[ http://www.reviewboard.org/media/screenshots/2009/02/02/dashboard.png | ReviewBoard ]]. I actually quite like it (except when everything is red) and I can image that people will review just to have better color balance. The code is not production ready for these reasons: - We load holidays again and again for each revision. I couldn't cache it to static variable because it could persist multiple requests, right? - I don't know how to expand height to the whole cell (I'm really bad in CSS). - CSS rules are probably in wrong file. - We probably want to use different colors. This is how it looks: {F16406} Test Plan: Displayed revision list. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3190
2012-08-20 23:05:46 +02:00
'differential-revision-list-css' =>
array(
Sprite menu label and hover states Summary: These can all fit into the gradient sprite. Test Plan: Looked at menu with selected item, hovered over menu. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4453
2013-01-16 00:49:48 +01:00
'uri' => '/res/fe6c4721/rsrc/css/application/differential/revision-list.css',
Highlight update time in revision list Summary: This is another experiment for reducing reviewers response time. I stole the idea (and colors) from [[ http://www.reviewboard.org/media/screenshots/2009/02/02/dashboard.png | ReviewBoard ]]. I actually quite like it (except when everything is red) and I can image that people will review just to have better color balance. The code is not production ready for these reasons: - We load holidays again and again for each revision. I couldn't cache it to static variable because it could persist multiple requests, right? - I don't know how to expand height to the whole cell (I'm really bad in CSS). - CSS rules are probably in wrong file. - We probably want to use different colors. This is how it looks: {F16406} Test Plan: Displayed revision list. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3190
2012-08-20 23:05:46 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-list.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'differential-table-of-contents-css' =>
array(
More grey text updates Summary: More grey tweaks, breaking these up so I can test and tweak each as needed. Test Plan: Review pages. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6866
2013-09-02 22:57:48 +02:00
'uri' => '/res/79824664/rsrc/css/application/differential/table-of-contents.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/table-of-contents.css',
),
'diffusion-commit-view-css' =>
array(
Delete unused CSS Summary: Unused since D2062. Test Plan: View commit. View task. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2108
2012-04-05 19:47:20 +02:00
'uri' => '/res/b445944e/rsrc/css/application/diffusion/commit-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diffusion/commit-view.css',
),
Improve Diffusion behavior for externals Summary: - Feature request from Airtime that I missed in the feedback notes, came up yesterday. - Identify git submodules as "FILE_SUBMODULE", not "FILE_NORMAL". - Link git submodules to an external resolver endpoint, which tries to find commits in tracked repositories. - Identify git symlinks as "FILE_SYMLINK", not "FILE_NORMAL". - Add folder, file, symlink and externals icons. Test Plan: - externals/javelin is now identified as a submoudule and links to Javelin, not identified as a file and links to error. - bin/phd is now identified as a symlink. - Interfaces have pretty icons. Reviewers: btrahan, cpiro, ddfisher, keebuhm, allenjohnashton Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1975
2012-03-21 22:01:20 +01:00
'diffusion-icons-css' =>
array(
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'uri' => '/res/b93e32c9/rsrc/css/application/diffusion/diffusion-icons.css',
Improve Diffusion behavior for externals Summary: - Feature request from Airtime that I missed in the feedback notes, came up yesterday. - Identify git submodules as "FILE_SUBMODULE", not "FILE_NORMAL". - Link git submodules to an external resolver endpoint, which tries to find commits in tracked repositories. - Identify git symlinks as "FILE_SYMLINK", not "FILE_NORMAL". - Add folder, file, symlink and externals icons. Test Plan: - externals/javelin is now identified as a submoudule and links to Javelin, not identified as a file and links to error. - bin/phd is now identified as a symlink. - Interfaces have pretty icons. Reviewers: btrahan, cpiro, ddfisher, keebuhm, allenjohnashton Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1975
2012-03-21 22:01:20 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diffusion/diffusion-icons.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'diffusion-source-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/072800bb/rsrc/css/application/diffusion/diffusion-source.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diffusion/diffusion-source.css',
),
Generate PHP function documentation in Diviner Summary: Ref T988. Various improvements: - Generate function documentation, mostly correctly. - Raise some warnings about bad documentation. - Allow `.book` files to exclude paths from generation. - Add a book for technical docs. - Exclude "ghosts" from common queries (atoms which used to exist, but no longer do, but which we want to keep the PHIDs around for in case they come back later). This is a bit rough still, but puts us much closer to being able to get rid of the old Diviner. Test Plan: See screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T988 Differential Revision: https://secure.phabricator.com/D6812
2013-08-27 12:14:00 +02:00
'diviner-shared-css' =>
array(
PHUIPropertyListView Summary: This builds out and implements PHUIPropertyListView (container) and PHUIPropertyListItemView (section) as well as adding tabs. Test Plan: Tested each page I edited with the exception of Releeph and Phortune, though those changes look ok to me diff wise. Updated examples page with tabs. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7283
2013-10-11 16:53:56 +02:00
'uri' => '/res/2e831eea/rsrc/css/diviner/diviner-shared.css',
Generate PHP function documentation in Diviner Summary: Ref T988. Various improvements: - Generate function documentation, mostly correctly. - Raise some warnings about bad documentation. - Allow `.book` files to exclude paths from generation. - Add a book for technical docs. - Exclude "ghosts" from common queries (atoms which used to exist, but no longer do, but which we want to keep the PHIDs around for in case they come back later). This is a bit rough still, but puts us much closer to being able to get rid of the old Diviner. Test Plan: See screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T988 Differential Revision: https://secure.phabricator.com/D6812
2013-08-27 12:14:00 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/diviner/diviner-shared.css',
),
Modernize file uploads Summary: Modernizes file uploads. In particular: - Adds a mobile menu, with an "Upload File" item. - Adds crumbs to the list view, detail view and upload view. - Adds "Upload File" action to crumbs. - Moves upload file to a separate page. - Removes the combined upload file + recent files page. - Makes upload file use a normal file control by default (works on mobile). - Home page, file list and file upload page are now global drop targets which accept files dropped anywhere on them. Dragging a file into the window shows a mask and an instructional message. - User education on this is a little weak but I think that's a big can of worms? - Fixes a bug where dropping multiple files into a Remarkup text area produced bad results (resolves T2190). T879 is related, although it's specifically about Maniphest. I've declined to make global drop targets yet there because there are multiple drop targets on the page with different meanings. That UI needs updating in general. @chad, do we have an "upload" icon (counterpart to "download")? Test Plan: Uploaded files in Maniphest, Differential, Files, and from Home. Dragged and dropped multiple files into Differential. Used crumbs, mobile. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2190 Differential Revision: https://secure.phabricator.com/D4200
2012-12-17 01:34:01 +01:00
'global-drag-and-drop-css' =>
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
array(
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'uri' => '/res/4e24cb65/rsrc/css/application/files/global-drag-and-drop.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
Modernize file uploads Summary: Modernizes file uploads. In particular: - Adds a mobile menu, with an "Upload File" item. - Adds crumbs to the list view, detail view and upload view. - Adds "Upload File" action to crumbs. - Moves upload file to a separate page. - Removes the combined upload file + recent files page. - Makes upload file use a normal file control by default (works on mobile). - Home page, file list and file upload page are now global drop targets which accept files dropped anywhere on them. Dragging a file into the window shows a mask and an instructional message. - User education on this is a little weak but I think that's a big can of worms? - Fixes a bug where dropping multiple files into a Remarkup text area produced bad results (resolves T2190). T879 is related, although it's specifically about Maniphest. I've declined to make global drop targets yet there because there are multiple drop targets on the page with different meanings. That UI needs updating in general. @chad, do we have an "upload" icon (counterpart to "download")? Test Plan: Uploaded files in Maniphest, Differential, Files, and from Home. Dragged and dropped multiple files into Differential. Used crumbs, mobile. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2190 Differential Revision: https://secure.phabricator.com/D4200
2012-12-17 01:34:01 +01:00
'disk' => '/rsrc/css/application/files/global-drag-and-drop.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'herald-css' =>
array(
Clean up Login, Responsive Forms Summary: Removes the panel-view on login and adds additonal responsive styles for mobile forms. Test Plan: View in mobile browser, resize page. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4530
2013-01-19 23:30:26 +01:00
'uri' => '/res/2150a55d/rsrc/css/application/herald/herald.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/herald/herald.css',
),
'herald-rule-editor' =>
array(
Allow Herald rules to add reviewers Summary: Ref T1279. Although I think this is a bad idea in general (we once supported it, removed it, and seemed better off for it) users expect it to exist and want it to be available. Give them enough rope to shoot themselves in the foot. I will probably write some lengthy treatise on how you shouldn't use this rule later. Implementation is straightforward because Differential previously supported this rule. This rule can also be used to add project reviewers. Test Plan: Made some "add reviewers" rules, created revisions, saw reviewers trigger. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T1279 Differential Revision: https://secure.phabricator.com/D7235
2013-10-05 19:36:26 +02:00
'uri' => '/res/a561eb19/rsrc/js/application/herald/HeraldRuleEditor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'multirow-row-manager',
1 => 'javelin-install',
2 => 'javelin-typeahead',
3 => 'javelin-util',
4 => 'javelin-dom',
5 => 'javelin-tokenizer',
6 => 'javelin-typeahead-preloaded-source',
7 => 'javelin-stratcom',
8 => 'javelin-json',
9 => 'phabricator-prefab',
),
'disk' => '/rsrc/js/application/herald/HeraldRuleEditor.js',
),
'herald-test-css' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/51199954/rsrc/css/application/herald/herald-test.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/herald/herald-test.css',
),
Separate the inline comment summary element into a separate view Summary: - Affects the "Inline Comments" summary table which appears in comments that have attached inlines in the discussion threads in Differential. - Prepares for inclusion in Diffusion. - No application changes (minor CSS), just factors code better. - Simplify/separate CSS. Test Plan: Looked at on-diff and off-diff comment summaries in Differential, display looked correct. Reviewers: davidreuss, nh, btrahan Reviewed By: davidreuss CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1928
2012-03-20 03:45:16 +01:00
'inline-comment-summary-css' =>
array(
More grey text updates Summary: More grey tweaks, breaking these up so I can test and tweak each as needed. Test Plan: Review pages. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6866
2013-09-02 22:57:48 +02:00
'uri' => '/res/3cf1f7a7/rsrc/css/application/diff/inline-comment-summary.css',
Separate the inline comment summary element into a separate view Summary: - Affects the "Inline Comments" summary table which appears in comments that have attached inlines in the discussion threads in Differential. - Prepares for inclusion in Diffusion. - No application changes (minor CSS), just factors code better. - Simplify/separate CSS. Test Plan: Looked at on-diff and off-diff comment summaries in Differential, display looked correct. Reviewers: davidreuss, nh, btrahan Reviewed By: davidreuss CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1928
2012-03-20 03:45:16 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diff/inline-comment-summary.css',
),
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
'javelin-aphlict' =>
array(
Improve Aphlict server Summary: - Move to port 22280 by default. - Warn when running as non-root. - Allow subscription and publish/admin ports to be configured. - Allow server to drop root after binding to 843. - Allow log path to be configured. - Add /status/ admin URI which shows server status. - Return HTTP 400 Bad Request for other requests, instead of hanging. - Minor formatting cleanup. Test Plan: Ran without root: $ node aphlict_server.js ...got a good error message. Ran with --user: $ sudo node aphlict_server.js --user=epriestley ...verified server dropped permissions. Ran with --port / --admin. Hit /status/ with GET, got status. Hit other URLs with GET, got 400. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran Differential Revision: https://secure.phabricator.com/D2737
2012-06-14 15:12:54 +02:00
'uri' => '/res/c0b9e53f/rsrc/js/application/aphlict/Aphlict.js',
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
'disk' => '/rsrc/js/application/aphlict/Aphlict.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/15482715/rsrc/externals/javelin/lib/behavior.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-magical-init',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-util',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/behavior.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Adds the UI dropdown panel Summary: Add a dropdown to display notificaitons. Right now there is nothing real time about it, but we do update the panel when the user clicks. This panel is only displayed if the install has notifications enabled and you have them enabled in your preferences (not using them by default). Test Plan: Turn off notifications for user1, left them on for user2. Did things from user1 and from user2 on task both were cc'd on. user2 recieved all notifications, user1 recieved nothing. Made new user, made sure everything was switched off by default. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: keebuhm, ddfisher, aran, Korvin Differential Revision: https://secure.phabricator.com/D2703
2012-06-11 18:37:06 +02:00
'javelin-behavior-aphlict-dropdown' =>
array(
Allow only one global top menu to be open at a time Summary: Fixes T3715. Makes "visible" global instead of per-menu, so all the menus share a visible state. Test Plan: For menus A and B, clicked "A, A", "A, B, A", "A, B, B", "A, B, B, A", etc. Couldn't figure out a way to break it. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T3715 Differential Revision: https://secure.phabricator.com/D6745
2013-08-13 23:57:52 +02:00
'uri' => '/res/3ff0c90a/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js',
Adds the UI dropdown panel Summary: Add a dropdown to display notificaitons. Right now there is nothing real time about it, but we do update the panel when the user clicks. This panel is only displayed if the install has notifications enabled and you have them enabled in your preferences (not using them by default). Test Plan: Turn off notifications for user1, left them on for user2. Did things from user1 and from user2 on task both were cc'd on. user2 recieved all notifications, user1 recieved nothing. Made new user, made sure everything was switched off by default. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: keebuhm, ddfisher, aran, Korvin Differential Revision: https://secure.phabricator.com/D2703
2012-06-11 18:37:06 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Apply AMAZING DESIGN SKILLS to notification menu Summary: I am a fancy designer! {F12665} {F12666} Test Plan: Opened/closed menu. Viewed with-notification-count and without-notification count states. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, chad, joe Maniphest Tasks: T974 Differential Revision: https://secure.phabricator.com/D2735
2012-06-14 15:13:53 +02:00
1 => 'javelin-request',
2 => 'javelin-stratcom',
3 => 'javelin-vector',
4 => 'javelin-dom',
Improve style of notifications Summary: - Gets about 25% of the way toward @chad's notification mocks. - YES: Hover states, entire notification is a click target, border, header, footer. - NO: Profile pictures (lazy), timestamps (want to refactor time code before introducing a new formatting style), app icons (they'd look funny without timestamps I think) - Deletes some old files. - Mostly trying to get this good enough to turn on by default. Test Plan: Looked at notifications. Clicked some notifications. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D4119
2012-12-08 01:26:43 +01:00
5 => 'javelin-uri',
Adds the UI dropdown panel Summary: Add a dropdown to display notificaitons. Right now there is nothing real time about it, but we do update the panel when the user clicks. This panel is only displayed if the install has notifications enabled and you have them enabled in your preferences (not using them by default). Test Plan: Turn off notifications for user1, left them on for user2. Did things from user1 and from user2 on task both were cc'd on. user2 recieved all notifications, user1 recieved nothing. Made new user, made sure everything was switched off by default. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: keebuhm, ddfisher, aran, Korvin Differential Revision: https://secure.phabricator.com/D2703
2012-06-11 18:37:06 +02:00
),
'disk' => '/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js',
),
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
'javelin-behavior-aphlict-listen' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/7487f207/rsrc/js/application/aphlict/behavior-aphlict-listen.js',
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-aphlict',
Show only one "reload" popup, use 'alert' style, click to reload Summary: Use the features from D2758. Test Plan: Updated T1 with two browser windows pointing at it, verified reload appeared, only one reload, and it appeared with 'alert' style. Reviewers: jungejason, vrana Reviewed By: jungejason CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2781
2012-06-18 23:07:45 +02:00
2 => 'javelin-stratcom',
3 => 'javelin-request',
4 => 'javelin-uri',
5 => 'javelin-dom',
Improve debug support for notifications Summary: Add a `notification.debug` setting that shows debug info in the browser. Also improve some logging/error handling stuff and fix a bug with host names. Test Plan: {F13098} Reviewers: jungejason, btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2810
2012-06-20 22:20:47 +02:00
6 => 'javelin-json',
7 => 'phabricator-notification',
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
),
'disk' => '/rsrc/js/application/aphlict/behavior-aphlict-listen.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-aphront-basic-tokenizer' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/c7fd9a7b/rsrc/js/core/behavior-tokenizer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
1 => 'phabricator-prefab',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-tokenizer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Merge branch 'master' into phutil_tag (Sync.)
2013-02-07 17:08:01 +01:00
'javelin-behavior-aphront-crop' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/8c800f36/rsrc/js/core/behavior-crop.js',
Merge branch 'master' into phutil_tag (Sync.)
2013-02-07 17:08:01 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-vector',
3 => 'javelin-magical-init',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-crop.js',
Merge branch 'master' into phutil_tag (Sync.)
2013-02-07 17:08:01 +01:00
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-aphront-drag-and-drop-textarea' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/a261f6e6/rsrc/js/core/behavior-drag-and-drop-textarea.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'phabricator-drag-and-drop-file-upload',
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
3 => 'phabricator-textareautils',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-drag-and-drop-textarea.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-behavior-aphront-form-disable-on-submit' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/a4a4ff07/rsrc/js/core/behavior-form.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-form.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Show "show more..." link in "Local Commits" view in Differential Summary: Javascript! Depends on D2437 to do anything useful. Test Plan: Clicked "show more", saw more. Reviewers: csilvers, btrahan Reviewed By: csilvers CC: aran Maniphest Tasks: T1189 Differential Revision: https://secure.phabricator.com/D2438
2012-05-10 00:56:37 +02:00
'javelin-behavior-aphront-more' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/fae13324/rsrc/js/core/behavior-more.js',
Show "show more..." link in "Local Commits" view in Differential Summary: Javascript! Depends on D2437 to do anything useful. Test Plan: Clicked "show more", saw more. Reviewers: csilvers, btrahan Reviewed By: csilvers CC: aran Maniphest Tasks: T1189 Differential Revision: https://secure.phabricator.com/D2438
2012-05-10 00:56:37 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-more.js',
Show "show more..." link in "Local Commits" view in Differential Summary: Javascript! Depends on D2437 to do anything useful. Test Plan: Clicked "show more", saw more. Reviewers: csilvers, btrahan Reviewed By: csilvers CC: aran Maniphest Tasks: T1189 Differential Revision: https://secure.phabricator.com/D2438
2012-05-10 00:56:37 +02:00
),
Implement macros as audio sources Summary: Fixes T3887. Basically: - Macros with audio get passed to the `audio-source` behavior. - This keeps track of where they are relative to the viewport as the user scrolls. - When the user scrolls a "once" macro into view, and it reaches roughly the middle of the screen, we play the sound. - When the user scrolls near a "loop" macro, we start playing the sound at low volume and increase the volume as the user scrolls. This feels pretty good on both counts. Test Plan: Tested in Safari, Chrome, and Firefox. FF seems a bit less responsive and doesn't support MP3, but it was fairly nice in Chrome/Safari. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3887 Differential Revision: https://secure.phabricator.com/D7160
2013-09-28 01:02:02 +02:00
'javelin-behavior-audio-source' =>
array(
'uri' => '/res/21831141/rsrc/js/core/behavior-audio-source.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-vector',
3 => 'javelin-dom',
),
'disk' => '/rsrc/js/core/behavior-audio-source.js',
),
Add preview and drafts to audits Summary: Add comment previews and saved drafts to audits, like Maniphest / Differential. Test Plan: Typed stuff into the box. Got a preview. Reloaded page. Stuff was still there. Submitted comment. Stuff is gone. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1699
2012-02-27 22:00:23 +01:00
'javelin-behavior-audit-preview' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/d8f31e46/rsrc/js/application/diffusion/behavior-audit-preview.js',
Add preview and drafts to audits Summary: Add comment previews and saved drafts to audits, like Maniphest / Differential. Test Plan: Typed stuff into the box. Got a preview. Reloaded page. Stuff was still there. Submitted comment. Stuff is gone. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1699
2012-02-27 22:00:23 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/diffusion/behavior-audit-preview.js',
),
Updated the CLI for smoother use Summary: Ref T2903 Test Plan: Tested all CLI possibilities Reviewers: epriestley, AnhNhan Reviewed By: epriestley CC: AnhNhan, aran, Korvin, jqh9804 Maniphest Tasks: T2903 Differential Revision: https://secure.phabricator.com/D5711
2013-04-29 21:14:50 +02:00
'javelin-behavior-balanced-payment-form' =>
array(
'uri' => '/res/6876492d/rsrc/js/application/phortune/behavior-balanced-payment-form.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'phortune-credit-card-form',
),
'disk' => '/rsrc/js/application/phortune/behavior-balanced-payment-form.js',
),
Allow custom fields to be reordered and disabled from Config Summary: Ref T1703. Put a more reasonable UI than "blob of JSON" on top of this. Test Plan: Reordered, enabled and disabled user profile fields. {F49317} Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T1703 Differential Revision: https://secure.phabricator.com/D6393
2013-07-09 17:27:19 +02:00
'javelin-behavior-config-reorder-fields' =>
array(
'uri' => '/res/691c5c8c/rsrc/js/application/config/behavior-reorder-fields.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-json',
4 => 'phabricator-draggable-list',
),
'disk' => '/rsrc/js/application/config/behavior-reorder-fields.js',
),
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'javelin-behavior-conpherence-menu' =>
array(
Conpherence - add daily date dividers Summary: nice title. Fixes T3203. If its been N days and now its Tuesday, it just shows a single marker for Tuesday. Test Plan: Viewed a conpherence and there were date dividers! Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3203 Differential Revision: https://secure.phabricator.com/D6081
2013-05-30 23:24:50 +02:00
'uri' => '/res/f27205d4/rsrc/js/application/conpherence/behavior-menu.js',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Conpherence - fix JS and add code to repair old bad data Summary: the JS is fragile with respect to the tokenizer coming in from the people widget. make sure to always try to load this up. Note this generally needs to get cleaned up where the server should only send down the *exact* bits the client needs. This is all TODO as part of getting this on mobile perfectly. Also note this fragility exists still in that you can break conpherence by clicking quickly before the initial tokenizer load loads. For old bad data, at some point we weren't updating participation as well as we do today in the editor class. the result is with the migration and code change some conversation participants have bad "last seen message" counts. the simplest case is the test user talking to themselves -- threads before the editor code fixes / changes will have the entire thread as unread for these folks. The other buggy case I saw was where the "last reply" to a thread wasn't being count. These issues showed up for threads February and older which is old. Test Plan: edited conpherence meta data and no JS bugs. pontificated and no JS bugs. added a person and no JS bugs. Reviewers: chad, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5622
2013-04-08 22:41:34 +02:00
2 => 'javelin-util',
Conpherence - make the JS layer a bit better Summary: this diff tries to polish the poo out of the JS layer while achieving fixes T3157 accolades. Test Plan: introduced sleeps in the various controllers and clicked about. verified good "loading" UI in the menu / message / widget section as appropros. Loaded up in device size and resize and desktop sized and resized and all was good. Reviewers: epriestley Reviewed By: epriestley CC: chad, aran, Korvin Maniphest Tasks: T3164, T3157 Differential Revision: https://secure.phabricator.com/D6069
2013-05-29 21:46:06 +02:00
3 => 'javelin-stratcom',
4 => 'javelin-workflow',
5 => 'javelin-behavior-device',
6 => 'javelin-history',
7 => 'javelin-vector',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
),
'disk' => '/rsrc/js/application/conpherence/behavior-menu.js',
),
Conpherence - make pontificate be all ajaxy Summary: serving up for some feedback -- does anything fancy need to happen when new messages load (say highlight em and fade the highlight out) or just scrolling down okay? in JS I have a TODO about how come it doesn't work; that code works okay in my console if I print out various debugging values and enter them in manually. Test Plan: pontificate with myself; note new message and message entry updates properly. pontificate as different user then as myself; note two messages load and message entry updates properly. pontificate as a user who isn't the last to reply; note new message and message entry updates properly Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2522 Differential Revision: https://secure.phabricator.com/D5214
2013-03-06 00:45:36 +01:00
'javelin-behavior-conpherence-pontificate' =>
array(
Fix white + icon hover / apps create Summary: Decided to just remove the hover grey to white, seems fine with the new white icons. Test Plan: use homepage + icons Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6181
2013-06-12 04:10:12 +02:00
'uri' => '/res/19cb581b/rsrc/js/application/conpherence/behavior-pontificate.js',
Conpherence - make pontificate be all ajaxy Summary: serving up for some feedback -- does anything fancy need to happen when new messages load (say highlight em and fade the highlight out) or just scrolling down okay? in JS I have a TODO about how come it doesn't work; that code works okay in my console if I print out various debugging values and enter them in manually. Test Plan: pontificate with myself; note new message and message entry updates properly. pontificate as different user then as myself; note two messages load and message entry updates properly. pontificate as a user who isn't the last to reply; note new message and message entry updates properly Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2522 Differential Revision: https://secure.phabricator.com/D5214
2013-03-06 00:45:36 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Add support for device swipe events Summary: Ref T2700. Allow JS to listen for swipes on devices. There are a bunch of tricky cases here and I probably didn't get them all totally right, but this interaction broadly looks like this: - We implement gesture recognition for the mouse in device modes (narrow browser), and for touch events from an actual device. - The sigil `touchable` indicates that a node wants to react to touch events. - When the user touches a `touchable` node, we start listening for moves. They might be tapping/clicking (in which case we don't care), but they might also be gesturing. - Once the user moves their finger/pointer far enough away from the tap origin, we recognize it as a gesture. I hardcoded this at 20px; I wasn't able to find any "official" Apple value, but 20px seems like a common default. - At this point, we look at where their finger has moved. - If they moved it mostly up/down, we interpret the gesture as "scroll" and just stop listening. The device does its own thing. - However, if they moved it mostly left/right, we interpret it as a "swipe". We start killing the moves so the device doesn't scroll. - Once we've recognized that a gesture is underway, we send a "gesture.swipe.start" event and then "gesture.swipe.move" events for every move. - When the user ends the gesture, we send "gesture.swipe.end". - If the user cancels the gesture (currently, only by tapping with a second finger), we send "gesture.swipe.cancel". - Gesture events have raw position data and some convenience fields. Test Plan: Wrote UI example and used it from the Desktop, iPhone simulator, and a real iphone. - The code always seems to get "scroll" vs "swipe" correct (i.e., consistent with my intentions). - The threshold feels pretty good to me. - Tapping with a second finger cancels the action. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T2700 Differential Revision: https://secure.phabricator.com/D5308
2013-03-09 22:53:15 +01:00
2 => 'javelin-util',
3 => 'javelin-workflow',
Decrease fragility of `conpherence-pontificate` behavior Summary: Currently, this behavior binds a ton of IDs. This makes the behavior fragile: if it is invoked on a page without all the right elements, some `JX.$()` tends to explode. Instead, don't assume anything is present on the page. This allows the behavior to be invoked on other pages (like the "New Conpherence" page) or pages without some elements (like some future thread-only mobile view) without creating JS errors. Test Plan: Added comments, added comments with files. Viewed "New conphenrece" page. NOTE: Control+Enter is currently broken, but this diff didn't change that behavior. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5468
2013-03-31 23:41:13 +02:00
4 => 'javelin-stratcom',
Conpherence - make pontificate be all ajaxy Summary: serving up for some feedback -- does anything fancy need to happen when new messages load (say highlight em and fade the highlight out) or just scrolling down okay? in JS I have a TODO about how come it doesn't work; that code works okay in my console if I print out various debugging values and enter them in manually. Test Plan: pontificate with myself; note new message and message entry updates properly. pontificate as different user then as myself; note two messages load and message entry updates properly. pontificate as a user who isn't the last to reply; note new message and message entry updates properly Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2522 Differential Revision: https://secure.phabricator.com/D5214
2013-03-06 00:45:36 +01:00
),
'disk' => '/rsrc/js/application/conpherence/behavior-pontificate.js',
),
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'javelin-behavior-conpherence-widget-pane' =>
array(
Fix white + icon hover / apps create Summary: Decided to just remove the hover grey to white, seems fine with the new white icons. Test Plan: use homepage + icons Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6181
2013-06-12 04:10:12 +02:00
'uri' => '/res/562ca20e/rsrc/js/application/conpherence/behavior-widget-pane.js',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
Conpherence - add per thread notification setting Summary: Introduces a new settings panel for Conpherence specific settings. Test Plan: started a thread with a test user, thus two participants total. Replied to conpherence, toggling notification settings in between. Verified 1 or 2 emails were sent as appropos to the current toggle. Toggled global setting and verified setting was updated in conpherences where nothing was specified. Verified setting conpherence setting overrides global setting. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2521 Differential Revision: https://secure.phabricator.com/D5391
2013-03-26 21:30:35 +01:00
3 => 'javelin-workflow',
4 => 'javelin-util',
5 => 'phabricator-notification',
Conpherence - mobilized Summary: makes conpherence switch to a liquid layout once we go from desktop -> less than that. When we make the switch conpherence updates to show a few more "Widgets" -- the list of conpherences and the current conversation -- and the switcher starts working. As you transition from device to device you are automagically forced to have the "conversation" widget toggled on initial change to smaller than desktop and then file widget once you get back to desktop. Generally looks good when I make my browser small. Does not look as good on iOS simulator - in particular there seems to be a weird visual artifact on the "add people" widget that is present in all tokenizers, and the pontificate UI on mobile could use some work. ref T2399. Test Plan: played in Safari, FF, Chrome and iOS Simulator. The first 3 were all pretty spiffy, and otherwise iOS add people widget was a bit ugly. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2399 Differential Revision: https://secure.phabricator.com/D5674
2013-04-16 01:27:41 +02:00
6 => 'javelin-behavior-device',
Conpherence - make widget selector be a fun JS-based menu Summary: Ref T3155. Also re-adds the ability to update Conpherence titles by letting user click the title and fill out a little dialogue. Also fixes a bunch of random bugs and what have you. I tried to make the javascript less mysterious by trying to code what's actually happening more explicitly. Still a work in progress all over the place but a good stopping point for feedback. Test Plan: played around with Conpherence. In particular, went to /conpherence/ and re-sized and went to /conpherence/X/ and re-sized. Also loaded up my no conpherneces user. Reviewers: epriestley Reviewed By: epriestley CC: chad, aran, Korvin Maniphest Tasks: T3155 Differential Revision: https://secure.phabricator.com/D6022
2013-05-24 19:50:18 +02:00
7 => 'phabricator-dropdown-menu',
8 => 'phabricator-menu-item',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
),
'disk' => '/rsrc/js/application/conpherence/behavior-widget-pane.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-countdown-timer' =>
array(
Modernize Countdown somewhat Summary: Far from perfect, but better? Test Plan: {F51153} {F51154} {F51155} Reviewers: btrahan, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6533
2013-07-23 15:16:19 +02:00
'uri' => '/res/13d40efa/rsrc/js/application/countdown/timer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/countdown/timer.js',
),
'javelin-behavior-dark-console' =>
array(
Display bullet next to request with errors in DarkConsole. Summary: I always put a `phlog()` somewhere or something fails and I have hard times figuring out which request it was. Also fix safe HTML in panel. Test Plan: Looked at DarkConsole with error on main page, AJAX request and both. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5784
2013-04-26 03:30:13 +02:00
'uri' => '/res/1e2c7a5e/rsrc/js/core/behavior-dark-console.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-request',
5 => 'phabricator-keyboard-shortcut',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-dark-console.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Add "device" JS/CSS for reactive stuff Summary: As we work through @chad's redesign, one thing I want to do is improve the tablet/mobile experience. Add a "device" behavior which sets a "device-phone", "device-tablet" or "device-desktop" class on the root div. The behavior (device names, width triggers) is mostly based on Bootstrap. Also adds a preview viewport=meta tag, which makes the iPhone not scale the page like crazy and is a desirable end state, but currently makes the app less usable since things get cut off. Test Plan: Added some classes like this: .device-desktop { background: blue; } .device-tablet { background: orange; } .device-phone { background: yellow; } ...and loaded the site on a desktop, iPad and iPhone. Resized the window. Got the right background color in all cases. Reviewers: btrahan, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D3063
2012-07-25 20:51:27 +02:00
'javelin-behavior-device' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/12e43f5a/rsrc/js/core/behavior-device.js',
Add "device" JS/CSS for reactive stuff Summary: As we work through @chad's redesign, one thing I want to do is improve the tablet/mobile experience. Add a "device" behavior which sets a "device-phone", "device-tablet" or "device-desktop" class on the root div. The behavior (device names, width triggers) is mostly based on Bootstrap. Also adds a preview viewport=meta tag, which makes the iPhone not scale the page like crazy and is a desirable end state, but currently makes the app less usable since things get cut off. Test Plan: Added some classes like this: .device-desktop { background: blue; } .device-tablet { background: orange; } .device-phone { background: yellow; } ...and loaded the site on a desktop, iPad and iPhone. Resized the window. Got the right background color in all cases. Reviewers: btrahan, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D3063
2012-07-25 20:51:27 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-vector',
Make the top nav non-fixed-position Summary: See some discussion in D1673. - There's a concrete (if minor) problem with this in Firefox with wrapping search. - People complain about how we're stealing all their pixels. - There isn't much of a functional purpose to it since all the operations are fairly rare. - This addresses the aesthetic purpose of the fixed-position nav (not making the side nav ugly) by making the side nav scroll up 44px and then stop. Test Plan: Scrolled in desktop, tablet modes. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3412
2012-08-31 03:58:51 +02:00
4 => 'javelin-install',
Add "device" JS/CSS for reactive stuff Summary: As we work through @chad's redesign, one thing I want to do is improve the tablet/mobile experience. Add a "device" behavior which sets a "device-phone", "device-tablet" or "device-desktop" class on the root div. The behavior (device names, width triggers) is mostly based on Bootstrap. Also adds a preview viewport=meta tag, which makes the iPhone not scale the page like crazy and is a desirable end state, but currently makes the app less usable since things get cut off. Test Plan: Added some classes like this: .device-desktop { background: blue; } .device-tablet { background: orange; } .device-phone { background: yellow; } ...and loaded the site on a desktop, iPad and iPhone. Resized the window. Got the right background color in all cases. Reviewers: btrahan, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D3063
2012-07-25 20:51:27 +02:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-device.js',
Add "device" JS/CSS for reactive stuff Summary: As we work through @chad's redesign, one thing I want to do is improve the tablet/mobile experience. Add a "device" behavior which sets a "device-phone", "device-tablet" or "device-desktop" class on the root div. The behavior (device names, width triggers) is mostly based on Bootstrap. Also adds a preview viewport=meta tag, which makes the iPhone not scale the page like crazy and is a desirable end state, but currently makes the app less usable since things get cut off. Test Plan: Added some classes like this: .device-desktop { background: blue; } .device-tablet { background: orange; } .device-phone { background: yellow; } ...and loaded the site on a desktop, iPad and iPhone. Resized the window. Got the right background color in all cases. Reviewers: btrahan, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D3063
2012-07-25 20:51:27 +02:00
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-differential-accept-with-errors' =>
array(
Make all of Drydock work on Mobile Summary: This is probably not the most useful app to have work on mobile, but get the log view to do something fairly sensible. Test Plan: Looked at all Drydock views in mobile. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2015 Differential Revision: https://secure.phabricator.com/D4224
2012-12-18 00:16:44 +01:00
'uri' => '/res/8fea67b3/rsrc/js/application/differential/behavior-accept-with-errors.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-accept-with-errors.js',
),
'javelin-behavior-differential-add-reviewers-and-ccs' =>
array(
Store revision reviewer state as edges Summary: Keep track of the state of a reviewer in an edge between reviewer and revision. The edge stores the state of the review, added or rejected. And if the revision was accepted by that reviewer the id of the diff accepted. Test Plan: Create diffs and clowncopterize reviewer list changes. This includes: * Adding new reviewers * Resigning * Commandering a revision Reviewers: epriestley CC: aran, Korvin Maniphest Tasks: T1279 Differential Revision: https://secure.phabricator.com/D6372 Conflicts: src/applications/differential/editor/DifferentialCommentEditor.php
2013-07-10 22:45:14 +02:00
'uri' => '/res/fd9f2c1c/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
2 => 'phabricator-prefab',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js',
),
'javelin-behavior-differential-comment-jump' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/8ffb4222/rsrc/js/application/differential/behavior-comment-jump.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-stratcom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-comment-jump.js',
),
'javelin-behavior-differential-diff-radios' =>
array(
'uri' => '/res/004cb66f/rsrc/js/application/differential/behavior-diff-radios.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-diff-radios.js',
),
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'javelin-behavior-differential-dropdown-menus' =>
array(
See https://github.com/facebook/phabricator/issues/262
2013-07-09 04:56:40 +02:00
'uri' => '/res/722c679c/rsrc/js/application/differential/behavior-dropdown-menus.js',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Add a link from Differential to Diffusion Summary: Provide an easy way to jump to Diffusion from Differential if we have the data we need to connect them. Test Plan: Tested menu in linked and unlinked diffs. Used menu item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley, btrahan Maniphest Tasks: T309 Differential Revision: https://secure.phabricator.com/D1326
2012-01-05 23:41:11 +01:00
2 => 'javelin-util',
3 => 'javelin-stratcom',
4 => 'phabricator-dropdown-menu',
5 => 'phabricator-menu-item',
Rebuild the Celerity map, which ended up in a bad state after after the application/core stuff.
2013-04-23 20:32:24 +02:00
6 => 'phabricator-phtize',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
),
'disk' => '/rsrc/js/application/differential/behavior-dropdown-menus.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-differential-edit-inline-comments' =>
array(
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'uri' => '/res/935d4012/rsrc/js/application/differential/behavior-edit-inline-comments.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-util',
4 => 'javelin-vector',
5 => 'differential-inline-comment-editor',
),
'disk' => '/rsrc/js/application/differential/behavior-edit-inline-comments.js',
),
'javelin-behavior-differential-feedback-preview' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/4421fac6/rsrc/js/application/differential/behavior-comment-preview.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-request',
4 => 'javelin-util',
5 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/differential/behavior-comment-preview.js',
),
'javelin-behavior-differential-keyboard-navigation' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/22ed93ba/rsrc/js/application/differential/behavior-keyboard-nav.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Add more keyboard navigation options for inline comments Summary: - Use n/p to jump between comments. - Use r to reply to the selected comment. - Use e to edit the selected comment. Test Plan: Verified n, p, r, e, j, k, J, K, "click edit" and "click reply" behavior in as many weird cases as I could come up with. Reviewers: btrahan, jungejason, nh, cpiro, jl Reviewed By: btrahan CC: aran, btrahan, epriestley Maniphest Tasks: T583 Differential Revision: https://secure.phabricator.com/D1308
2012-01-04 17:21:22 +01:00
2 => 'javelin-stratcom',
3 => 'phabricator-keyboard-shortcut',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/differential/behavior-keyboard-nav.js',
),
'javelin-behavior-differential-populate' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/bb9a29f4/rsrc/js/application/differential/behavior-populate.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-workflow',
2 => 'javelin-util',
3 => 'javelin-dom',
Show a tooltip about code coverage Summary: - Show a tip in the margin about what coverage colors mean. - Highlight the line when mousing over coverage. - Randomly change the colors to different colors. - Fix a bug with "show more" that I introduced with the other coverage diff (oops!) Test Plan: Moused over coverage things. Reviewers: tuomaspelkonen, btrahan Reviewed By: tuomaspelkonen CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1874
2012-03-13 04:04:12 +01:00
4 => 'javelin-stratcom',
Minor, update Celerity map.
2013-01-15 00:44:16 +01:00
5 => 'javelin-behavior-device',
Stabilize scroll position as diffs load Summary: Try to lock the screen to whatever the user is looking at as we load changesets. Notably, this improves the use case of taking a known action on a diff. Currently, you have to wait for everything to load or the comments keep getting scrolled down. After this change, the comments stay in the same place on screen. Test Plan: Raised the autoload changeset limit from 100 to 1000, looked at a 220 changeset diff. - Reloaded it while scrolled at the top; normal behavior (no scrolling). - Reloaded it, scrolled to the bottom. Comment area now stable. - Reloaded it, kind of scrolled around the middle? Behavior seemed stable/reasonable. This one is kind of heursitic so it's hard to say I'm getting it totally right or not, but it's less important than the "bottom" case. Reviewers: vrana, btrahan, chad, dctrwatson Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D4774
2013-02-01 19:52:07 +01:00
6 => 'javelin-vector',
7 => 'phabricator-tooltip',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/differential/behavior-populate.js',
),
'javelin-behavior-differential-show-all-comments' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/8801848d/rsrc/js/application/differential/behavior-show-all-comments.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-show-all-comments.js',
),
Hide lint and unit error details Summary: Before: {F10754} After: {F10753} Test Plan: View revision with lint warnings and unit errors. Click on Details. Click on Details. Click on Details. Click on Details. Reviewers: asukhachev, epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2351
2012-05-01 01:08:01 +02:00
'javelin-behavior-differential-show-field-details' =>
array(
Further improve unit/lint rendering Summary: I think this improves things, let me know if you have feedback. Also addresses T840. Test Plan: See screenshots... Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, zeeg Maniphest Tasks: T840 Differential Revision: https://secure.phabricator.com/D2357
2012-05-01 19:15:56 +02:00
'uri' => '/res/8d57f459/rsrc/js/application/differential/behavior-show-field-details.js',
Hide lint and unit error details Summary: Before: {F10754} After: {F10753} Test Plan: View revision with lint warnings and unit errors. Click on Details. Click on Details. Click on Details. Click on Details. Reviewers: asukhachev, epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2351
2012-05-01 01:08:01 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-show-field-details.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-differential-show-more' =>
array(
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'uri' => '/res/03b7bc9e/rsrc/js/application/differential/behavior-show-more.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-workflow',
3 => 'javelin-util',
4 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/differential/behavior-show-more.js',
),
Update Celerity map
2012-06-14 07:47:46 +02:00
'javelin-behavior-differential-toggle-files' =>
array(
Implement ApplicationSearch in Flags Summary: Ref T1809. Provide ApplicationSearch to Flags and allow the user to select flags by color. @chad might have some design feedback on my control. Test Plan: {F54131} Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T1809 Differential Revision: https://secure.phabricator.com/D6747
2013-08-14 01:27:26 +02:00
'uri' => '/res/beb89813/rsrc/js/application/differential/behavior-toggle-files.js',
Update Celerity map
2012-06-14 07:47:46 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
Differential - add an undo element when you collapse a file Summary: Fixes T2258. Test Plan: collapsed and expanded file via the dropdown - good stuff. got the "undo" element into the mix - also good stuff. Reviewers: epriestley Reviewed By: epriestley CC: chad, Korvin, aran Maniphest Tasks: T2258 Differential Revision: https://secure.phabricator.com/D6742
2013-08-14 01:05:09 +02:00
3 => 'phabricator-phtize',
Update Celerity map
2012-06-14 07:47:46 +02:00
),
'disk' => '/rsrc/js/application/differential/behavior-toggle-files.js',
),
Hide selection to provide a visual cue about clipboard JS magic in Differential Summary: Inspired by D2242. Test Plan: Select text in left pane. Select text in right pane. Select all. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2249
2012-04-17 03:53:38 +02:00
'javelin-behavior-differential-user-select' =>
array(
Update Celerity map.
2012-09-24 22:56:04 +02:00
'uri' => '/res/23c51a5d/rsrc/js/application/differential/behavior-user-select.js',
Hide selection to provide a visual cue about clipboard JS magic in Differential Summary: Inspired by D2242. Test Plan: Select text in left pane. Select text in right pane. Select all. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2249
2012-04-17 03:53:38 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/differential/behavior-user-select.js',
),
Load commit branches and tags by AJAX Summary: Each query takes over 2 seconds in FBCODE. I didn't find a way how to speed them up. There's also no easy way how to parallelize them at least. So AJAX is the last instance. Test Plan: Loaded commit with one branch and no tag. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3112
2012-08-01 01:27:48 +02:00
'javelin-behavior-diffusion-commit-branches' =>
array(
Remove placeholder Summary: See discussion in D3103. We don't need this for now; if we do in the future we should probably use an alternate implementation. Test Plan: Grepped for 'placeholder', viewed UI examples. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3115
2012-08-01 03:28:08 +02:00
'uri' => '/res/1ede335a/rsrc/js/application/diffusion/behavior-commit-branches.js',
Load commit branches and tags by AJAX Summary: Each query takes over 2 seconds in FBCODE. I didn't find a way how to speed them up. There's also no easy way how to parallelize them at least. So AJAX is the last instance. Test Plan: Loaded commit with one branch and no tag. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3112
2012-08-01 01:27:48 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'javelin-request',
),
'disk' => '/rsrc/js/application/diffusion/behavior-commit-branches.js',
),
Render pretty graphical traces for commit branches, etc Summary: I AM A WIZARD Test Plan: BEHOLD Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T961 Differential Revision: https://secure.phabricator.com/D2007
2012-03-24 01:11:15 +01:00
'javelin-behavior-diffusion-commit-graph' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/536b8483/rsrc/js/application/diffusion/behavior-commit-graph.js',
Render pretty graphical traces for commit branches, etc Summary: I AM A WIZARD Test Plan: BEHOLD Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T961 Differential Revision: https://secure.phabricator.com/D2007
2012-03-24 01:11:15 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/diffusion/behavior-commit-graph.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-diffusion-jump-to' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/bade44bd/rsrc/js/application/diffusion/behavior-jump-to.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-vector',
2 => 'javelin-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/diffusion/behavior-jump-to.js',
),
'javelin-behavior-diffusion-pull-lastmodified' =>
array(
'uri' => '/res/29fe2790/rsrc/js/application/diffusion/behavior-pull-lastmodified.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'javelin-request',
),
'disk' => '/rsrc/js/application/diffusion/behavior-pull-lastmodified.js',
),
Add remarkup support for Asana URIs Summary: Ref T2852. Primarily, this expands API access to Asana. As a user-visible effect, it links Asana tasks in Remarkup. When a user enters an Asana URI, we register an onload behavior to make an Ajax call for the lookup. This respects privacy imposed by the API without creating a significant performance impact. Test Plan: {F47183} Reviewers: btrahan Reviewed By: btrahan CC: chad, aran Maniphest Tasks: T2852 Differential Revision: https://secure.phabricator.com/D6274
2013-06-25 00:55:08 +02:00
'javelin-behavior-doorkeeper-tag' =>
array(
'uri' => '/res/59480572/rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-json',
3 => 'javelin-workflow',
4 => 'javelin-magical-init',
),
'disk' => '/rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-error-log' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/acefdea7/rsrc/js/core/behavior-error-log.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-dom',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-error-log.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Add a datepicker control Summary: I looooove JS! It makes me giddy with glee! Test Plan: Picked dates. See screenshots. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2086
2012-04-04 21:14:10 +02:00
'javelin-behavior-fancy-datepicker' =>
array(
Allow datetime inputs to be optional Summary: Fixes T3279. For ApplicationSearch (and in some other cases) I'd like users to be able to provide an optional date. This isn't currently possible. Add a checkbox which disables or enables the input. Test Plan: Used UIExample to enter dates. Used Calendar to enter dates. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T3279 Differential Revision: https://secure.phabricator.com/D6082
2013-05-31 01:19:43 +02:00
'uri' => '/res/dcd7c2ca/rsrc/js/core/behavior-fancy-datepicker.js',
Add a datepicker control Summary: I looooove JS! It makes me giddy with glee! Test Plan: Picked dates. See screenshots. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2086
2012-04-04 21:14:10 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-util',
2 => 'javelin-dom',
Minor, move dialogs above masks.
2012-10-23 21:07:08 +02:00
3 => 'javelin-stratcom',
4 => 'javelin-vector',
Add a datepicker control Summary: I looooove JS! It makes me giddy with glee! Test Plan: Picked dates. See screenshots. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2086
2012-04-04 21:14:10 +02:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-fancy-datepicker.js',
Add a datepicker control Summary: I looooove JS! It makes me giddy with glee! Test Plan: Picked dates. See screenshots. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2086
2012-04-04 21:14:10 +02:00
),
Modernize file uploads Summary: Modernizes file uploads. In particular: - Adds a mobile menu, with an "Upload File" item. - Adds crumbs to the list view, detail view and upload view. - Adds "Upload File" action to crumbs. - Moves upload file to a separate page. - Removes the combined upload file + recent files page. - Makes upload file use a normal file control by default (works on mobile). - Home page, file list and file upload page are now global drop targets which accept files dropped anywhere on them. Dragging a file into the window shows a mask and an instructional message. - User education on this is a little weak but I think that's a big can of worms? - Fixes a bug where dropping multiple files into a Remarkup text area produced bad results (resolves T2190). T879 is related, although it's specifically about Maniphest. I've declined to make global drop targets yet there because there are multiple drop targets on the page with different meanings. That UI needs updating in general. @chad, do we have an "upload" icon (counterpart to "download")? Test Plan: Uploaded files in Maniphest, Differential, Files, and from Home. Dragged and dropped multiple files into Differential. Used crumbs, mobile. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2190 Differential Revision: https://secure.phabricator.com/D4200
2012-12-17 01:34:01 +01:00
'javelin-behavior-global-drag-and-drop' =>
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/ee8e9c39/rsrc/js/core/behavior-global-drag-and-drop.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-uri',
Modernize file uploads Summary: Modernizes file uploads. In particular: - Adds a mobile menu, with an "Upload File" item. - Adds crumbs to the list view, detail view and upload view. - Adds "Upload File" action to crumbs. - Moves upload file to a separate page. - Removes the combined upload file + recent files page. - Makes upload file use a normal file control by default (works on mobile). - Home page, file list and file upload page are now global drop targets which accept files dropped anywhere on them. Dragging a file into the window shows a mask and an instructional message. - User education on this is a little weak but I think that's a big can of worms? - Fixes a bug where dropping multiple files into a Remarkup text area produced bad results (resolves T2190). T879 is related, although it's specifically about Maniphest. I've declined to make global drop targets yet there because there are multiple drop targets on the page with different meanings. That UI needs updating in general. @chad, do we have an "upload" icon (counterpart to "download")? Test Plan: Uploaded files in Maniphest, Differential, Files, and from Home. Dragged and dropped multiple files into Differential. Used crumbs, mobile. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2190 Differential Revision: https://secure.phabricator.com/D4200
2012-12-17 01:34:01 +01:00
3 => 'javelin-mask',
4 => 'phabricator-drag-and-drop-file-upload',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-global-drag-and-drop.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-behavior-herald-rule-editor' =>
array(
'uri' => '/res/77a0c945/rsrc/js/application/herald/herald-rule-editor.js',
'type' => 'js',
'requires' =>
array(
0 => 'herald-rule-editor',
1 => 'javelin-behavior',
),
'disk' => '/rsrc/js/application/herald/herald-rule-editor.js',
),
Minor, update celerity map.
2013-03-05 00:03:54 +01:00
'javelin-behavior-history-install' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/9099a161/rsrc/js/core/behavior-history-install.js',
Minor, update celerity map.
2013-03-05 00:03:54 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-history',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-history-install.js',
Minor, update celerity map.
2013-03-05 00:03:54 +01:00
),
Do something cooler Summary: It seemed like a good idea at the time. Test Plan: Uh huh. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3352
2012-08-22 17:20:23 +02:00
'javelin-behavior-konami' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/b7bb7c24/rsrc/js/core/behavior-konami.js',
Do something cooler Summary: It seemed like a good idea at the time. Test Plan: Uh huh. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3352
2012-08-22 17:20:23 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-konami.js',
Do something cooler Summary: It seemed like a good idea at the time. Test Plan: Uh huh. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3352
2012-08-22 17:20:23 +02:00
),
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
'javelin-behavior-lightbox-attachments' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/72b4d3a8/rsrc/js/core/behavior-lightbox-attachments.js',
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-mask',
Simplify lightboxing and fix a few things Summary: Minor tweaks to lightboxes. - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it. - Make the lightbox go over the menu bar -- was it intentional that it wasn't? - Make 'jx-mask' use "position: fixed;" too. - Add a loading indicator. - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area. I'm going to do a couple of other tweaks here but need to update JX.Mask. Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3795
2012-10-24 02:34:43 +02:00
4 => 'javelin-util',
5 => 'phabricator-busy',
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-lightbox-attachments.js',
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
),
Allow Fact app to draw charts Summary: For any count fact, allow a chart to be drawn. INCREDIBLY POWERFUL DATA ANALYSIS PLATFORM. Test Plan: Drew a chart of object counts. Drew the Maniphest burn chart. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T1562 Differential Revision: https://secure.phabricator.com/D3099
2012-07-30 19:44:08 +02:00
'javelin-behavior-line-chart' =>
array(
Add support for placeholders Summary: Support placeholder text for inputs. We currently don't use this because it requires JS and doesn't degrade (no JS means you have zero idea what the input is for if it isn't separately labeled) but there are some cases where intent is obvious from context (for example, the search input in the menu bar, which is fairly obvious on its own and will soon have a magnifying glass icon) and in such cases it's much prettier and saves a bunch of space over an explicit label. Add a behavior so we can add placeholders where they make sense. This implementation is somewhat sanity-checked agianst the two jQuery placeholder implementations I was able to google: https://github.com/danielstocks/jQuery-Placeholder/ https://github.com/mathiasbynens/jquery-placeholder Since we don't currently have any uses cases, I haven't included support for making JS access to the `value` work, for password inputs, or for dynamically altering the placeholder. Test Plan: Played around with the placeholder in the UI example in various browsers and couldn't break it. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3103
2012-07-31 01:08:10 +02:00
'uri' => '/res/1aa5ac88/rsrc/js/application/maniphest/behavior-line-chart.js',
Allow Fact app to draw charts Summary: For any count fact, allow a chart to be drawn. INCREDIBLY POWERFUL DATA ANALYSIS PLATFORM. Test Plan: Drew a chart of object counts. Drew the Maniphest burn chart. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T1562 Differential Revision: https://secure.phabricator.com/D3099
2012-07-30 19:44:08 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-vector',
),
'disk' => '/rsrc/js/application/maniphest/behavior-line-chart.js',
),
Load blame in Diffusion by AJAX Summary: I have blame enabled by default and displaying files with long history takes easily over 10 seconds. Load the blame data by AJAX instead. This is actually doing more work and the total response time is longer but it's worth it for me as I am interested just in the file contents quite often. I know you were talking about building blame cache but until we have it... I'm not sure if the AJAX loading indicator in bottom right corner is enough to inform the user that we are loading it on background. Test Plan: ?view=highlighted ?view=plainblame ?view=blame Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5244
2013-03-05 23:31:20 +01:00
'javelin-behavior-load-blame' =>
array(
'uri' => '/res/138e2961/rsrc/js/application/diffusion/behavior-load-blame.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-request',
),
'disk' => '/rsrc/js/application/diffusion/behavior-load-blame.js',
),
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
'javelin-behavior-maniphest-batch-editor' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/81b2b86f/rsrc/js/application/maniphest/behavior-batch-editor.js',
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-prefab',
4 => 'multirow-row-manager',
Add "Change Priority", "Open / Close", "Comment" and "Assign" actions to Maniphest batch editor Summary: I think these are all the actions which make any sense. Test Plan: - Performed and verified each action through the batch editor. - Performed a large batch edit which applied each action type multiple times and verified the aggregate behavior was correct. Reviewers: btrahan, cpiro Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1971
2012-03-21 22:01:04 +01:00
5 => 'javelin-json',
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
),
'disk' => '/rsrc/js/application/maniphest/behavior-batch-editor.js',
),
'javelin-behavior-maniphest-batch-selector' =>
array(
Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. Summary: Adds plain support for object lists that just look like lists Test Plan: review UIexamples and a number of other applications Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6922
2013-09-09 23:14:34 +02:00
'uri' => '/res/423c5f1b/rsrc/js/application/maniphest/behavior-batch-selector.js',
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
Use ObjectItemListView for Maniphest Summary: This isn't quite complete, but everything else is technical cleanup. Broadly: - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature. - Updated drag-to-reorder code to work with ObjectItemListView. - Closed/resolved is now shown with a grey footer icon. - Assigned is now shown with a user profile image handle icon, with a hover state. This could probably use some more tweaks, but overall I think it looks pretty reasonable? Test Plan: {F35897} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5340
2013-03-23 22:38:01 +01:00
3 => 'javelin-util',
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
),
'disk' => '/rsrc/js/application/maniphest/behavior-batch-selector.js',
),
Allow Maniphest tasks to be edited from the list view Summary: Fixes T1945. Ref T2947. At various times, installs (Disqus, Dropbox, etc.) have asked for a way to edit tasks more quickly. Provide edit-from-lists. {F44700} {F44701} The one rough edge on this is that if you change the task priority we update it inline but don't move it. It's probably infeasible to actually move it, but maybe we could give it some sort of visual style to indicate that it's dirty. Test Plan: Edited tasks normally and via this action thing. Reviewers: chad, btrahan Reviewed By: chad CC: tido, deuresti, ahoffer, aran Maniphest Tasks: T1945, T2947 Differential Revision: https://secure.phabricator.com/D6086
2013-05-31 03:55:25 +02:00
'javelin-behavior-maniphest-list-editor' =>
array(
Allow named queries to be reordered by dragging Summary: Also you have to drop them. So drag, and then drop. This needs some cleanup and reconciliation/generalization with the Maniphest implementation. In particular, you can't drag things to the very top right now, and they should share more CSS and more behaviors. Test Plan: Look I alphabetized them: {F45286} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6136
2013-06-06 01:22:27 +02:00
'uri' => '/res/a251e72f/rsrc/js/application/maniphest/behavior-list-edit.js',
Allow Maniphest tasks to be edited from the list view Summary: Fixes T1945. Ref T2947. At various times, installs (Disqus, Dropbox, etc.) have asked for a way to edit tasks more quickly. Provide edit-from-lists. {F44700} {F44701} The one rough edge on this is that if you change the task priority we update it inline but don't move it. It's probably infeasible to actually move it, but maybe we could give it some sort of visual style to indicate that it's dirty. Test Plan: Edited tasks normally and via this action thing. Reviewers: chad, btrahan Reviewed By: chad CC: tido, deuresti, ahoffer, aran Maniphest Tasks: T1945, T2947 Differential Revision: https://secure.phabricator.com/D6086
2013-05-31 03:55:25 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
3 => 'javelin-workflow',
4 => 'javelin-fx',
5 => 'javelin-util',
),
'disk' => '/rsrc/js/application/maniphest/behavior-list-edit.js',
),
Allow tasks to be subprioritized by drag-and-drop Summary: Like the title says, similar to Facebook Tasks. Not sure how I really feel about this, but I guess it's kind of OK? I never used this feature in Facebook Tasks but I think some people like it. The drag-and-drop to repri across priorities feels okayish. Because subpriority is a double and we just split the difference when reprioritizing, you lose ~a bit of precision every time you repri two tasks against each other and so you can break it by swapping the priorities of two tasks ~50 times. This case is pretty silly and pathological. We can add some code to deal with this at some point if necessary. I think this also fixes the whacky task layout widths once and for all. (There are a couple of minor UI glitches like headers not vanishing and header counts not updating that I'm not fixing because I am lazy.) Test Plan: Dragged and dropped tasks around. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley, mgummelt Maniphest Tasks: T859 Differential Revision: https://secure.phabricator.com/D1731
2012-04-02 21:12:04 +02:00
'javelin-behavior-maniphest-subpriority-editor' =>
array(
Allow draggable elements to be dragged to the first list position Summary: Currently, draggable lists (in Config and ApplicationSearch, for example) don't let you drag an item into the first position. This is because the behavior is correct in Maniphest: the first position is above an initial header, like "High Prioirty", and shouldn't be targetable. Permit the behavior in general; forbid it in Maniphest. Test Plan: - Dragged elements into the first position in ApplicationSearch. - Failed to drag elements into the first position in Maniphest. Reviewers: garoevans, btrahan Reviewed By: garoevans CC: aran Differential Revision: https://secure.phabricator.com/D7128
2013-09-25 22:27:58 +02:00
'uri' => '/res/1fa4961f/rsrc/js/application/maniphest/behavior-subpriorityeditor.js',
Allow tasks to be subprioritized by drag-and-drop Summary: Like the title says, similar to Facebook Tasks. Not sure how I really feel about this, but I guess it's kind of OK? I never used this feature in Facebook Tasks but I think some people like it. The drag-and-drop to repri across priorities feels okayish. Because subpriority is a double and we just split the difference when reprioritizing, you lose ~a bit of precision every time you repri two tasks against each other and so you can break it by swapping the priorities of two tasks ~50 times. This case is pretty silly and pathological. We can add some code to deal with this at some point if necessary. I think this also fixes the whacky task layout widths once and for all. (There are a couple of minor UI glitches like headers not vanishing and header counts not updating that I'm not fixing because I am lazy.) Test Plan: Dragged and dropped tasks around. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley, mgummelt Maniphest Tasks: T859 Differential Revision: https://secure.phabricator.com/D1731
2012-04-02 21:12:04 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Mostly generalize Maniphest's drag-and-drop list Summary: I want to use draggable lists in at least three other interfaces: - (Today) Reorganizing named search queries. - (Today) Reorganizing custom fields. - (Future) Dragging tasks around on boards. This mostly generalizes the drag-and-drop code in Maniphest's task list. It isn't a total generalization and will need some more tweaking (for example, Maniphest's list is unusual in that the user can't drag items to the top of the list), but it substantially separates the Maniphest-specific behaviors from the general dragging behaviors. This diff causes no functional changes. Test Plan: Dragged and dropped tasks in Maniphest. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6124
2013-06-05 00:28:31 +02:00
1 => 'javelin-dom',
Simplify drag-and-drop list implementations Summary: - Use the same styles for shared operations (`drag-ghost`, `drag-dragging`). - Move shared code into the base class. Test Plan: Dragged around tasks and named queries. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6141
2013-06-06 02:36:33 +02:00
2 => 'javelin-stratcom',
3 => 'javelin-workflow',
4 => 'phabricator-draggable-list',
Allow tasks to be subprioritized by drag-and-drop Summary: Like the title says, similar to Facebook Tasks. Not sure how I really feel about this, but I guess it's kind of OK? I never used this feature in Facebook Tasks but I think some people like it. The drag-and-drop to repri across priorities feels okayish. Because subpriority is a double and we just split the difference when reprioritizing, you lose ~a bit of precision every time you repri two tasks against each other and so you can break it by swapping the priorities of two tasks ~50 times. This case is pretty silly and pathological. We can add some code to deal with this at some point if necessary. I think this also fixes the whacky task layout widths once and for all. (There are a couple of minor UI glitches like headers not vanishing and header counts not updating that I'm not fixing because I am lazy.) Test Plan: Dragged and dropped tasks around. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley, mgummelt Maniphest Tasks: T859 Differential Revision: https://secure.phabricator.com/D1731
2012-04-02 21:12:04 +02:00
),
'disk' => '/rsrc/js/application/maniphest/behavior-subpriorityeditor.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-maniphest-transaction-controls' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/e8498688/rsrc/js/application/maniphest/behavior-transaction-controls.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
2 => 'phabricator-prefab',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/maniphest/behavior-transaction-controls.js',
),
'javelin-behavior-maniphest-transaction-expand' =>
array(
'uri' => '/res/966410de/rsrc/js/application/maniphest/behavior-transaction-expand.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-workflow',
3 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/maniphest/behavior-transaction-expand.js',
),
'javelin-behavior-maniphest-transaction-preview' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/9447a3f9/rsrc/js/application/maniphest/behavior-transaction-preview.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
Make Maniphest Transaction preview tokenizer aware Summary: ...pretty sure the JS is too hack-tastic but it works...! :D also fixed a small error from assert_instances_of change where a null value is all errors and what have you Test Plan: played around with tasks in firefox and safari. made cc, owner, and project changes, as well as priority, etc. Reviewers: epriestley Reviewed By: epriestley CC: aran Maniphest Tasks: T1074 Differential Revision: https://secure.phabricator.com/D2234
2012-04-14 16:05:58 +02:00
3 => 'javelin-json',
4 => 'javelin-stratcom',
5 => 'phabricator-shaped-request',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/maniphest/behavior-transaction-preview.js',
),
'javelin-behavior-owners-path-editor' =>
array(
'uri' => '/res/9cf78ffc/rsrc/js/application/owners/owners-path-editor.js',
'type' => 'js',
'requires' =>
array(
0 => 'owners-path-editor',
1 => 'javelin-behavior',
),
'disk' => '/rsrc/js/application/owners/owners-path-editor.js',
),
Minor, map regen.
2012-08-22 00:03:01 +02:00
'javelin-behavior-phabricator-active-nav' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/9c8d3df8/rsrc/js/core/behavior-active-nav.js',
Minor, map regen.
2012-08-22 00:03:01 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-vector',
3 => 'javelin-dom',
4 => 'javelin-uri',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-active-nav.js',
Minor, map regen.
2012-08-22 00:03:01 +02:00
),
Add a "jump nav" element to the homepage, for quick tool/object navigation Summary: - Restore quick methods for getting to common features (upload file, create task, etc.) - Provide a flexible cli-like navigation element similar to stuff used at Facebook (bunny1 / lolbunny). Test Plan: Used jump nav and nav buttons. Reviewers: btrahan, fratrik Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1619
2012-02-16 02:49:23 +01:00
'javelin-behavior-phabricator-autofocus' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/bf92b8d6/rsrc/js/core/behavior-autofocus.js',
Add a "jump nav" element to the homepage, for quick tool/object navigation Summary: - Restore quick methods for getting to common features (upload file, create task, etc.) - Provide a flexible cli-like navigation element similar to stuff used at Facebook (bunny1 / lolbunny). Test Plan: Used jump nav and nav buttons. Reviewers: btrahan, fratrik Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1619
2012-02-16 02:49:23 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-autofocus.js',
Add a "jump nav" element to the homepage, for quick tool/object navigation Summary: - Restore quick methods for getting to common features (upload file, create task, etc.) - Provide a flexible cli-like navigation element similar to stuff used at Facebook (bunny1 / lolbunny). Test Plan: Used jump nav and nav buttons. Reviewers: btrahan, fratrik Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1619
2012-02-16 02:49:23 +01:00
),
Fix full width form layouts Summary: Fixes T3473, mostly reverts previous changes to clean up required field text, will have to redesign that in general for responsiveness. Test Plan: use logout form, use new conpherence form Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3473 Differential Revision: https://secure.phabricator.com/D6371
2013-07-04 05:24:28 +02:00
'javelin-behavior-phabricator-busy-example' =>
array(
'uri' => '/res/dbe12f2f/rsrc/js/application/uiexample/busy-example.js',
'type' => 'js',
'requires' =>
array(
0 => 'phabricator-busy',
1 => 'javelin-behavior',
),
'disk' => '/rsrc/js/application/uiexample/busy-example.js',
),
Minor, fix celerity map.
2013-02-06 17:32:36 +01:00
'javelin-behavior-phabricator-file-tree' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/e5bf93df/rsrc/js/core/behavior-file-tree.js',
Minor, fix celerity map.
2013-02-06 17:32:36 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'phabricator-keyboard-shortcut',
2 => 'javelin-stratcom',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-file-tree.js',
Minor, fix celerity map.
2013-02-06 17:32:36 +01:00
),
Add support for device swipe events Summary: Ref T2700. Allow JS to listen for swipes on devices. There are a bunch of tricky cases here and I probably didn't get them all totally right, but this interaction broadly looks like this: - We implement gesture recognition for the mouse in device modes (narrow browser), and for touch events from an actual device. - The sigil `touchable` indicates that a node wants to react to touch events. - When the user touches a `touchable` node, we start listening for moves. They might be tapping/clicking (in which case we don't care), but they might also be gesturing. - Once the user moves their finger/pointer far enough away from the tap origin, we recognize it as a gesture. I hardcoded this at 20px; I wasn't able to find any "official" Apple value, but 20px seems like a common default. - At this point, we look at where their finger has moved. - If they moved it mostly up/down, we interpret the gesture as "scroll" and just stop listening. The device does its own thing. - However, if they moved it mostly left/right, we interpret it as a "swipe". We start killing the moves so the device doesn't scroll. - Once we've recognized that a gesture is underway, we send a "gesture.swipe.start" event and then "gesture.swipe.move" events for every move. - When the user ends the gesture, we send "gesture.swipe.end". - If the user cancels the gesture (currently, only by tapping with a second finger), we send "gesture.swipe.cancel". - Gesture events have raw position data and some convenience fields. Test Plan: Wrote UI example and used it from the Desktop, iPhone simulator, and a real iphone. - The code always seems to get "scroll" vs "swipe" correct (i.e., consistent with my intentions). - The threshold feels pretty good to me. - Tapping with a second finger cancels the action. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T2700 Differential Revision: https://secure.phabricator.com/D5308
2013-03-09 22:53:15 +01:00
'javelin-behavior-phabricator-gesture' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/16e1e77c/rsrc/js/core/behavior-gesture.js',
Add support for device swipe events Summary: Ref T2700. Allow JS to listen for swipes on devices. There are a bunch of tricky cases here and I probably didn't get them all totally right, but this interaction broadly looks like this: - We implement gesture recognition for the mouse in device modes (narrow browser), and for touch events from an actual device. - The sigil `touchable` indicates that a node wants to react to touch events. - When the user touches a `touchable` node, we start listening for moves. They might be tapping/clicking (in which case we don't care), but they might also be gesturing. - Once the user moves their finger/pointer far enough away from the tap origin, we recognize it as a gesture. I hardcoded this at 20px; I wasn't able to find any "official" Apple value, but 20px seems like a common default. - At this point, we look at where their finger has moved. - If they moved it mostly up/down, we interpret the gesture as "scroll" and just stop listening. The device does its own thing. - However, if they moved it mostly left/right, we interpret it as a "swipe". We start killing the moves so the device doesn't scroll. - Once we've recognized that a gesture is underway, we send a "gesture.swipe.start" event and then "gesture.swipe.move" events for every move. - When the user ends the gesture, we send "gesture.swipe.end". - If the user cancels the gesture (currently, only by tapping with a second finger), we send "gesture.swipe.cancel". - Gesture events have raw position data and some convenience fields. Test Plan: Wrote UI example and used it from the Desktop, iPhone simulator, and a real iphone. - The code always seems to get "scroll" vs "swipe" correct (i.e., consistent with my intentions). - The threshold feels pretty good to me. - Tapping with a second finger cancels the action. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T2700 Differential Revision: https://secure.phabricator.com/D5308
2013-03-09 22:53:15 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-behavior-device',
2 => 'javelin-stratcom',
3 => 'javelin-vector',
4 => 'javelin-dom',
5 => 'javelin-magical-init',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-gesture.js',
Add support for device swipe events Summary: Ref T2700. Allow JS to listen for swipes on devices. There are a bunch of tricky cases here and I probably didn't get them all totally right, but this interaction broadly looks like this: - We implement gesture recognition for the mouse in device modes (narrow browser), and for touch events from an actual device. - The sigil `touchable` indicates that a node wants to react to touch events. - When the user touches a `touchable` node, we start listening for moves. They might be tapping/clicking (in which case we don't care), but they might also be gesturing. - Once the user moves their finger/pointer far enough away from the tap origin, we recognize it as a gesture. I hardcoded this at 20px; I wasn't able to find any "official" Apple value, but 20px seems like a common default. - At this point, we look at where their finger has moved. - If they moved it mostly up/down, we interpret the gesture as "scroll" and just stop listening. The device does its own thing. - However, if they moved it mostly left/right, we interpret it as a "swipe". We start killing the moves so the device doesn't scroll. - Once we've recognized that a gesture is underway, we send a "gesture.swipe.start" event and then "gesture.swipe.move" events for every move. - When the user ends the gesture, we send "gesture.swipe.end". - If the user cancels the gesture (currently, only by tapping with a second finger), we send "gesture.swipe.cancel". - Gesture events have raw position data and some convenience fields. Test Plan: Wrote UI example and used it from the Desktop, iPhone simulator, and a real iphone. - The code always seems to get "scroll" vs "swipe" correct (i.e., consistent with my intentions). - The threshold feels pretty good to me. - Tapping with a second finger cancels the action. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T2700 Differential Revision: https://secure.phabricator.com/D5308
2013-03-09 22:53:15 +01:00
),
'javelin-behavior-phabricator-gesture-example' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/91d1e7f2/rsrc/js/application/uiexample/gesture-example.js',
Add support for device swipe events Summary: Ref T2700. Allow JS to listen for swipes on devices. There are a bunch of tricky cases here and I probably didn't get them all totally right, but this interaction broadly looks like this: - We implement gesture recognition for the mouse in device modes (narrow browser), and for touch events from an actual device. - The sigil `touchable` indicates that a node wants to react to touch events. - When the user touches a `touchable` node, we start listening for moves. They might be tapping/clicking (in which case we don't care), but they might also be gesturing. - Once the user moves their finger/pointer far enough away from the tap origin, we recognize it as a gesture. I hardcoded this at 20px; I wasn't able to find any "official" Apple value, but 20px seems like a common default. - At this point, we look at where their finger has moved. - If they moved it mostly up/down, we interpret the gesture as "scroll" and just stop listening. The device does its own thing. - However, if they moved it mostly left/right, we interpret it as a "swipe". We start killing the moves so the device doesn't scroll. - Once we've recognized that a gesture is underway, we send a "gesture.swipe.start" event and then "gesture.swipe.move" events for every move. - When the user ends the gesture, we send "gesture.swipe.end". - If the user cancels the gesture (currently, only by tapping with a second finger), we send "gesture.swipe.cancel". - Gesture events have raw position data and some convenience fields. Test Plan: Wrote UI example and used it from the Desktop, iPhone simulator, and a real iphone. - The code always seems to get "scroll" vs "swipe" correct (i.e., consistent with my intentions). - The threshold feels pretty good to me. - Tapping with a second finger cancels the action. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T2700 Differential Revision: https://secure.phabricator.com/D5308
2013-03-09 22:53:15 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-stratcom',
1 => 'javelin-behavior',
2 => 'javelin-vector',
3 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/uiexample/gesture-example.js',
),
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
'javelin-behavior-phabricator-hovercards' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/4fe6b436/rsrc/js/core/behavior-hovercard.js',
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-behavior-device',
2 => 'javelin-stratcom',
Load hovercards on-demand Summary: See discussion in D5563. This loads hovercards on-demand, and shows them once they load. Ref T1048. Test Plan: Made a preview comment like `T1`, waved my mouse over it, got a hovercard shortly thereafter. Reviewers: AnhNhan Reviewed By: AnhNhan CC: aran Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5588
2013-04-05 20:01:56 +02:00
3 => 'javelin-vector',
4 => 'phabricator-hovercard',
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-hovercard.js',
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-phabricator-keyboard-pager' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/6a5445b8/rsrc/js/core/behavior-keyboard-pager.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-uri',
2 => 'phabricator-keyboard-shortcut',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-keyboard-pager.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-behavior-phabricator-keyboard-shortcuts' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/b971e713/rsrc/js/core/behavior-keyboard-shortcuts.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-workflow',
2 => 'javelin-json',
Fix a missing @requires Summary: Split from D1921. Lint complained. Test Plan: Lint doesn't complain. Reviewers: nh, vrana, btrahan Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1923
2012-03-20 03:17:40 +01:00
3 => 'javelin-dom',
4 => 'phabricator-keyboard-shortcut',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-keyboard-shortcuts.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Line highlighting for pastes Summary: Add the ability to select singular and multiple lines in paste to highlight. This is related to T3627 Test Plan: Create a paste, select one or more lines. Reviewers: epriestley, tberman Reviewed By: epriestley CC: aran, chad Maniphest Tasks: T3627 Differential Revision: https://secure.phabricator.com/D6668
2013-08-04 21:11:10 +02:00
'javelin-behavior-phabricator-line-linker' =>
array(
'uri' => '/res/1cefdb6a/rsrc/js/core/behavior-line-linker.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-history',
),
'disk' => '/rsrc/js/core/behavior-line-linker.js',
),
Allow pages to use new "flexible" nav Summary: This allows the nav to be laid out with divs instead of tables and for the navigation column to be made flexible. Design is non-final, this is just a step toward reactive menus that work on tablets/phones and an application menu. I'm going to play around with flexible nav and document navigation and see if that goes anywhere. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3114
2012-08-01 21:31:33 +02:00
'javelin-behavior-phabricator-nav' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/afabcf16/rsrc/js/core/behavior-phabricator-nav.js',
Allow pages to use new "flexible" nav Summary: This allows the nav to be laid out with divs instead of tables and for the navigation column to be made flexible. Design is non-final, this is just a step toward reactive menus that work on tablets/phones and an application menu. I'm going to play around with flexible nav and document navigation and see if that goes anywhere. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3114
2012-08-01 21:31:33 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Make the top nav non-fixed-position Summary: See some discussion in D1673. - There's a concrete (if minor) problem with this in Firefox with wrapping search. - People complain about how we're stealing all their pixels. - There isn't much of a functional purpose to it since all the operations are fairly rare. - This addresses the aesthetic purpose of the fixed-position nav (not making the side nav ugly) by making the side nav scroll up 44px and then stop. Test Plan: Scrolled in desktop, tablet modes. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3412
2012-08-31 03:58:51 +02:00
1 => 'javelin-behavior-device',
2 => 'javelin-stratcom',
3 => 'javelin-dom',
4 => 'javelin-magical-init',
5 => 'javelin-vector',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
6 => 'javelin-request',
7 => 'javelin-util',
Allow pages to use new "flexible" nav Summary: This allows the nav to be laid out with divs instead of tables and for the navigation column to be made flexible. Design is non-final, this is just a step toward reactive menus that work on tablets/phones and an application menu. I'm going to play around with flexible nav and document navigation and see if that goes anywhere. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3114
2012-08-01 21:31:33 +02:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-phabricator-nav.js',
Allow pages to use new "flexible" nav Summary: This allows the nav to be laid out with divs instead of tables and for the navigation column to be made flexible. Design is non-final, this is just a step toward reactive menus that work on tablets/phones and an application menu. I'm going to play around with flexible nav and document navigation and see if that goes anywhere. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3114
2012-08-01 21:31:33 +02:00
),
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'javelin-behavior-phabricator-notification-example' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/7c50cefd/rsrc/js/application/uiexample/notification-example.js',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'phabricator-notification',
1 => 'javelin-stratcom',
2 => 'javelin-behavior',
),
'disk' => '/rsrc/js/application/uiexample/notification-example.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-phabricator-object-selector' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/461f95f7/rsrc/js/core/behavior-object-selector.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-request',
3 => 'javelin-util',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-object-selector.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Kind-of-terrible (?) oncopy handler Summary: Works in Safari, Firefox, Chrome. Test Plan: Copied some text, threw up a little in my mouth. Reviewers: aran, tuomaspelkonen, tomo, rstout, btrahan Reviewed By: aran CC: aran, epriestley, ddfisher Maniphest Tasks: T145, T995 Differential Revision: https://secure.phabricator.com/D244
2012-03-16 03:04:59 +01:00
'javelin-behavior-phabricator-oncopy' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/cd3a9345/rsrc/js/core/behavior-oncopy.js',
Kind-of-terrible (?) oncopy handler Summary: Works in Safari, Firefox, Chrome. Test Plan: Copied some text, threw up a little in my mouth. Reviewers: aran, tuomaspelkonen, tomo, rstout, btrahan Reviewed By: aran CC: aran, epriestley, ddfisher Maniphest Tasks: T145, T995 Differential Revision: https://secure.phabricator.com/D244
2012-03-16 03:04:59 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-oncopy.js',
Kind-of-terrible (?) oncopy handler Summary: Works in Safari, Firefox, Chrome. Test Plan: Copied some text, threw up a little in my mouth. Reviewers: aran, tuomaspelkonen, tomo, rstout, btrahan Reviewed By: aran CC: aran, epriestley, ddfisher Maniphest Tasks: T145, T995 Differential Revision: https://secure.phabricator.com/D244
2012-03-16 03:04:59 +01:00
),
Minor, fix bad Celerity Map merge.
2012-10-02 03:48:39 +02:00
'javelin-behavior-phabricator-remarkup-assist' =>
array(
Remove "Chaos" mode and fix fullscreen in Conpherence Summary: Fixes T3782. Two changes: - Remove the "Chaos" mode, which wasn't as funny as I'd hoped and has had a good run. - Fix "Order" (now "Fullscreen") mode in Conpherence. Best fix I could come up with is dropping the "position: fixed" on all parents while in the mode. Test Plan: Used Fullscreen mode in Conpherence in Chrome. Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T3782 Differential Revision: https://secure.phabricator.com/D6844
2013-08-30 00:59:15 +02:00
'uri' => '/res/c3f4439f/rsrc/js/core/behavior-phabricator-remarkup-assist.js',
Minor, fix bad Celerity Map merge.
2012-10-02 03:48:39 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'phabricator-textareautils',
Implement order and chaos modes for Remarkup editing Summary: Ref T2599. Implements an "order" mode which fullscreens the editor and reduces distractions, similar to Asana's "focus" mode and GitHub's "zen" mode. This can help users who need fewer distractions get work done. Implements a "chaos" mode which does the opposite. This can help users who need more distractions to get work done. Test Plan: Clicked "order" and "chaos" buttons. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2599 Differential Revision: https://secure.phabricator.com/D5735
2013-04-20 04:50:21 +02:00
4 => 'javelin-workflow',
Remove "Chaos" mode and fix fullscreen in Conpherence Summary: Fixes T3782. Two changes: - Remove the "Chaos" mode, which wasn't as funny as I'd hoped and has had a good run. - Fix "Order" (now "Fullscreen") mode in Conpherence. Best fix I could come up with is dropping the "position: fixed" on all parents while in the mode. Test Plan: Used Fullscreen mode in Conpherence in Chrome. Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T3782 Differential Revision: https://secure.phabricator.com/D6844
2013-08-30 00:59:15 +02:00
5 => 'javelin-vector',
Minor, fix bad Celerity Map merge.
2012-10-02 03:48:39 +02:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-phabricator-remarkup-assist.js',
Minor, fix bad Celerity Map merge.
2012-10-02 03:48:39 +02:00
),
Implement basic transaction detail blocks Summary: Some transactions (like editing configuration values, task descriptions, or Conpherence images) can't be simply explained and need an additional larger element to show them fully (like a text diff). Support change details like this in ApplicationTransactions. Implements the element in Config, so you can see changes. Test Plan: {F32974} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2213 Differential Revision: https://secure.phabricator.com/D4984
2013-02-17 15:37:02 +01:00
'javelin-behavior-phabricator-reveal-content' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/fef525ef/rsrc/js/core/behavior-reveal-content.js',
Implement basic transaction detail blocks Summary: Some transactions (like editing configuration values, task descriptions, or Conpherence images) can't be simply explained and need an additional larger element to show them fully (like a text diff). Support change details like this in ApplicationTransactions. Implements the element in Config, so you can see changes. Test Plan: {F32974} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2213 Differential Revision: https://secure.phabricator.com/D4984
2013-02-17 15:37:02 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-reveal-content.js',
Implement basic transaction detail blocks Summary: Some transactions (like editing configuration values, task descriptions, or Conpherence images) can't be simply explained and need an additional larger element to show them fully (like a text diff). Support change details like this in ApplicationTransactions. Implements the element in Config, so you can see changes. Test Plan: {F32974} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2213 Differential Revision: https://secure.phabricator.com/D4984
2013-02-17 15:37:02 +01:00
),
Add a basic search typeahead Summary: This needs a bunch of refinement but pretty much works. Currently shows only users and applications. Plans: - Show actual search results too. - Clean up the datasource endpoint so it's less of a mess. - Make other typeaheads look more like this one. - Improve sorting. - Make object names hit the named objects as the first match. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: vrana CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3110
2012-08-01 02:58:21 +02:00
'javelin-behavior-phabricator-search-typeahead' =>
array(
Use ApplicationPHIDs to power object name typehaead results Summary: Ref T2715. When you type "T12", etc., into the search box, use ApplicationPHIDs to try to find an object name match. Test Plan: Typed "T12", "rP", "Q11", etc. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2715 Differential Revision: https://secure.phabricator.com/D6618
2013-07-29 16:31:59 +02:00
'uri' => '/res/409d9567/rsrc/js/core/behavior-search-typeahead.js',
Add a basic search typeahead Summary: This needs a bunch of refinement but pretty much works. Currently shows only users and applications. Plans: - Show actual search results too. - Clean up the datasource endpoint so it's less of a mess. - Make other typeaheads look more like this one. - Improve sorting. - Make object names hit the named objects as the first match. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: vrana CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3110
2012-08-01 02:58:21 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-typeahead-ondemand-source',
2 => 'javelin-typeahead',
3 => 'javelin-dom',
4 => 'javelin-uri',
Improve ordering of main typeahead results Summary: Always order applications first, then users, then other results (currently, there are no other results, of course). (This is similar to the general ordering algorithm used in JX.Prefab but has enough current/future differences that I split it rather than trying to share them.) Test Plan: Queried results, verified order. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3117
2012-08-01 21:36:33 +02:00
5 => 'javelin-util',
6 => 'javelin-stratcom',
Add a basic search typeahead Summary: This needs a bunch of refinement but pretty much works. Currently shows only users and applications. Plans: - Show actual search results too. - Clean up the datasource endpoint so it's less of a mess. - Make other typeaheads look more like this one. - Improve sorting. - Make object names hit the named objects as the first match. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: vrana CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3110
2012-08-01 02:58:21 +02:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-search-typeahead.js',
Add a basic search typeahead Summary: This needs a bunch of refinement but pretty much works. Currently shows only users and applications. Plans: - Show actual search results too. - Clean up the datasource endpoint so it's less of a mess. - Make other typeaheads look more like this one. - Improve sorting. - Make object names hit the named objects as the first match. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: vrana CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3110
2012-08-01 02:58:21 +02:00
),
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'javelin-behavior-phabricator-tooltips' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/a0ac5320/rsrc/js/core/behavior-tooltip.js',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Show tooltips in the application nav Summary: Replaces the full names after D3413. Test Plan: See screenshot. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3414
2012-08-31 03:59:08 +02:00
1 => 'javelin-behavior-device',
2 => 'javelin-stratcom',
3 => 'phabricator-tooltip',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-tooltip.js',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
),
Add previews to ApplicationTransaction Summary: Implements previews for Macros and Pholio. (Design is nonfinal -- kind of split the difference between `diff_full_view.png`, laziness, and space concerns. Next couple diffs will add more stuff here.) Test Plan: {F28055} Reviewers: btrahan, chad Reviewed By: btrahan CC: aran, vrana Maniphest Tasks: T2104 Differential Revision: https://secure.phabricator.com/D4246
2012-12-21 14:51:33 +01:00
'javelin-behavior-phabricator-transaction-comment-form' =>
array(
Restore comments on Ponder answers Summary: Ref T3373. This is still pretty messy: - The JS bugs out a bit with multiple primary object PHIDs on a single page. I'll fix this in a followup. - The comment form itself is enormous, I'll restore some show/hide stuff in a followup. Test Plan: Added answer comments in Ponder. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3373 Differential Revision: https://secure.phabricator.com/D6608
2013-07-29 02:40:11 +02:00
'uri' => '/res/3c8d3c10/rsrc/js/application/transactions/behavior-transaction-comment-form.js',
Add previews to ApplicationTransaction Summary: Implements previews for Macros and Pholio. (Design is nonfinal -- kind of split the difference between `diff_full_view.png`, laziness, and space concerns. Next couple diffs will add more stuff here.) Test Plan: {F28055} Reviewers: btrahan, chad Reviewed By: btrahan CC: aran, vrana Maniphest Tasks: T2104 Differential Revision: https://secure.phabricator.com/D4246
2012-12-21 14:51:33 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
Make ApplicationTransactions preview -> submit flow less janky Summary: ...also make it so in Pholio when you add an inline comment the preview refreshes. Fixes T2649. Test Plan: played around in pholio leaving commentary. noted that a new inline comment would refresh the preview. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2649 Differential Revision: https://secure.phabricator.com/D6267
2013-06-25 00:41:59 +02:00
3 => 'javelin-fx',
4 => 'javelin-request',
5 => 'phabricator-shaped-request',
Add previews to ApplicationTransaction Summary: Implements previews for Macros and Pholio. (Design is nonfinal -- kind of split the difference between `diff_full_view.png`, laziness, and space concerns. Next couple diffs will add more stuff here.) Test Plan: {F28055} Reviewers: btrahan, chad Reviewed By: btrahan CC: aran, vrana Maniphest Tasks: T2104 Differential Revision: https://secure.phabricator.com/D4246
2012-12-21 14:51:33 +01:00
),
'disk' => '/rsrc/js/application/transactions/behavior-transaction-comment-form.js',
),
Modernize the top half of Maniphest Summary: Use modern elements: crumbs, header, action list, property list, tags. No functional changes. Test Plan: {F26934} Reviewers: chad, btrahan, vrana Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D4153
2012-12-11 23:03:16 +01:00
'javelin-behavior-phabricator-transaction-list' =>
array(
Update Form Layouts Summary: This attempts some consistency in form layouts. Notably, they all now contain headers and are 16px off the sides and tops of pages. Also updated dialogs to the same look and feel. I think I got 98% of forms with this pass, but it's likely I missed some buried somewhere. TODO: will take another pass as consolidating these colors and new gradients in another diff. Test Plan: Played in my sandbox all week. Please play with it too and let me know how they feel. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6806
2013-08-26 20:53:11 +02:00
'uri' => '/res/f05b3c6b/rsrc/js/application/transactions/behavior-transaction-list.js',
Modernize the top half of Maniphest Summary: Use modern elements: crumbs, header, action list, property list, tags. No functional changes. Test Plan: {F26934} Reviewers: chad, btrahan, vrana Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D4153
2012-12-11 23:03:16 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-workflow',
3 => 'javelin-dom',
4 => 'javelin-fx',
),
'disk' => '/rsrc/js/application/transactions/behavior-transaction-list.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-phabricator-watch-anchor' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/69a90817/rsrc/js/core/behavior-watch-anchor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
Retry failed page anchor navigation Summary: When the user loads a page with an anchor on it like #thing, or clicks a link to #thing, and #thing doesn't exist, keep trying to navigate to #thing for a few seconds. This allows anchors to work when the target is in content which is later ajaxed in. In particular, this affects inline comments in Differential. Test Plan: Opened inline comment links in a new tab, was in the right place when I switched tabs. Reviewers: nh, btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan, epriestley Maniphest Tasks: T492 Differential Revision: https://secure.phabricator.com/D1327
2012-01-06 01:36:59 +01:00
3 => 'javelin-vector',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-watch-anchor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Phame V1 - Phabricator blogging software Summary: 'cuz we need to be phamous! V1 feature set - posts -- standard thing you'd expect - a title and a remarkup-powered body and... -- "phame" title - a short string that can be used to reference the story. this gets auto-updated when you mess with the title. -- configuration - for now, do you want Facebook, Disqus or no comments? this is a per-post thing but feeds from an instance-wide configuration Please do toss out any must have features or changes. Test Plan: played around with this bad boy like whoa Reviewers: epriestley Reviewed By: epriestley CC: aran, vrana Maniphest Tasks: T1111 Differential Revision: https://secure.phabricator.com/D2202
2012-04-12 22:09:04 +02:00
'javelin-behavior-phame-post-preview' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/181d1cbe/rsrc/js/application/phame/phame-post-preview.js',
Phame V1 - Phabricator blogging software Summary: 'cuz we need to be phamous! V1 feature set - posts -- standard thing you'd expect - a title and a remarkup-powered body and... -- "phame" title - a short string that can be used to reference the story. this gets auto-updated when you mess with the title. -- configuration - for now, do you want Facebook, Disqus or no comments? this is a per-post thing but feeds from an instance-wide configuration Please do toss out any must have features or changes. Test Plan: played around with this bad boy like whoa Reviewers: epriestley Reviewed By: epriestley CC: aran, vrana Maniphest Tasks: T1111 Differential Revision: https://secure.phabricator.com/D2202
2012-04-12 22:09:04 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/phame/phame-post-preview.js',
),
Pholio - make the form maintain client side edits between file uploads Summary: Fixes T3553. Did it by adding some code that refreshes the File object on keyup events within a given file entry. also fixes an html derp I found trying to fix this. Test Plan: added cool things like 'bbb' to every field and noted they were maintained when I added more files Reviewers: btrahan Reviewed By: btrahan CC: aran, Korvin, chad Maniphest Tasks: T3553 Differential Revision: https://secure.phabricator.com/D6488
2013-07-19 00:04:08 +02:00
'javelin-behavior-pholio-mock-edit' =>
array(
Allow only one global top menu to be open at a time Summary: Fixes T3715. Makes "visible" global instead of per-menu, so all the menus share a visible state. Test Plan: For menus A and B, clicked "A, A", "A, B, A", "A, B, B", "A, B, B, A", etc. Couldn't figure out a way to break it. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T3715 Differential Revision: https://secure.phabricator.com/D6745
2013-08-13 23:57:52 +02:00
'uri' => '/res/1fd14497/rsrc/js/application/pholio/behavior-pholio-mock-edit.js',
Pholio - make the form maintain client side edits between file uploads Summary: Fixes T3553. Did it by adding some code that refreshes the File object on keyup events within a given file entry. also fixes an html derp I found trying to fix this. Test Plan: added cool things like 'bbb' to every field and noted they were maintained when I added more files Reviewers: btrahan Reviewed By: btrahan CC: aran, Korvin, chad Maniphest Tasks: T3553 Differential Revision: https://secure.phabricator.com/D6488
2013-07-19 00:04:08 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-workflow',
4 => 'phabricator-phtize',
5 => 'phabricator-drag-and-drop-file-upload',
Allow Pholio mock images to be drag-reordered Summary: Ref T3640. JS part only, should give you a list in `imageOrder` on the server that you can read with `$request->getStrList('imageOrder')`. NOTE: You can't drag images into the first position; this is an existing thing that I just need to fix with DraggableList. @chad might have some design feedback. Test Plan: Dragged images around, things seemed to work? Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T3640 Differential Revision: https://secure.phabricator.com/D6729
2013-08-12 21:08:54 +02:00
6 => 'phabricator-draggable-list',
Pholio - make the form maintain client side edits between file uploads Summary: Fixes T3553. Did it by adding some code that refreshes the File object on keyup events within a given file entry. also fixes an html derp I found trying to fix this. Test Plan: added cool things like 'bbb' to every field and noted they were maintained when I added more files Reviewers: btrahan Reviewed By: btrahan CC: aran, Korvin, chad Maniphest Tasks: T3553 Differential Revision: https://secure.phabricator.com/D6488
2013-07-19 00:04:08 +02:00
),
'disk' => '/rsrc/js/application/pholio/behavior-pholio-mock-edit.js',
),
Show all photos in a Pholio mock and allow switching between them Summary: Mock page now shows all images. Switching between images is done by clicking thumbnails. Test Plan: Verified that all images are shown. Verified that by clicking thumbnail the image clicked will show. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2427 Differential Revision: https://secure.phabricator.com/D4698
2013-01-28 20:18:50 +01:00
'javelin-behavior-pholio-mock-view' =>
array(
Line highlighting for pastes Summary: Add the ability to select singular and multiple lines in paste to highlight. This is related to T3627 Test Plan: Create a paste, select one or more lines. Reviewers: epriestley, tberman Reviewed By: epriestley CC: aran, chad Maniphest Tasks: T3627 Differential Revision: https://secure.phabricator.com/D6668
2013-08-04 21:11:10 +02:00
'uri' => '/res/f9588dcf/rsrc/js/application/pholio/behavior-pholio-mock-view.js',
Show all photos in a Pholio mock and allow switching between them Summary: Mock page now shows all images. Switching between images is done by clicking thumbnails. Test Plan: Verified that all images are shown. Verified that by clicking thumbnail the image clicked will show. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2427 Differential Revision: https://secure.phabricator.com/D4698
2013-01-28 20:18:50 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
When an image is too wide in Pholio, scale it down Summary: Currently, if an image is too wide for the viewport, we freak out. Instead, scale it down. This means we must also scale down all the rectangles on it, which is why this is tricky. However, all the draw/load separation has made it reasonably straightforward. We'll possibly need to add some kind of "view full size" thing. I'm planning to add an element which shows "85%" or whatever if it's currently scaled. Test Plan: Before: {F33607} After: {F33608} Reviewers: chad, ljalonen Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5088
2013-02-23 15:28:34 +01:00
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-dom',
4 => 'javelin-vector',
5 => 'javelin-magical-init',
6 => 'javelin-request',
Make Pholio URIs aware of which image you are looking at Summary: Fixes T2658. Map `/Mxx/yy/` to images in a mock. Use HTML5 history stuff to make it work nicely. This also makes right-click-open-in-new-tab work correctly. Test Plan: Clicked thumbs in a mock. Right-clicked thumbs. Copy and pasted a URI. Used browser back button. Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2658 Differential Revision: https://secure.phabricator.com/D5222
2013-03-05 03:43:29 +01:00
7 => 'javelin-history',
Improve behavior of inline comment dialog Summary: Fixes T2669. - Currently, making an inline comment does not focus the textarea. Instead, focus the textarea. - Currently, the positioning is kind of buggy. Make it viewport-relative and put the dialog slightly below the inline reticle. - Use `JX.Workflow` more and simplify some of the ajax stuff. Test Plan: Created inline comments. Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2669 Differential Revision: https://secure.phabricator.com/D5229
2013-03-05 21:30:05 +01:00
8 => 'javelin-workflow',
Improve Pholio on mobile Summary: Ref T2644. This isn't perfect, but makes Pholio more-or-less usable on mobile. In particular: - Inline comments drop below the image. - Clicking the image lightboxes a full size version so you can scroll around it and inspect details. - Clicking it again dismisses it. Things that aren't good: - Can't add inline comments. This seems complicated and not critical. - Can't easily figure out which inline comments go where since there's no hover. Maybe let you tap them? Not sure if we really need this. - Thumbs are between image and image data. I'm planning to get rid of the thumbs and do swipe left/right instead. - It would be nice to scroll the lightbox to center on the part of the image you tapped. I just thought of this, though. Test Plan: {F34640} {F34641} {F34642} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2644 Differential Revision: https://secure.phabricator.com/D5232
2013-03-05 21:30:58 +01:00
9 => 'javelin-mask',
10 => 'javelin-behavior-device',
11 => 'phabricator-keyboard-shortcut',
Show all photos in a Pholio mock and allow switching between them Summary: Mock page now shows all images. Switching between images is done by clicking thumbnails. Test Plan: Verified that all images are shown. Verified that by clicking thumbnail the image clicked will show. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2427 Differential Revision: https://secure.phabricator.com/D4698
2013-01-28 20:18:50 +01:00
),
'disk' => '/rsrc/js/application/pholio/behavior-pholio-mock-view.js',
),
Make the policy control a JS dropdown with icons Summary: Ref T603. After thinking about this for a bit I can't really come up with anything better than what Facebook does, so I'm going to implement something similar for choosing custom policies. To start with, swap this over to a JS-driven dropdown. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: btrahan CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7285
2013-10-13 02:08:11 +02:00
'javelin-behavior-policy-control' =>
array(
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'uri' => '/res/f43ba427/rsrc/js/application/policy/behavior-policy-control.js',
Make the policy control a JS dropdown with icons Summary: Ref T603. After thinking about this for a bit I can't really come up with anything better than what Facebook does, so I'm going to implement something similar for choosing custom policies. To start with, swap this over to a JS-driven dropdown. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: btrahan CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7285
2013-10-13 02:08:11 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-dropdown-menu',
4 => 'phabricator-menu-item',
),
'disk' => '/rsrc/js/application/policy/behavior-policy-control.js',
),
Custom Policy Editor Summary: Ref T603. This isn't remotely usable yet, but I wanted to get any feedback before I build it out anymore. I think this is a reasonable interface for defining custom policies? It's basically similar to Herald, although it's a bit simpler. I imagine users will rarely interact with this, but this will service the high end of policy complexity (and allow the definition of things like "is member of LDAP group" or whatever). Test Plan: See screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran, asherkin Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7217
2013-10-09 23:05:10 +02:00
'javelin-behavior-policy-rule-editor' =>
array(
'uri' => '/res/4ae4249d/rsrc/js/application/policy/behavior-policy-rule-editor.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'multirow-row-manager',
2 => 'javelin-dom',
3 => 'javelin-util',
4 => 'phabricator-prefab',
5 => 'javelin-tokenizer',
6 => 'javelin-typeahead',
7 => 'javelin-typeahead-preloaded-source',
8 => 'javelin-json',
),
'disk' => '/rsrc/js/application/policy/behavior-policy-rule-editor.js',
),
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
'javelin-behavior-ponder-votebox' =>
array(
Fixed voting comments bug on Ponder Summary: When user changed his mind for voting, counting does not work properly. If user vote up first and vote down, vote count must be decreased 2. fixed in javascript file Test Plan: http://cihad.phabricator.pompa.la/Q11 user : demo pass : demodemo Reviewers: aran, Korvin, epriestley Reviewed By: epriestley CC: simsekburak Differential Revision: https://secure.phabricator.com/D6446
2013-07-14 00:58:30 +02:00
'uri' => '/res/c28daa12/rsrc/js/application/ponder/behavior-votebox.js',
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
Add applications for Owners, Repositories, PHID manager, PHPAST Summary: See D3572. Test Plan: Viewed /applications/, saw all these applications. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3579
2012-10-01 21:56:33 +02:00
3 => 'javelin-stratcom',
4 => 'javelin-request',
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
),
'disk' => '/rsrc/js/application/ponder/behavior-votebox.js',
),
Allow commits to be associated with projects and associated goodies Summary: - Commit detail view - List of projects - "edit" action which takes the user to a simple form where they can only add / remove projects. - Integrated the project relationship into the commit search indexer - fixed a bug from D790; it seems you must select the column if you're going to join against it later. Without this change searching for author or projectfails 100% for me. Test Plan: added and removed projects. verified appropriate projects showed up in detail and edit view. searched for commits by project and found the ones I was supposed to...! Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1614 Differential Revision: https://secure.phabricator.com/D3189
2012-08-08 19:03:41 +02:00
'javelin-behavior-project-create' =>
array(
'uri' => '/res/e91f3f8f/rsrc/js/application/projects/behavior-project-create.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
3 => 'javelin-workflow',
),
'disk' => '/rsrc/js/application/projects/behavior-project-create.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-refresh-csrf' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/6c54100f/rsrc/js/core/behavior-refresh-csrf.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-request',
1 => 'javelin-behavior',
2 => 'javelin-dom',
Simplify lightboxing and fix a few things Summary: Minor tweaks to lightboxes. - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it. - Make the lightbox go over the menu bar -- was it intentional that it wasn't? - Make 'jx-mask' use "position: fixed;" too. - Add a loading indicator. - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area. I'm going to do a couple of other tweaks here but need to update JX.Mask. Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3795
2012-10-24 02:34:43 +02:00
3 => 'phabricator-busy',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-refresh-csrf.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Releeph (Phabricator part) Summary: A copy of the Releeph release tool. Test Plan: Generally, click everything at least once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D4932
2013-03-15 12:28:43 +01:00
'javelin-behavior-releeph-preview-branch' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/f694854d/rsrc/js/application/releeph/releeph-preview-branch.js',
Releeph (Phabricator part) Summary: A copy of the Releeph release tool. Test Plan: Generally, click everything at least once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D4932
2013-03-15 12:28:43 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
2 => 'javelin-uri',
3 => 'javelin-request',
Releeph (Phabricator part) Summary: A copy of the Releeph release tool. Test Plan: Generally, click everything at least once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D4932
2013-03-15 12:28:43 +01:00
),
'disk' => '/rsrc/js/application/releeph/releeph-preview-branch.js',
),
'javelin-behavior-releeph-request-state-change' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/07ecde0c/rsrc/js/application/releeph/releeph-request-state-change.js',
Releeph (Phabricator part) Summary: A copy of the Releeph release tool. Test Plan: Generally, click everything at least once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D4932
2013-03-15 12:28:43 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
3 => 'javelin-request',
Releeph (Phabricator part) Summary: A copy of the Releeph release tool. Test Plan: Generally, click everything at least once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D4932
2013-03-15 12:28:43 +01:00
4 => 'phabricator-keyboard-shortcut',
5 => 'phabricator-notification',
),
'disk' => '/rsrc/js/application/releeph/releeph-request-state-change.js',
),
'javelin-behavior-releeph-request-typeahead' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/2c2350a0/rsrc/js/application/releeph/releeph-request-typeahead.js',
Releeph (Phabricator part) Summary: A copy of the Releeph release tool. Test Plan: Generally, click everything at least once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D4932
2013-03-15 12:28:43 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-dom',
2 => 'javelin-typeahead',
3 => 'javelin-typeahead-ondemand-source',
4 => 'javelin-dom',
Releeph (Phabricator part) Summary: A copy of the Releeph release tool. Test Plan: Generally, click everything at least once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D4932
2013-03-15 12:28:43 +01:00
),
'disk' => '/rsrc/js/application/releeph/releeph-request-typeahead.js',
),
Partially generalize Remarkup previews and add support to Differential Summary: Ref T3671. A lot of applications have pretty ad-hoc preview code. Clean it up a bit and add Summary preview to Differential. After ApplicationTransactions we might want to try to serialize the whole form and show a preview of all the transactions, but this seems not very useful in most cases (I'd guess that Remarkup previews are 99% of the value) and tricky to get right (e.g., adding images which don't exist yet to Pholio mocks). I think I can add this in a few other places, too. Test Plan: Edited Maniphest Tasks and Differential Revisions, mashed some buttons. Verified previews rendered correctly. Grepped for removed CSS classes (no hits). {F52907} Reviewers: btrahan, Firehed Reviewed By: btrahan CC: aran, chad Maniphest Tasks: T3671 Differential Revision: https://secure.phabricator.com/D6673
2013-08-05 19:46:39 +02:00
'javelin-behavior-remarkup-preview' =>
array(
'uri' => '/res/6ec98508/rsrc/js/core/behavior-remarkup-preview.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/core/behavior-remarkup-preview.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-repository-crossreference' =>
array(
Removed getElementsByClassName in repositor-crossreference.js Summary: Used JX.DOM.scry() to locate blocks. Test Plan: I made the necessary changes, differential is loading diffs as usual. Let me know if I have done it correctly. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T3007 Differential Revision: https://secure.phabricator.com/D5887 Conflicts: src/__celerity_resource_map__.php Conflicts: src/__celerity_resource_map__.php
2013-05-12 15:52:53 +02:00
'uri' => '/res/d3f9d50b/rsrc/js/application/repository/repository-crossreference.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Don't open symbols on double click Summary: My average double click speed is 10 ms but I tried to double click as I think normal people double clicks and it was around 200 ms. I don't want to make the timeout much longer because it looks like that something doesn't work. Test Plan: Double clicked on symbol. Clicked on symbol. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3509
2012-09-17 23:50:49 +02:00
2 => 'javelin-stratcom',
3 => 'javelin-uri',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/repository/repository-crossreference.js',
),
Allow named queries to be reordered by dragging Summary: Also you have to drop them. So drag, and then drop. This needs some cleanup and reconciliation/generalization with the Maniphest implementation. In particular, you can't drag things to the very top right now, and they should share more CSS and more behaviors. Test Plan: Look I alphabetized them: {F45286} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6136
2013-06-06 01:22:27 +02:00
'javelin-behavior-search-reorder-queries' =>
array(
Simplify drag-and-drop list implementations Summary: - Use the same styles for shared operations (`drag-ghost`, `drag-dragging`). - Move shared code into the base class. Test Plan: Dragged around tasks and named queries. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6141
2013-06-06 02:36:33 +02:00
'uri' => '/res/9864b481/rsrc/js/application/search/behavior-reorder-queries.js',
Allow named queries to be reordered by dragging Summary: Also you have to drop them. So drag, and then drop. This needs some cleanup and reconciliation/generalization with the Maniphest implementation. In particular, you can't drag things to the very top right now, and they should share more CSS and more behaviors. Test Plan: Look I alphabetized them: {F45286} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6136
2013-06-06 01:22:27 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Simplify drag-and-drop list implementations Summary: - Use the same styles for shared operations (`drag-ghost`, `drag-dragging`). - Move shared code into the base class. Test Plan: Dragged around tasks and named queries. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6141
2013-06-06 02:36:33 +02:00
1 => 'javelin-stratcom',
2 => 'javelin-workflow',
3 => 'javelin-dom',
4 => 'phabricator-draggable-list',
Allow named queries to be reordered by dragging Summary: Also you have to drop them. So drag, and then drop. This needs some cleanup and reconciliation/generalization with the Maniphest implementation. In particular, you can't drag things to the very top right now, and they should share more CSS and more behaviors. Test Plan: Look I alphabetized them: {F45286} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6136
2013-06-06 01:22:27 +02:00
),
'disk' => '/rsrc/js/application/search/behavior-reorder-queries.js',
),
Embed slowvotes have basic interaction Summary: User can now vote through embed slowvote Test Plan: Voted'n stuff Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad, AnhNhan Maniphest Tasks: T2883 Differential Revision: https://secure.phabricator.com/D5743
2013-05-04 00:48:59 +02:00
'javelin-behavior-slowvote-embed' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/8e85e20d/rsrc/js/application/slowvote/behavior-slowvote-embed.js',
Embed slowvotes have basic interaction Summary: User can now vote through embed slowvote Test Plan: Voted'n stuff Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad, AnhNhan Maniphest Tasks: T2883 Differential Revision: https://secure.phabricator.com/D5743
2013-05-04 00:48:59 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-request',
Embed slowvotes have basic interaction Summary: User can now vote through embed slowvote Test Plan: Voted'n stuff Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad, AnhNhan Maniphest Tasks: T2883 Differential Revision: https://secure.phabricator.com/D5743
2013-05-04 00:48:59 +02:00
2 => 'javelin-stratcom',
3 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/slowvote/behavior-slowvote-embed.js',
),
For discussion -- Stripe integration Summary: various stripe stuff, including - external stripe library - payment form - test controller to play with payment form, sample business logic My main questions / discussion topics are... - is the stripe PHP library too big? (ie should I write something more simple just for phabricator?) -- if its cool, what is the best way to include the client? (ie should I make it a submodule rather than the flat copy here?) - is the JS I wrote (too) ridiculous? -- particularly unhappy with the error message stuff being in JS *but* it seemed the best choice given the most juicy error messages come from the stripe JS such that the overall code complexity is lowest this way. - how should the stripe JS be included? -- flat copy like I did here? -- some sort of external? -- can we just load it off stripe servers at request time? (I like that from the "if stripe is down, stripe is down" perspective) - wasn't sure if the date control was too silly and should just be baked into the form? -- for some reason I feel like its good to be prepared to walk away from Stripe / switch providers here, though I think this is on the wrong side of pragmatic Test Plan: - played around with sample client form Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2096
2012-04-05 01:09:29 +02:00
'javelin-behavior-stripe-payment-form' =>
array(
Updated the CLI for smoother use Summary: Ref T2903 Test Plan: Tested all CLI possibilities Reviewers: epriestley, AnhNhan Reviewed By: epriestley CC: AnhNhan, aran, Korvin, jqh9804 Maniphest Tasks: T2903 Differential Revision: https://secure.phabricator.com/D5711
2013-04-29 21:14:50 +02:00
'uri' => '/res/c1a12d77/rsrc/js/application/phortune/behavior-stripe-payment-form.js',
For discussion -- Stripe integration Summary: various stripe stuff, including - external stripe library - payment form - test controller to play with payment form, sample business logic My main questions / discussion topics are... - is the stripe PHP library too big? (ie should I write something more simple just for phabricator?) -- if its cool, what is the best way to include the client? (ie should I make it a submodule rather than the flat copy here?) - is the JS I wrote (too) ridiculous? -- particularly unhappy with the error message stuff being in JS *but* it seemed the best choice given the most juicy error messages come from the stripe JS such that the overall code complexity is lowest this way. - how should the stripe JS be included? -- flat copy like I did here? -- some sort of external? -- can we just load it off stripe servers at request time? (I like that from the "if stripe is down, stripe is down" perspective) - wasn't sure if the date control was too silly and should just be baked into the form? -- for some reason I feel like its good to be prepared to walk away from Stripe / switch providers here, though I think this is on the wrong side of pragmatic Test Plan: - played around with sample client form Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2096
2012-04-05 01:09:29 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Updated the CLI for smoother use Summary: Ref T2903 Test Plan: Tested all CLI possibilities Reviewers: epriestley, AnhNhan Reviewed By: epriestley CC: AnhNhan, aran, Korvin, jqh9804 Maniphest Tasks: T2903 Differential Revision: https://secure.phabricator.com/D5711
2013-04-29 21:14:50 +02:00
2 => 'phortune-credit-card-form',
For discussion -- Stripe integration Summary: various stripe stuff, including - external stripe library - payment form - test controller to play with payment form, sample business logic My main questions / discussion topics are... - is the stripe PHP library too big? (ie should I write something more simple just for phabricator?) -- if its cool, what is the best way to include the client? (ie should I make it a submodule rather than the flat copy here?) - is the JS I wrote (too) ridiculous? -- particularly unhappy with the error message stuff being in JS *but* it seemed the best choice given the most juicy error messages come from the stripe JS such that the overall code complexity is lowest this way. - how should the stripe JS be included? -- flat copy like I did here? -- some sort of external? -- can we just load it off stripe servers at request time? (I like that from the "if stripe is down, stripe is down" perspective) - wasn't sure if the date control was too silly and should just be baked into the form? -- for some reason I feel like its good to be prepared to walk away from Stripe / switch providers here, though I think this is on the wrong side of pragmatic Test Plan: - played around with sample client form Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2096
2012-04-05 01:09:29 +02:00
),
'disk' => '/rsrc/js/application/phortune/behavior-stripe-payment-form.js',
),
Updated the CLI for smoother use Summary: Ref T2903 Test Plan: Tested all CLI possibilities Reviewers: epriestley, AnhNhan Reviewed By: epriestley CC: AnhNhan, aran, Korvin, jqh9804 Maniphest Tasks: T2903 Differential Revision: https://secure.phabricator.com/D5711
2013-04-29 21:14:50 +02:00
'javelin-behavior-test-payment-form' =>
array(
'uri' => '/res/a8fe8616/rsrc/js/application/phortune/behavior-test-payment-form.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'phortune-credit-card-form',
),
'disk' => '/rsrc/js/application/phortune/behavior-test-payment-form.js',
),
Add a "toggle-class" behavior Summary: The new menu stuff needs this but it was easy to pull out on its own. Test Plan: Cliked UI example buttons. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3104
2012-07-31 01:08:42 +02:00
'javelin-behavior-toggle-class' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/79921b7f/rsrc/js/core/behavior-toggle-class.js',
Add a "toggle-class" behavior Summary: The new menu stuff needs this but it was easy to pull out on its own. Test Plan: Cliked UI example buttons. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3104
2012-07-31 01:08:42 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-toggle-class.js',
Add a "toggle-class" behavior Summary: The new menu stuff needs this but it was easy to pull out on its own. Test Plan: Cliked UI example buttons. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3104
2012-07-31 01:08:42 +02:00
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-view-placeholder' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/6abdb85b/rsrc/externals/javelin/ext/view/ViewPlaceholder.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-view-renderer',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
3 => 'javelin-install',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/ext/view/ViewPlaceholder.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-behavior-workflow' =>
array(
Generalize rules for "workflow" sigil Summary: See discussion in D6130. Basically, all of these should activate workflow: <a data-sigil="workflow" href="...">...</a> <div data-sigil="workflow"> <a href="...">...</a> </div> <form data-sigil="workflow" action="...">...</form> <div data-sigil="workflow"> <form action="...">...</form> </div> The only case where we don't want to activate workflow is this one: <form data-sigil="workflow"> <a href="...">...</a> </form> Here, the form should workflow but the `<a />` should not. These cases aren't really covered: // Undefined no matter where "workflow" is because it's nonsense. <a><a>...</a></a> // As above except like a million times more dumb. <form><form>...</form></form> // This one is ambiguous. The <a /> will currently workflow. We don't do // this anywhere and probably never will. If we want a different rule we // can cross that bridge when we come to it. <div data-sigil="workflow"> <form action="..."> <a href="...">...</a> </form> </div> Test Plan: Clicked/submitted some things with workflow. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6131
2013-06-06 01:21:21 +02:00
'uri' => '/res/4a0595c1/rsrc/js/core/behavior-workflow.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-workflow',
Restore a more surgical workflow/target check Summary: D3707 removed some overbroad rules for when we trigger workflows, but there is still one case we should check for -- an <a /> without workflow inside a <form /> with workflow. This occurs in, e.g., the "help" button in Remarkup. If the node with workflow isn't a link, don't trigger workflow. This should allow the <a><img /></a> case to keep working properly. Test Plan: Clicked "?" in remarkup bar. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3722
2012-10-17 17:28:37 +02:00
3 => 'javelin-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/behavior-workflow.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-color' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/f17034de/rsrc/externals/javelin/ext/fx/Color.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/ext/fx/Color.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-cookie' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/ee0d399f/rsrc/externals/javelin/lib/Cookie.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/Cookie.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-dom' =>
array(
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'uri' => '/res/580c0aeb/rsrc/externals/javelin/lib/DOM.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-magical-init',
1 => 'javelin-install',
2 => 'javelin-util',
3 => 'javelin-vector',
4 => 'javelin-stratcom',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/DOM.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-dynval' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/ea6f2a9d/rsrc/externals/javelin/ext/reactor/core/DynVal.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-reactornode',
2 => 'javelin-util',
3 => 'javelin-reactor',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/ext/reactor/core/DynVal.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-event' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/5f70f4d0/rsrc/externals/javelin/core/Event.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/core/Event.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-fx' =>
array(
Make animations set their initial values immediately Summary: Currently, it takes one frame for animations to set their first value. For fading stuff in, that means it briefly appears at 100% opacity, then jumps to 0%, then fades in from there. Instead, immediately tween to the initial value. Test Plan: Comments in Pholio fade in nicely. Preview is still a janky pile of mess until D6267. Reviewers: btrahan, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6268
2013-06-22 03:57:10 +02:00
'uri' => '/res/23fb3d44/rsrc/externals/javelin/ext/fx/FX.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-color',
1 => 'javelin-install',
2 => 'javelin-util',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/ext/fx/FX.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-history' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/6c084b09/rsrc/externals/javelin/lib/History.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-stratcom',
1 => 'javelin-install',
2 => 'javelin-uri',
3 => 'javelin-util',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/History.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-install' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/904356c0/rsrc/externals/javelin/core/install.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-util',
1 => 'javelin-magical-init',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/core/install.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-json' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/cf83e72c/rsrc/externals/javelin/lib/JSON.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/JSON.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-magical-init' =>
array(
Improve an awkward initialization behavior in Javelin in Firefox Summary: See comment; see IRC. This didn't cause anything bad, but ended up with `document.body.id == "null"` in Firefox, which is a bit weird. Test Plan: Loaded page, put `document.body.null` into the console, got consistent results. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7288
2013-10-13 02:08:56 +02:00
'uri' => '/res/374d1f02/rsrc/externals/javelin/core/init.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/core/init.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-mask' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/465cf513/rsrc/externals/javelin/lib/Mask.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Fix mask positioning and use mask classes in lightbox Summary: See D3795 / D3797. Also made the mask darker. Test Plan: Mask now sizes properly on window resize in all browsers / mask uses. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3798
2012-10-23 20:39:33 +02:00
1 => 'javelin-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/Mask.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-reactor' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/c05f2658/rsrc/externals/javelin/ext/reactor/core/Reactor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/ext/reactor/core/Reactor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-reactor-dom' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/5e03117e/rsrc/externals/javelin/ext/reactor/dom/RDOM.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-dom',
1 => 'javelin-dynval',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
2 => 'javelin-reactor',
3 => 'javelin-reactornode',
4 => 'javelin-install',
5 => 'javelin-util',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/ext/reactor/dom/RDOM.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-reactor-node-calmer' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/a93dd6b6/rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-reactor',
2 => 'javelin-util',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-reactornode' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/4eac475b/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-reactor',
2 => 'javelin-util',
3 => 'javelin-reactor-node-calmer',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-request' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/687bdcfc/rsrc/externals/javelin/lib/Request.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-stratcom',
2 => 'javelin-util',
3 => 'javelin-behavior',
4 => 'javelin-json',
5 => 'javelin-dom',
Update static resource packages Summary: These are a bit out of date; bundle things together better. Test Plan: Viewed page source for home, differential list, differential diff, maniphest list, maniphest task. Verified reasonable resource packaging. Reviewers: chad, vrana, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4002
2012-11-21 03:01:25 +01:00
6 => 'javelin-resource',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/Request.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-resource' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/33a3bb57/rsrc/externals/javelin/lib/Resource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
0 => 'javelin-util',
1 => 'javelin-uri',
2 => 'javelin-install',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/Resource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-stratcom' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/714946e7/rsrc/externals/javelin/core/Stratcom.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-event',
2 => 'javelin-util',
3 => 'javelin-magical-init',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/core/Stratcom.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-tokenizer' =>
array(
Fix two tokenizer issues on iDevices Summary: Fixes T3853. See inline comments for details. Test Plan: Using iOS simulator, mashed the right hand side of tokenizers. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T3853 Differential Revision: https://secure.phabricator.com/D7049
2013-09-20 00:42:02 +02:00
'uri' => '/res/cddb70f3/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-dom',
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-install',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-typeahead' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/fd79f758/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-dom',
2 => 'javelin-vector',
3 => 'javelin-util',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-typeahead-composite-source' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/487b3da2/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-typeahead-source',
2 => 'javelin-util',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-typeahead-normalizer' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/5a4bd979/rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-typeahead-ondemand-source' =>
array(
Use ApplicationPHIDs to power object name typehaead results Summary: Ref T2715. When you type "T12", etc., into the search box, use ApplicationPHIDs to try to find an object name match. Test Plan: Typed "T12", "rP", "Q11", etc. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2715 Differential Revision: https://secure.phabricator.com/D6618
2013-07-29 16:31:59 +02:00
'uri' => '/res/92286a21/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
2 => 'javelin-request',
3 => 'javelin-typeahead-source',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-typeahead-preloaded-source' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/147900c7/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
2 => 'javelin-request',
3 => 'javelin-typeahead-source',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-typeahead-source' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/13289259/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-dom',
3 => 'javelin-typeahead-normalizer',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Don't open symbols on double click Summary: My average double click speed is 10 ms but I tried to double click as I think normal people double clicks and it was around 200 ms. I don't want to make the timeout much longer because it looks like that something doesn't work. Test Plan: Double clicked on symbol. Clicked on symbol. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3509
2012-09-17 23:50:49 +02:00
'javelin-typeahead-static-source' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/bb0a5173/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js',
Don't open symbols on double click Summary: My average double click speed is 10 ms but I tried to double click as I think normal people double clicks and it was around 200 ms. I don't want to make the timeout much longer because it looks like that something doesn't work. Test Plan: Double clicked on symbol. Clicked on symbol. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3509
2012-09-17 23:50:49 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-typeahead-source',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js',
Don't open symbols on double click Summary: My average double click speed is 10 ms but I tried to double click as I think normal people double clicks and it was around 200 ms. I don't want to make the timeout much longer because it looks like that something doesn't work. Test Plan: Double clicked on symbol. Clicked on symbol. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3509
2012-09-17 23:50:49 +02:00
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-uri' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/75aa4597/rsrc/externals/javelin/lib/URI.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-stratcom',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/URI.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-util' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/90222113/rsrc/externals/javelin/core/util.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/core/util.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-vector' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/58ea3dd7/rsrc/externals/javelin/lib/Vector.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-event',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/Vector.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-view' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/38daaec0/rsrc/externals/javelin/ext/view/View.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/ext/view/View.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-view-html' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/0d225e8c/rsrc/externals/javelin/ext/view/HTMLView.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-dom',
2 => 'javelin-view-visitor',
3 => 'javelin-util',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/ext/view/HTMLView.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-view-interpreter' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/b0c07f96/rsrc/externals/javelin/ext/view/ViewInterpreter.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-view',
1 => 'javelin-install',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
2 => 'javelin-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/ext/view/ViewInterpreter.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-view-renderer' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/fe0d2f60/rsrc/externals/javelin/ext/view/ViewRenderer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-util',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/ext/view/ViewRenderer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-view-visitor' =>
array(
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'uri' => '/res/b1606cec/rsrc/externals/javelin/ext/view/ViewVisitor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/ext/view/ViewVisitor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-workflow' =>
array(
Allow Maniphest tasks to be edited from the list view Summary: Fixes T1945. Ref T2947. At various times, installs (Disqus, Dropbox, etc.) have asked for a way to edit tasks more quickly. Provide edit-from-lists. {F44700} {F44701} The one rough edge on this is that if you change the task priority we update it inline but don't move it. It's probably infeasible to actually move it, but maybe we could give it some sort of visual style to indicate that it's dirty. Test Plan: Edited tasks normally and via this action thing. Reviewers: chad, btrahan Reviewed By: chad CC: tido, deuresti, ahoffer, aran Maniphest Tasks: T1945, T2947 Differential Revision: https://secure.phabricator.com/D6086
2013-05-31 03:55:25 +02:00
'uri' => '/res/7626494b/rsrc/externals/javelin/lib/Workflow.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-stratcom',
1 => 'javelin-request',
2 => 'javelin-dom',
3 => 'javelin-vector',
4 => 'javelin-install',
5 => 'javelin-util',
6 => 'javelin-mask',
7 => 'javelin-uri',
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/javelin/lib/Workflow.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Legalpad V0.1 Summary: got some basics here -- - can create document - creates document object and document body object and cross-reference - can update document - creates document body object and updates reference from document object - contributors stored correctly - a contributor is anyone who has created or updated a legal document - can subscribe to documents - can flag documents - can comment on documents - can query for documents based on creator and create range - uses basically modern stuff Missing stuff -- - T3488 - T3483 - T3482 - T3481 - T3480 - T3479 Test Plan: TRUNCATED the database. From scratch made 3 legal docs. Verified versions and version were correct in document and document body database entries respectively. Left comments and verified versions and version did not update. Left updates and verified those updated versions and version. Flagged document and verified it showed up on homepage. Subscribed and verified transaction showed up. Reviewers: epriestley Reviewed By: epriestley CC: chad, aran, Korvin Maniphest Tasks: T3116 Differential Revision: https://secure.phabricator.com/D6351
2013-07-03 20:15:45 +02:00
'legalpad-documentbody-css' =>
array(
'uri' => '/res/034c3494/rsrc/css/application/legalpad/legalpad-documentbody.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/legalpad/legalpad-documentbody.css',
),
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
'lightbox-attachment-css' =>
array(
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'uri' => '/res/4657e15d/rsrc/css/aphront/lightbox-attachment.css',
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/lightbox-attachment.css',
),
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
'maniphest-batch-editor' =>
array(
'uri' => '/res/fb15d744/rsrc/css/application/maniphest/batch-editor.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/batch-editor.css',
),
Iterate on Maniphest reports Summary: - These are still slow, awkward and hideous -- but slightly better than before. - Allow "open" reports to be sorted. - Add a "burn" chart/table for assessing project volatility. - Add navigation. Test Plan: Looked at reports. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T923 Differential Revision: https://secure.phabricator.com/D1737
2012-03-01 23:19:11 +01:00
'maniphest-report-css' =>
array(
'uri' => '/res/2e633fcf/rsrc/css/application/maniphest/report.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/report.css',
),
Add a description preview to maniphest create / edit panel Summary: also fixes a small bug where the page title was always "Create Task". switch it to the header name which is much more descriptive / correct IMO. Test Plan: created a new task and watched the description preview update. edited an old task and saw the description preview populate with the correct existing data. edited an old task and edited the description and saw the description preview update Reviewers: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1489
2012-01-25 20:23:00 +01:00
'maniphest-task-edit-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/f5926f5a/rsrc/css/application/maniphest/task-edit.css',
Add a description preview to maniphest create / edit panel Summary: also fixes a small bug where the page title was always "Create Task". switch it to the header name which is much more descriptive / correct IMO. Test Plan: created a new task and watched the description preview update. edited an old task and saw the description preview populate with the correct existing data. edited an old task and edited the description and saw the description preview update Reviewers: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1489
2012-01-25 20:23:00 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/task-edit.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'maniphest-task-summary-css' =>
array(
Color tweaks for action list, headers Summary: Starting to roll out the standard colors and spacing to action list, headers, and property views. Also softened the grey borders a hex. Test Plan: Review Maniphest and Differential on desktop and mobile. Felt the flow of standardization waft over me. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6869
2013-09-03 16:00:06 +02:00
'uri' => '/res/5de3b188/rsrc/css/application/maniphest/task-summary.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/task-summary.css',
),
'multirow-row-manager' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/408fae4f/rsrc/js/core/MultirowRowManager.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-util',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/MultirowRowManager.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'owners-path-editor' =>
array(
Allow excluding paths from package Summary: Resolves T2149. Test Plan: $ bin/storage upgrade # /owners/ - saw + # /owners/package/1/ - saw + # /owners/edit/1/ - added exclude paths, saw correct e-mail # /rPabc123 - included paths are still highlighted and excluded not # /owners/view/search/?path=/included/ - found # /owners/view/search/?path=/excluded/ - not found # owners.query - path: /included/ # owners.query - path: /excluded/ # new unit test PhabricatorOwnersPackage::loadAffectedPackages( $repository, array('/excluded/b.php')); PhabricatorOwnersPackage::loadAffectedPackages( $repository, array('/included/a.php')); Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2149 Differential Revision: https://secure.phabricator.com/D4102
2012-12-07 02:23:56 +01:00
'uri' => '/res/29b68354/rsrc/js/application/owners/OwnersPathEditor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'multirow-row-manager',
1 => 'javelin-install',
2 => 'path-typeahead',
3 => 'javelin-dom',
4 => 'javelin-util',
Allow excluding paths from package Summary: Resolves T2149. Test Plan: $ bin/storage upgrade # /owners/ - saw + # /owners/package/1/ - saw + # /owners/edit/1/ - added exclude paths, saw correct e-mail # /rPabc123 - included paths are still highlighted and excluded not # /owners/view/search/?path=/included/ - found # /owners/view/search/?path=/excluded/ - not found # owners.query - path: /included/ # owners.query - path: /excluded/ # new unit test PhabricatorOwnersPackage::loadAffectedPackages( $repository, array('/excluded/b.php')); PhabricatorOwnersPackage::loadAffectedPackages( $repository, array('/included/a.php')); Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2149 Differential Revision: https://secure.phabricator.com/D4102
2012-12-07 02:23:56 +01:00
5 => 'phabricator-prefab',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/owners/OwnersPathEditor.js',
),
'owners-path-editor-css' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/c91cc4a8/rsrc/css/application/owners/owners-path-editor.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/owners/owners-path-editor.css',
),
Paste embeds look super cool Summary: Make Paste embeds look super cool Test Plan: {F35387} Reviewers: epriestley CC: aran, Korvin, chad, btrahan, AnhNhan Maniphest Tasks: T1770 Differential Revision: https://secure.phabricator.com/D5323
2013-03-13 14:44:27 +01:00
'paste-css' =>
array(
Add gradient to object-list cards Summary: Adds a gradient, also re-ran sprite generator to attempt to sprite - for some reason all images were un-optimized. Test Plan: Test on UI Examples page Reviewers: epriestley, btrahan Reviewed By: btrahan CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5354
2013-03-16 01:15:57 +01:00
'uri' => '/res/216fbfe9/rsrc/css/application/paste/paste.css',
Paste embeds look super cool Summary: Make Paste embeds look super cool Test Plan: {F35387} Reviewers: epriestley CC: aran, Korvin, chad, btrahan, AnhNhan Maniphest Tasks: T1770 Differential Revision: https://secure.phabricator.com/D5323
2013-03-13 14:44:27 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/paste/paste.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'path-typeahead' =>
array(
'uri' => '/res/50246fb6/rsrc/js/application/herald/PathTypeahead.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-typeahead',
2 => 'javelin-dom',
3 => 'javelin-request',
4 => 'javelin-typeahead-ondemand-source',
5 => 'javelin-util',
),
'disk' => '/rsrc/js/application/herald/PathTypeahead.js',
),
Improve UI for selecting profile pictures Summary: Ref T1703. Move profile pictures to a separate, dedicated interface. Instead of the 35 controls we currently provide, just show all the possible images we can find and then let the user upload an additional one if they want. Possible improvements to this interface: - Write an edge so we can show old profile pictures too. - The cropping/scaling got a bit buggy at some point, fix that. - Refresh OAuth sources which we're capable of refreshing before showing images (more work than I really want to deal with). - We could show little inset icons for the image source ("f" for Facebook, etc.) instead of just the tooltips. Test Plan: Chose images, uploaded new images, hit various error cases. {F49344} Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2919, T1703 Differential Revision: https://secure.phabricator.com/D6398
2013-07-10 01:23:54 +02:00
'people-profile-css' =>
array(
Phabricator event timeline removed Summary: Removed related files and references Test Plan: Crossed my fingers Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2003 Differential Revision: https://secure.phabricator.com/D5744 Conflicts: src/__phutil_library_map__.php src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php
2013-07-10 03:06:01 +02:00
'uri' => '/res/d50d9502/rsrc/css/application/people/people-profile.css',
Improve UI for selecting profile pictures Summary: Ref T1703. Move profile pictures to a separate, dedicated interface. Instead of the 35 controls we currently provide, just show all the possible images we can find and then let the user upload an additional one if they want. Possible improvements to this interface: - Write an edge so we can show old profile pictures too. - The cropping/scaling got a bit buggy at some point, fix that. - Refresh OAuth sources which we're capable of refreshing before showing images (more work than I really want to deal with). - We could show little inset icons for the image source ("f" for Facebook, etc.) instead of just the tooltips. Test Plan: Chose images, uploaded new images, hit various error cases. {F49344} Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2919, T1703 Differential Revision: https://secure.phabricator.com/D6398
2013-07-10 01:23:54 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/people/people-profile.css',
),
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'phabricator-action-header-view-css' =>
array(
ObjectHeader Status icons Summary: Adds status icons and colors to Maniphest and Differential. Also minor tweaks to them in hovercards. Probably some other stuff too. Test Plan: Test many diff and task states. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7098
2013-09-24 17:42:04 +02:00
'uri' => '/res/cd8b4a61/rsrc/css/layout/phabricator-action-header-view.css',
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-action-header-view.css',
),
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'phabricator-action-list-view-css' =>
array(
Fix border on Actions List. Summary: This adds setActionList to PropertyListView and properly places it in an archaic HTML 1.0 table. Test Plan: test layouts with actions really tall or properties really tall. Always see a full height border. Reviewers: epriestley, btrahan CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7239
2013-10-06 20:12:00 +02:00
'uri' => '/res/2dce4556/rsrc/css/layout/phabricator-action-list-view.css',
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-action-list-view.css',
),
Add a meta-application Summary: - Adds a new "Applications" application. - Builds an application list via application config instead of via hard-coding, so we can move toward better concepts of installing/uninstalling applications, etc. - Applications indicate that they need attention with notice counts and brief status messages rathern than 50 giant tables of all sorts of app data. I want to try replacing the home screen with this screen, pretty much. Not sure if this is totally crazy or not. What does everyone else think? Test Plan: Will add screenshots. Reviewers: btrahan, chad, vrana, alanh Reviewed By: vrana CC: aran, davidreuss, champo Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3129
2012-08-02 23:07:21 +02:00
'phabricator-application-launch-view-css' =>
array(
Fix hovers on mobile menus. Summary: Restrict the menu hovers to desktop Test Plan: test desktop and mobile Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6190
2013-06-12 19:30:15 +02:00
'uri' => '/res/21a67228/rsrc/css/application/base/phabricator-application-launch-view.css',
Add a meta-application Summary: - Adds a new "Applications" application. - Builds an application list via application config instead of via hard-coding, so we can move toward better concepts of installing/uninstalling applications, etc. - Applications indicate that they need attention with notice counts and brief status messages rathern than 50 giant tables of all sorts of app data. I want to try replacing the home screen with this screen, pretty much. Not sure if this is totally crazy or not. What does everyone else think? Test Plan: Will add screenshots. Reviewers: btrahan, chad, vrana, alanh Reviewed By: vrana CC: aran, davidreuss, champo Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3129
2012-08-02 23:07:21 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/base/phabricator-application-launch-view.css',
),
Simplify lightboxing and fix a few things Summary: Minor tweaks to lightboxes. - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it. - Make the lightbox go over the menu bar -- was it intentional that it wasn't? - Make 'jx-mask' use "position: fixed;" too. - Add a loading indicator. - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area. I'm going to do a couple of other tweaks here but need to update JX.Mask. Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3795
2012-10-24 02:34:43 +02:00
'phabricator-busy' =>
array(
Fix full width form layouts Summary: Fixes T3473, mostly reverts previous changes to clean up required field text, will have to redesign that in general for responsiveness. Test Plan: use logout form, use new conpherence form Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3473 Differential Revision: https://secure.phabricator.com/D6371
2013-07-04 05:24:28 +02:00
'uri' => '/res/083c11d2/rsrc/js/core/Busy.js',
Simplify lightboxing and fix a few things Summary: Minor tweaks to lightboxes. - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it. - Make the lightbox go over the menu bar -- was it intentional that it wasn't? - Make 'jx-mask' use "position: fixed;" too. - Add a loading indicator. - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area. I'm going to do a couple of other tweaks here but need to update JX.Mask. Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3795
2012-10-24 02:34:43 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-dom',
Fix full width form layouts Summary: Fixes T3473, mostly reverts previous changes to clean up required field text, will have to redesign that in general for responsiveness. Test Plan: use logout form, use new conpherence form Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3473 Differential Revision: https://secure.phabricator.com/D6371
2013-07-04 05:24:28 +02:00
2 => 'javelin-fx',
Simplify lightboxing and fix a few things Summary: Minor tweaks to lightboxes. - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it. - Make the lightbox go over the menu bar -- was it intentional that it wasn't? - Make 'jx-mask' use "position: fixed;" too. - Add a loading indicator. - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area. I'm going to do a couple of other tweaks here but need to update JX.Mask. Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3795
2012-10-24 02:34:43 +02:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/Busy.js',
Simplify lightboxing and fix a few things Summary: Minor tweaks to lightboxes. - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it. - Make the lightbox go over the menu bar -- was it intentional that it wasn't? - Make 'jx-mask' use "position: fixed;" too. - Add a loading indicator. - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area. I'm going to do a couple of other tweaks here but need to update JX.Mask. Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3795
2012-10-24 02:34:43 +02:00
),
Add a basic chatlog Summary: This is pretty simple and unpolished, but it's getting pretty big and it seems like a reasonable starting point. - Log chat in various "channels". - Conduit record and query methods. - IRCBot integration for IRC logging Major TODO: - Web UI is really unpolished and has no search, paging, anchor-linking, etc. Basically all presentation stuff, though. - I think the bot should have a map of channels to log with channel aliases? - The "channels" should probably be in a separate table. - The "authors" should probably be correlated to Phabricator accounts somehow, where possible. Test Plan: Used phabotlocal to log #phabricator. Reviewers: kdeggelman, btrahan, Koolvin Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T837 Differential Revision: https://secure.phabricator.com/D1625
2012-02-17 19:21:38 +01:00
'phabricator-chatlog-css' =>
array(
Improve pagination in ChatLog application Summary: - Add an extra paginator at the top. - Add a link to jump to the bottom (where the latest messages are). - Align paginators with edge of content rather than the page. Test Plan: Looked at the chatlog. Reviewers: epriestley, chad, #blessed_reviewers CC: chad, Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7280
2013-10-10 13:49:04 +02:00
'uri' => '/res/cf9b0aa7/rsrc/css/application/chatlog/chatlog.css',
Add a basic chatlog Summary: This is pretty simple and unpolished, but it's getting pretty big and it seems like a reasonable starting point. - Log chat in various "channels". - Conduit record and query methods. - IRCBot integration for IRC logging Major TODO: - Web UI is really unpolished and has no search, paging, anchor-linking, etc. Basically all presentation stuff, though. - I think the bot should have a map of channels to log with channel aliases? - The "channels" should probably be in a separate table. - The "authors" should probably be correlated to Phabricator accounts somehow, where possible. Test Plan: Used phabotlocal to log #phabricator. Reviewers: kdeggelman, btrahan, Koolvin Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T837 Differential Revision: https://secure.phabricator.com/D1625
2012-02-17 19:21:38 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/chatlog/chatlog.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-content-source-view-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/f15a9527/rsrc/css/application/contentsource/content-source-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/contentsource/content-source-view.css',
),
'phabricator-core-css' =>
array(
Update Form Layouts Summary: This attempts some consistency in form layouts. Notably, they all now contain headers and are 16px off the sides and tops of pages. Also updated dialogs to the same look and feel. I think I got 98% of forms with this pass, but it's likely I missed some buried somewhere. TODO: will take another pass as consolidating these colors and new gradients in another diff. Test Plan: Played in my sandbox all week. Please play with it too and let me know how they feel. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6806
2013-08-26 20:53:11 +02:00
'uri' => '/res/9e767fb1/rsrc/css/core/core.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/core.css',
),
'phabricator-countdown-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/d85bdfd5/rsrc/css/application/countdown/timer.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/countdown/timer.css',
),
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'phabricator-crumbs-view-css' =>
array(
Policy, Status in PHUIHeaderView Summary: The adds the ability to set 'properties' such as state, privacy, due date to the header of objects. Test Plan: Implemented in Paste, Pholio. Tested various states. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7016
2013-09-17 18:12:37 +02:00
'uri' => '/res/4d722e16/rsrc/css/layout/phabricator-crumbs-view.css',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-crumbs-view.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-drag-and-drop-file-upload' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/396d3b3b/rsrc/js/core/DragAndDropFileUpload.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-request',
3 => 'javelin-dom',
4 => 'javelin-uri',
Show upload status, success and failures for drag-and-drop files in notifications Summary: Currently, we do a poor job of communicating drag-and-drop upload errors. Show progress and success/failure in notifications. Test Plan: {F20671} {F20672} Uploaded files to maniphest attachments, remarkup text areas, Files tool. Reviewers: btrahan, vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3655
2012-10-09 00:23:05 +02:00
5 => 'phabricator-file-upload',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/DragAndDropFileUpload.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Mostly generalize Maniphest's drag-and-drop list Summary: I want to use draggable lists in at least three other interfaces: - (Today) Reorganizing named search queries. - (Today) Reorganizing custom fields. - (Future) Dragging tasks around on boards. This mostly generalizes the drag-and-drop code in Maniphest's task list. It isn't a total generalization and will need some more tweaking (for example, Maniphest's list is unusual in that the user can't drag items to the top of the list), but it substantially separates the Maniphest-specific behaviors from the general dragging behaviors. This diff causes no functional changes. Test Plan: Dragged and dropped tasks in Maniphest. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6124
2013-06-05 00:28:31 +02:00
'phabricator-draggable-list' =>
array(
Allow draggable elements to be dragged to the first list position Summary: Currently, draggable lists (in Config and ApplicationSearch, for example) don't let you drag an item into the first position. This is because the behavior is correct in Maniphest: the first position is above an initial header, like "High Prioirty", and shouldn't be targetable. Permit the behavior in general; forbid it in Maniphest. Test Plan: - Dragged elements into the first position in ApplicationSearch. - Failed to drag elements into the first position in Maniphest. Reviewers: garoevans, btrahan Reviewed By: garoevans CC: aran Differential Revision: https://secure.phabricator.com/D7128
2013-09-25 22:27:58 +02:00
'uri' => '/res/75c556db/rsrc/js/core/DraggableList.js',
Mostly generalize Maniphest's drag-and-drop list Summary: I want to use draggable lists in at least three other interfaces: - (Today) Reorganizing named search queries. - (Today) Reorganizing custom fields. - (Future) Dragging tasks around on boards. This mostly generalizes the drag-and-drop code in Maniphest's task list. It isn't a total generalization and will need some more tweaking (for example, Maniphest's list is unusual in that the user can't drag items to the top of the list), but it substantially separates the Maniphest-specific behaviors from the general dragging behaviors. This diff causes no functional changes. Test Plan: Dragged and dropped tasks in Maniphest. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6124
2013-06-05 00:28:31 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
3 => 'javelin-util',
4 => 'javelin-vector',
5 => 'javelin-magical-init',
),
'disk' => '/rsrc/js/core/DraggableList.js',
),
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'phabricator-dropdown-menu' =>
array(
Make the policy control a JS dropdown with icons Summary: Ref T603. After thinking about this for a bit I can't really come up with anything better than what Facebook does, so I'm going to implement something similar for choosing custom policies. To start with, swap this over to a JS-driven dropdown. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: btrahan CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7285
2013-10-13 02:08:11 +02:00
'uri' => '/res/9e33be73/rsrc/js/core/DropdownMenu.js',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-dom',
3 => 'javelin-vector',
4 => 'javelin-stratcom',
5 => 'phabricator-menu-item',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/DropdownMenu.js',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
),
Port extension checks to new-style setup Summary: - Allow new-style setup to raise fatal setup errors. - Port extension checks to new-style setup as fatal errors. - When fatal errors are raised, abort setup and show them in a chrome-free response. Test Plan: {F29981} Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2228 Differential Revision: https://secure.phabricator.com/D4587
2013-01-23 00:16:26 +01:00
'phabricator-fatal-config-template-css' =>
array(
'uri' => '/res/6e1a8d22/rsrc/css/application/config/config-template.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/config/config-template.css',
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'phabricator-feed-css' =>
array(
Set `overflow-x: auto` Summary: Stops funny overflow on long text with no breaking characters Test Plan: View the public feed Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Differential Revision: https://secure.phabricator.com/D5916
2013-05-13 18:14:40 +02:00
'uri' => '/res/e19633ed/rsrc/css/application/feed/feed.css',
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/feed/feed.css',
),
Show upload status, success and failures for drag-and-drop files in notifications Summary: Currently, we do a poor job of communicating drag-and-drop upload errors. Show progress and success/failure in notifications. Test Plan: {F20671} {F20672} Uploaded files to maniphest attachments, remarkup text areas, Files tool. Reviewers: btrahan, vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3655
2012-10-09 00:23:05 +02:00
'phabricator-file-upload' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/c9605008/rsrc/js/core/FileUpload.js',
Show upload status, success and failures for drag-and-drop files in notifications Summary: Currently, we do a poor job of communicating drag-and-drop upload errors. Show progress and success/failure in notifications. Test Plan: {F20671} {F20672} Uploaded files to maniphest attachments, remarkup text areas, Files tool. Reviewers: btrahan, vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3655
2012-10-09 00:23:05 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Minor, fix some missing dependencies for installs with notifications off.
2012-10-09 17:34:06 +02:00
1 => 'javelin-dom',
2 => 'phabricator-notification',
Show upload status, success and failures for drag-and-drop files in notifications Summary: Currently, we do a poor job of communicating drag-and-drop upload errors. Show progress and success/failure in notifications. Test Plan: {F20671} {F20672} Uploaded files to maniphest attachments, remarkup text areas, Files tool. Reviewers: btrahan, vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3655
2012-10-09 00:23:05 +02:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/FileUpload.js',
Show upload status, success and failures for drag-and-drop files in notifications Summary: Currently, we do a poor job of communicating drag-and-drop upload errors. Show progress and success/failure in notifications. Test Plan: {F20671} {F20672} Uploaded files to maniphest attachments, remarkup text areas, Files tool. Reviewers: btrahan, vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3655
2012-10-09 00:23:05 +02:00
),
Minor, map regen.
2012-08-22 00:03:01 +02:00
'phabricator-filetree-view-css' =>
array(
Use white "+" icon for homepage tile hoverstate Summary: The easiest approach here is proably to provide a more specific rule in the sheet CSS. This saves us from having to write any JS, notably. Test Plan: Hovered over "+" on homepage. Reviewers: chad, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4579
2013-01-22 18:56:18 +01:00
'uri' => '/res/c912ed91/rsrc/css/layout/phabricator-filetree-view.css',
Minor, map regen.
2012-08-22 00:03:01 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-filetree-view.css',
),
Add "Flags" to allow users to collect the things they love Summary: Flags are a personal collection of things you want to take a look at later. You can use several different colors and add notes. Not really sure if this is actually a good idea or not but it was easy to build. Planned features: - Allow Herald rules to add flags. - In the "edit flag" dialog, have a "[x] Subscribe Me" checkbox that CCs you. - Support Diffusion. - Support Phriction. - Always show flags on an object if you have them (in every view)? - Edit dialog feels a little heavy? - More filtering in /flag/ tool. - Add a top-level links somewhere? Test Plan: Added, edited and removed flags from things. Viewed flags in flag view. Reviewers: aran, btrahan Reviewed By: btrahan CC: aran, epriestley, Koolvin Maniphest Tasks: T1041 Differential Revision: https://secure.phabricator.com/D2024
2012-03-28 01:22:40 +02:00
'phabricator-flag-css' =>
array(
Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. Summary: Adds plain support for object lists that just look like lists Test Plan: review UIexamples and a number of other applications Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6922
2013-09-09 23:14:34 +02:00
'uri' => '/res/cdb5cb1b/rsrc/css/application/flag/flag.css',
Add "Flags" to allow users to collect the things they love Summary: Flags are a personal collection of things you want to take a look at later. You can use several different colors and add notes. Not really sure if this is actually a good idea or not but it was easy to build. Planned features: - Allow Herald rules to add flags. - In the "edit flag" dialog, have a "[x] Subscribe Me" checkbox that CCs you. - Support Diffusion. - Support Phriction. - Always show flags on an object if you have them (in every view)? - Edit dialog feels a little heavy? - More filtering in /flag/ tool. - Add a top-level links somewhere? Test Plan: Added, edited and removed flags from things. Viewed flags in flag view. Reviewers: aran, btrahan Reviewed By: btrahan CC: aran, epriestley, Koolvin Maniphest Tasks: T1041 Differential Revision: https://secure.phabricator.com/D2024
2012-03-28 01:22:40 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/flag/flag.css',
),
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
'phabricator-hovercard' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/7fb94260/rsrc/js/core/Hovercard.js',
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Load hovercards on-demand Summary: See discussion in D5563. This loads hovercards on-demand, and shows them once they load. Ref T1048. Test Plan: Made a preview comment like `T1`, waved my mouse over it, got a hovercard shortly thereafter. Reviewers: AnhNhan Reviewed By: AnhNhan CC: aran Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5588
2013-04-05 20:01:56 +02:00
1 => 'javelin-dom',
2 => 'javelin-vector',
3 => 'javelin-request',
4 => 'javelin-uri',
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/Hovercard.js',
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
),
First pass at hovercard design Summary: Refs T1048 - I'm pretty happy and happy to tell you Savepoint CR Everything's dummy right now. If you are testing locally, don't forget to edit the PHIDs. Or populate your own handles. Doesn't really matter. I'm mainly sending it in for the CSS, not the messy PHP code. Ignore the `margin: auto`, that's just for looking nice. Test Plan: UI Example » Hovercard Reviewers: epriestley, chad CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5519
2013-04-02 18:15:33 +02:00
'phabricator-hovercard-view-css' =>
array(
Color consolidation Summary: Another pass at consolidating colors Test Plan: Test various pages and UI elements Reviewers: epriestley Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6905
2013-09-07 18:13:55 +02:00
'uri' => '/res/79c61f0e/rsrc/css/layout/phabricator-hovercard-view.css',
First pass at hovercard design Summary: Refs T1048 - I'm pretty happy and happy to tell you Savepoint CR Everything's dummy right now. If you are testing locally, don't forget to edit the PHIDs. Or populate your own handles. Doesn't really matter. I'm mainly sending it in for the CSS, not the messy PHP code. Ignore the `margin: auto`, that's just for looking nice. Test Plan: UI Example » Hovercard Reviewers: epriestley, chad CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5519
2013-04-02 18:15:33 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-hovercard-view.css',
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'phabricator-jump-nav' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/7db8cead/rsrc/css/application/directory/phabricator-jump-nav.css',
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/directory/phabricator-jump-nav.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-keyboard-shortcut' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/44747afd/rsrc/js/core/KeyboardShortcut.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'phabricator-keyboard-shortcut-manager',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/KeyboardShortcut.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'phabricator-keyboard-shortcut-manager' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/bf9bc02a/rsrc/js/core/KeyboardShortcutManager.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-dom',
4 => 'javelin-vector',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/KeyboardShortcutManager.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Switch to new menubar Summary: - Looks better (can probably still use some tweaks), especially search. - Moves logout from weird footer location to main menu. - Reactive: on tablets and phones, the menu adjusts to remain useful. - Fixed position on desktops for future side nav changes. - Adds an icon header thing that's currently hard-coded but will be application-driven soon. Test Plan: Used menu on desktop, tablet, phone, logged in / logged out, toggled darkconsole. Will add some screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3105
2012-07-31 01:09:14 +02:00
'phabricator-main-menu-view' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/ef11f2fc/rsrc/css/application/base/main-menu-view.css',
Switch to new menubar Summary: - Looks better (can probably still use some tweaks), especially search. - Moves logout from weird footer location to main menu. - Reactive: on tablets and phones, the menu adjusts to remain useful. - Fixed position on desktops for future side nav changes. - Adds an icon header thing that's currently hard-coded but will be application-driven soon. Test Plan: Used menu on desktop, tablet, phone, logged in / logged out, toggled darkconsole. Will add some screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3105
2012-07-31 01:09:14 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/base/main-menu-view.css',
),
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'phabricator-menu-item' =>
array(
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'uri' => '/res/345d4168/rsrc/js/core/DropdownMenuItem.js',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-dom',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/DropdownMenuItem.js',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
),
Allow pages to use new "flexible" nav Summary: This allows the nav to be laid out with divs instead of tables and for the navigation column to be made flexible. Design is non-final, this is just a step toward reactive menus that work on tablets/phones and an application menu. I'm going to play around with flexible nav and document navigation and see if that goes anywhere. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3114
2012-08-01 21:31:33 +02:00
'phabricator-nav-view-css' =>
array(
Flatten side nav Summary: Debating removing the textures from the sidenavs, sending this around for comments. Test Plan: Test homepage and various sidenavs, mobile layouts. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5948
2013-05-17 18:58:37 +02:00
'uri' => '/res/37955b6a/rsrc/css/aphront/phabricator-nav-view.css',
Allow pages to use new "flexible" nav Summary: This allows the nav to be laid out with divs instead of tables and for the navigation column to be made flexible. Design is non-final, this is just a step toward reactive menus that work on tablets/phones and an application menu. I'm going to play around with flexible nav and document navigation and see if that goes anywhere. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3114
2012-08-01 21:31:33 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/phabricator-nav-view.css',
),
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'phabricator-notification' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/0764da14/rsrc/js/core/Notification.js',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
Add multiple notifications and notification types Summary: - Allow more than one notification to be shown. - Allow notifications to be customized with extra classes. Test Plan: {F12776} Reviewers: allenjohnashton, ddfisher, keebuhm, jungejason Reviewed By: jungejason CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2758
2012-06-17 20:35:36 +02:00
3 => 'javelin-util',
Minor, fix some missing dependencies for installs with notifications off.
2012-10-09 17:34:06 +02:00
4 => 'phabricator-notification-css',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/Notification.js',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
),
'phabricator-notification-css' =>
array(
More grey text updates Summary: More grey tweaks, breaking these up so I can test and tweak each as needed. Test Plan: Review pages. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6866
2013-09-02 22:57:48 +02:00
'uri' => '/res/2b9cdac0/rsrc/css/aphront/notification.css',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/notification.css',
),
Switch to new menubar Summary: - Looks better (can probably still use some tweaks), especially search. - Moves logout from weird footer location to main menu. - Reactive: on tablets and phones, the menu adjusts to remain useful. - Fixed position on desktops for future side nav changes. - Adds an icon header thing that's currently hard-coded but will be application-driven soon. Test Plan: Used menu on desktop, tablet, phone, logged in / logged out, toggled darkconsole. Will add some screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3105
2012-07-31 01:09:14 +02:00
'phabricator-notification-menu-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/c6b17cfb/rsrc/css/application/base/notification-menu.css',
Switch to new menubar Summary: - Looks better (can probably still use some tweaks), especially search. - Moves logout from weird footer location to main menu. - Reactive: on tablets and phones, the menu adjusts to remain useful. - Fixed position on desktops for future side nav changes. - Adds an icon header thing that's currently hard-coded but will be application-driven soon. Test Plan: Used menu on desktop, tablet, phone, logged in / logged out, toggled darkconsole. Will add some screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3105
2012-07-31 01:09:14 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/base/notification-menu.css',
),
Make project membership edits use transactions and PHIDs and not be awful Summary: - Split project profile editing apart from project membership editing. - Make project membership editing simpler and easier to use. - Drop role / owner stuff from the UI. Test Plan: Added and removed project members. Edited project profile information. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D3184
2012-08-07 20:57:38 +02:00
'phabricator-object-list-view-css' =>
array(
Allow commits to be associated with projects and associated goodies Summary: - Commit detail view - List of projects - "edit" action which takes the user to a simple form where they can only add / remove projects. - Integrated the project relationship into the commit search indexer - fixed a bug from D790; it seems you must select the column if you're going to join against it later. Without this change searching for author or projectfails 100% for me. Test Plan: added and removed projects. verified appropriate projects showed up in detail and edit view. searched for commits by project and found the ones I was supposed to...! Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1614 Differential Revision: https://secure.phabricator.com/D3189
2012-08-08 19:03:41 +02:00
'uri' => '/res/4f183668/rsrc/css/application/projects/phabricator-object-list-view.css',
Make project membership edits use transactions and PHIDs and not be awful Summary: - Split project profile editing apart from project membership editing. - Make project membership editing simpler and easier to use. - Drop role / owner stuff from the UI. Test Plan: Added and removed project members. Edited project profile information. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D3184
2012-08-07 20:57:38 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/projects/phabricator-object-list-view.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-object-selector-css' =>
array(
More grey text updates Summary: More grey tweaks, breaking these up so I can test and tweak each as needed. Test Plan: Review pages. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6866
2013-09-02 22:57:48 +02:00
'uri' => '/res/20c94e28/rsrc/css/application/objectselector/object-selector.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
0 => 'aphront-dialog-view-css',
),
'disk' => '/rsrc/css/application/objectselector/object-selector.css',
),
Rebuild the Celerity map, which ended up in a bad state after after the application/core stuff.
2013-04-23 20:32:24 +02:00
'phabricator-phtize' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/dc655a81/rsrc/js/core/phtize.js',
Rebuild the Celerity map, which ended up in a bad state after after the application/core stuff.
2013-04-23 20:32:24 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-util',
),
'disk' => '/rsrc/js/core/phtize.js',
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'phabricator-prefab' =>
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/511859ca/rsrc/js/core/Prefab.js',
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
2 => 'javelin-dom',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
3 => 'javelin-typeahead',
4 => 'javelin-tokenizer',
5 => 'javelin-typeahead-preloaded-source',
6 => 'javelin-typeahead-ondemand-source',
7 => 'javelin-dom',
8 => 'javelin-stratcom',
9 => 'javelin-util',
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/Prefab.js',
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-profile-css' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/c1f72695/rsrc/css/application/profile/profile-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/profile/profile-view.css',
),
Show projects on Maniphest tasks Summary: - Remove the "Priority" column, since this is indicated by the color swatch, to save space. - Reduce the "Updated" column from datetime to date only, since time isn't incredibly useful, to save space. - Show the first two projects a task is associated with, and "..." if there are more. - Show "None" (for "no owner") in a lighter color. Test Plan: Looked at tasks on homepage and in Maniphest. Reviewers: btrahan, 20after4 Reviewed By: btrahan CC: aran, edward Maniphest Tasks: T967 Differential Revision: https://secure.phabricator.com/D2065
2012-04-02 19:27:31 +02:00
'phabricator-project-tag-css' =>
array(
Fix some Maniphest links Summary: A few things link to old URIs for Maniphest, update them. Test Plan: Clicked all the things. Reviewers: chad, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6989
2013-09-14 01:56:21 +02:00
'uri' => '/res/535b8b7a/rsrc/css/application/projects/project-tag.css',
Show projects on Maniphest tasks Summary: - Remove the "Priority" column, since this is indicated by the color swatch, to save space. - Reduce the "Updated" column from datetime to date only, since time isn't incredibly useful, to save space. - Show the first two projects a task is associated with, and "..." if there are more. - Show "None" (for "no owner") in a lighter color. Test Plan: Looked at tasks on homepage and in Maniphest. Reviewers: btrahan, 20after4 Reviewed By: btrahan CC: aran, edward Maniphest Tasks: T967 Differential Revision: https://secure.phabricator.com/D2065
2012-04-02 19:27:31 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/projects/project-tag.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-remarkup-css' =>
array(
Make <audio /> work slightly better on devices Summary: Ref T3887. `300px` is a little too wide on devices. Test Plan: Viewed on a phone. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T3887 Differential Revision: https://secure.phabricator.com/D7157
2013-09-27 20:06:00 +02:00
'uri' => '/res/7e8988dd/rsrc/css/core/remarkup.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/remarkup.css',
),
'phabricator-search-results-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/5407f3ea/rsrc/css/application/search/search-results.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/search/search-results.css',
),
Placed Radio buttons for Home Page Preferences Settings Summary: Replaced AphrontFormSelectControl in PhabricatorSettingsPanelHomePreferences with AphrontFormRadioButtonControl :). Test Plan: By checking out Home page prefreces setting and playing around the values to see if it works ! Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin, chad, demo, AnhNhan Maniphest Tasks: T2340 Differential Revision: https://secure.phabricator.com/D5414
2013-04-09 18:43:41 +02:00
'phabricator-settings-css' =>
array(
'uri' => '/res/fb9d017f/rsrc/css/application/settings/settings.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/settings/settings.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-shaped-request' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/d173af85/rsrc/js/core/ShapedRequest.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-request',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/ShapedRequest.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Refactor the main menu in preparation for a mobile application menu Summary: As per discussion, this primes the existing mobile menu / menu button for "phabricator" and "application" menus. Design here is very rough, I'm just trying to get everything laid in functionally first. It's based on `frame_v3.png` but missing a lot of touches. Test Plan: {F26143} {F26144} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T1960 Differential Revision: https://secure.phabricator.com/D4058
2012-12-07 22:33:03 +01:00
'phabricator-side-menu-view-css' =>
array(
Update Form Layouts Summary: This attempts some consistency in form layouts. Notably, they all now contain headers and are 16px off the sides and tops of pages. Also updated dialogs to the same look and feel. I think I got 98% of forms with this pass, but it's likely I missed some buried somewhere. TODO: will take another pass as consolidating these colors and new gradients in another diff. Test Plan: Played in my sandbox all week. Please play with it too and let me know how they feel. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6806
2013-08-26 20:53:11 +02:00
'uri' => '/res/e83fbe58/rsrc/css/layout/phabricator-side-menu-view.css',
Refactor the main menu in preparation for a mobile application menu Summary: As per discussion, this primes the existing mobile menu / menu button for "phabricator" and "application" menus. Design here is very rough, I'm just trying to get everything laid in functionally first. It's based on `frame_v3.png` but missing a lot of touches. Test Plan: {F26143} {F26144} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T1960 Differential Revision: https://secure.phabricator.com/D4058
2012-12-07 22:33:03 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-side-menu-view.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-slowvote-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/e61a54eb/rsrc/css/application/slowvote/slowvote.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/slowvote/slowvote.css',
),
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'phabricator-source-code-view-css' =>
array(
Restore white background to Paste Summary: I think we lost this recently (maybe with the line highlighting change), but it's more readable if we put these on a white background. Test Plan: Looked at a Paste (like `/P123`), saw white background. Reviewers: chad, btrahan, asherkin Reviewed By: asherkin CC: aran Differential Revision: https://secure.phabricator.com/D6852
2013-08-30 18:29:31 +02:00
'uri' => '/res/aee63670/rsrc/css/layout/phabricator-source-code-view.css',
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-source-code-view.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-standard-page-view' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/59c804b1/rsrc/css/application/base/standard-page-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/base/standard-page-view.css',
),
Build PhabricatorTagView Summary: Builds out most of the non-hover-stuff from `overview-hovercards.png`. Things I didn't build: - Tokens (I like them a lot but don't want to scope creep) - Functions (backend mess / future work) - Icons for tags. - Tags with pointy ends and holes in them (an earlier mock had this I think but they're gone on final) - The cyaney color for "Sporadic" since I just noticed it while typing this up. Test Plan: Looked at UIExample page. Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2089 Differential Revision: https://secure.phabricator.com/D4029
2012-11-24 15:47:06 +01:00
'phabricator-tag-view-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/65ad2dc3/rsrc/css/layout/phabricator-tag-view.css',
Build PhabricatorTagView Summary: Builds out most of the non-hover-stuff from `overview-hovercards.png`. Things I didn't build: - Tokens (I like them a lot but don't want to scope creep) - Functions (backend mess / future work) - Icons for tags. - Tags with pointy ends and holes in them (an earlier mock had this I think but they're gone on final) - The cyaney color for "Sporadic" since I just noticed it while typing this up. Test Plan: Looked at UIExample page. Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2089 Differential Revision: https://secure.phabricator.com/D4029
2012-11-24 15:47:06 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-tag-view.css',
),
Minor, fix bad Celerity Map merge.
2012-10-02 03:48:39 +02:00
'phabricator-textareautils' =>
array(
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'uri' => '/res/03c03e8b/rsrc/js/core/TextAreaUtils.js',
Minor, fix bad Celerity Map merge.
2012-10-02 03:48:39 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/TextAreaUtils.js',
Minor, fix bad Celerity Map merge.
2012-10-02 03:48:39 +02:00
),
Improve Lightbox behavior for nonstandard clicks Summary: When users middle click or command-click an image, we should open it in a new tab, not open a lightbox. See https://github.com/facebook/phabricator/issues/234 Test Plan: Left, middle, and command-clicked a lightbox image. Reviewers: vrana, chad, btrahan Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D4020
2012-11-22 17:25:13 +01:00
'phabricator-timeline-view-css' =>
array(
Tweak mobile timeline Summary: Improves timeline legebility by pulling date inline with title in timeline mobile. Test Plan: shrink screen for a task, see new layout Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7236
2013-10-05 20:18:07 +02:00
'uri' => '/res/d139291d/rsrc/css/layout/phabricator-timeline-view.css',
Improve Lightbox behavior for nonstandard clicks Summary: When users middle click or command-click an image, we should open it in a new tab, not open a lightbox. See https://github.com/facebook/phabricator/issues/234 Test Plan: Left, middle, and command-clicked a lightbox image. Reviewers: vrana, chad, btrahan Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D4020
2012-11-22 17:25:13 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-timeline-view.css',
),
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'phabricator-tooltip' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/a23bc887/rsrc/js/core/ToolTip.js',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-dom',
3 => 'javelin-vector',
),
Move js/application/core/ one level up Test Plan: Pressed `?` on homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5761
2013-04-23 19:56:46 +02:00
'disk' => '/rsrc/js/core/ToolTip.js',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'phabricator-transaction-view-css' =>
array(
Fix transaction bg color Summary: Should just be white here. Test Plan: review a task and diff. Reviewers: epriestley Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7047
2013-09-19 23:23:44 +02:00
'uri' => '/res/e797779e/rsrc/css/aphront/transaction.css',
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/transaction.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-ui-example-css' =>
array(
Add a "toggle-class" behavior Summary: The new menu stuff needs this but it was easy to pull out on its own. Test Plan: Cliked UI example buttons. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3104
2012-07-31 01:08:42 +02:00
'uri' => '/res/376ab671/rsrc/css/application/uiexample/example.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/uiexample/example.css',
),
'phabricator-uiexample-javelin-view' =>
array(
Fix more JavelinView example stuff Summary: Fixes T3544. Depends on D6475. This was just a missing dependency combined with some questionable error handling which I'll maybe fix some day. Test Plan: Loaded page, saw result. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3544 Differential Revision: https://secure.phabricator.com/D6476
2013-07-16 22:35:25 +02:00
'uri' => '/res/d42834b6/rsrc/js/application/uiexample/JavelinViewExample.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-dom',
Fix more JavelinView example stuff Summary: Fixes T3544. Depends on D6475. This was just a missing dependency combined with some questionable error handling which I'll maybe fix some day. Test Plan: Loaded page, saw result. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3544 Differential Revision: https://secure.phabricator.com/D6476
2013-07-16 22:35:25 +02:00
2 => 'javelin-view',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/uiexample/JavelinViewExample.js',
),
'phabricator-uiexample-reactor-button' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/6bfe4f05/rsrc/js/application/uiexample/ReactorButtonExample.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
2 => 'javelin-util',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
3 => 'javelin-dynval',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorButtonExample.js',
),
'phabricator-uiexample-reactor-checkbox' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/3e8b30ac/rsrc/js/application/uiexample/ReactorCheckboxExample.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-dom',
2 => 'javelin-reactor-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/uiexample/ReactorCheckboxExample.js',
),
'phabricator-uiexample-reactor-focus' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/d8f3b56e/rsrc/js/application/uiexample/ReactorFocusExample.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-dom',
2 => 'javelin-reactor-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/uiexample/ReactorFocusExample.js',
),
'phabricator-uiexample-reactor-input' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/936352d9/rsrc/js/application/uiexample/ReactorInputExample.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-reactor-dom',
2 => 'javelin-view-html',
3 => 'javelin-view-interpreter',
4 => 'javelin-view-renderer',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/uiexample/ReactorInputExample.js',
),
'phabricator-uiexample-reactor-mouseover' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/031a9f4f/rsrc/js/application/uiexample/ReactorMouseoverExample.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-dom',
2 => 'javelin-reactor-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/uiexample/ReactorMouseoverExample.js',
),
'phabricator-uiexample-reactor-radio' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/208c58e3/rsrc/js/application/uiexample/ReactorRadioExample.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-dom',
2 => 'javelin-reactor-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/uiexample/ReactorRadioExample.js',
),
'phabricator-uiexample-reactor-select' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/1b68a6db/rsrc/js/application/uiexample/ReactorSelectExample.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-dom',
2 => 'javelin-reactor-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/uiexample/ReactorSelectExample.js',
),
'phabricator-uiexample-reactor-sendclass' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/00cb3131/rsrc/js/application/uiexample/ReactorSendClassExample.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-dom',
2 => 'javelin-reactor-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/uiexample/ReactorSendClassExample.js',
),
'phabricator-uiexample-reactor-sendproperties' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/392f1e02/rsrc/js/application/uiexample/ReactorSendPropertiesExample.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
1 => 'javelin-dom',
2 => 'javelin-reactor-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/uiexample/ReactorSendPropertiesExample.js',
),
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'phabricator-zindex-css' =>
array(
Implement "Add to CC" rule for Audits Summary: D6660 accidentally allowed you to build Herald rules for commits that take action "Add to CC", but provided no implementation. Someone at Facebook then wrote such a rule. Fix forward since there's no real reason not to allow this. Test Plan: Used `./scripts/repository/reparse.php --herald rXnnnn` to trigger rules. Observed rule trigger and subsequent subscription. Reviewers: wez, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D6845
2013-08-30 02:03:40 +02:00
'uri' => '/res/b443d508/rsrc/css/core/z-index.css',
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/z-index.css',
),
Add concept of "skins" to phame, and add a phacility skin Summary: introduce an abstract "PhameBlogSkin" class and instantiate two versions -- PhabricatorBlogSkin (Default) and PhacilityBlogSkin. Most notable hack is including the directory /rsrc/images/phacility - this lets things "work" without messing around with the phacility.com CSS and instead just cutting and pasting most of the file. Test Plan: played around with Phame a bunch. In particular, created a blog with a custom domain and the phacility skin. Verified it looked good and individual posts looked okay. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1373 Differential Revision: https://secure.phabricator.com/D3687
2012-10-13 01:01:33 +02:00
'phame-css' =>
Modernize phame and add concept of "blog style" to blog post list view Summary: "blog style" for now is just "true" to make this UI render better for the blog LATER it will be a string which will choose the larger template. this will also have to do some messing around with links; when viewing on a phabricator instance links need to be a bit dirtier to carry around the blog whereas when viewing offsite we can tell what blog it is based on the host domain. anyhoo, this is future diff work Test Plan: looked at blog - less ugly. resized blog to smaller sizes - became a "single list" of goodness for quality reading quite quickly. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1373 Differential Revision: https://secure.phabricator.com/D3587
2012-10-02 00:37:02 +02:00
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/405e77b8/rsrc/css/application/phame/phame.css',
Modernize phame and add concept of "blog style" to blog post list view Summary: "blog style" for now is just "true" to make this UI render better for the blog LATER it will be a string which will choose the larger template. this will also have to do some messing around with links; when viewing on a phabricator instance links need to be a bit dirtier to carry around the blog whereas when viewing offsite we can tell what blog it is based on the host domain. anyhoo, this is future diff work Test Plan: looked at blog - less ugly. resized blog to smaller sizes - became a "single list" of goodness for quality reading quite quickly. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1373 Differential Revision: https://secure.phabricator.com/D3587
2012-10-02 00:37:02 +02:00
'type' => 'css',
'requires' =>
array(
),
Add concept of "skins" to phame, and add a phacility skin Summary: introduce an abstract "PhameBlogSkin" class and instantiate two versions -- PhabricatorBlogSkin (Default) and PhacilityBlogSkin. Most notable hack is including the directory /rsrc/images/phacility - this lets things "work" without messing around with the phacility.com CSS and instead just cutting and pasting most of the file. Test Plan: played around with Phame a bunch. In particular, created a blog with a custom domain and the phacility skin. Verified it looked good and individual posts looked okay. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1373 Differential Revision: https://secure.phabricator.com/D3687
2012-10-13 01:01:33 +02:00
'disk' => '/rsrc/css/application/phame/phame.css',
Modernize phame and add concept of "blog style" to blog post list view Summary: "blog style" for now is just "true" to make this UI render better for the blog LATER it will be a string which will choose the larger template. this will also have to do some messing around with links; when viewing on a phabricator instance links need to be a bit dirtier to carry around the blog whereas when viewing offsite we can tell what blog it is based on the host domain. anyhoo, this is future diff work Test Plan: looked at blog - less ugly. resized blog to smaller sizes - became a "single list" of goodness for quality reading quite quickly. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1373 Differential Revision: https://secure.phabricator.com/D3587
2012-10-02 00:37:02 +02:00
),
Pholio tile to home page and mock to show first image Summary: Pholio tile to show up on home page First image is shown at mock page. Test Plan: Pholio app shows up on home page. First image is shown at mock page. Reviewers: epriestley CC: aran, Korvin Maniphest Tasks: T2356 Differential Revision: https://secure.phabricator.com/D4553
2013-01-20 18:29:34 +01:00
'pholio-css' =>
array(
Add objectheaders to new View Summary: This adds the 'PHUIObjectBox' to nearly every place that should get it. I need to comb through Diffusion a little more. I've left Differential mostly alone, but may decide to do it anyways this weekend. I'm sure I missed something else, but these are easy enough to update. Test Plan: tested each new layout. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7162
2013-09-29 00:55:38 +02:00
'uri' => '/res/e64264c9/rsrc/css/application/pholio/pholio.css',
Pholio tile to home page and mock to show first image Summary: Pholio tile to show up on home page First image is shown at mock page. Test Plan: Pholio app shows up on home page. First image is shown at mock page. Reviewers: epriestley CC: aran, Korvin Maniphest Tasks: T2356 Differential Revision: https://secure.phabricator.com/D4553
2013-01-20 18:29:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/pholio/pholio.css',
),
Pholio - support editing images - fixes T3489 Summary: Nice title. We add three new transactions - IMAGE_FILE, IMAGE_NAME, and IMAGE_DESCRIPTION. The first is a bit like subscribers as it is a list of file phids. The latter have values of the form ($file_phid => $data), where $data is $name or $description respectively. This is because we need to collate transactions based on $file_phid... Overall, this uses the _underyling files_ and not the "PholioImage" to determine if things are unique or not. That said, simply mark PholioImages as obsolete so inline comments about no-longer applicable PholioImages don't break. Does a reasonable job implementing the mock. Note you can't "update" an image at this time, though you can delete and add at will. Test Plan: played with pholio a ton. Reviewers: epriestley Reviewed By: epriestley CC: chad, aran, Korvin Maniphest Tasks: T3489 Differential Revision: https://secure.phabricator.com/D6441
2013-07-16 22:31:20 +02:00
'pholio-edit-css' =>
array(
More grey text updates Summary: More grey tweaks, breaking these up so I can test and tweak each as needed. Test Plan: Review pages. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6866
2013-09-02 22:57:48 +02:00
'uri' => '/res/04013652/rsrc/css/application/pholio/pholio-edit.css',
Pholio - support editing images - fixes T3489 Summary: Nice title. We add three new transactions - IMAGE_FILE, IMAGE_NAME, and IMAGE_DESCRIPTION. The first is a bit like subscribers as it is a list of file phids. The latter have values of the form ($file_phid => $data), where $data is $name or $description respectively. This is because we need to collate transactions based on $file_phid... Overall, this uses the _underyling files_ and not the "PholioImage" to determine if things are unique or not. That said, simply mark PholioImages as obsolete so inline comments about no-longer applicable PholioImages don't break. Does a reasonable job implementing the mock. Note you can't "update" an image at this time, though you can delete and add at will. Test Plan: played with pholio a ton. Reviewers: epriestley Reviewed By: epriestley CC: chad, aran, Korvin Maniphest Tasks: T3489 Differential Revision: https://secure.phabricator.com/D6441
2013-07-16 22:31:20 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/pholio/pholio-edit.css',
),
Show editor Summary: Show editor when user clicks edit button for inline comment. Test Plan: Verified that editor is shown. Reviewers: epriestley CC: aran, Korvin Maniphest Tasks: T2446 Differential Revision: https://secure.phabricator.com/D5030
2013-02-22 15:39:08 +01:00
'pholio-inline-comments-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/67e2f18c/rsrc/css/application/pholio/pholio-inline-comments.css',
Show editor Summary: Show editor when user clicks edit button for inline comment. Test Plan: Verified that editor is shown. Reviewers: epriestley CC: aran, Korvin Maniphest Tasks: T2446 Differential Revision: https://secure.phabricator.com/D5030
2013-02-22 15:39:08 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/pholio/pholio-inline-comments.css',
),
Updated the CLI for smoother use Summary: Ref T2903 Test Plan: Tested all CLI possibilities Reviewers: epriestley, AnhNhan Reviewed By: epriestley CC: AnhNhan, aran, Korvin, jqh9804 Maniphest Tasks: T2903 Differential Revision: https://secure.phabricator.com/D5711
2013-04-29 21:14:50 +02:00
'phortune-credit-card-form' =>
array(
'uri' => '/res/bc948778/rsrc/js/application/phortune/phortune-credit-card-form.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-dom',
2 => 'javelin-json',
3 => 'javelin-workflow',
4 => 'javelin-util',
),
'disk' => '/rsrc/js/application/phortune/phortune-credit-card-form.js',
),
'phortune-credit-card-form-css' =>
array(
'uri' => '/res/563c8c6d/rsrc/css/application/phortune/phortune-credit-card-form.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/phortune/phortune-credit-card-form.css',
),
Minor, fix celerity map.
2013-04-01 05:07:47 +02:00
'phrequent-css' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/e2f09149/rsrc/css/application/phrequent/phrequent.css',
Minor, fix celerity map.
2013-04-01 05:07:47 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/phrequent/phrequent.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phriction-document-css' =>
array(
Color consolidation Summary: Another pass at consolidating colors Test Plan: Test various pages and UI elements Reviewers: epriestley Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6905
2013-09-07 18:13:55 +02:00
'uri' => '/res/7ae003b1/rsrc/css/application/phriction/phriction-document-css.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/phriction/phriction-document-css.css',
),
PHUIBoxView Summary: Adds a basic div box that takes some styles. Not sure this is the best approach for the spacing, but overall hoping people can spend less time in CSS and just use this class. Test Plan: UIExamples Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5723
2013-04-18 20:34:02 +02:00
'phui-box-css' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/cd1b04cf/rsrc/css/phui/phui-box.css',
PHUIBoxView Summary: Adds a basic div box that takes some styles. Not sure this is the best approach for the spacing, but overall hoping people can spend less time in CSS and just use this class. Test Plan: UIExamples Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5723
2013-04-18 20:34:02 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-box.css',
),
PHUIButtonView class Summary: Rough pass at a PHUIButtonView Class. Keeps phutil_tag intact and adds some image features if you use the class. Test Plan: UIExamples Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6192
2013-06-13 03:23:35 +02:00
'phui-button-css' =>
array(
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'uri' => '/res/3be4ec80/rsrc/css/phui/phui-button.css',
PHUIButtonView class Summary: Rough pass at a PHUIButtonView Class. Keeps phutil_tag intact and adds some image features if you use the class. Test Plan: UIExamples Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6192
2013-06-13 03:23:35 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-button.css',
),
Separate Phriction style into PHUIDocumentView Summary: Ref T988. Fixes T3150. I want to use this element in Diviner, so separate it from Phriction. This makes no changes to the actual display except for fixing {T3150} by adding `overflow: hidden;`. Test Plan: Viewed Phriction documents in mobile and desktop views. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T988, T3150 Differential Revision: https://secure.phabricator.com/D6101
2013-06-01 00:03:59 +02:00
'phui-document-view-css' =>
array(
PHUIPropertyListView Summary: This builds out and implements PHUIPropertyListView (container) and PHUIPropertyListItemView (section) as well as adding tabs. Test Plan: Tested each page I edited with the exception of Releeph and Phortune, though those changes look ok to me diff wise. Updated examples page with tabs. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7283
2013-10-11 16:53:56 +02:00
'uri' => '/res/f744b3b2/rsrc/css/phui/phui-document.css',
Separate Phriction style into PHUIDocumentView Summary: Ref T988. Fixes T3150. I want to use this element in Diviner, so separate it from Phriction. This makes no changes to the actual display except for fixing {T3150} by adding `overflow: hidden;`. Test Plan: Viewed Phriction documents in mobile and desktop views. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T988, T3150 Differential Revision: https://secure.phabricator.com/D6101
2013-06-01 00:03:59 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-document.css',
),
PHUIFeedStoryView, Update Profile Summary: This moves Feed's rendering over to a PHUI class. I want to build it out and have it power Ponder, Phame, Feed, as well as Profiles and Projects in some fashion. It also provides some more data depth over ObjectItemView. Also updated Profile for mobile and fixed some other display issues there. Test Plan: Tested Feed, Profile. Used iOS and Chrome. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5687
2013-04-15 04:32:26 +02:00
'phui-feed-story-css' =>
array(
Color consolidation Summary: Another pass at consolidating colors Test Plan: Test various pages and UI elements Reviewers: epriestley Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6905
2013-09-07 18:13:55 +02:00
'uri' => '/res/8f28c686/rsrc/css/phui/phui-feed-story.css',
PHUIFeedStoryView, Update Profile Summary: This moves Feed's rendering over to a PHUI class. I want to build it out and have it power Ponder, Phame, Feed, as well as Profiles and Projects in some fashion. It also provides some more data depth over ObjectItemView. Also updated Profile for mobile and fixed some other display issues there. Test Plan: Tested Feed, Profile. Used iOS and Chrome. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5687
2013-04-15 04:32:26 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-feed-story.css',
),
Update form styles, implement in many places Summary: This creates a common form look and feel across the site. I spent a bit of time working out a number of kinks in our various renderings. Some things: - Font Styles are correctly applied for form elements now. - Everything lines up! - Selects are larger, easier to read, interact. - Inputs have been squared. - Consistant CSS applied glow (try it!) - Improved Mobile Responsiveness - CSS applied to all form elements, not just Aphront - Many other minor tweaks. I tried to hit as many high profile forms as possible in an effort to increase consistency. Stopped for now and will follow up after this lands. I know Evan is not a super fan of the glow, but after working with it for a week, it's way cleaner and responsive than the OS controls. Give it a try. Test Plan: Tested many applications, forms, mobile and tablet. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5860
2013-05-07 23:07:06 +02:00
'phui-form-css' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/29b48d06/rsrc/css/phui/phui-form.css',
Update form styles, implement in many places Summary: This creates a common form look and feel across the site. I spent a bit of time working out a number of kinks in our various renderings. Some things: - Font Styles are correctly applied for form elements now. - Everything lines up! - Selects are larger, easier to read, interact. - Inputs have been squared. - Consistant CSS applied glow (try it!) - Improved Mobile Responsiveness - CSS applied to all form elements, not just Aphront - Many other minor tweaks. I tried to hit as many high profile forms as possible in an effort to increase consistency. Stopped for now and will follow up after this lands. I know Evan is not a super fan of the glow, but after working with it for a week, it's way cleaner and responsive than the OS controls. Give it a try. Test Plan: Tested many applications, forms, mobile and tablet. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5860
2013-05-07 23:07:06 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-form.css',
),
Update Form Layouts Summary: This attempts some consistency in form layouts. Notably, they all now contain headers and are 16px off the sides and tops of pages. Also updated dialogs to the same look and feel. I think I got 98% of forms with this pass, but it's likely I missed some buried somewhere. TODO: will take another pass as consolidating these colors and new gradients in another diff. Test Plan: Played in my sandbox all week. Please play with it too and let me know how they feel. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6806
2013-08-26 20:53:11 +02:00
'phui-form-view-css' =>
array(
Add objectheaders to new View Summary: This adds the 'PHUIObjectBox' to nearly every place that should get it. I need to comb through Diffusion a little more. I've left Differential mostly alone, but may decide to do it anyways this weekend. I'm sure I missed something else, but these are easy enough to update. Test Plan: tested each new layout. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7162
2013-09-29 00:55:38 +02:00
'uri' => '/res/157ddd8b/rsrc/css/phui/phui-form-view.css',
Update Form Layouts Summary: This attempts some consistency in form layouts. Notably, they all now contain headers and are 16px off the sides and tops of pages. Also updated dialogs to the same look and feel. I think I got 98% of forms with this pass, but it's likely I missed some buried somewhere. TODO: will take another pass as consolidating these colors and new gradients in another diff. Test Plan: Played in my sandbox all week. Please play with it too and let me know how they feel. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6806
2013-08-26 20:53:11 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-form-view.css',
),
Policy, Status in PHUIHeaderView Summary: The adds the ability to set 'properties' such as state, privacy, due date to the header of objects. Test Plan: Implemented in Paste, Pholio. Tested various states. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7016
2013-09-17 18:12:37 +02:00
'phui-header-view-css' =>
array(
PHUIPropertyListView Summary: This builds out and implements PHUIPropertyListView (container) and PHUIPropertyListItemView (section) as well as adding tabs. Test Plan: Tested each page I edited with the exception of Releeph and Phortune, though those changes look ok to me diff wise. Updated examples page with tabs. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7283
2013-10-11 16:53:56 +02:00
'uri' => '/res/d4cec460/rsrc/css/phui/phui-header-view.css',
Policy, Status in PHUIHeaderView Summary: The adds the ability to set 'properties' such as state, privacy, due date to the header of objects. Test Plan: Implemented in Paste, Pholio. Tested various states. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7016
2013-09-17 18:12:37 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-header-view.css',
),
PHUIIconView Summary: Adds a base class for displaying images and icons. Test Plan: Tested giving and taking tokens, viewed action headers, uiexamples for icons, workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5736
2013-04-20 02:44:20 +02:00
'phui-icon-view-css' =>
array(
Policy, Status in PHUIHeaderView Summary: The adds the ability to set 'properties' such as state, privacy, due date to the header of objects. Test Plan: Implemented in Paste, Pholio. Tested various states. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7016
2013-09-17 18:12:37 +02:00
'uri' => '/res/28fb5ae5/rsrc/css/phui/phui-icon.css',
PHUIIconView Summary: Adds a base class for displaying images and icons. Test Plan: Tested giving and taking tokens, viewed action headers, uiexamples for icons, workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5736
2013-04-20 02:44:20 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-icon.css',
),
PHUIList, PHUIDocument updates Summary: This diff covers a bit of ground. - PHUIDocumentExample has been added - PHUIDocument has been extended with new features - PhabricatorMenuView is now PHUIListView - PhabricatorMenuItemView is now PHUIItemListView Overall - I think I've gotten all the edges covered here. There is some derpi-ness that we can talk about, comments in the code. Responsive design is missing from the new features on PHUIDocument, will follow up later. Test Plan: Tested mobile and desktop menus, old phriction layout, new document views, new lists, and object lists. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6130
2013-06-05 17:41:43 +02:00
'phui-list-view-css' =>
array(
Adds status colors to navbar tabs Summary: Adds the abilit to set a status color of warning or fail to navbar tab lists (for objectheaders) Test Plan: uiexamples, photoshop Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7266
2013-10-08 04:29:05 +02:00
'uri' => '/res/c748be1f/rsrc/css/phui/phui-list.css',
PHUIList, PHUIDocument updates Summary: This diff covers a bit of ground. - PHUIDocumentExample has been added - PHUIDocument has been extended with new features - PhabricatorMenuView is now PHUIListView - PhabricatorMenuItemView is now PHUIItemListView Overall - I think I've gotten all the edges covered here. There is some derpi-ness that we can talk about, comments in the code. Responsive design is missing from the new features on PHUIDocument, will follow up later. Test Plan: Tested mobile and desktop menus, old phriction layout, new document views, new lists, and object lists. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6130
2013-06-05 17:41:43 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-list.css',
),
Add objectheaders to new View Summary: This adds the 'PHUIObjectBox' to nearly every place that should get it. I need to comb through Diffusion a little more. I've left Differential mostly alone, but may decide to do it anyways this weekend. I'm sure I missed something else, but these are easy enough to update. Test Plan: tested each new layout. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7162
2013-09-29 00:55:38 +02:00
'phui-object-box-css' =>
array(
Fix border on Actions List. Summary: This adds setActionList to PropertyListView and properly places it in an archaic HTML 1.0 table. Test Plan: test layouts with actions really tall or properties really tall. Always see a full height border. Reviewers: epriestley, btrahan CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7239
2013-10-06 20:12:00 +02:00
'uri' => '/res/8504279f/rsrc/css/phui/phui-object-box.css',
Add objectheaders to new View Summary: This adds the 'PHUIObjectBox' to nearly every place that should get it. I need to comb through Diffusion a little more. I've left Differential mostly alone, but may decide to do it anyways this weekend. I'm sure I missed something else, but these are easy enough to update. Test Plan: tested each new layout. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7162
2013-09-29 00:55:38 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-object-box.css',
),
Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. Summary: Adds plain support for object lists that just look like lists Test Plan: review UIexamples and a number of other applications Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6922
2013-09-09 23:14:34 +02:00
'phui-object-item-list-view-css' =>
array(
Maniphest mobile CSS tweaks Summary: Fixes a few minor quirks when viewing maniphest on mobile. Test Plan: shrink maniphest screen, easier to read. Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7270
2013-10-08 23:35:56 +02:00
'uri' => '/res/c3a0ea74/rsrc/css/phui/phui-object-item-list-view.css',
Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. Summary: Adds plain support for object lists that just look like lists Test Plan: review UIexamples and a number of other applications Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6922
2013-09-09 23:14:34 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-object-item-list-view.css',
),
Update pinboard view styles, move to PHUI Summary: Tightens up the CSS to display more items (4 wide on 15") and fixes some mobile CSS issues with appseach. Fixes T3614 Test Plan: Tested Pholio, Macros, mobile layouts Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3614 Differential Revision: https://secure.phabricator.com/D6694
2013-08-07 19:58:09 +02:00
'phui-pinboard-view-css' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/f791ea99/rsrc/css/phui/phui-pinboard-view.css',
Update pinboard view styles, move to PHUI Summary: Tightens up the CSS to display more items (4 wide on 15") and fixes some mobile CSS issues with appseach. Fixes T3614 Test Plan: Tested Pholio, Macros, mobile layouts Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3614 Differential Revision: https://secure.phabricator.com/D6694
2013-08-07 19:58:09 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-pinboard-view.css',
),
PHUIPropertyListView Summary: This builds out and implements PHUIPropertyListView (container) and PHUIPropertyListItemView (section) as well as adding tabs. Test Plan: Tested each page I edited with the exception of Releeph and Phortune, though those changes look ok to me diff wise. Updated examples page with tabs. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7283
2013-10-11 16:53:56 +02:00
'phui-property-list-view-css' =>
array(
'uri' => '/res/6c937c64/rsrc/css/phui/phui-property-list-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-property-list-view.css',
),
Partially generalize Remarkup previews and add support to Differential Summary: Ref T3671. A lot of applications have pretty ad-hoc preview code. Clean it up a bit and add Summary preview to Differential. After ApplicationTransactions we might want to try to serialize the whole form and show a preview of all the transactions, but this seems not very useful in most cases (I'd guess that Remarkup previews are 99% of the value) and tricky to get right (e.g., adding images which don't exist yet to Pholio mocks). I think I can add this in a few other places, too. Test Plan: Edited Maniphest Tasks and Differential Revisions, mashed some buttons. Verified previews rendered correctly. Grepped for removed CSS classes (no hits). {F52907} Reviewers: btrahan, Firehed Reviewed By: btrahan CC: aran, chad Maniphest Tasks: T3671 Differential Revision: https://secure.phabricator.com/D6673
2013-08-05 19:46:39 +02:00
'phui-remarkup-preview-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/50fa4178/rsrc/css/phui/phui-remarkup-preview.css',
Partially generalize Remarkup previews and add support to Differential Summary: Ref T3671. A lot of applications have pretty ad-hoc preview code. Clean it up a bit and add Summary preview to Differential. After ApplicationTransactions we might want to try to serialize the whole form and show a preview of all the transactions, but this seems not very useful in most cases (I'd guess that Remarkup previews are 99% of the value) and tricky to get right (e.g., adding images which don't exist yet to Pholio mocks). I think I can add this in a few other places, too. Test Plan: Edited Maniphest Tasks and Differential Revisions, mashed some buttons. Verified previews rendered correctly. Grepped for removed CSS classes (no hits). {F52907} Reviewers: btrahan, Firehed Reviewed By: btrahan CC: aran, chad Maniphest Tasks: T3671 Differential Revision: https://secure.phabricator.com/D6673
2013-08-05 19:46:39 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-remarkup-preview.css',
),
PHUIButtonView class Summary: Rough pass at a PHUIButtonView Class. Keeps phutil_tag intact and adds some image features if you use the class. Test Plan: UIExamples Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6192
2013-06-13 03:23:35 +02:00
'phui-spacing-css' =>
array(
'uri' => '/res/28891fd3/rsrc/css/phui/phui-spacing.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-spacing.css',
),
Add PHUIStatusListView Summary: For Diffusion's auditors list, and Differential's reviewers list (eventually). An inline option might make more sense in Differential, but I want to use this in Diffusion first, and we need more information there. Test Plan: {F51424} Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D6559
2013-07-24 23:13:22 +02:00
'phui-status-list-view-css' =>
array(
Make UIStatusList background element transparent instead of white Summary: Fixes T3933. Test Plan: See screenshot. Reviewers: chad Reviewed By: chad CC: chad, aran Maniphest Tasks: T3933 Differential Revision: https://secure.phabricator.com/D7272
2013-10-09 02:18:57 +02:00
'uri' => '/res/3410386e/rsrc/css/phui/phui-status.css',
Add PHUIStatusListView Summary: For Diffusion's auditors list, and Differential's reviewers list (eventually). An inline option might make more sense in Differential, but I want to use this in Diffusion first, and we need more information there. Test Plan: {F51424} Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D6559
2013-07-24 23:13:22 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-status.css',
),
PHUI Text View Summary: Adds basic colors and text styles for shorthand use. Test Plan: UIExamples Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5751
2013-04-22 23:28:23 +02:00
'phui-text-css' =>
array(
Implement color variables in CSS. Summary: Added in color variables in most used places. Tweaked green to be a bit more serious. Test Plan: Tested Tags, Error View, Timeline, Object Views, and Color Palette. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6244
2013-06-20 05:25:41 +02:00
'uri' => '/res/63e53cac/rsrc/css/phui/phui-text.css',
PHUI Text View Summary: Adds basic colors and text styles for shorthand use. Test Plan: UIExamples Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5751
2013-04-22 23:28:23 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-text.css',
),
Move Workboards to PHUI Summary: This is just renaming to PHUI (I like shorter text :) Test Plan: reload workboard examples page, seems to not fatal and looks very appealing Reviewers: epriestley Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6904
2013-09-06 23:06:12 +02:00
'phui-workboard-view-css' =>
array(
'uri' => '/res/628679e5/rsrc/css/phui/phui-workboard-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-workboard-view.css',
),
'phui-workpanel-view-css' =>
array(
'uri' => '/res/a81825b2/rsrc/css/phui/phui-workpanel-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-workpanel-view.css',
),
Improve messaging of special policy rules in applications Summary: Ref T603. When the user encounters an action which is controlled by a special policy rule in the application, make it easier for applications to show the user what policy controls the action and what the setting is. I took this about halfway before and left a TODO, but turn it into something more useful. Test Plan: See screenshots. Reviewers: btrahan, chad Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7265
2013-10-09 22:52:04 +02:00
'policy-css' =>
array(
Custom Policy Editor Summary: Ref T603. This isn't remotely usable yet, but I wanted to get any feedback before I build it out anymore. I think this is a reasonable interface for defining custom policies? It's basically similar to Herald, although it's a bit simpler. I imagine users will rarely interact with this, but this will service the high end of policy complexity (and allow the definition of things like "is member of LDAP group" or whatever). Test Plan: See screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran, asherkin Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7217
2013-10-09 23:05:10 +02:00
'uri' => '/res/51325bff/rsrc/css/application/policy/policy.css',
Improve messaging of special policy rules in applications Summary: Ref T603. When the user encounters an action which is controlled by a special policy rule in the application, make it easier for applications to show the user what policy controls the action and what the setting is. I took this about halfway before and left a TODO, but turn it into something more useful. Test Plan: See screenshots. Reviewers: btrahan, chad Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7265
2013-10-09 22:52:04 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/policy/policy.css',
),
Custom Policy Editor Summary: Ref T603. This isn't remotely usable yet, but I wanted to get any feedback before I build it out anymore. I think this is a reasonable interface for defining custom policies? It's basically similar to Herald, although it's a bit simpler. I imagine users will rarely interact with this, but this will service the high end of policy complexity (and allow the definition of things like "is member of LDAP group" or whatever). Test Plan: See screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran, asherkin Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7217
2013-10-09 23:05:10 +02:00
'policy-edit-css' =>
array(
'uri' => '/res/1e2a2b5e/rsrc/css/application/policy/policy-edit.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/policy/policy-edit.css',
),
adding comments to ponder Summary: This is pretty spartan, but it does the job. Test Plan: Patch, update storage, add some comment to your favorite question or answer. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: aran, Korvin, starruler, syrneus, me.here, victorzarate7 Maniphest Tasks: T1645 Differential Revision: https://secure.phabricator.com/D3471
2012-09-11 21:13:20 +02:00
'ponder-comment-table-css' =>
array(
Add objectheaders to new View Summary: This adds the 'PHUIObjectBox' to nearly every place that should get it. I need to comb through Diffusion a little more. I've left Differential mostly alone, but may decide to do it anyways this weekend. I'm sure I missed something else, but these are easy enough to update. Test Plan: tested each new layout. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7162
2013-09-29 00:55:38 +02:00
'uri' => '/res/4aa4b865/rsrc/css/application/ponder/comments.css',
adding comments to ponder Summary: This is pretty spartan, but it does the job. Test Plan: Patch, update storage, add some comment to your favorite question or answer. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: aran, Korvin, starruler, syrneus, me.here, victorzarate7 Maniphest Tasks: T1645 Differential Revision: https://secure.phabricator.com/D3471
2012-09-11 21:13:20 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/ponder/comments.css',
),
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
'ponder-feed-view-css' =>
array(
Improve Ponder on Mobile Summary: Ponder was pretty unusable on mobile, I fixed most of the issues and ran some pht's as well. Test Plan: Use Ponder //shudder// Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5977
2013-05-20 16:55:23 +02:00
'uri' => '/res/cab09075/rsrc/css/application/ponder/feed.css',
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/ponder/feed.css',
),
'ponder-post-css' =>
array(
adding comments to ponder Summary: This is pretty spartan, but it does the job. Test Plan: Patch, update storage, add some comment to your favorite question or answer. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: aran, Korvin, starruler, syrneus, me.here, victorzarate7 Maniphest Tasks: T1645 Differential Revision: https://secure.phabricator.com/D3471
2012-09-11 21:13:20 +02:00
'uri' => '/res/013b9e2c/rsrc/css/application/ponder/post.css',
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/ponder/post.css',
),
'ponder-vote-css' =>
array(
Restore feed stories to Ponder Summary: Ref T3578. These are a touch rough still, but work. Test Plan: {F52154} Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3578 Differential Revision: https://secure.phabricator.com/D6616
2013-07-29 15:30:07 +02:00
'uri' => '/res/6bbe8538/rsrc/css/application/ponder/vote.css',
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/ponder/vote.css',
),
Rebuild celerity map There's an underlying issue here with symlinks + Windows, I think.
2013-04-11 15:32:41 +02:00
'raphael-core' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/5dc5e17c/rsrc/externals/raphael/raphael.js',
Rebuild celerity map There's an underlying issue here with symlinks + Windows, I think.
2013-04-11 15:32:41 +02:00
'type' => 'js',
'requires' =>
array(
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/raphael/raphael.js',
Rebuild celerity map There's an underlying issue here with symlinks + Windows, I think.
2013-04-11 15:32:41 +02:00
),
'raphael-g' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/229b89a1/rsrc/externals/raphael/g.raphael.js',
Rebuild celerity map There's an underlying issue here with symlinks + Windows, I think.
2013-04-11 15:32:41 +02:00
'type' => 'js',
'requires' =>
array(
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/raphael/g.raphael.js',
Rebuild celerity map There's an underlying issue here with symlinks + Windows, I think.
2013-04-11 15:32:41 +02:00
),
'raphael-g-line' =>
array(
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/96da30f7/rsrc/externals/raphael/g.raphael.line.js',
Rebuild celerity map There's an underlying issue here with symlinks + Windows, I think.
2013-04-11 15:32:41 +02:00
'type' => 'js',
'requires' =>
array(
),
Move all external JS into webroot/rsrc/externals Summary: Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up. At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now. See https://github.com/facebook/phabricator/issues/294 Test Plan: Rebuilt map, verified Burnup Rate + Stripe work. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 19:06:05 +02:00
'disk' => '/rsrc/externals/raphael/g.raphael.line.js',
Rebuild celerity map There's an underlying issue here with symlinks + Windows, I think.
2013-04-11 15:32:41 +02:00
),
Releeph (Phabricator part) Summary: A copy of the Releeph release tool. Test Plan: Generally, click everything at least once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D4932
2013-03-15 12:28:43 +01:00
'releeph-branch' =>
array(
'uri' => '/res/6ad6420d/rsrc/css/application/releeph/releeph-branch.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-branch.css',
),
'releeph-colors' =>
array(
'uri' => '/res/dff4b26a/rsrc/css/application/releeph/releeph-colors.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-colors.css',
),
'releeph-core' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/dad04eff/rsrc/css/application/releeph/releeph-core.css',
Releeph (Phabricator part) Summary: A copy of the Releeph release tool. Test Plan: Generally, click everything at least once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D4932
2013-03-15 12:28:43 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-core.css',
),
'releeph-intents' =>
array(
'uri' => '/res/4e73e9dd/rsrc/css/application/releeph/releeph-intents.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-intents.css',
),
'releeph-preview-branch' =>
array(
'uri' => '/res/65e5dece/rsrc/css/application/releeph/releeph-preview-branch.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-preview-branch.css',
),
'releeph-project' =>
array(
'uri' => '/res/b9376e59/rsrc/css/application/releeph/releeph-project.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-project.css',
),
'releeph-request-differential-create-dialog' =>
array(
'uri' => '/res/4df30ce1/rsrc/css/application/releeph/releeph-request-differential-create-dialog.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-request-differential-create-dialog.css',
),
'releeph-request-typeahead-css' =>
array(
'uri' => '/res/9c9a1acf/rsrc/css/application/releeph/releeph-request-typeahead.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-request-typeahead.css',
),
'releeph-status' =>
array(
'uri' => '/res/588529df/rsrc/css/application/releeph/releeph-status.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-status.css',
),
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'setup-issue-css' =>
array(
UIColor Blues and common color integration Summary: This adds standard 'blues' and start integration of standard colors for text, backgrounds, and borders. Test Plan: sb Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6857
2013-09-02 17:10:47 +02:00
'uri' => '/res/135c19ed/rsrc/css/application/config/setup-issue.css',
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/config/setup-issue.css',
),
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'sprite-actions-css' =>
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
array(
Add action icons to object list views Summary: We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well. Instead, provide first-class actions: {F42978} They produce targets which my meaty ham-fists can plausibly hit on mobile, too: {F42979} (We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?) Test Plan: Added UIExamples. Checked desktop/mobile. Reviewers: chad, btrahan, edward Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
'uri' => '/res/bd43efa8/rsrc/css/sprite-actions.css',
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-actions.css',
),
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'sprite-apps-css' =>
array(
Celery!
2013-07-29 21:07:35 +02:00
'uri' => '/res/0805dd1d/rsrc/css/sprite-apps.css',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-apps.css',
),
'sprite-apps-large-css' =>
array(
Celery!
2013-07-29 21:07:35 +02:00
'uri' => '/res/ebba1243/rsrc/css/sprite-apps-large.css',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-apps-large.css',
),
'sprite-apps-xlarge-css' =>
array(
Added Feed icons. Summary: Adds a feed icon for feed applications. Test Plan: Photoshop Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4388
2013-01-10 19:00:18 +01:00
'uri' => '/res/33a8e644/rsrc/css/sprite-apps-xlarge.css',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-apps-xlarge.css',
),
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'sprite-conpherence-css' =>
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
array(
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'uri' => '/res/f6793453/rsrc/css/sprite-conpherence.css',
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
'type' => 'css',
'requires' =>
array(
),
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'disk' => '/rsrc/css/sprite-conpherence.css',
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
),
Document icons sprite sheet. Summary: Adds 32 and 64 px images to represent basic documents. Test Plan: Differential Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5317
2013-03-10 22:16:16 +01:00
'sprite-docs-css' =>
array(
'uri' => '/res/b32f93bc/rsrc/css/sprite-docs.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-docs.css',
),
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'sprite-gradient-css' =>
array(
Add objectheaders to new View Summary: This adds the 'PHUIObjectBox' to nearly every place that should get it. I need to comb through Diffusion a little more. I've left Differential mostly alone, but may decide to do it anyways this weekend. I'm sure I missed something else, but these are easy enough to update. Test Plan: tested each new layout. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7162
2013-09-29 00:55:38 +02:00
'uri' => '/res/e31d9063/rsrc/css/sprite-gradient.css',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-gradient.css',
),
Add action icons to object list views Summary: We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well. Instead, provide first-class actions: {F42978} They produce targets which my meaty ham-fists can plausibly hit on mobile, too: {F42979} (We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?) Test Plan: Added UIExamples. Checked desktop/mobile. Reviewers: chad, btrahan, edward Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
'sprite-icons-css' =>
Generate an icon sprite map with new sprites and 2x retina graphics Summary: - The filesystem is now the authority for which sprites are available. If you add new icons, the generation process will pick them up. - I broke out icon generation and added retina support. App icon generation still uses the old method. - Update ActionList and RemarkupControl to use the new sheet. - Use white icons on hover. - Also fixed a couple of minor issues with some stuff in Firefox/Chrome. Test Plan: {F25750} {F25751} {F25752} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2013 Differential Revision: https://secure.phabricator.com/D4027
2012-11-24 01:35:39 +01:00
array(
New icons for Maniphest Summary: Fixes 2x white icons, adds 'user' and 'project' icons. Test Plan: tested new states in Maniphest Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7176
2013-09-30 02:53:37 +02:00
'uri' => '/res/6e245ca0/rsrc/css/sprite-icons.css',
Generate an icon sprite map with new sprites and 2x retina graphics Summary: - The filesystem is now the authority for which sprites are available. If you add new icons, the generation process will pick them up. - I broke out icon generation and added retina support. App icon generation still uses the old method. - Update ActionList and RemarkupControl to use the new sheet. - Use white icons on hover. - Also fixed a couple of minor issues with some stuff in Firefox/Chrome. Test Plan: {F25750} {F25751} {F25752} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2013 Differential Revision: https://secure.phabricator.com/D4027
2012-11-24 01:35:39 +01:00
'type' => 'css',
'requires' =>
array(
),
Add action icons to object list views Summary: We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well. Instead, provide first-class actions: {F42978} They produce targets which my meaty ham-fists can plausibly hit on mobile, too: {F42979} (We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?) Test Plan: Added UIExamples. Checked desktop/mobile. Reviewers: chad, btrahan, edward Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
'disk' => '/rsrc/css/sprite-icons.css',
Generate an icon sprite map with new sprites and 2x retina graphics Summary: - The filesystem is now the authority for which sprites are available. If you add new icons, the generation process will pick them up. - I broke out icon generation and added retina support. App icon generation still uses the old method. - Update ActionList and RemarkupControl to use the new sheet. - Use white icons on hover. - Also fixed a couple of minor issues with some stuff in Firefox/Chrome. Test Plan: {F25750} {F25751} {F25752} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2013 Differential Revision: https://secure.phabricator.com/D4027
2012-11-24 01:35:39 +01:00
),
Login icons Summary: Took a stab at some login icons for buttons. Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6174
2013-06-11 19:22:09 +02:00
'sprite-login-css' =>
array(
Jira, TwitchTV login icons Summary: icons Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6716
2013-08-11 20:00:38 +02:00
'uri' => '/res/8bd33e35/rsrc/css/sprite-login.css',
Login icons Summary: Took a stab at some login icons for buttons. Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6174
2013-06-11 19:22:09 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-login.css',
),
Use "flame" notification icon and bubble instead of lightning bolt Summary: Switch to the final versions of these Test Plan: Will add screenshots... Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4032
2012-11-27 23:03:25 +01:00
'sprite-menu-css' =>
array(
Mobile "quick create" icons. Summary: icons. Test Plan: for mobile. Reviewers: epriestley, tomo Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6599
2013-07-28 22:47:09 +02:00
'uri' => '/res/764ab039/rsrc/css/sprite-menu.css',
Use "flame" notification icon and bubble instead of lightning bolt Summary: Switch to the final versions of these Test Plan: Will add screenshots... Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4032
2012-11-27 23:03:25 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-menu.css',
),
Leafy greens.
2013-04-04 20:35:22 +02:00
'sprite-minicons-css' =>
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
array(
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'uri' => '/res/2dba70cd/rsrc/css/sprite-minicons.css',
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-minicons.css',
),
Payment sprite icons. Summary: Adds some icons for taking money. Test Plan: UIExamples Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5753
2013-04-23 01:41:00 +02:00
'sprite-payments-css' =>
array(
Leafy Summary: Yummy greens Test Plan: Celerity Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5755
2013-04-23 01:43:29 +02:00
'uri' => '/res/876697b6/rsrc/css/sprite-payments.css',
Payment sprite icons. Summary: Adds some icons for taking money. Test Plan: UIExamples Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5753
2013-04-23 01:41:00 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-payments.css',
),
Projects Icons Series 1 Summary: A set of random icons for use as project identifiers. 42, white. Test Plan: photoshop, epriestley Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7290
2013-10-13 04:15:38 +02:00
'sprite-projects-css' =>
array(
'uri' => '/res/3ff34b69/rsrc/css/sprite-projects.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-projects.css',
),
Status Icons Summary: Status icons for next to people names Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2064 Differential Revision: https://secure.phabricator.com/D6479
2013-07-17 17:44:11 +02:00
'sprite-status-css' =>
array(
Fix retina ObjectHeader status icons Summary: There are reversed on retina displays/ Test Plan: Review on retina Mac Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7257
2013-10-07 17:47:40 +02:00
'uri' => '/res/f8d8766d/rsrc/css/sprite-status.css',
Status Icons Summary: Status icons for next to people names Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2064 Differential Revision: https://secure.phabricator.com/D6479
2013-07-17 17:44:11 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-status.css',
),
Tokens v1 Summary: Features! - Giving tokens. - Taking tokens back. - Not giving tokens. Test Plan: See screenshots. Reviewers: chad, vrana Reviewed By: chad CC: aran, btrahan Maniphest Tasks: T2541 Differential Revision: https://secure.phabricator.com/D4964
2013-02-15 16:47:14 +01:00
'sprite-tokens-css' =>
array(
PHUIIconView Summary: Adds a base class for displaying images and icons. Test Plan: Tested giving and taking tokens, viewed action headers, uiexamples for icons, workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5736
2013-04-20 02:44:20 +02:00
'uri' => '/res/edb4e341/rsrc/css/sprite-tokens.css',
Tokens v1 Summary: Features! - Giving tokens. - Taking tokens back. - Not giving tokens. Test Plan: See screenshots. Reviewers: chad, vrana Reviewed By: chad CC: aran, btrahan Maniphest Tasks: T2541 Differential Revision: https://secure.phabricator.com/D4964
2013-02-15 16:47:14 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-tokens.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'syntax-highlighting-css' =>
array(
Move #888 and #999 to $lightgreytext Summary: Moves lighter grey text to a common color. Test Plan: sandbox, review diff Reviewers: epriestley, btrahan, mutech.aka Reviewed By: mutech.aka CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6859
2013-09-02 17:12:18 +02:00
'uri' => '/res/db7c0e13/rsrc/css/core/syntax.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/syntax.css',
),
Tokens v1 Summary: Features! - Giving tokens. - Taking tokens back. - Not giving tokens. Test Plan: See screenshots. Reviewers: chad, vrana Reviewed By: chad CC: aran, btrahan Maniphest Tasks: T2541 Differential Revision: https://secure.phabricator.com/D4964
2013-02-15 16:47:14 +01:00
'tokens-css' =>
array(
Twerk Tokens Layout Summary: Fixes T3581. Lightens up border, tightens spacing 4px. Test Plan: iOS simulator Reviewers: epriestley, btrahan Reviewed By: btrahan CC: aran, Korvin Maniphest Tasks: T3581 Differential Revision: https://secure.phabricator.com/D6507
2013-07-20 21:29:05 +02:00
'uri' => '/res/bbddf548/rsrc/css/application/tokens/tokens.css',
Tokens v1 Summary: Features! - Giving tokens. - Taking tokens back. - Not giving tokens. Test Plan: See screenshots. Reviewers: chad, vrana Reviewed By: chad CC: aran, btrahan Maniphest Tasks: T2541 Differential Revision: https://secure.phabricator.com/D4964
2013-02-15 16:47:14 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/tokens/tokens.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
), array(
'packages' =>
array(
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'1f32154b' =>
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
array(
'name' => 'core.pkg.css',
'symbols' =>
array(
0 => 'phabricator-core-css',
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
1 => 'phabricator-zindex-css',
PHUIButtonView class Summary: Rough pass at a PHUIButtonView Class. Keeps phutil_tag intact and adds some image features if you use the class. Test Plan: UIExamples Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6192
2013-06-13 03:23:35 +02:00
2 => 'phui-button-css',
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
3 => 'phabricator-standard-page-view',
4 => 'aphront-dialog-view-css',
Update Form Layouts Summary: This attempts some consistency in form layouts. Notably, they all now contain headers and are 16px off the sides and tops of pages. Also updated dialogs to the same look and feel. I think I got 98% of forms with this pass, but it's likely I missed some buried somewhere. TODO: will take another pass as consolidating these colors and new gradients in another diff. Test Plan: Played in my sandbox all week. Please play with it too and let me know how they feel. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6806
2013-08-26 20:53:11 +02:00
5 => 'phui-form-view-css',
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
6 => 'aphront-panel-view-css',
Remove all older-style navs Summary: Move all navs to use the newer-style, darker, textured look. I'm //pretty// sure this doesn't break anything. Test Plan: Looked at a bunch of apps. Reviewers: btrahan, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4376
2013-01-09 21:03:58 +01:00
7 => 'aphront-table-view-css',
Minor, celerity derps.
2013-03-14 00:28:27 +01:00
8 => 'aphront-tokenizer-control-css',
9 => 'aphront-typeahead-control-css',
10 => 'aphront-list-filter-view-css',
Use ObjectItemListView in Diviner Summary: Ref T988. Nuke the old directory CSS. Test Plan: {F44796} Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T988 Differential Revision: https://secure.phabricator.com/D6093
2013-05-31 19:51:53 +02:00
11 => 'phabricator-jump-nav',
12 => 'phabricator-remarkup-css',
13 => 'syntax-highlighting-css',
14 => 'aphront-pager-view-css',
15 => 'phabricator-transaction-view-css',
16 => 'aphront-tooltip-css',
17 => 'phabricator-flag-css',
18 => 'aphront-error-view-css',
19 => 'sprite-icons-css',
20 => 'sprite-gradient-css',
21 => 'sprite-menu-css',
22 => 'sprite-apps-large-css',
Tweak static resource package definitions Summary: Add a couple more resources that we need on most pages. Test Plan: Regenerated resources, viewed homepage. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7155
2013-09-27 19:50:40 +02:00
23 => 'sprite-status-css',
24 => 'phabricator-main-menu-view',
25 => 'phabricator-notification-css',
26 => 'phabricator-notification-menu-css',
27 => 'lightbox-attachment-css',
28 => 'phui-header-view-css',
29 => 'phabricator-filetree-view-css',
30 => 'phabricator-nav-view-css',
31 => 'phabricator-side-menu-view-css',
32 => 'phabricator-crumbs-view-css',
33 => 'phui-object-item-list-view-css',
34 => 'global-drag-and-drop-css',
35 => 'phui-spacing-css',
36 => 'phui-form-css',
37 => 'phui-icon-view-css',
38 => 'phabricator-application-launch-view-css',
39 => 'phabricator-action-list-view-css',
PHUIPropertyListView Summary: This builds out and implements PHUIPropertyListView (container) and PHUIPropertyListItemView (section) as well as adding tabs. Test Plan: Tested each page I edited with the exception of Releeph and Phortune, though those changes look ok to me diff wise. Updated examples page with tabs. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7283
2013-10-11 16:53:56 +02:00
40 => 'phui-property-list-view-css',
Tweak static resource package definitions Summary: Add a couple more resources that we need on most pages. Test Plan: Regenerated resources, viewed homepage. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7155
2013-09-27 19:50:40 +02:00
41 => 'phabricator-tag-view-css',
42 => 'phui-list-view-css',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
),
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'uri' => '/res/pkg/1f32154b/core.pkg.css',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
'type' => 'css',
),
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'8fafb027' =>
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
array(
'name' => 'core.pkg.js',
'symbols' =>
array(
Update static resource packages Summary: These are a bit out of date; bundle things together better. Test Plan: Viewed page source for home, differential list, differential diff, maniphest list, maniphest task. Verified reasonable resource packaging. Reviewers: chad, vrana, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4002
2012-11-21 03:01:25 +01:00
0 => 'javelin-behavior-aphront-basic-tokenizer',
1 => 'javelin-behavior-workflow',
2 => 'javelin-behavior-aphront-form-disable-on-submit',
3 => 'phabricator-keyboard-shortcut-manager',
4 => 'phabricator-keyboard-shortcut',
5 => 'javelin-behavior-phabricator-keyboard-shortcuts',
6 => 'javelin-behavior-refresh-csrf',
7 => 'javelin-behavior-phabricator-watch-anchor',
8 => 'javelin-behavior-phabricator-autofocus',
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
9 => 'phabricator-menu-item',
10 => 'phabricator-dropdown-menu',
Put JX.phtize in package
2013-04-24 02:19:44 +02:00
11 => 'phabricator-phtize',
12 => 'javelin-behavior-phabricator-oncopy',
13 => 'phabricator-tooltip',
14 => 'javelin-behavior-phabricator-tooltips',
15 => 'phabricator-prefab',
16 => 'javelin-behavior-device',
17 => 'javelin-behavior-toggle-class',
18 => 'javelin-behavior-lightbox-attachments',
19 => 'phabricator-busy',
20 => 'javelin-aphlict',
21 => 'phabricator-notification',
22 => 'javelin-behavior-aphlict-listen',
23 => 'javelin-behavior-phabricator-search-typeahead',
24 => 'javelin-behavior-konami',
25 => 'javelin-behavior-aphlict-dropdown',
26 => 'javelin-behavior-history-install',
27 => 'javelin-behavior-phabricator-gesture',
28 => 'javelin-behavior-phabricator-active-nav',
29 => 'javelin-behavior-phabricator-nav',
30 => 'javelin-behavior-phabricator-remarkup-assist',
31 => 'phabricator-textareautils',
32 => 'phabricator-file-upload',
33 => 'javelin-behavior-global-drag-and-drop',
34 => 'javelin-behavior-phabricator-reveal-content',
Minor, package more resources and rebuild Celerity map.
2013-05-19 02:12:42 +02:00
35 => 'phabricator-hovercard',
36 => 'javelin-behavior-phabricator-hovercards',
Tweak static resource package definitions Summary: Add a couple more resources that we need on most pages. Test Plan: Regenerated resources, viewed homepage. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7155
2013-09-27 19:50:40 +02:00
37 => 'javelin-color',
38 => 'javelin-fx',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
),
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'uri' => '/res/pkg/8fafb027/core.pkg.js',
Update static resource packages Summary: These are a bit out of date; bundle things together better. Test Plan: Viewed page source for home, differential list, differential diff, maniphest list, maniphest task. Verified reasonable resource packaging. Reviewers: chad, vrana, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4002
2012-11-21 03:01:25 +01:00
'type' => 'js',
),
Display bullet next to request with errors in DarkConsole. Summary: I always put a `phlog()` somewhere or something fails and I have hard times figuring out which request it was. Also fix safe HTML in panel. Test Plan: Looked at DarkConsole with error on main page, AJAX request and both. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5784
2013-04-26 03:30:13 +02:00
'4ccfeb47' =>
Update static resource packages Summary: These are a bit out of date; bundle things together better. Test Plan: Viewed page source for home, differential list, differential diff, maniphest list, maniphest task. Verified reasonable resource packaging. Reviewers: chad, vrana, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4002
2012-11-21 03:01:25 +01:00
array(
'name' => 'darkconsole.pkg.js',
'symbols' =>
array(
DarkConsole: fix rendering, move request log, load over ajax Summary: This accomplishes three major goals: # Fixes phutil_render_tag -> phutil_tag callsites in DarkConsole. # Moves the Ajax request log to a new panel on the left. This panel (and the tabs panel) get scrollbars when they get large, instead of making the page constantly scroll down. # Loads the panel content over ajax, instead of dumping it into the page body / ajax response body. I've been planning to do this for about 3 years, which is why the plugins are architected the way they are. This should make debugging easier by making response bodies not be 50%+ darkconsole stuff. Additionally, load the plugins dynamically (the old method predates library maps and PhutilSymbolLoader). Test Plan: {F30675} - Switched between requests and tabs, reloaded page, saw same tab. - Used "analyze queries", "profile page", triggered errors. - Verified page does not load anything by default if dark console is closed with Charles. - Generally banged on it a bit. Reviewers: vrana, btrahan, chad Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4692
2013-01-29 03:45:32 +01:00
0 => 'javelin-behavior-dark-console',
1 => 'javelin-behavior-error-log',
Update static resource packages Summary: These are a bit out of date; bundle things together better. Test Plan: Viewed page source for home, differential list, differential diff, maniphest list, maniphest task. Verified reasonable resource packaging. Reviewers: chad, vrana, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4002
2012-11-21 03:01:25 +01:00
),
Display bullet next to request with errors in DarkConsole. Summary: I always put a `phlog()` somewhere or something fails and I have hard times figuring out which request it was. Also fix safe HTML in panel. Test Plan: Looked at DarkConsole with error on main page, AJAX request and both. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5784
2013-04-26 03:30:13 +02:00
'uri' => '/res/pkg/4ccfeb47/darkconsole.pkg.js',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
'type' => 'js',
),
Minor Results table CSS updates Summary: Missed these in the previous pass. Long term I'd like to move the results to tabs, will probably mock those up today and ask for your help coding. Test Plan: Tested the changes on a diff. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7256
2013-10-07 17:41:01 +02:00
'4dc2311c' =>
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
array(
'name' => 'differential.pkg.css',
'symbols' =>
array(
0 => 'differential-core-view-css',
1 => 'differential-changeset-view-css',
Further improve unit/lint rendering Summary: I think this improves things, let me know if you have feedback. Also addresses T840. Test Plan: See screenshots... Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, zeeg Maniphest Tasks: T840 Differential Revision: https://secure.phabricator.com/D2357
2012-05-01 19:15:56 +02:00
2 => 'differential-results-table-css',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
3 => 'differential-revision-history-css',
Highlight update time in revision list Summary: This is another experiment for reducing reviewers response time. I stole the idea (and colors) from [[ http://www.reviewboard.org/media/screenshots/2009/02/02/dashboard.png | ReviewBoard ]]. I actually quite like it (except when everything is red) and I can image that people will review just to have better color balance. The code is not production ready for these reasons: - We load holidays again and again for each revision. I couldn't cache it to static variable because it could persist multiple requests, right? - I don't know how to expand height to the whole cell (I'm really bad in CSS). - CSS rules are probably in wrong file. - We probably want to use different colors. This is how it looks: {F16406} Test Plan: Displayed revision list. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3190
2012-08-20 23:05:46 +02:00
4 => 'differential-revision-list-css',
5 => 'differential-table-of-contents-css',
6 => 'differential-revision-comment-css',
7 => 'differential-revision-add-comment-css',
8 => 'differential-revision-comment-list-css',
9 => 'phabricator-object-selector-css',
render_tag -> tag: phabricator_render_form -> phabricator_form Summary: Convert most phabricator_render_form callsites. In the case of the "headsup view", it converts it by deleting the element entirely (this is the very old Maniphest/Differential header which we no longer use). Test Plan: Poked around a bit. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4726
2013-01-30 20:30:38 +01:00
10 => 'phabricator-content-source-view-css',
11 => 'differential-local-commits-view-css',
12 => 'inline-comment-summary-css',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
),
Minor Results table CSS updates Summary: Missed these in the previous pass. Long term I'd like to move the results to tabs, will probably mock those up today and ask for your help coding. Test Plan: Tested the changes on a diff. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7256
2013-10-07 17:41:01 +02:00
'uri' => '/res/pkg/4dc2311c/differential.pkg.css',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'type' => 'css',
),
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'5e9e5c4e' =>
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
array(
'name' => 'differential.pkg.js',
'symbols' =>
array(
0 => 'phabricator-drag-and-drop-file-upload',
1 => 'phabricator-shaped-request',
2 => 'javelin-behavior-differential-feedback-preview',
3 => 'javelin-behavior-differential-edit-inline-comments',
4 => 'javelin-behavior-differential-populate',
5 => 'javelin-behavior-differential-show-more',
6 => 'javelin-behavior-differential-diff-radios',
7 => 'javelin-behavior-differential-accept-with-errors',
8 => 'javelin-behavior-differential-comment-jump',
9 => 'javelin-behavior-differential-add-reviewers-and-ccs',
10 => 'javelin-behavior-differential-keyboard-navigation',
Pholio - make the form maintain client side edits between file uploads Summary: Fixes T3553. Did it by adding some code that refreshes the File object on keyup events within a given file entry. also fixes an html derp I found trying to fix this. Test Plan: added cool things like 'bbb' to every field and noted they were maintained when I added more files Reviewers: btrahan Reviewed By: btrahan CC: aran, Korvin, chad Maniphest Tasks: T3553 Differential Revision: https://secure.phabricator.com/D6488
2013-07-19 00:04:08 +02:00
11 => 'javelin-behavior-aphront-drag-and-drop-textarea',
12 => 'javelin-behavior-phabricator-object-selector',
13 => 'javelin-behavior-repository-crossreference',
14 => 'javelin-behavior-load-blame',
15 => 'differential-inline-comment-editor',
16 => 'javelin-behavior-differential-dropdown-menus',
17 => 'javelin-behavior-differential-toggle-files',
18 => 'javelin-behavior-differential-user-select',
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
),
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'uri' => '/res/pkg/5e9e5c4e/differential.pkg.js',
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
'type' => 'js',
),
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'c8ce2d88' =>
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
array(
'name' => 'diffusion.pkg.css',
'symbols' =>
array(
0 => 'diffusion-commit-view-css',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
1 => 'diffusion-icons-css',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
),
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'uri' => '/res/pkg/c8ce2d88/diffusion.pkg.css',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
'type' => 'css',
),
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
96909266 =>
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
array(
'name' => 'diffusion.pkg.js',
'symbols' =>
array(
0 => 'javelin-behavior-diffusion-pull-lastmodified',
1 => 'javelin-behavior-diffusion-commit-graph',
2 => 'javelin-behavior-audit-preview',
),
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'uri' => '/res/pkg/96909266/diffusion.pkg.js',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'type' => 'js',
),
Fix two tokenizer issues on iDevices Summary: Fixes T3853. See inline comments for details. Test Plan: Using iOS simulator, mashed the right hand side of tokenizers. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T3853 Differential Revision: https://secure.phabricator.com/D7049
2013-09-20 00:42:02 +02:00
'9564fa17' =>
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
array(
'name' => 'javelin.pkg.js',
'symbols' =>
array(
0 => 'javelin-util',
1 => 'javelin-install',
2 => 'javelin-event',
3 => 'javelin-stratcom',
4 => 'javelin-behavior',
Update static resource packages Summary: These are a bit out of date; bundle things together better. Test Plan: Viewed page source for home, differential list, differential diff, maniphest list, maniphest task. Verified reasonable resource packaging. Reviewers: chad, vrana, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4002
2012-11-21 03:01:25 +01:00
5 => 'javelin-resource',
6 => 'javelin-request',
7 => 'javelin-vector',
8 => 'javelin-dom',
9 => 'javelin-json',
10 => 'javelin-uri',
11 => 'javelin-workflow',
12 => 'javelin-mask',
13 => 'javelin-typeahead',
14 => 'javelin-typeahead-normalizer',
15 => 'javelin-typeahead-source',
16 => 'javelin-typeahead-preloaded-source',
17 => 'javelin-typeahead-ondemand-source',
18 => 'javelin-tokenizer',
Minor, package more resources and rebuild Celerity map.
2013-05-19 02:12:42 +02:00
19 => 'javelin-history',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
),
Fix two tokenizer issues on iDevices Summary: Fixes T3853. See inline comments for details. Test Plan: Using iOS simulator, mashed the right hand side of tokenizers. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T3853 Differential Revision: https://secure.phabricator.com/D7049
2013-09-20 00:42:02 +02:00
'uri' => '/res/pkg/9564fa17/javelin.pkg.js',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'type' => 'js',
),
Remove ManiphestTransactionDetailView Summary: Ref T2217. No remaining callsites. Also nukes associated CSS. Test Plan: `grep`, looked at some tasks. Reviewers: btrahan Reviewed By: btrahan CC: chad, aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7076
2013-09-23 23:30:38 +02:00
49898640 =>
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
array(
'name' => 'maniphest.pkg.css',
'symbols' =>
array(
0 => 'maniphest-task-summary-css',
Remove ManiphestTransactionDetailView Summary: Ref T2217. No remaining callsites. Also nukes associated CSS. Test Plan: `grep`, looked at some tasks. Reviewers: btrahan Reviewed By: btrahan CC: chad, aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7076
2013-09-23 23:30:38 +02:00
1 => 'phabricator-project-tag-css',
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
),
Remove ManiphestTransactionDetailView Summary: Ref T2217. No remaining callsites. Also nukes associated CSS. Test Plan: `grep`, looked at some tasks. Reviewers: btrahan Reviewed By: btrahan CC: chad, aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7076
2013-09-23 23:30:38 +02:00
'uri' => '/res/pkg/49898640/maniphest.pkg.css',
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
'type' => 'css',
),
Allow draggable elements to be dragged to the first list position Summary: Currently, draggable lists (in Config and ApplicationSearch, for example) don't let you drag an item into the first position. This is because the behavior is correct in Maniphest: the first position is above an initial header, like "High Prioirty", and shouldn't be targetable. Permit the behavior in general; forbid it in Maniphest. Test Plan: - Dragged elements into the first position in ApplicationSearch. - Failed to drag elements into the first position in Maniphest. Reviewers: garoevans, btrahan Reviewed By: garoevans CC: aran Differential Revision: https://secure.phabricator.com/D7128
2013-09-25 22:27:58 +02:00
'0a694954' =>
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
array(
'name' => 'maniphest.pkg.js',
'symbols' =>
array(
0 => 'javelin-behavior-maniphest-batch-selector',
1 => 'javelin-behavior-maniphest-transaction-controls',
2 => 'javelin-behavior-maniphest-transaction-preview',
3 => 'javelin-behavior-maniphest-transaction-expand',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
4 => 'javelin-behavior-maniphest-subpriority-editor',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
),
Allow draggable elements to be dragged to the first list position Summary: Currently, draggable lists (in Config and ApplicationSearch, for example) don't let you drag an item into the first position. This is because the behavior is correct in Maniphest: the first position is above an initial header, like "High Prioirty", and shouldn't be targetable. Permit the behavior in general; forbid it in Maniphest. Test Plan: - Dragged elements into the first position in ApplicationSearch. - Failed to drag elements into the first position in Maniphest. Reviewers: garoevans, btrahan Reviewed By: garoevans CC: aran Differential Revision: https://secure.phabricator.com/D7128
2013-09-25 22:27:58 +02:00
'uri' => '/res/pkg/0a694954/maniphest.pkg.js',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'type' => 'js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'reverse' =>
array(
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'aphront-dialog-view-css' => '1f32154b',
'aphront-error-view-css' => '1f32154b',
'aphront-list-filter-view-css' => '1f32154b',
'aphront-pager-view-css' => '1f32154b',
'aphront-panel-view-css' => '1f32154b',
'aphront-table-view-css' => '1f32154b',
'aphront-tokenizer-control-css' => '1f32154b',
'aphront-tooltip-css' => '1f32154b',
'aphront-typeahead-control-css' => '1f32154b',
Minor Results table CSS updates Summary: Missed these in the previous pass. Long term I'd like to move the results to tabs, will probably mock those up today and ask for your help coding. Test Plan: Tested the changes on a diff. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7256
2013-10-07 17:41:01 +02:00
'differential-changeset-view-css' => '4dc2311c',
'differential-core-view-css' => '4dc2311c',
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'differential-inline-comment-editor' => '5e9e5c4e',
Minor Results table CSS updates Summary: Missed these in the previous pass. Long term I'd like to move the results to tabs, will probably mock those up today and ask for your help coding. Test Plan: Tested the changes on a diff. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7256
2013-10-07 17:41:01 +02:00
'differential-local-commits-view-css' => '4dc2311c',
'differential-results-table-css' => '4dc2311c',
'differential-revision-add-comment-css' => '4dc2311c',
'differential-revision-comment-css' => '4dc2311c',
'differential-revision-comment-list-css' => '4dc2311c',
'differential-revision-history-css' => '4dc2311c',
'differential-revision-list-css' => '4dc2311c',
'differential-table-of-contents-css' => '4dc2311c',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'global-drag-and-drop-css' => '1f32154b',
Minor Results table CSS updates Summary: Missed these in the previous pass. Long term I'd like to move the results to tabs, will probably mock those up today and ask for your help coding. Test Plan: Tested the changes on a diff. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7256
2013-10-07 17:41:01 +02:00
'inline-comment-summary-css' => '4dc2311c',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'javelin-aphlict' => '8fafb027',
Fix two tokenizer issues on iDevices Summary: Fixes T3853. See inline comments for details. Test Plan: Using iOS simulator, mashed the right hand side of tokenizers. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T3853 Differential Revision: https://secure.phabricator.com/D7049
2013-09-20 00:42:02 +02:00
'javelin-behavior' => '9564fa17',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'javelin-behavior-aphlict-dropdown' => '8fafb027',
'javelin-behavior-aphlict-listen' => '8fafb027',
'javelin-behavior-aphront-basic-tokenizer' => '8fafb027',
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'javelin-behavior-aphront-drag-and-drop-textarea' => '5e9e5c4e',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'javelin-behavior-aphront-form-disable-on-submit' => '8fafb027',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'javelin-behavior-audit-preview' => '96909266',
Display bullet next to request with errors in DarkConsole. Summary: I always put a `phlog()` somewhere or something fails and I have hard times figuring out which request it was. Also fix safe HTML in panel. Test Plan: Looked at DarkConsole with error on main page, AJAX request and both. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5784
2013-04-26 03:30:13 +02:00
'javelin-behavior-dark-console' => '4ccfeb47',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'javelin-behavior-device' => '8fafb027',
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'javelin-behavior-differential-accept-with-errors' => '5e9e5c4e',
'javelin-behavior-differential-add-reviewers-and-ccs' => '5e9e5c4e',
'javelin-behavior-differential-comment-jump' => '5e9e5c4e',
'javelin-behavior-differential-diff-radios' => '5e9e5c4e',
'javelin-behavior-differential-dropdown-menus' => '5e9e5c4e',
'javelin-behavior-differential-edit-inline-comments' => '5e9e5c4e',
'javelin-behavior-differential-feedback-preview' => '5e9e5c4e',
'javelin-behavior-differential-keyboard-navigation' => '5e9e5c4e',
'javelin-behavior-differential-populate' => '5e9e5c4e',
'javelin-behavior-differential-show-more' => '5e9e5c4e',
'javelin-behavior-differential-toggle-files' => '5e9e5c4e',
'javelin-behavior-differential-user-select' => '5e9e5c4e',
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-19 02:04:22 +02:00
'javelin-behavior-diffusion-commit-graph' => '96909266',
'javelin-behavior-diffusion-pull-lastmodified' => '96909266',
Display bullet next to request with errors in DarkConsole. Summary: I always put a `phlog()` somewhere or something fails and I have hard times figuring out which request it was. Also fix safe HTML in panel. Test Plan: Looked at DarkConsole with error on main page, AJAX request and both. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5784
2013-04-26 03:30:13 +02:00
'javelin-behavior-error-log' => '4ccfeb47',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'javelin-behavior-global-drag-and-drop' => '8fafb027',
'javelin-behavior-history-install' => '8fafb027',
'javelin-behavior-konami' => '8fafb027',
'javelin-behavior-lightbox-attachments' => '8fafb027',
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'javelin-behavior-load-blame' => '5e9e5c4e',
Allow draggable elements to be dragged to the first list position Summary: Currently, draggable lists (in Config and ApplicationSearch, for example) don't let you drag an item into the first position. This is because the behavior is correct in Maniphest: the first position is above an initial header, like "High Prioirty", and shouldn't be targetable. Permit the behavior in general; forbid it in Maniphest. Test Plan: - Dragged elements into the first position in ApplicationSearch. - Failed to drag elements into the first position in Maniphest. Reviewers: garoevans, btrahan Reviewed By: garoevans CC: aran Differential Revision: https://secure.phabricator.com/D7128
2013-09-25 22:27:58 +02:00
'javelin-behavior-maniphest-batch-selector' => '0a694954',
'javelin-behavior-maniphest-subpriority-editor' => '0a694954',
'javelin-behavior-maniphest-transaction-controls' => '0a694954',
'javelin-behavior-maniphest-transaction-expand' => '0a694954',
'javelin-behavior-maniphest-transaction-preview' => '0a694954',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'javelin-behavior-phabricator-active-nav' => '8fafb027',
'javelin-behavior-phabricator-autofocus' => '8fafb027',
'javelin-behavior-phabricator-gesture' => '8fafb027',
'javelin-behavior-phabricator-hovercards' => '8fafb027',
'javelin-behavior-phabricator-keyboard-shortcuts' => '8fafb027',
'javelin-behavior-phabricator-nav' => '8fafb027',
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'javelin-behavior-phabricator-object-selector' => '5e9e5c4e',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'javelin-behavior-phabricator-oncopy' => '8fafb027',
'javelin-behavior-phabricator-remarkup-assist' => '8fafb027',
'javelin-behavior-phabricator-reveal-content' => '8fafb027',
'javelin-behavior-phabricator-search-typeahead' => '8fafb027',
'javelin-behavior-phabricator-tooltips' => '8fafb027',
'javelin-behavior-phabricator-watch-anchor' => '8fafb027',
'javelin-behavior-refresh-csrf' => '8fafb027',
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'javelin-behavior-repository-crossreference' => '5e9e5c4e',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'javelin-behavior-toggle-class' => '8fafb027',
'javelin-behavior-workflow' => '8fafb027',
'javelin-color' => '8fafb027',
Fix two tokenizer issues on iDevices Summary: Fixes T3853. See inline comments for details. Test Plan: Using iOS simulator, mashed the right hand side of tokenizers. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T3853 Differential Revision: https://secure.phabricator.com/D7049
2013-09-20 00:42:02 +02:00
'javelin-dom' => '9564fa17',
'javelin-event' => '9564fa17',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'javelin-fx' => '8fafb027',
Fix two tokenizer issues on iDevices Summary: Fixes T3853. See inline comments for details. Test Plan: Using iOS simulator, mashed the right hand side of tokenizers. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T3853 Differential Revision: https://secure.phabricator.com/D7049
2013-09-20 00:42:02 +02:00
'javelin-history' => '9564fa17',
'javelin-install' => '9564fa17',
'javelin-json' => '9564fa17',
'javelin-mask' => '9564fa17',
'javelin-request' => '9564fa17',
'javelin-resource' => '9564fa17',
'javelin-stratcom' => '9564fa17',
'javelin-tokenizer' => '9564fa17',
'javelin-typeahead' => '9564fa17',
'javelin-typeahead-normalizer' => '9564fa17',
'javelin-typeahead-ondemand-source' => '9564fa17',
'javelin-typeahead-preloaded-source' => '9564fa17',
'javelin-typeahead-source' => '9564fa17',
'javelin-uri' => '9564fa17',
'javelin-util' => '9564fa17',
'javelin-vector' => '9564fa17',
'javelin-workflow' => '9564fa17',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'lightbox-attachment-css' => '1f32154b',
Remove ManiphestTransactionDetailView Summary: Ref T2217. No remaining callsites. Also nukes associated CSS. Test Plan: `grep`, looked at some tasks. Reviewers: btrahan Reviewed By: btrahan CC: chad, aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7076
2013-09-23 23:30:38 +02:00
'maniphest-task-summary-css' => '49898640',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'phabricator-action-list-view-css' => '1f32154b',
'phabricator-application-launch-view-css' => '1f32154b',
'phabricator-busy' => '8fafb027',
Minor Results table CSS updates Summary: Missed these in the previous pass. Long term I'd like to move the results to tabs, will probably mock those up today and ask for your help coding. Test Plan: Tested the changes on a diff. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7256
2013-10-07 17:41:01 +02:00
'phabricator-content-source-view-css' => '4dc2311c',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'phabricator-core-css' => '1f32154b',
'phabricator-crumbs-view-css' => '1f32154b',
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'phabricator-dropdown-menu' => '8fafb027',
'phabricator-file-upload' => '8fafb027',
'phabricator-filetree-view-css' => '1f32154b',
'phabricator-flag-css' => '1f32154b',
'phabricator-hovercard' => '8fafb027',
'phabricator-jump-nav' => '1f32154b',
'phabricator-keyboard-shortcut' => '8fafb027',
'phabricator-keyboard-shortcut-manager' => '8fafb027',
'phabricator-main-menu-view' => '1f32154b',
'phabricator-menu-item' => '8fafb027',
'phabricator-nav-view-css' => '1f32154b',
'phabricator-notification' => '8fafb027',
'phabricator-notification-css' => '1f32154b',
'phabricator-notification-menu-css' => '1f32154b',
Minor Results table CSS updates Summary: Missed these in the previous pass. Long term I'd like to move the results to tabs, will probably mock those up today and ask for your help coding. Test Plan: Tested the changes on a diff. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7256
2013-10-07 17:41:01 +02:00
'phabricator-object-selector-css' => '4dc2311c',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'phabricator-phtize' => '8fafb027',
'phabricator-prefab' => '8fafb027',
Remove ManiphestTransactionDetailView Summary: Ref T2217. No remaining callsites. Also nukes associated CSS. Test Plan: `grep`, looked at some tasks. Reviewers: btrahan Reviewed By: btrahan CC: chad, aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7076
2013-09-23 23:30:38 +02:00
'phabricator-project-tag-css' => '49898640',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'phabricator-remarkup-css' => '1f32154b',
Don't mangle inline comments with tables in them in Differential Summary: Fixes T3814. Broadly, remarkup tables in inline comments did not work properly. I ran into several messes here and cleaned up some of them: - Some of this code is doing `JX.$N('div', {}, JX.$H(response.markup))`, to turn an HTML response into a node, passing that around, and then doing junk with it. This is super old and gross. - The slightly more modern pattern is `JX.$H(response.markup).getFragment().firstChild`, but this is kind of yuck too and not as safe as it could be. - Introduce `JX.$H(response.markup).getNode()`, which actually expresses intent here. We have a bunch of `getFragment().firstChild` callsites which should switch to this, but I didn't clean those up yet because I don't want to test them all. - Switch the `JX.$N('div', {}, JX.$H(response.markup))`-style callsites to `JX.$H(response.markup).getNode()`. - `copyRows()` is too aggressive in finding `<tr />` tags. This actually causes the bug in T3814. We only want to find these tags at top level, not all tags. Don't copy `<tr />` tags which belong to some deeper table. - Once this is fixed, there's another bug with mousing over the cells in tables in inline comments. We select the nearest `<td />`, but that's the cell in the remarkup table. Instead, select the correct `<td />`. - At this point, these last two callsites were looking ugly. I provided `findAbove()` to clean them up. Test Plan: Created, edited, deleted, moused over, and reloaded a revision with inline comments including remarkup tables. Used "Show more context" links. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3814 Differential Revision: https://secure.phabricator.com/D6924
2013-09-11 00:31:32 +02:00
'phabricator-shaped-request' => '5e9e5c4e',
Highlight the currently selected policy in the policy dropdown control thing Summary: Ref T603. Make this a little easier to use by highlighting the current value. Test Plan: See screenshot. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7289
2013-10-13 02:08:35 +02:00
'phabricator-side-menu-view-css' => '1f32154b',
'phabricator-standard-page-view' => '1f32154b',
'phabricator-tag-view-css' => '1f32154b',
'phabricator-textareautils' => '8fafb027',
'phabricator-tooltip' => '8fafb027',
'phabricator-transaction-view-css' => '1f32154b',
'phabricator-zindex-css' => '1f32154b',
'phui-button-css' => '1f32154b',
'phui-form-css' => '1f32154b',
'phui-form-view-css' => '1f32154b',
'phui-header-view-css' => '1f32154b',
'phui-icon-view-css' => '1f32154b',
'phui-list-view-css' => '1f32154b',
'phui-object-item-list-view-css' => '1f32154b',
'phui-property-list-view-css' => '1f32154b',
'phui-spacing-css' => '1f32154b',
'sprite-apps-large-css' => '1f32154b',
'sprite-gradient-css' => '1f32154b',
'sprite-icons-css' => '1f32154b',
'sprite-menu-css' => '1f32154b',
'sprite-status-css' => '1f32154b',
'syntax-highlighting-css' => '1f32154b',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
));
Copy permalink