2011-01-24 20:01:53 +01:00
|
|
|
<?php
|
|
|
|
|
2013-02-15 16:47:14 +01:00
|
|
|
final class DifferentialRevision extends DifferentialDAO
|
2013-03-30 17:32:29 +01:00
|
|
|
implements
|
|
|
|
PhabricatorTokenReceiverInterface,
|
|
|
|
PhabricatorPolicyInterface,
|
|
|
|
PhrequentTrackableInterface {
|
2011-01-24 20:01:53 +01:00
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
protected $title;
|
2012-06-14 05:52:10 +02:00
|
|
|
protected $originalTitle;
|
2011-01-24 20:01:53 +01:00
|
|
|
protected $status;
|
|
|
|
|
|
|
|
protected $summary;
|
|
|
|
protected $testPlan;
|
|
|
|
|
|
|
|
protected $phid;
|
2011-01-30 19:37:36 +01:00
|
|
|
protected $authorPHID;
|
2012-03-05 19:51:47 +01:00
|
|
|
protected $lastReviewerPHID;
|
2011-01-24 20:01:53 +01:00
|
|
|
|
|
|
|
protected $dateCommitted;
|
|
|
|
|
|
|
|
protected $lineCount;
|
2011-02-17 23:32:01 +01:00
|
|
|
protected $attached = array();
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-05-05 08:09:42 +02:00
|
|
|
protected $mailKey;
|
2012-04-10 21:51:34 +02:00
|
|
|
protected $branchName;
|
|
|
|
protected $arcanistProjectPHID;
|
2011-05-05 08:09:42 +02:00
|
|
|
|
2013-09-03 15:02:14 +02:00
|
|
|
private $relationships = self::ATTACHABLE;
|
|
|
|
private $commits = self::ATTACHABLE;
|
|
|
|
private $activeDiff = self::ATTACHABLE;
|
|
|
|
private $diffIDs = self::ATTACHABLE;
|
|
|
|
private $hashes = self::ATTACHABLE;
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2013-09-03 15:02:14 +02:00
|
|
|
private $reviewerStatus = self::ATTACHABLE;
|
2012-04-10 21:51:34 +02:00
|
|
|
|
2011-01-27 03:46:34 +01:00
|
|
|
const RELATIONSHIP_TABLE = 'differential_relationship';
|
2011-04-08 06:59:42 +02:00
|
|
|
const TABLE_COMMIT = 'differential_commit';
|
2011-01-27 03:46:34 +01:00
|
|
|
|
|
|
|
const RELATION_REVIEWER = 'revw';
|
|
|
|
const RELATION_SUBSCRIBED = 'subd';
|
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function getConfiguration() {
|
|
|
|
return array(
|
|
|
|
self::CONFIG_AUX_PHID => true,
|
2011-02-17 23:32:01 +01:00
|
|
|
self::CONFIG_SERIALIZATION => array(
|
2011-02-19 23:36:13 +01:00
|
|
|
'attached' => self::SERIALIZATION_JSON,
|
|
|
|
'unsubscribed' => self::SERIALIZATION_JSON,
|
2011-02-17 23:32:01 +01:00
|
|
|
),
|
2011-01-26 02:17:19 +01:00
|
|
|
) + parent::getConfiguration();
|
|
|
|
}
|
|
|
|
|
2012-06-14 05:52:10 +02:00
|
|
|
public function setTitle($title) {
|
|
|
|
$this->title = $title;
|
|
|
|
if (!$this->getID()) {
|
|
|
|
$this->originalTitle = $title;
|
|
|
|
}
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2012-06-23 01:52:08 +02:00
|
|
|
public function loadIDsByCommitPHIDs($phids) {
|
|
|
|
if (!$phids) {
|
|
|
|
return array();
|
|
|
|
}
|
|
|
|
$revision_ids = queryfx_all(
|
|
|
|
$this->establishConnection('r'),
|
|
|
|
'SELECT * FROM %T WHERE commitPHID IN (%Ls)',
|
|
|
|
self::TABLE_COMMIT,
|
|
|
|
$phids);
|
|
|
|
return ipull($revision_ids, 'revisionID', 'commitPHID');
|
|
|
|
}
|
|
|
|
|
2011-04-08 06:59:42 +02:00
|
|
|
public function loadCommitPHIDs() {
|
|
|
|
if (!$this->getID()) {
|
|
|
|
return ($this->commits = array());
|
|
|
|
}
|
|
|
|
|
|
|
|
$commits = queryfx_all(
|
|
|
|
$this->establishConnection('r'),
|
|
|
|
'SELECT commitPHID FROM %T WHERE revisionID = %d',
|
|
|
|
self::TABLE_COMMIT,
|
|
|
|
$this->getID());
|
|
|
|
$commits = ipull($commits, 'commitPHID');
|
|
|
|
|
|
|
|
return ($this->commits = $commits);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getCommitPHIDs() {
|
2013-09-03 15:02:14 +02:00
|
|
|
return $this->assertAttached($this->commits);
|
2011-04-08 06:59:42 +02:00
|
|
|
}
|
|
|
|
|
2011-12-21 02:05:52 +01:00
|
|
|
public function getActiveDiff() {
|
|
|
|
// TODO: Because it's currently technically possible to create a revision
|
|
|
|
// without an associated diff, we allow an attached-but-null active diff.
|
|
|
|
// It would be good to get rid of this once we make diff-attaching
|
|
|
|
// transactional.
|
|
|
|
|
2013-09-03 15:02:14 +02:00
|
|
|
return $this->assertAttached($this->activeDiff);
|
2011-12-21 02:05:52 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function attachActiveDiff($diff) {
|
|
|
|
$this->activeDiff = $diff;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getDiffIDs() {
|
2013-09-03 15:02:14 +02:00
|
|
|
return $this->assertAttached($this->diffIDs);
|
2011-12-21 02:05:52 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function attachDiffIDs(array $ids) {
|
|
|
|
rsort($ids);
|
|
|
|
$this->diffIDs = array_values($ids);
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function attachCommitPHIDs(array $phids) {
|
|
|
|
$this->commits = array_values($phids);
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-02-17 23:32:01 +01:00
|
|
|
public function getAttachedPHIDs($type) {
|
|
|
|
return array_keys(idx($this->attached, $type, array()));
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setAttachedPHIDs($type, array $phids) {
|
|
|
|
$this->attached[$type] = array_fill_keys($phids, array());
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function generatePHID() {
|
2011-03-03 03:58:21 +01:00
|
|
|
return PhabricatorPHID::generateNewPHID(
|
2013-07-21 17:11:37 +02:00
|
|
|
DifferentialPHIDTypeRevision::TYPECONST);
|
2011-01-26 02:17:19 +01:00
|
|
|
}
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-01-27 23:55:52 +01:00
|
|
|
public function loadDiffs() {
|
|
|
|
if (!$this->getID()) {
|
|
|
|
return array();
|
|
|
|
}
|
|
|
|
return id(new DifferentialDiff())->loadAllWhere(
|
|
|
|
'revisionID = %d',
|
|
|
|
$this->getID());
|
|
|
|
}
|
|
|
|
|
2011-01-30 19:37:36 +01:00
|
|
|
public function loadComments() {
|
|
|
|
if (!$this->getID()) {
|
|
|
|
return array();
|
|
|
|
}
|
Put all DifferentialComment loading behind DifferentialCommentQuery
Summary:
Ref T2222.
I'm thinking about how I want to approach the Asana sync, and I want to try to do T2222 first so that we can build it cleanly on top of ApplicationTransactions. I think we can at least walk down this road a little bit and if it turns out to be scary we can take another approach.
I was generally very happy with how the auth migration turned out (seemingly, it was almost completely clean), and want to pursue a similar strategy here. Basically:
- Wrap the new objects in the old objects for reads/writes.
- Migrate all the existing data to the new table.
- Everything hard is done; move things over a piece at a time at a leisurely pace in lots of smallish, relatively-easy-to-understand changes.
This deletes or abstracts all reads of the DifferentialComment table. In particular, these things are **deleted**:
- The script `undo_commits.php`, which I haven't pointed anyone at in a very long time.
- The `differential.getrevisionfeedback` Conduit method, which has been marked deprecated for a year or more.
- The `/stats/` interface in Differential, which should be rebuilt on Fact and has never been exposed in the UI. It does a ton of joins and such which are prohibitively difficult to migrate.
This leaves a small number of reading interfaces, which I replaced with a new `DifferentialCommentQuery`. Some future change will make this actually load transactions and wrap them with DifferentialComment interfaces.
Test Plan: Viewed a revision; made revision comments
Reviewers: btrahan
Reviewed By: btrahan
CC: edward, chad, aran
Maniphest Tasks: T2222
Differential Revision: https://secure.phabricator.com/D6260
2013-06-21 21:51:18 +02:00
|
|
|
return id(new DifferentialCommentQuery())
|
|
|
|
->withRevisionIDs(array($this->getID()))
|
|
|
|
->execute();
|
2011-01-30 19:37:36 +01:00
|
|
|
}
|
|
|
|
|
2011-01-30 22:20:56 +01:00
|
|
|
public function loadActiveDiff() {
|
|
|
|
return id(new DifferentialDiff())->loadOneWhere(
|
|
|
|
'revisionID = %d ORDER BY id DESC LIMIT 1',
|
|
|
|
$this->getID());
|
|
|
|
}
|
2011-05-05 08:09:42 +02:00
|
|
|
|
|
|
|
public function save() {
|
|
|
|
if (!$this->getMailKey()) {
|
Replace callsites to sha1() that use it to asciify entropy with
Filesystem::readRandomCharacters()
Summary: See T547. To improve auditability of use of crypto-sensitive hash
functions, use Filesystem::readRandomCharacters() in place of
sha1(Filesystem::readRandomBytes()) when we're just generating random ASCII
strings.
Test Plan:
- Generated a new PHID.
- Logged out and logged back in (to test sessions).
- Regenerated Conduit certificate.
- Created a new task, verified mail key generated sensibly.
- Created a new revision, verified mail key generated sensibly.
- Ran "arc list", got blocked, installed new certificate, ran "arc list"
again.
Reviewers: jungejason, nh, tuomaspelkonen, aran, benmathews
Reviewed By: jungejason
CC: aran, epriestley, jungejason
Differential Revision: 1000
2011-10-11 04:22:30 +02:00
|
|
|
$this->mailKey = Filesystem::readRandomCharacters(40);
|
2011-05-05 08:09:42 +02:00
|
|
|
}
|
|
|
|
return parent::save();
|
|
|
|
}
|
2011-01-30 22:20:56 +01:00
|
|
|
|
2012-06-19 20:52:50 +02:00
|
|
|
public function delete() {
|
|
|
|
$this->openTransaction();
|
|
|
|
$diffs = $this->loadDiffs();
|
|
|
|
foreach ($diffs as $diff) {
|
|
|
|
$diff->delete();
|
|
|
|
}
|
|
|
|
|
|
|
|
$conn_w = $this->establishConnection('w');
|
|
|
|
|
|
|
|
queryfx(
|
|
|
|
$conn_w,
|
|
|
|
'DELETE FROM %T WHERE revisionID = %d',
|
|
|
|
self::RELATIONSHIP_TABLE,
|
|
|
|
$this->getID());
|
|
|
|
|
|
|
|
queryfx(
|
|
|
|
$conn_w,
|
|
|
|
'DELETE FROM %T WHERE revisionID = %d',
|
|
|
|
self::TABLE_COMMIT,
|
|
|
|
$this->getID());
|
|
|
|
|
Put all DifferentialComment loading behind DifferentialCommentQuery
Summary:
Ref T2222.
I'm thinking about how I want to approach the Asana sync, and I want to try to do T2222 first so that we can build it cleanly on top of ApplicationTransactions. I think we can at least walk down this road a little bit and if it turns out to be scary we can take another approach.
I was generally very happy with how the auth migration turned out (seemingly, it was almost completely clean), and want to pursue a similar strategy here. Basically:
- Wrap the new objects in the old objects for reads/writes.
- Migrate all the existing data to the new table.
- Everything hard is done; move things over a piece at a time at a leisurely pace in lots of smallish, relatively-easy-to-understand changes.
This deletes or abstracts all reads of the DifferentialComment table. In particular, these things are **deleted**:
- The script `undo_commits.php`, which I haven't pointed anyone at in a very long time.
- The `differential.getrevisionfeedback` Conduit method, which has been marked deprecated for a year or more.
- The `/stats/` interface in Differential, which should be rebuilt on Fact and has never been exposed in the UI. It does a ton of joins and such which are prohibitively difficult to migrate.
This leaves a small number of reading interfaces, which I replaced with a new `DifferentialCommentQuery`. Some future change will make this actually load transactions and wrap them with DifferentialComment interfaces.
Test Plan: Viewed a revision; made revision comments
Reviewers: btrahan
Reviewed By: btrahan
CC: edward, chad, aran
Maniphest Tasks: T2222
Differential Revision: https://secure.phabricator.com/D6260
2013-06-21 21:51:18 +02:00
|
|
|
$comments = id(new DifferentialCommentQuery())
|
|
|
|
->withRevisionIDs(array($this->getID()))
|
|
|
|
->execute();
|
2012-06-19 20:52:50 +02:00
|
|
|
foreach ($comments as $comment) {
|
|
|
|
$comment->delete();
|
|
|
|
}
|
|
|
|
|
2013-06-21 21:54:56 +02:00
|
|
|
$inlines = id(new DifferentialInlineCommentQuery())
|
|
|
|
->withRevisionIDs(array($this->getID()))
|
|
|
|
->execute();
|
2012-06-19 20:52:50 +02:00
|
|
|
foreach ($inlines as $inline) {
|
|
|
|
$inline->delete();
|
|
|
|
}
|
|
|
|
|
|
|
|
$fields = id(new DifferentialAuxiliaryField())->loadAllWhere(
|
|
|
|
'revisionPHID = %s',
|
|
|
|
$this->getPHID());
|
|
|
|
foreach ($fields as $field) {
|
|
|
|
$field->delete();
|
|
|
|
}
|
|
|
|
|
2012-10-04 00:50:42 +02:00
|
|
|
// we have to do paths a little differentally as they do not have
|
|
|
|
// an id or phid column for delete() to act on
|
|
|
|
$dummy_path = new DifferentialAffectedPath();
|
|
|
|
queryfx(
|
|
|
|
$conn_w,
|
|
|
|
'DELETE FROM %T WHERE revisionID = %d',
|
|
|
|
$dummy_path->getTableName(),
|
2012-06-19 20:52:50 +02:00
|
|
|
$this->getID());
|
|
|
|
|
|
|
|
$result = parent::delete();
|
|
|
|
$this->saveTransaction();
|
|
|
|
return $result;
|
|
|
|
}
|
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function loadRelationships() {
|
2011-01-27 03:46:34 +01:00
|
|
|
if (!$this->getID()) {
|
|
|
|
$this->relationships = array();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
$data = queryfx_all(
|
|
|
|
$this->establishConnection('r'),
|
|
|
|
'SELECT * FROM %T WHERE revisionID = %d ORDER BY sequence',
|
|
|
|
self::RELATIONSHIP_TABLE,
|
|
|
|
$this->getID());
|
2011-10-02 20:42:41 +02:00
|
|
|
return $this->attachRelationships($data);
|
|
|
|
}
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-10-02 20:42:41 +02:00
|
|
|
public function attachRelationships(array $relationships) {
|
|
|
|
$this->relationships = igroup($relationships, 'relation');
|
2011-01-27 03:46:34 +01:00
|
|
|
return $this;
|
2011-01-26 02:17:19 +01:00
|
|
|
}
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function getReviewers() {
|
2011-01-27 03:46:34 +01:00
|
|
|
return $this->getRelatedPHIDs(self::RELATION_REVIEWER);
|
2011-01-26 02:17:19 +01:00
|
|
|
}
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function getCCPHIDs() {
|
2011-01-27 03:46:34 +01:00
|
|
|
return $this->getRelatedPHIDs(self::RELATION_SUBSCRIBED);
|
|
|
|
}
|
|
|
|
|
|
|
|
private function getRelatedPHIDs($relation) {
|
2013-09-03 15:02:14 +02:00
|
|
|
$this->assertAttached($this->relationships);
|
2011-02-03 04:38:43 +01:00
|
|
|
|
2011-02-03 02:38:03 +01:00
|
|
|
return ipull($this->getRawRelations($relation), 'objectPHID');
|
2011-01-27 03:46:34 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function getRawRelations($relation) {
|
|
|
|
return idx($this->relationships, $relation, array());
|
|
|
|
}
|
2011-04-30 07:26:22 +02:00
|
|
|
|
2013-02-02 01:48:10 +01:00
|
|
|
public function loadUnsubscribedPHIDs() {
|
|
|
|
return PhabricatorEdgeQuery::loadDestinationPHIDs(
|
|
|
|
$this->phid,
|
|
|
|
PhabricatorEdgeConfig::TYPE_OBJECT_HAS_UNSUBSCRIBER);
|
2011-04-30 07:26:22 +02:00
|
|
|
}
|
2011-10-19 08:35:45 +02:00
|
|
|
|
2012-05-18 09:33:21 +02:00
|
|
|
public function getPrimaryReviewer() {
|
2012-08-08 22:27:52 +02:00
|
|
|
$reviewers = $this->getReviewers();
|
|
|
|
$last = $this->lastReviewerPHID;
|
|
|
|
if (!$last || !in_array($last, $reviewers)) {
|
2012-05-18 09:33:21 +02:00
|
|
|
return head($this->getReviewers());
|
|
|
|
}
|
2012-08-08 22:27:52 +02:00
|
|
|
return $last;
|
2012-05-18 09:33:21 +02:00
|
|
|
}
|
|
|
|
|
2011-10-19 08:35:45 +02:00
|
|
|
public function loadReviewedBy() {
|
|
|
|
$reviewer = null;
|
|
|
|
|
2012-01-10 20:39:11 +01:00
|
|
|
if ($this->status == ArcanistDifferentialRevisionStatus::ACCEPTED ||
|
2012-04-24 02:40:57 +02:00
|
|
|
$this->status == ArcanistDifferentialRevisionStatus::CLOSED) {
|
2011-10-19 08:35:45 +02:00
|
|
|
$comments = $this->loadComments();
|
|
|
|
foreach ($comments as $comment) {
|
|
|
|
$action = $comment->getAction();
|
|
|
|
if ($action == DifferentialAction::ACTION_ACCEPT) {
|
|
|
|
$reviewer = $comment->getAuthorPHID();
|
|
|
|
} else if ($action == DifferentialAction::ACTION_REJECT ||
|
|
|
|
$action == DifferentialAction::ACTION_ABANDON ||
|
|
|
|
$action == DifferentialAction::ACTION_RETHINK) {
|
|
|
|
$reviewer = null;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return $reviewer;
|
|
|
|
}
|
2012-06-26 18:07:52 +02:00
|
|
|
|
|
|
|
public function getHashes() {
|
2013-09-03 15:02:14 +02:00
|
|
|
return $this->assertAttached($this->hashes);
|
2012-06-26 18:07:52 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
public function attachHashes(array $hashes) {
|
|
|
|
$this->hashes = $hashes;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2013-02-15 16:47:14 +01:00
|
|
|
public function getCapabilities() {
|
|
|
|
return array(
|
|
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getPolicy($capability) {
|
|
|
|
return PhabricatorPolicies::POLICY_USER;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function hasAutomaticCapability($capability, PhabricatorUser $user) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2013-02-19 02:44:45 +01:00
|
|
|
public function getUsersToNotifyOfTokenGiven() {
|
|
|
|
return array(
|
|
|
|
$this->getAuthorPHID(),
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2013-07-15 04:18:55 +02:00
|
|
|
public function getReviewerStatus() {
|
2013-09-03 15:02:14 +02:00
|
|
|
return $this->assertAttached($this->reviewerStatus);
|
2013-07-15 04:18:55 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
public function attachReviewerStatus(array $reviewers) {
|
|
|
|
assert_instances_of($reviewers, 'DifferentialReviewer');
|
|
|
|
|
|
|
|
$this->reviewerStatus = $reviewers;
|
|
|
|
return $this;
|
|
|
|
}
|
2011-01-24 20:01:53 +01:00
|
|
|
}
|