2011-01-24 20:01:53 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
/*
|
2012-01-10 20:39:11 +01:00
|
|
|
* Copyright 2012 Facebook, Inc.
|
2011-01-24 20:01:53 +01:00
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
2012-03-13 19:18:11 +01:00
|
|
|
final class DifferentialRevision extends DifferentialDAO {
|
2011-01-24 20:01:53 +01:00
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
protected $title;
|
2012-06-14 05:52:10 +02:00
|
|
|
protected $originalTitle;
|
2011-01-24 20:01:53 +01:00
|
|
|
protected $status;
|
|
|
|
|
|
|
|
protected $summary;
|
|
|
|
protected $testPlan;
|
|
|
|
|
|
|
|
protected $phid;
|
2011-01-30 19:37:36 +01:00
|
|
|
protected $authorPHID;
|
2012-03-05 19:51:47 +01:00
|
|
|
protected $lastReviewerPHID;
|
2011-01-24 20:01:53 +01:00
|
|
|
|
|
|
|
protected $dateCommitted;
|
|
|
|
|
|
|
|
protected $lineCount;
|
2011-02-17 23:32:01 +01:00
|
|
|
protected $attached = array();
|
2011-02-19 23:36:13 +01:00
|
|
|
protected $unsubscribed = array();
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-05-05 08:09:42 +02:00
|
|
|
protected $mailKey;
|
2012-04-10 21:51:34 +02:00
|
|
|
protected $branchName;
|
|
|
|
protected $arcanistProjectPHID;
|
2011-05-05 08:09:42 +02:00
|
|
|
|
2011-02-03 02:38:03 +01:00
|
|
|
private $relationships;
|
2011-04-08 06:59:42 +02:00
|
|
|
private $commits;
|
2011-12-21 02:05:52 +01:00
|
|
|
private $activeDiff = false;
|
|
|
|
private $diffIDs;
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2012-04-10 21:51:34 +02:00
|
|
|
|
2011-01-27 03:46:34 +01:00
|
|
|
const RELATIONSHIP_TABLE = 'differential_relationship';
|
2011-04-08 06:59:42 +02:00
|
|
|
const TABLE_COMMIT = 'differential_commit';
|
2011-01-27 03:46:34 +01:00
|
|
|
|
|
|
|
const RELATION_REVIEWER = 'revw';
|
|
|
|
const RELATION_SUBSCRIBED = 'subd';
|
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function getConfiguration() {
|
|
|
|
return array(
|
|
|
|
self::CONFIG_AUX_PHID => true,
|
2011-02-17 23:32:01 +01:00
|
|
|
self::CONFIG_SERIALIZATION => array(
|
2011-02-19 23:36:13 +01:00
|
|
|
'attached' => self::SERIALIZATION_JSON,
|
|
|
|
'unsubscribed' => self::SERIALIZATION_JSON,
|
2011-02-17 23:32:01 +01:00
|
|
|
),
|
2011-01-26 02:17:19 +01:00
|
|
|
) + parent::getConfiguration();
|
|
|
|
}
|
|
|
|
|
2012-06-14 05:52:10 +02:00
|
|
|
public function setTitle($title) {
|
|
|
|
$this->title = $title;
|
|
|
|
if (!$this->getID()) {
|
|
|
|
$this->originalTitle = $title;
|
|
|
|
}
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2012-06-23 01:52:08 +02:00
|
|
|
public function loadIDsByCommitPHIDs($phids) {
|
|
|
|
if (!$phids) {
|
|
|
|
return array();
|
|
|
|
}
|
|
|
|
$revision_ids = queryfx_all(
|
|
|
|
$this->establishConnection('r'),
|
|
|
|
'SELECT * FROM %T WHERE commitPHID IN (%Ls)',
|
|
|
|
self::TABLE_COMMIT,
|
|
|
|
$phids);
|
|
|
|
return ipull($revision_ids, 'revisionID', 'commitPHID');
|
|
|
|
}
|
|
|
|
|
2011-04-08 06:59:42 +02:00
|
|
|
public function loadCommitPHIDs() {
|
|
|
|
if (!$this->getID()) {
|
|
|
|
return ($this->commits = array());
|
|
|
|
}
|
|
|
|
|
|
|
|
$commits = queryfx_all(
|
|
|
|
$this->establishConnection('r'),
|
|
|
|
'SELECT commitPHID FROM %T WHERE revisionID = %d',
|
|
|
|
self::TABLE_COMMIT,
|
|
|
|
$this->getID());
|
|
|
|
$commits = ipull($commits, 'commitPHID');
|
|
|
|
|
|
|
|
return ($this->commits = $commits);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getCommitPHIDs() {
|
|
|
|
if ($this->commits === null) {
|
2011-12-21 02:05:52 +01:00
|
|
|
throw new Exception("Must attach commits first!");
|
2011-04-08 06:59:42 +02:00
|
|
|
}
|
|
|
|
return $this->commits;
|
|
|
|
}
|
|
|
|
|
2011-12-21 02:05:52 +01:00
|
|
|
public function getActiveDiff() {
|
|
|
|
// TODO: Because it's currently technically possible to create a revision
|
|
|
|
// without an associated diff, we allow an attached-but-null active diff.
|
|
|
|
// It would be good to get rid of this once we make diff-attaching
|
|
|
|
// transactional.
|
|
|
|
|
|
|
|
if ($this->activeDiff === false) {
|
|
|
|
throw new Exception("Must attach active diff first!");
|
|
|
|
}
|
|
|
|
return $this->activeDiff;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function attachActiveDiff($diff) {
|
|
|
|
$this->activeDiff = $diff;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getDiffIDs() {
|
|
|
|
if ($this->diffIDs === null) {
|
|
|
|
throw new Exception("Must attach diff IDs first!");
|
|
|
|
}
|
|
|
|
return $this->diffIDs;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function attachDiffIDs(array $ids) {
|
|
|
|
rsort($ids);
|
|
|
|
$this->diffIDs = array_values($ids);
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function attachCommitPHIDs(array $phids) {
|
|
|
|
$this->commits = array_values($phids);
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-02-17 23:32:01 +01:00
|
|
|
public function getAttachedPHIDs($type) {
|
|
|
|
return array_keys(idx($this->attached, $type, array()));
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setAttachedPHIDs($type, array $phids) {
|
|
|
|
$this->attached[$type] = array_fill_keys($phids, array());
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function generatePHID() {
|
2011-03-03 03:58:21 +01:00
|
|
|
return PhabricatorPHID::generateNewPHID(
|
|
|
|
PhabricatorPHIDConstants::PHID_TYPE_DREV);
|
2011-01-26 02:17:19 +01:00
|
|
|
}
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-01-27 23:55:52 +01:00
|
|
|
public function loadDiffs() {
|
|
|
|
if (!$this->getID()) {
|
|
|
|
return array();
|
|
|
|
}
|
|
|
|
return id(new DifferentialDiff())->loadAllWhere(
|
|
|
|
'revisionID = %d',
|
|
|
|
$this->getID());
|
|
|
|
}
|
|
|
|
|
2011-01-30 19:37:36 +01:00
|
|
|
public function loadComments() {
|
|
|
|
if (!$this->getID()) {
|
|
|
|
return array();
|
|
|
|
}
|
|
|
|
return id(new DifferentialComment())->loadAllWhere(
|
|
|
|
'revisionID = %d',
|
|
|
|
$this->getID());
|
|
|
|
}
|
|
|
|
|
2011-01-30 22:20:56 +01:00
|
|
|
public function loadActiveDiff() {
|
|
|
|
return id(new DifferentialDiff())->loadOneWhere(
|
|
|
|
'revisionID = %d ORDER BY id DESC LIMIT 1',
|
|
|
|
$this->getID());
|
|
|
|
}
|
2011-05-05 08:09:42 +02:00
|
|
|
|
|
|
|
public function save() {
|
|
|
|
if (!$this->getMailKey()) {
|
Replace callsites to sha1() that use it to asciify entropy with
Filesystem::readRandomCharacters()
Summary: See T547. To improve auditability of use of crypto-sensitive hash
functions, use Filesystem::readRandomCharacters() in place of
sha1(Filesystem::readRandomBytes()) when we're just generating random ASCII
strings.
Test Plan:
- Generated a new PHID.
- Logged out and logged back in (to test sessions).
- Regenerated Conduit certificate.
- Created a new task, verified mail key generated sensibly.
- Created a new revision, verified mail key generated sensibly.
- Ran "arc list", got blocked, installed new certificate, ran "arc list"
again.
Reviewers: jungejason, nh, tuomaspelkonen, aran, benmathews
Reviewed By: jungejason
CC: aran, epriestley, jungejason
Differential Revision: 1000
2011-10-11 04:22:30 +02:00
|
|
|
$this->mailKey = Filesystem::readRandomCharacters(40);
|
2011-05-05 08:09:42 +02:00
|
|
|
}
|
|
|
|
return parent::save();
|
|
|
|
}
|
2011-01-30 22:20:56 +01:00
|
|
|
|
2012-06-19 20:52:50 +02:00
|
|
|
public function delete() {
|
|
|
|
$this->openTransaction();
|
|
|
|
$diffs = $this->loadDiffs();
|
|
|
|
foreach ($diffs as $diff) {
|
|
|
|
$diff->delete();
|
|
|
|
}
|
|
|
|
|
|
|
|
$conn_w = $this->establishConnection('w');
|
|
|
|
|
|
|
|
queryfx(
|
|
|
|
$conn_w,
|
|
|
|
'DELETE FROM %T WHERE revisionID = %d',
|
|
|
|
self::RELATIONSHIP_TABLE,
|
|
|
|
$this->getID());
|
|
|
|
|
|
|
|
queryfx(
|
|
|
|
$conn_w,
|
|
|
|
'DELETE FROM %T WHERE revisionID = %d',
|
|
|
|
self::TABLE_COMMIT,
|
|
|
|
$this->getID());
|
|
|
|
|
|
|
|
$comments = id(new DifferentialComment())->loadAllWhere(
|
|
|
|
'revisionID = %d',
|
|
|
|
$this->getID());
|
|
|
|
foreach ($comments as $comment) {
|
|
|
|
$comment->delete();
|
|
|
|
}
|
|
|
|
|
|
|
|
$inlines = id(new DifferentialInlineComment())->loadAllWhere(
|
|
|
|
'revisionID = %d',
|
|
|
|
$this->getID());
|
|
|
|
foreach ($inlines as $inline) {
|
|
|
|
$inline->delete();
|
|
|
|
}
|
|
|
|
|
|
|
|
$fields = id(new DifferentialAuxiliaryField())->loadAllWhere(
|
|
|
|
'revisionPHID = %s',
|
|
|
|
$this->getPHID());
|
|
|
|
foreach ($fields as $field) {
|
|
|
|
$field->delete();
|
|
|
|
}
|
|
|
|
|
|
|
|
$paths = id(new DifferentialAffectedPath())->loadAllWhere(
|
|
|
|
'revisionID = %d',
|
|
|
|
$this->getID());
|
|
|
|
foreach ($paths as $path) {
|
|
|
|
$path->delete();
|
|
|
|
}
|
|
|
|
|
|
|
|
$result = parent::delete();
|
|
|
|
$this->saveTransaction();
|
|
|
|
return $result;
|
|
|
|
}
|
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function loadRelationships() {
|
2011-01-27 03:46:34 +01:00
|
|
|
if (!$this->getID()) {
|
|
|
|
$this->relationships = array();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
$data = queryfx_all(
|
|
|
|
$this->establishConnection('r'),
|
|
|
|
'SELECT * FROM %T WHERE revisionID = %d ORDER BY sequence',
|
|
|
|
self::RELATIONSHIP_TABLE,
|
|
|
|
$this->getID());
|
|
|
|
|
2011-10-02 20:42:41 +02:00
|
|
|
return $this->attachRelationships($data);
|
|
|
|
}
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-10-02 20:42:41 +02:00
|
|
|
public function attachRelationships(array $relationships) {
|
|
|
|
$this->relationships = igroup($relationships, 'relation');
|
2011-01-27 03:46:34 +01:00
|
|
|
return $this;
|
2011-01-26 02:17:19 +01:00
|
|
|
}
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function getReviewers() {
|
2011-01-27 03:46:34 +01:00
|
|
|
return $this->getRelatedPHIDs(self::RELATION_REVIEWER);
|
2011-01-26 02:17:19 +01:00
|
|
|
}
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function getCCPHIDs() {
|
2011-01-27 03:46:34 +01:00
|
|
|
return $this->getRelatedPHIDs(self::RELATION_SUBSCRIBED);
|
|
|
|
}
|
|
|
|
|
|
|
|
private function getRelatedPHIDs($relation) {
|
2011-02-03 02:38:03 +01:00
|
|
|
if ($this->relationships === null) {
|
2011-01-27 03:46:34 +01:00
|
|
|
throw new Exception("Must load relationships!");
|
|
|
|
}
|
2011-02-03 04:38:43 +01:00
|
|
|
|
2011-02-03 02:38:03 +01:00
|
|
|
return ipull($this->getRawRelations($relation), 'objectPHID');
|
2011-01-27 03:46:34 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function getRawRelations($relation) {
|
|
|
|
return idx($this->relationships, $relation, array());
|
|
|
|
}
|
2011-04-30 07:26:22 +02:00
|
|
|
|
|
|
|
public function getUnsubscribedPHIDs() {
|
|
|
|
return array_keys($this->getUnsubscribed());
|
|
|
|
}
|
2011-10-19 08:35:45 +02:00
|
|
|
|
2012-05-18 09:33:21 +02:00
|
|
|
public function getPrimaryReviewer() {
|
|
|
|
if (!$this->lastReviewerPHID) {
|
|
|
|
return head($this->getReviewers());
|
|
|
|
}
|
|
|
|
return $this->lastReviewerPHID;
|
|
|
|
}
|
|
|
|
|
2011-10-19 08:35:45 +02:00
|
|
|
public function loadReviewedBy() {
|
|
|
|
$reviewer = null;
|
|
|
|
|
2012-01-10 20:39:11 +01:00
|
|
|
if ($this->status == ArcanistDifferentialRevisionStatus::ACCEPTED ||
|
2012-04-24 02:40:57 +02:00
|
|
|
$this->status == ArcanistDifferentialRevisionStatus::CLOSED) {
|
2011-10-19 08:35:45 +02:00
|
|
|
$comments = $this->loadComments();
|
|
|
|
foreach ($comments as $comment) {
|
|
|
|
$action = $comment->getAction();
|
|
|
|
if ($action == DifferentialAction::ACTION_ACCEPT) {
|
|
|
|
$reviewer = $comment->getAuthorPHID();
|
|
|
|
} else if ($action == DifferentialAction::ACTION_REJECT ||
|
|
|
|
$action == DifferentialAction::ACTION_ABANDON ||
|
|
|
|
$action == DifferentialAction::ACTION_RETHINK) {
|
|
|
|
$reviewer = null;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return $reviewer;
|
|
|
|
}
|
2011-01-24 20:01:53 +01:00
|
|
|
}
|