2012-08-15 19:45:06 +02:00
|
|
|
/**
|
2013-09-09 23:14:34 +02:00
|
|
|
* @provides phui-object-item-list-view-css
|
2012-08-15 19:45:06 +02:00
|
|
|
*/
|
|
|
|
|
|
2015-01-14 01:28:55 +01:00
|
|
|
ul.phui-object-item-list-view {
|
2015-01-27 19:24:28 +01:00
|
|
|
padding: 8px;
|
2015-01-14 01:28:55 +01:00
|
|
|
list-style: none;
|
2012-08-15 19:45:06 +02:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.device-desktop .phui-object-item-list-view {
|
2014-01-21 23:23:36 +01:00
|
|
|
padding: 16px;
|
2013-01-19 03:08:06 +01:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-list-view + .phui-object-item-list-view {
|
Use ApplicationSearch in Differential
Summary:
Ref T603. Ref T2625. Fixes T3241. Depends on D5451. Depends on D6346.
@wez, this changes the Differential revision list UI substantially and may generate a lot of bikeshedding / who-moved-my-cheese churn. See T3417 for context, for example. The motivations for this change are:
- The list now works on devices, like phones and tablets. This is a requirement to make the rest of Differential work on devices.
- Although ApplicationSearch intentionally presents a simpler interface initially and some options which were one click away before aren't now, it is much more powerful than the search it replaces and allows users to build, save, share, fork, edit, and customize a much wider range of queries. Users who used the old filters frequently can use Advanced Search -> Save Custom Query to create new versions of them, and of any other query. "Edit Queries.." allows users to remove and reorder queries, including builtin queries. Basically, there are like three things which have gone from "1-click" to "a few clicks", and ten trillion things which have gone from "hard/impossible" to "relatively easy".
The local screenshots look a bit iffy, but I think a lot of this is the fakenesss of my test data. If they still feel iffy in production we can tweak them until they feel good, like we did for Maniphest.
Test Plan:
{F48477}
{F48478}
Reviewers: btrahan, chad, wez
Reviewed By: btrahan
CC: aran, s
Maniphest Tasks: T603, T2625, T3241
Differential Revision: https://secure.phabricator.com/D6347
2013-07-03 15:11:07 +02:00
|
|
|
padding-top: 0;
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-list-view.phui-object-list-flush {
|
2013-03-23 22:37:18 +01:00
|
|
|
padding: 0;
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
margin: 0;
|
2013-03-23 22:37:18 +01:00
|
|
|
}
|
|
|
|
|
|
[Redesign] Convert Dashboard Panels to ObjectBox
Summary: Moves Dashboard Panels to use PHUIObjectBoxView and PHUIHeaderView
Test Plan:
Tested the most common dashboards, Differential, Maniphest, Projects, Feed, Audit. Some edge cases (Legalpad, Macro) still are in progress. Tested laying out a new Dashboard, removing panels, moving panels.
{F406170}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D12873
2015-05-17 16:05:14 +02:00
|
|
|
.phui-object-box .phui-object-item-list-view .phui-object-item {
|
2015-01-28 00:30:11 +01:00
|
|
|
margin: 0;
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-01 23:45:56 +01:00
|
|
|
.phui-object-item-list-view .phui-info-view {
|
2015-02-12 13:58:20 +01:00
|
|
|
margin: 0;
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-01 23:45:56 +01:00
|
|
|
.phui-object-box .phui-object-item-list-view .phui-info-view {
|
2015-02-02 17:43:10 +01:00
|
|
|
margin: 4px 0;
|
2014-06-25 00:10:19 +02:00
|
|
|
color: {$greytext};
|
2015-02-02 17:43:10 +01:00
|
|
|
border: none;
|
[Rough Sketch] Differential ObjectItemView Smexyness
Summary:
Tried out `PhabricatorObjectItemView` for Differential. It looks smexy and smooth.
Refs T2014
- Title and Date as Maniphest
- Author in the handle icon
- Bar color reflects revision status (Needs Review, Accepted, Abandoned etc.) @chad looking for non-blue is faster than keeping watch for everything that's not "Closed" in old table form
- Some status information are in footer icons; currently only stale/old status display as well as saved drafts, maybe more in future; these come into my mind:
- No reviewer warning
- Push Blocking Priority (T2730)
- Trivial, fast review guaranteed
- Sketch / Just looking for advice/help
- Arcanist Project (T2614)
- Denote "Public Send-in" (T1476)
{F37662}
{F37663}
{F37664}
{F37665}
Some flaws:
- Date and reviewers on every entry the same?
- No respect for Differential fields (for some reason, every entry appeared the same, so broke it to parts)
- Plenty of (potential) increase in height - advise reducing paging length from 100 to 50 - or just ignore me
Suggestions for the future:
- Expand the meta information regarding revisions; e.g. the various status displays above
- Uh... T2543, T1279, T793, T731 and what else I want for Differential, because they are awesome!
- T793 should be in particular easy appearance-wise, just copy-paste from Maniphest
Test Plan: By looking at it, of course. Verified there are no errors or crashed
Reviewers: epriestley, chad, btrahan, liguobig
Reviewed By: chad
CC: aran, Korvin, edward, nh
Maniphest Tasks: T2014
Differential Revision: https://secure.phabricator.com/D5451
Conflicts:
src/__celerity_resource_map__.php
2013-07-02 21:14:33 +02:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item {
|
2012-12-13 19:59:29 +01:00
|
|
|
border-style: solid;
|
2013-09-02 17:10:47 +02:00
|
|
|
border-color: {$lightgreyborder};
|
2013-01-25 06:00:47 +01:00
|
|
|
margin: 5px 0;
|
2014-05-09 02:41:48 +02:00
|
|
|
overflow: hidden;
|
2014-08-08 23:07:50 +02:00
|
|
|
background: #fff;
|
2014-06-07 21:12:11 +02:00
|
|
|
margin-bottom: 4px;
|
2012-08-15 19:45:06 +02:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item .phui-icon-view {
|
2013-07-03 17:53:01 +02:00
|
|
|
display: inline-block;
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-frame {
|
2015-05-08 06:18:57 +02:00
|
|
|
border: 1px solid {$lightgreyborder};
|
2013-03-23 22:37:18 +01:00
|
|
|
position: relative;
|
2014-12-02 19:24:59 +01:00
|
|
|
min-height: 33px;
|
2014-05-09 02:41:48 +02:00
|
|
|
overflow: hidden;
|
2013-03-23 22:37:18 +01:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.device-desktop .phui-object-item {
|
2014-08-08 23:07:50 +02:00
|
|
|
margin: 0 0 4px 0;
|
2013-01-19 03:08:06 +01:00
|
|
|
}
|
|
|
|
|
|
2015-02-19 17:11:17 +01:00
|
|
|
.phui-object-box .phui-object-list-flush .phui-object-item {
|
|
|
|
|
margin: 0;
|
|
|
|
|
}
|
|
|
|
|
|
[Redesign] Convert Dashboard Panels to ObjectBox
Summary: Moves Dashboard Panels to use PHUIObjectBoxView and PHUIHeaderView
Test Plan:
Tested the most common dashboards, Differential, Maniphest, Projects, Feed, Audit. Some edge cases (Legalpad, Macro) still are in progress. Tested laying out a new Dashboard, removing panels, moving panels.
{F406170}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D12873
2015-05-17 16:05:14 +02:00
|
|
|
.phui-object-box .phui-object-item-list-view {
|
|
|
|
|
margin: 0;
|
|
|
|
|
}
|
|
|
|
|
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
.phui-object-item-status-icon {
|
|
|
|
|
font-weight: bold;
|
2015-05-23 20:01:29 +02:00
|
|
|
padding: 3px;
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
font-size: 16px;
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-name {
|
2015-05-19 15:40:08 +02:00
|
|
|
font-weight: 500;
|
2014-12-02 19:24:59 +01:00
|
|
|
padding: 8px 8px 0;
|
2013-04-06 20:38:43 +02:00
|
|
|
white-space: nowrap;
|
2014-12-02 19:24:59 +01:00
|
|
|
word-wrap: break-word;
|
|
|
|
|
overflow: hidden;
|
|
|
|
|
text-overflow: ellipsis;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.device-phone .phui-object-item-name {
|
|
|
|
|
overflow: normal;
|
|
|
|
|
white-space: normal;
|
2015-05-19 15:40:08 +02:00
|
|
|
font-weight: bold;
|
2013-03-23 22:37:18 +01:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-link {
|
2014-12-02 19:24:59 +01:00
|
|
|
display: inline;
|
2013-03-23 22:37:18 +01:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-objname {
|
2015-05-19 17:26:22 +02:00
|
|
|
color: {$darkbluetext};
|
2013-03-23 22:38:01 +01:00
|
|
|
cursor: text;
|
2015-05-19 17:26:22 +02:00
|
|
|
font-weight: bold;
|
2012-08-15 19:45:06 +02:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-content {
|
2014-12-02 19:24:59 +01:00
|
|
|
margin: 4px 8px 2px 0;
|
2012-12-17 17:26:44 +01:00
|
|
|
overflow: hidden;
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-grippable {
|
2013-03-23 22:37:18 +01:00
|
|
|
cursor: move;
|
|
|
|
|
}
|
|
|
|
|
|
2014-12-02 19:24:59 +01:00
|
|
|
.device .phui-object-item-grippable {
|
|
|
|
|
cursor: normal;
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-grip {
|
2013-03-23 22:37:18 +01:00
|
|
|
position: absolute;
|
|
|
|
|
top: 0;
|
|
|
|
|
bottom: 0;
|
|
|
|
|
left: 0;
|
2015-05-23 20:01:29 +02:00
|
|
|
width: 16px;
|
2013-09-09 23:14:34 +02:00
|
|
|
background: url('/rsrc/image/texture/grip.png') center center no-repeat;
|
2013-03-23 22:37:18 +01:00
|
|
|
}
|
|
|
|
|
|
2014-12-02 19:24:59 +01:00
|
|
|
.device .phui-object-item-grip {
|
|
|
|
|
display: none;
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-grippable .phui-object-item-frame {
|
2015-05-23 20:01:29 +02:00
|
|
|
padding-left: 16px;
|
2013-03-23 22:37:18 +01:00
|
|
|
}
|
|
|
|
|
|
2014-12-02 19:24:59 +01:00
|
|
|
.device .phui-object-item-grippable .phui-object-item-frame {
|
|
|
|
|
padding-left: 0;
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-list-header {
|
Use ApplicationSearch in Differential
Summary:
Ref T603. Ref T2625. Fixes T3241. Depends on D5451. Depends on D6346.
@wez, this changes the Differential revision list UI substantially and may generate a lot of bikeshedding / who-moved-my-cheese churn. See T3417 for context, for example. The motivations for this change are:
- The list now works on devices, like phones and tablets. This is a requirement to make the rest of Differential work on devices.
- Although ApplicationSearch intentionally presents a simpler interface initially and some options which were one click away before aren't now, it is much more powerful than the search it replaces and allows users to build, save, share, fork, edit, and customize a much wider range of queries. Users who used the old filters frequently can use Advanced Search -> Save Custom Query to create new versions of them, and of any other query. "Edit Queries.." allows users to remove and reorder queries, including builtin queries. Basically, there are like three things which have gone from "1-click" to "a few clicks", and ten trillion things which have gone from "hard/impossible" to "relatively easy".
The local screenshots look a bit iffy, but I think a lot of this is the fakenesss of my test data. If they still feel iffy in production we can tweak them until they feel good, like we did for Maniphest.
Test Plan:
{F48477}
{F48478}
Reviewers: btrahan, chad, wez
Reviewed By: btrahan
CC: aran, s
Maniphest Tasks: T603, T2625, T3241
Differential Revision: https://secure.phabricator.com/D6347
2013-07-03 15:11:07 +02:00
|
|
|
padding: 0 0 8px 0;
|
2013-09-07 18:13:55 +02:00
|
|
|
color: {$darkgreytext};
|
Use ApplicationSearch in Differential
Summary:
Ref T603. Ref T2625. Fixes T3241. Depends on D5451. Depends on D6346.
@wez, this changes the Differential revision list UI substantially and may generate a lot of bikeshedding / who-moved-my-cheese churn. See T3417 for context, for example. The motivations for this change are:
- The list now works on devices, like phones and tablets. This is a requirement to make the rest of Differential work on devices.
- Although ApplicationSearch intentionally presents a simpler interface initially and some options which were one click away before aren't now, it is much more powerful than the search it replaces and allows users to build, save, share, fork, edit, and customize a much wider range of queries. Users who used the old filters frequently can use Advanced Search -> Save Custom Query to create new versions of them, and of any other query. "Edit Queries.." allows users to remove and reorder queries, including builtin queries. Basically, there are like three things which have gone from "1-click" to "a few clicks", and ten trillion things which have gone from "hard/impossible" to "relatively easy".
The local screenshots look a bit iffy, but I think a lot of this is the fakenesss of my test data. If they still feel iffy in production we can tweak them until they feel good, like we did for Maniphest.
Test Plan:
{F48477}
{F48478}
Reviewers: btrahan, chad, wez
Reviewed By: btrahan
CC: aran, s
Maniphest Tasks: T603, T2625, T3241
Differential Revision: https://secure.phabricator.com/D6347
2013-07-03 15:11:07 +02:00
|
|
|
}
|
|
|
|
|
|
2014-12-02 19:24:59 +01:00
|
|
|
.phui-object-item-table {
|
|
|
|
|
display: table;
|
|
|
|
|
table-layout: fixed;
|
|
|
|
|
width: 100%;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-table-row {
|
|
|
|
|
display: table-row;
|
|
|
|
|
}
|
|
|
|
|
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
.phui-object-item-col0 {
|
2015-05-23 20:01:29 +02:00
|
|
|
width: 20px;
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
display: table-cell;
|
|
|
|
|
vertical-align: middle;
|
|
|
|
|
}
|
|
|
|
|
|
[Redesign] Mobile/Phone design pass
Summary: Ref T8099, Quick descent pass at making header, object lists, tables, filter view, mobile friendly.
Test Plan:
Test home, differential diff, maniphest task, new task, search, and a few other views.
{F414034}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D12984
2015-05-23 02:52:51 +02:00
|
|
|
.device-phone .phui-object-item-col0 {
|
|
|
|
|
vertical-align: top;
|
|
|
|
|
padding-top: 8px;
|
|
|
|
|
}
|
|
|
|
|
|
2014-12-02 19:24:59 +01:00
|
|
|
.phui-object-item-col1 {
|
|
|
|
|
display: table-cell;
|
|
|
|
|
vertical-align: top;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-col2 {
|
|
|
|
|
width: 160px;
|
|
|
|
|
display: table-cell;
|
|
|
|
|
vertical-align: top;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.device-phone .phui-object-item-col1,
|
|
|
|
|
.device-phone .phui-object-item-col2 {
|
|
|
|
|
display: block;
|
|
|
|
|
width: auto;
|
|
|
|
|
}
|
|
|
|
|
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
/* - Item Actions --------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
Action buttons, like "Edit" and "Delete".
|
|
|
|
|
|
|
|
|
|
*/
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-actions {
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
position: absolute;
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
right: 4px;
|
|
|
|
|
top: 4px;
|
|
|
|
|
bottom: 4px;
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
vertical-align: middle;
|
|
|
|
|
text-align: right;
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-actions .phui-list-item-view {
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
float: right;
|
|
|
|
|
height: 100%;
|
|
|
|
|
width: 24px;
|
|
|
|
|
display: inline-block;
|
|
|
|
|
position: relative;
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-actions .phui-list-item-href {
|
2013-06-05 17:41:43 +02:00
|
|
|
display: inline-block;
|
|
|
|
|
position: relative;
|
|
|
|
|
width: 24px;
|
|
|
|
|
height: 100%;
|
|
|
|
|
}
|
|
|
|
|
|
2014-12-02 19:24:59 +01:00
|
|
|
.device-desktop .phui-object-item-actions .phui-list-item-href:hover {
|
2014-06-07 20:28:37 +02:00
|
|
|
background: {$hoverblue};
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
border-radius: 3px;
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-actions .phui-list-item-icon {
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
width: 14px;
|
|
|
|
|
height: 14px;
|
|
|
|
|
position: absolute;
|
|
|
|
|
display: block;
|
|
|
|
|
top: 50%;
|
|
|
|
|
margin-top: -7px;
|
2014-05-12 19:08:32 +02:00
|
|
|
left: 3px;
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-actions .phui-list-item-name {
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
display: none;
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-with-1-actions .phui-object-item-content-box {
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
margin-right: 24px;
|
2013-10-08 23:35:56 +02:00
|
|
|
overflow: hidden;
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-with-2-actions .phui-object-item-content-box {
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
margin-right: 48px;
|
2013-10-08 23:35:56 +02:00
|
|
|
overflow: hidden;
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-with-3-actions .phui-object-item-content-box {
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
margin-right: 72px;
|
2013-10-08 23:35:56 +02:00
|
|
|
overflow: hidden;
|
Add action icons to object list views
Summary:
We have a few interfaces where add "Edit", "Delete" or some other action to a list. Currently, this happens via icons, but these are cumbersome and weird, are inconsistent, can't be workflow'd, are hard to hit on desktops and virtually impossible to hit on mobile, and generally just feel iffy to me. Prominent examples are Projects and Flags. I'd like to try adding an "edit" action to Maniphest (to provide quick edit from list views, basically). It looks like some of Releeph would benefit here, as well.
Instead, provide first-class actions:
{F42978}
They produce targets which my meaty ham-fists can plausibly hit on mobile, too:
{F42979}
(We could do some kind of swipe-to-expose thing eventually, but I think putting them by default is OK?)
Test Plan: Added UIExamples. Checked desktop/mobile.
Reviewers: chad, btrahan, edward
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D5890
2013-05-10 21:57:01 +02:00
|
|
|
}
|
|
|
|
|
|
2013-03-10 02:55:01 +01:00
|
|
|
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
/* - Object Box List -----------------------------------------------------------
|
2013-03-10 02:55:01 +01:00
|
|
|
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
Tighter, stacking list when inside an Object Box
|
2013-03-10 02:55:01 +01:00
|
|
|
|
|
|
|
|
*/
|
|
|
|
|
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
.phui-object-box .phui-object-item-list-view {
|
2014-06-07 20:28:37 +02:00
|
|
|
padding: 0;
|
|
|
|
|
border: none;
|
|
|
|
|
}
|
|
|
|
|
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
.phui-object-box .phui-object-item-frame {
|
2014-06-07 20:28:37 +02:00
|
|
|
border-right: none;
|
|
|
|
|
}
|
|
|
|
|
|
2015-05-07 23:11:44 +02:00
|
|
|
.phui-object-box .phui-object-item:last-child
|
2014-12-30 11:48:26 +01:00
|
|
|
.phui-object-item-frame {
|
2014-06-07 20:28:37 +02:00
|
|
|
border-bottom: none;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
2013-05-06 23:01:57 +02:00
|
|
|
/* - Subhead -------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
Descriptive Text or Links under the main header, before attributes.
|
|
|
|
|
|
|
|
|
|
*/
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-subhead {
|
2013-09-02 17:10:47 +02:00
|
|
|
color: {$greytext};
|
2013-05-06 23:01:57 +02:00
|
|
|
padding: 0 8px 6px;
|
|
|
|
|
}
|
|
|
|
|
|
2013-03-10 02:55:01 +01:00
|
|
|
|
2012-12-17 17:26:44 +01:00
|
|
|
/* - Attribute List ------------------------------------------------------------
|
2012-12-13 19:59:29 +01:00
|
|
|
|
|
|
|
|
Object attributes, commonly used to render created date, etc.
|
|
|
|
|
|
|
|
|
|
*/
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-attributes {
|
2013-04-03 17:28:22 +02:00
|
|
|
padding: 0 8px 6px;
|
2014-12-02 19:24:59 +01:00
|
|
|
line-height: 18px;
|
2012-12-13 19:59:29 +01:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-attribute {
|
2012-12-13 19:59:29 +01:00
|
|
|
display: inline;
|
2013-09-02 17:10:47 +02:00
|
|
|
color: {$greytext};
|
2012-12-13 19:59:29 +01:00
|
|
|
}
|
2012-08-15 19:45:06 +02:00
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-attribute-spacer {
|
2012-12-13 19:59:29 +01:00
|
|
|
padding: 0 4px;
|
2012-08-15 19:45:06 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
2012-12-17 17:26:44 +01:00
|
|
|
/* - Icons ---------------------------------------------------------------------
|
2012-12-13 19:59:29 +01:00
|
|
|
|
2012-12-17 17:26:44 +01:00
|
|
|
Icons, which show object state. On mobile, they are rendered without labels
|
|
|
|
|
to save space.
|
2012-08-15 19:45:06 +02:00
|
|
|
|
|
|
|
|
*/
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-icon-pane {
|
2014-12-02 19:24:59 +01:00
|
|
|
margin: 8px 0 4px;
|
2013-04-06 20:38:43 +02:00
|
|
|
}
|
|
|
|
|
|
2014-12-02 19:24:59 +01:00
|
|
|
.device-phone .phui-object-icon-pane {
|
|
|
|
|
margin: 0 0 4px;
|
2013-03-23 22:37:18 +01:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-with-handle-icons .phui-object-item-icons {
|
2013-03-25 20:20:49 +01:00
|
|
|
padding-bottom: 30px;
|
2013-03-23 22:37:18 +01:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-icons {
|
2014-12-02 19:24:59 +01:00
|
|
|
padding: 0 10px 0 0;
|
2012-08-15 19:45:06 +02:00
|
|
|
}
|
|
|
|
|
|
2014-12-02 19:24:59 +01:00
|
|
|
.device-phone .phui-object-item-icons {
|
|
|
|
|
padding: 0 0 0 8px;
|
2012-08-15 19:45:06 +02:00
|
|
|
}
|
|
|
|
|
|
2014-12-02 19:24:59 +01:00
|
|
|
ul.phui-object-item-icons {
|
|
|
|
|
margin: 0;
|
2012-12-13 19:59:29 +01:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-icon {
|
2013-03-23 22:37:18 +01:00
|
|
|
vertical-align: middle;
|
2014-04-10 20:23:38 +02:00
|
|
|
font-size: 12px;
|
2015-05-19 15:40:08 +02:00
|
|
|
color: {$greytext};
|
2012-08-15 19:45:06 +02:00
|
|
|
text-align: right;
|
2012-12-13 19:59:29 +01:00
|
|
|
white-space: nowrap;
|
2012-08-15 19:45:06 +02:00
|
|
|
overflow: hidden;
|
2012-12-13 19:59:29 +01:00
|
|
|
min-height: 18px;
|
|
|
|
|
line-height: 18px;
|
2012-08-15 19:45:06 +02:00
|
|
|
}
|
|
|
|
|
|
2014-12-02 19:24:59 +01:00
|
|
|
.device-phone .phui-object-item-icon {
|
|
|
|
|
text-align: left;
|
|
|
|
|
font-size: 13px;
|
|
|
|
|
}
|
|
|
|
|
|
[Rough Sketch] Differential ObjectItemView Smexyness
Summary:
Tried out `PhabricatorObjectItemView` for Differential. It looks smexy and smooth.
Refs T2014
- Title and Date as Maniphest
- Author in the handle icon
- Bar color reflects revision status (Needs Review, Accepted, Abandoned etc.) @chad looking for non-blue is faster than keeping watch for everything that's not "Closed" in old table form
- Some status information are in footer icons; currently only stale/old status display as well as saved drafts, maybe more in future; these come into my mind:
- No reviewer warning
- Push Blocking Priority (T2730)
- Trivial, fast review guaranteed
- Sketch / Just looking for advice/help
- Arcanist Project (T2614)
- Denote "Public Send-in" (T1476)
{F37662}
{F37663}
{F37664}
{F37665}
Some flaws:
- Date and reviewers on every entry the same?
- No respect for Differential fields (for some reason, every entry appeared the same, so broke it to parts)
- Plenty of (potential) increase in height - advise reducing paging length from 100 to 50 - or just ignore me
Suggestions for the future:
- Expand the meta information regarding revisions; e.g. the various status displays above
- Uh... T2543, T1279, T793, T731 and what else I want for Differential, because they are awesome!
- T793 should be in particular easy appearance-wise, just copy-paste from Maniphest
Test Plan: By looking at it, of course. Verified there are no errors or crashed
Reviewers: epriestley, chad, btrahan, liguobig
Reviewed By: chad
CC: aran, Korvin, edward, nh
Maniphest Tasks: T2014
Differential Revision: https://secure.phabricator.com/D5451
Conflicts:
src/__celerity_resource_map__.php
2013-07-02 21:14:33 +02:00
|
|
|
/*
|
|
|
|
|
* Items with icon 'none' still have on mobile, thus creating a weird vertical
|
|
|
|
|
* margin for elements which follow
|
|
|
|
|
*/
|
2014-12-02 19:24:59 +01:00
|
|
|
.device-phone .phui-object-item-icon .none {
|
[Rough Sketch] Differential ObjectItemView Smexyness
Summary:
Tried out `PhabricatorObjectItemView` for Differential. It looks smexy and smooth.
Refs T2014
- Title and Date as Maniphest
- Author in the handle icon
- Bar color reflects revision status (Needs Review, Accepted, Abandoned etc.) @chad looking for non-blue is faster than keeping watch for everything that's not "Closed" in old table form
- Some status information are in footer icons; currently only stale/old status display as well as saved drafts, maybe more in future; these come into my mind:
- No reviewer warning
- Push Blocking Priority (T2730)
- Trivial, fast review guaranteed
- Sketch / Just looking for advice/help
- Arcanist Project (T2614)
- Denote "Public Send-in" (T1476)
{F37662}
{F37663}
{F37664}
{F37665}
Some flaws:
- Date and reviewers on every entry the same?
- No respect for Differential fields (for some reason, every entry appeared the same, so broke it to parts)
- Plenty of (potential) increase in height - advise reducing paging length from 100 to 50 - or just ignore me
Suggestions for the future:
- Expand the meta information regarding revisions; e.g. the various status displays above
- Uh... T2543, T1279, T793, T731 and what else I want for Differential, because they are awesome!
- T793 should be in particular easy appearance-wise, just copy-paste from Maniphest
Test Plan: By looking at it, of course. Verified there are no errors or crashed
Reviewers: epriestley, chad, btrahan, liguobig
Reviewed By: chad
CC: aran, Korvin, edward, nh
Maniphest Tasks: T2014
Differential Revision: https://secure.phabricator.com/D5451
Conflicts:
src/__celerity_resource_map__.php
2013-07-02 21:14:33 +02:00
|
|
|
display: none;
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-icon-image {
|
2012-12-13 19:59:29 +01:00
|
|
|
width: 14px;
|
|
|
|
|
height: 14px;
|
2014-05-12 19:08:32 +02:00
|
|
|
font-size: 13px;
|
2014-12-02 19:24:59 +01:00
|
|
|
margin-right: 4px;
|
2012-08-15 19:45:06 +02:00
|
|
|
}
|
|
|
|
|
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
/* - Bar Colors ----------------------------------------------------------------
|
|
|
|
|
Colors for the left-hand border bars, used to indicate object status or other
|
|
|
|
|
attributes.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
.phui-workboard-view .phui-object-item {
|
|
|
|
|
border-left-width: 4px;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item {
|
|
|
|
|
border-left-width: 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-bar-color-red {
|
|
|
|
|
border-left-color: {$red};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-bar-color-orange {
|
|
|
|
|
border-left-color: {$orange};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-bar-color-yellow {
|
|
|
|
|
border-left-color: {$yellow};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-bar-color-green {
|
|
|
|
|
border-left-color: {$green};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-bar-color-sky {
|
|
|
|
|
border-left-color: {$sky};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-bar-color-blue {
|
|
|
|
|
border-left-color: {$blue};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-bar-color-indigo {
|
|
|
|
|
border-left-color: {$indigo};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-bar-color-violet {
|
|
|
|
|
border-left-color: {$violet};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-bar-color-grey {
|
|
|
|
|
border-left-color: #bdc3c7;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-bar-color-black {
|
|
|
|
|
border-left-color: #333333;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
2013-07-12 20:31:20 +02:00
|
|
|
/* - Disabled ------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
Disabled/inactive objects.
|
|
|
|
|
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
|
2013-12-05 05:45:23 +01:00
|
|
|
.phui-object-item-disabled .phui-object-item-link,
|
|
|
|
|
.phui-object-item-disabled .phui-object-item-link a {
|
|
|
|
|
color: {$lightgreytext};
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-disabled .phui-object-item-frame {
|
2013-07-12 20:31:20 +02:00
|
|
|
border-color: #d7d7d7;
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-disabled .phui-object-item-objname {
|
2013-09-02 17:10:47 +02:00
|
|
|
color: {$greytext};
|
2013-12-05 05:45:23 +01:00
|
|
|
text-decoration: line-through;
|
2013-07-12 20:31:20 +02:00
|
|
|
}
|
|
|
|
|
|
2012-12-17 01:33:02 +01:00
|
|
|
|
|
|
|
|
/* - Effects -------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
Effects like highlighted items.
|
|
|
|
|
|
|
|
|
|
*/
|
|
|
|
|
|
2014-10-22 01:38:18 +02:00
|
|
|
.phui-object-item.phui-object-item-highlighted {
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
background: {$sh-yellowbackground};
|
2013-06-12 05:53:55 +02:00
|
|
|
}
|
|
|
|
|
|
2015-05-19 15:40:08 +02:00
|
|
|
ul.phui-object-item-list-view .phui-object-item-highlighted
|
|
|
|
|
.phui-object-item-frame {
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
border-color: {$sh-yellowborder};
|
2013-03-10 02:55:01 +01:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-selected {
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
background: {$sh-bluebackground};
|
2014-06-07 21:12:11 +02:00
|
|
|
}
|
|
|
|
|
|
2015-05-19 15:40:08 +02:00
|
|
|
ul.phui-object-item-list-view .phui-object-item-selected
|
|
|
|
|
.phui-object-item-frame {
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
border-color: {$sh-blueborder};
|
2013-03-10 02:55:01 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
/* - Foot Icons ----------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
Object counts shown in the footer.
|
|
|
|
|
|
|
|
|
|
*/
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-foot-icons {
|
2013-03-10 02:55:01 +01:00
|
|
|
margin-left: 10px;
|
2013-03-23 22:37:18 +01:00
|
|
|
bottom: 0;
|
|
|
|
|
position: absolute;
|
|
|
|
|
}
|
|
|
|
|
|
2014-12-02 19:24:59 +01:00
|
|
|
.phui-object-item-with-foot-icons .phui-object-item-content,
|
|
|
|
|
.device-phone .phui-object-item-with-foot-icons .phui-object-item-col2 {
|
|
|
|
|
padding-bottom: 24px;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.device-phone .phui-object-item-with-foot-icons .phui-object-item-content {
|
|
|
|
|
padding-bottom: 0;
|
2013-03-10 02:55:01 +01:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-foot-icon {
|
2013-03-10 02:55:01 +01:00
|
|
|
display: inline-block;
|
2014-12-02 19:24:59 +01:00
|
|
|
background: {$lightgreyborder};
|
2013-03-10 02:55:01 +01:00
|
|
|
color: #ffffff;
|
|
|
|
|
font-weight: bold;
|
|
|
|
|
margin-right: 3px;
|
2014-05-12 19:08:32 +02:00
|
|
|
padding: 3px 6px 0;
|
|
|
|
|
height: 17px;
|
2013-03-10 02:55:01 +01:00
|
|
|
vertical-align: middle;
|
|
|
|
|
position: relative;
|
2014-05-12 19:08:32 +02:00
|
|
|
font-size: 12px;
|
|
|
|
|
-webkit-font-smoothing: antialiased;
|
2013-03-10 02:55:01 +01:00
|
|
|
}
|
|
|
|
|
|
2014-05-12 19:08:32 +02:00
|
|
|
.phui-object-item-foot-icon .phui-icon-view {
|
|
|
|
|
margin-right: 4px;
|
2013-03-10 02:55:01 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
/* - Handle Icons --------------------------------------------------------------
|
|
|
|
|
|
2013-04-06 20:38:43 +02:00
|
|
|
Shows owners, reviewers, etc., using profile picture icons.
|
2013-03-10 02:55:01 +01:00
|
|
|
|
|
|
|
|
*/
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-handle-icons {
|
2013-03-10 02:55:01 +01:00
|
|
|
height: 28px;
|
|
|
|
|
margin-right: 10px;
|
2013-03-23 22:37:18 +01:00
|
|
|
bottom: 0;
|
|
|
|
|
right: 0;
|
|
|
|
|
text-align: right;
|
|
|
|
|
position: absolute;
|
2013-03-10 02:55:01 +01:00
|
|
|
}
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-handle-icon {
|
2013-05-31 17:40:03 +02:00
|
|
|
margin: 1px;
|
2013-03-10 02:55:01 +01:00
|
|
|
width: 28px;
|
|
|
|
|
height: 28px;
|
|
|
|
|
display: inline-block;
|
|
|
|
|
background-size: 28px 28px;
|
|
|
|
|
background-repeat: no-repeat;
|
2012-12-17 01:33:02 +01:00
|
|
|
}
|
2013-03-23 22:37:18 +01:00
|
|
|
|
|
|
|
|
|
2013-04-06 20:38:43 +02:00
|
|
|
/* - Bylines -------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
Shows owners, authors, reviewers, etc., in text.
|
|
|
|
|
|
|
|
|
|
*/
|
|
|
|
|
|
2013-09-09 23:14:34 +02:00
|
|
|
.phui-object-item-bylines {
|
2013-04-06 20:38:43 +02:00
|
|
|
padding: 0 10px;
|
2015-01-02 20:39:12 +01:00
|
|
|
margin: 4px 0 8px;
|
2014-04-10 20:23:38 +02:00
|
|
|
font-size: 12px;
|
2015-05-19 15:40:08 +02:00
|
|
|
color: {$greytext};
|
2014-12-02 19:24:59 +01:00
|
|
|
text-align: right;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-byline {
|
2013-04-06 20:38:43 +02:00
|
|
|
white-space: nowrap;
|
2014-12-02 19:24:59 +01:00
|
|
|
text-overflow: ellipsis;
|
2013-04-06 20:38:43 +02:00
|
|
|
overflow: hidden;
|
|
|
|
|
}
|
|
|
|
|
|
2014-04-10 20:23:38 +02:00
|
|
|
.device-phone .phui-object-item-bylines {
|
|
|
|
|
float: none;
|
|
|
|
|
text-align: left;
|
|
|
|
|
padding: 0 8px;
|
|
|
|
|
font-size: 13px;
|
|
|
|
|
}
|
|
|
|
|
|
2013-06-06 01:22:27 +02:00
|
|
|
|
2013-06-06 02:36:33 +02:00
|
|
|
/* - Draggable List ------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
These classes are applied by and/or provided for use with JX.DraggableList.
|
|
|
|
|
|
|
|
|
|
*/
|
|
|
|
|
|
2013-06-06 01:22:27 +02:00
|
|
|
.drag-ghost {
|
|
|
|
|
position: relative;
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
background: {$lightgreybackground};
|
2014-01-21 23:26:05 +01:00
|
|
|
margin-bottom: 4px;
|
2013-06-06 01:22:27 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.drag-dragging {
|
|
|
|
|
position: relative;
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
background: {$sh-bluebackground};
|
|
|
|
|
opacity: 0.9;
|
2013-06-06 01:22:27 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.drag-sending {
|
2014-06-07 20:28:37 +02:00
|
|
|
opacity: 0.5;
|
2013-06-06 01:22:27 +02:00
|
|
|
}
|
2013-09-09 23:14:34 +02:00
|
|
|
|
2014-04-29 19:14:18 +02:00
|
|
|
/* - State ---------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
Provides a list of object status or states, success or fail, etc
|
|
|
|
|
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
.phui-object-item-ficon {
|
2015-01-27 21:25:54 +01:00
|
|
|
width: 48px;
|
2014-04-29 19:14:18 +02:00
|
|
|
height: 26px;
|
2015-01-27 21:25:54 +01:00
|
|
|
margin-top: 12px;
|
2014-04-29 19:14:18 +02:00
|
|
|
position: absolute;
|
2015-01-27 21:25:54 +01:00
|
|
|
text-align: center;
|
|
|
|
|
font-size: 24px;
|
2014-05-01 18:35:14 +02:00
|
|
|
}
|
|
|
|
|
|
2014-04-29 19:14:18 +02:00
|
|
|
.phui-object-item-with-ficon .phui-object-item-content-box {
|
2014-05-01 18:35:14 +02:00
|
|
|
margin-left: 38px;
|
2014-04-29 19:14:18 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-box .phui-object-list-states {
|
2014-05-01 18:35:14 +02:00
|
|
|
padding: 0;
|
2014-04-29 19:14:18 +02:00
|
|
|
}
|
|
|
|
|
|
2015-03-01 23:45:56 +01:00
|
|
|
.phui-object-list-states .phui-info-view {
|
2014-05-02 23:25:58 +02:00
|
|
|
margin: 0;
|
|
|
|
|
border: none;
|
|
|
|
|
}
|
|
|
|
|
|
2014-05-23 22:44:51 +02:00
|
|
|
/* - Dashboards ------------------------------------------------------------ */
|
|
|
|
|
|
[Redesign] New PHUIObjectItemListView
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
- Remove FootIcons
- Remove Stackable
- Remove Plain List
- Add StatusIcon
- Add setting ObjectList to an ObjectBox
- Minor retouches to Headers
Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12865
2015-05-15 22:28:59 +02:00
|
|
|
.phui-object-box .phui-object-item-list-view .phui-object-item-frame {
|
2014-05-24 06:48:15 +02:00
|
|
|
border: none;
|
|
|
|
|
border-bottom: 1px solid {$thinblueborder};
|
2014-05-23 22:44:51 +02:00
|
|
|
}
|
2014-05-29 21:17:54 +02:00
|
|
|
|
2015-05-28 20:32:51 +02:00
|
|
|
.phui-object-box .phui-object-item-list-header {
|
2014-06-25 00:10:19 +02:00
|
|
|
font-size: 13px;
|
|
|
|
|
color: {$bluetext};
|
[Redesign] Convert Dashboard Panels to ObjectBox
Summary: Moves Dashboard Panels to use PHUIObjectBoxView and PHUIHeaderView
Test Plan:
Tested the most common dashboards, Differential, Maniphest, Projects, Feed, Audit. Some edge cases (Legalpad, Macro) still are in progress. Tested laying out a new Dashboard, removing panels, moving panels.
{F406170}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D12873
2015-05-17 16:05:14 +02:00
|
|
|
border-top: 1px solid {$thinblueborder};
|
2014-06-25 00:10:19 +02:00
|
|
|
border-bottom: 1px solid {$thinblueborder};
|
2015-05-18 19:00:15 +02:00
|
|
|
padding: 8px 4px;
|
[Redesign] Convert Dashboard Panels to ObjectBox
Summary: Moves Dashboard Panels to use PHUIObjectBoxView and PHUIHeaderView
Test Plan:
Tested the most common dashboards, Differential, Maniphest, Projects, Feed, Audit. Some edge cases (Legalpad, Macro) still are in progress. Tested laying out a new Dashboard, removing panels, moving panels.
{F406170}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D12873
2015-05-17 16:05:14 +02:00
|
|
|
font-weight: 500;
|
2014-06-25 00:10:19 +02:00
|
|
|
}
|
|
|
|
|
|
2015-05-28 20:32:51 +02:00
|
|
|
.phui-object-box .phui-header-shell + .phui-object-item-list-view
|
|
|
|
|
.phui-object-item-list-header,
|
|
|
|
|
.phui-object-box .phui-object-box-hidden-content + .phui-object-item-list-view
|
[Redesign] Convert Dashboard Panels to ObjectBox
Summary: Moves Dashboard Panels to use PHUIObjectBoxView and PHUIHeaderView
Test Plan:
Tested the most common dashboards, Differential, Maniphest, Projects, Feed, Audit. Some edge cases (Legalpad, Macro) still are in progress. Tested laying out a new Dashboard, removing panels, moving panels.
{F406170}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D12873
2015-05-17 16:05:14 +02:00
|
|
|
.phui-object-item-list-header {
|
|
|
|
|
border-top: none;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.dashboard-pane .phui-object-item-empty .phui-info-view {
|
2014-06-25 00:10:19 +02:00
|
|
|
border: none;
|
Fix outlier dashboard panel display bugs
Summary: ref T7236, should resolve all, or at least most issues.
Test Plan: Tested Legalpad, Account Activity, Feed, Maniphest, Differential, Projects, Countdown
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T7236
Differential Revision: https://secure.phabricator.com/D11738
2015-02-11 16:05:28 +01:00
|
|
|
margin: 0;
|
2014-06-25 00:10:19 +02:00
|
|
|
}
|
|
|
|
|
|
2014-12-10 20:40:56 +01:00
|
|
|
.device-desktop .aphront-multi-column-fluid .aphront-multi-column-2-up
|
|
|
|
|
.aphront-multi-column-column-outer.third .phui-object-item-col2 {
|
|
|
|
|
display: none;
|
|
|
|
|
}
|
|
|
|
|
|
2014-05-29 21:17:54 +02:00
|
|
|
|
|
|
|
|
/* - Launcher List ---------------------------------------------------------- */
|
|
|
|
|
|
|
|
|
|
.launcher-header {
|
[Redesign] Put all ApplicationSearch results in an ObjectBox
Summary:
Ref T8099. In most cases we return either an ObjectList or AphrontTable, and can pretty up the UI in ApplicationSearch. There are a few edge cases, like PeopleUserLog, that can be cleanup up individually in the future, but look fine for now.
Also added 'setNotice' for AphrontTable for a few cases where we want to convey addtional information.
TODO: Seems we always pass a Pager Object, which tries to get displayed, I'll redesign that interaction in the future, probably by passing the Pager to the ObjectBox
Test Plan: Went throught most/all ApplicationSearch panels I could find, even edge cases look better.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D12989
2015-05-24 18:13:58 +02:00
|
|
|
padding: 8px 4px;
|
|
|
|
|
font-weight: 500;
|
|
|
|
|
color: {$blue};
|
|
|
|
|
font-size: 13px;
|
|
|
|
|
border-top: 1px solid {$thinblueborder};
|
|
|
|
|
border-bottom: 1px solid {$thinblueborder};
|
2014-05-29 21:17:54 +02:00
|
|
|
}
|
|
|
|
|
|
[Redesign] Put all ApplicationSearch results in an ObjectBox
Summary:
Ref T8099. In most cases we return either an ObjectList or AphrontTable, and can pretty up the UI in ApplicationSearch. There are a few edge cases, like PeopleUserLog, that can be cleanup up individually in the future, but look fine for now.
Also added 'setNotice' for AphrontTable for a few cases where we want to convey addtional information.
TODO: Seems we always pass a Pager Object, which tries to get displayed, I'll redesign that interaction in the future, probably by passing the Pager to the ObjectBox
Test Plan: Went throught most/all ApplicationSearch panels I could find, even edge cases look better.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D12989
2015-05-24 18:13:58 +02:00
|
|
|
.phui-header-shell + .launcher-header {
|
|
|
|
|
border-top: none;
|
2014-05-29 21:17:54 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-image-icon {
|
|
|
|
|
background: none;
|
|
|
|
|
width: 30px;
|
|
|
|
|
height: 30px;
|
2015-05-23 20:01:29 +02:00
|
|
|
margin: 4px 0;
|
2014-05-29 21:17:54 +02:00
|
|
|
position: absolute;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-image-icon .phui-icon-view {
|
|
|
|
|
position: absolute;
|
2015-01-26 17:19:22 +01:00
|
|
|
width: 24px;
|
|
|
|
|
height: 24px;
|
|
|
|
|
left: 6px;
|
|
|
|
|
top: 10px;
|
|
|
|
|
font-size: 24px;
|
|
|
|
|
text-align: center;
|
|
|
|
|
vertical-align: bottom;
|
2014-05-29 21:17:54 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-with-image-icon .phui-object-item-frame {
|
|
|
|
|
min-height: 48px;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-with-image-icon .phui-object-item-content-box {
|
2015-01-26 17:19:22 +01:00
|
|
|
margin-left: 36px;
|
2014-05-29 21:17:54 +02:00
|
|
|
}
|
2014-06-05 19:09:14 +02:00
|
|
|
|
|
|
|
|
.device-desktop .phui-object-item-launcher-list .phui-object-item-content {
|
|
|
|
|
margin-right: 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.device-desktop .phui-object-item-launcher-list .phui-object-icon-pane {
|
|
|
|
|
width: auto;
|
|
|
|
|
}
|
[Redesign] Convert Dashboard Panels to ObjectBox
Summary: Moves Dashboard Panels to use PHUIObjectBoxView and PHUIHeaderView
Test Plan:
Tested the most common dashboards, Differential, Maniphest, Projects, Feed, Audit. Some edge cases (Legalpad, Macro) still are in progress. Tested laying out a new Dashboard, removing panels, moving panels.
{F406170}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D12873
2015-05-17 16:05:14 +02:00
|
|
|
|
|
|
|
|
.phui-object-item-image {
|
|
|
|
|
width: 40px;
|
|
|
|
|
height: 40px;
|
|
|
|
|
background-size: 100%;
|
|
|
|
|
margin: 6px;
|
|
|
|
|
position: absolute;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-with-image .phui-object-item-frame {
|
|
|
|
|
min-height: 52px;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.phui-object-item-with-image .phui-object-item-content-box {
|
|
|
|
|
margin-left: 46px;
|
|
|
|
|
}
|
