2012-11-09 03:37:15 +01:00
|
|
|
<?php
|
|
|
|
|
2015-06-15 10:02:26 +02:00
|
|
|
final class DiffusionLintSaveRunner extends Phobject {
|
2012-11-09 03:37:15 +01:00
|
|
|
private $arc = 'arc';
|
|
|
|
private $severity = ArcanistLintSeverity::SEVERITY_ADVICE;
|
|
|
|
private $all = false;
|
|
|
|
private $chunkSize = 256;
|
2013-03-05 01:22:30 +01:00
|
|
|
private $needsBlame = false;
|
2012-11-09 03:37:15 +01:00
|
|
|
|
|
|
|
private $svnRoot;
|
|
|
|
private $lintCommit;
|
|
|
|
private $branch;
|
|
|
|
private $conn;
|
|
|
|
private $deletes = array();
|
|
|
|
private $inserts = array();
|
2013-03-05 01:22:30 +01:00
|
|
|
private $blame = array();
|
2012-11-09 03:37:15 +01:00
|
|
|
|
|
|
|
|
|
|
|
public function setArc($path) {
|
|
|
|
$this->arc = $path;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setSeverity($string) {
|
|
|
|
$this->severity = $string;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setAll($bool) {
|
|
|
|
$this->all = $bool;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setChunkSize($number) {
|
|
|
|
$this->chunkSize = $number;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2013-03-05 01:22:30 +01:00
|
|
|
public function setNeedsBlame($boolean) {
|
|
|
|
$this->needsBlame = $boolean;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2012-11-09 03:37:15 +01:00
|
|
|
|
|
|
|
public function run($dir) {
|
|
|
|
$working_copy = ArcanistWorkingCopyIdentity::newFromPath($dir);
|
2014-03-11 21:07:45 +01:00
|
|
|
$configuration_manager = new ArcanistConfigurationManager();
|
|
|
|
$configuration_manager->setWorkingCopyIdentity($working_copy);
|
|
|
|
$api = ArcanistRepositoryAPI::newAPIFromConfigurationManager(
|
|
|
|
$configuration_manager);
|
2012-12-21 02:26:31 +01:00
|
|
|
|
2012-11-09 03:37:15 +01:00
|
|
|
$this->svnRoot = id(new PhutilURI($api->getSourceControlPath()))->getPath();
|
2012-12-21 02:26:31 +01:00
|
|
|
if ($api instanceof ArcanistGitAPI) {
|
|
|
|
$svn_fetch = $api->getGitConfig('svn-remote.svn.fetch');
|
|
|
|
list($this->svnRoot) = explode(':', $svn_fetch);
|
|
|
|
if ($this->svnRoot != '') {
|
2013-03-05 01:22:30 +01:00
|
|
|
$this->svnRoot = '/'.$this->svnRoot;
|
2012-12-21 02:26:31 +01:00
|
|
|
}
|
|
|
|
}
|
2012-11-09 03:37:15 +01:00
|
|
|
|
2015-05-18 16:07:46 +02:00
|
|
|
$callsign = $configuration_manager->getConfigFromAnySource(
|
|
|
|
'repository.callsign');
|
|
|
|
$uuid = $api->getRepositoryUUID();
|
|
|
|
$remote_uri = $api->getRemoteURI();
|
|
|
|
|
|
|
|
$repository_query = id(new PhabricatorRepositoryQuery())
|
|
|
|
->setViewer(PhabricatorUser::getOmnipotentUser());
|
|
|
|
|
|
|
|
if ($callsign) {
|
|
|
|
$repository_query->withCallsigns(array($callsign));
|
|
|
|
} else if ($uuid) {
|
|
|
|
$repository_query->withUUIDs(array($uuid));
|
|
|
|
} else if ($remote_uri) {
|
2016-01-12 15:45:17 +01:00
|
|
|
$repository_query->withURIs(array($remote_uri));
|
2012-11-09 03:37:15 +01:00
|
|
|
}
|
|
|
|
|
2015-05-18 16:07:46 +02:00
|
|
|
$repository = $repository_query->executeOne();
|
2012-11-09 03:37:15 +01:00
|
|
|
$branch_name = $api->getBranchName();
|
Provide a rough, unstable API for reporting coverage into Diffusion
Summary:
Ref T4994. This stuff works:
- You can dump a blob of coverage information into `diffusion.updatecoverage`. This wipes existing coverage information and replaces it.
- It shows up when viewing files.
- It shows up when viewing commits.
This stuff does not work:
- When viewing files, the Javascript hover interaction isn't tied in yet.
- We always show this information, even if you're behind the commit where it was generated.
- You can't do incremental updates.
- There's no aggregation at the file (this file has 90% coverage), diff (the changes in this commit are 90% covered), or directory (the code in this directory has 90% coverage) levels yet.
- This is probably not the final form of the UI, storage, or API, so you should expect occasional changes over time. I've marked the method as "Unstable" for now.
Test Plan:
- Ran `save_lint.php` to check for collateral damage; it worked fine.
- Ran `save_lint.php` on a new branch to check creation.
- Published some fake coverage information.
- Viewed an affected commit.
- Viewed an affected file.
{F151915}
{F151916}
Reviewers: chad, btrahan
Reviewed By: btrahan
Subscribers: jhurwitz, epriestley, zeeg
Maniphest Tasks: T5044, T4994
Differential Revision: https://secure.phabricator.com/D9022
2014-05-18 01:10:54 +02:00
|
|
|
|
2015-05-18 16:07:46 +02:00
|
|
|
if (!$repository) {
|
|
|
|
throw new Exception(pht('No repository was found.'));
|
|
|
|
}
|
|
|
|
|
Provide a rough, unstable API for reporting coverage into Diffusion
Summary:
Ref T4994. This stuff works:
- You can dump a blob of coverage information into `diffusion.updatecoverage`. This wipes existing coverage information and replaces it.
- It shows up when viewing files.
- It shows up when viewing commits.
This stuff does not work:
- When viewing files, the Javascript hover interaction isn't tied in yet.
- We always show this information, even if you're behind the commit where it was generated.
- You can't do incremental updates.
- There's no aggregation at the file (this file has 90% coverage), diff (the changes in this commit are 90% covered), or directory (the code in this directory has 90% coverage) levels yet.
- This is probably not the final form of the UI, storage, or API, so you should expect occasional changes over time. I've marked the method as "Unstable" for now.
Test Plan:
- Ran `save_lint.php` to check for collateral damage; it worked fine.
- Ran `save_lint.php` on a new branch to check creation.
- Published some fake coverage information.
- Viewed an affected commit.
- Viewed an affected file.
{F151915}
{F151916}
Reviewers: chad, btrahan
Reviewed By: btrahan
Subscribers: jhurwitz, epriestley, zeeg
Maniphest Tasks: T5044, T4994
Differential Revision: https://secure.phabricator.com/D9022
2014-05-18 01:10:54 +02:00
|
|
|
$this->branch = PhabricatorRepositoryBranch::loadOrCreateBranch(
|
2015-05-18 16:07:46 +02:00
|
|
|
$repository->getID(),
|
2012-11-09 03:37:15 +01:00
|
|
|
$branch_name);
|
Provide a rough, unstable API for reporting coverage into Diffusion
Summary:
Ref T4994. This stuff works:
- You can dump a blob of coverage information into `diffusion.updatecoverage`. This wipes existing coverage information and replaces it.
- It shows up when viewing files.
- It shows up when viewing commits.
This stuff does not work:
- When viewing files, the Javascript hover interaction isn't tied in yet.
- We always show this information, even if you're behind the commit where it was generated.
- You can't do incremental updates.
- There's no aggregation at the file (this file has 90% coverage), diff (the changes in this commit are 90% covered), or directory (the code in this directory has 90% coverage) levels yet.
- This is probably not the final form of the UI, storage, or API, so you should expect occasional changes over time. I've marked the method as "Unstable" for now.
Test Plan:
- Ran `save_lint.php` to check for collateral damage; it worked fine.
- Ran `save_lint.php` on a new branch to check creation.
- Published some fake coverage information.
- Viewed an affected commit.
- Viewed an affected file.
{F151915}
{F151916}
Reviewers: chad, btrahan
Reviewed By: btrahan
Subscribers: jhurwitz, epriestley, zeeg
Maniphest Tasks: T5044, T4994
Differential Revision: https://secure.phabricator.com/D9022
2014-05-18 01:10:54 +02:00
|
|
|
$this->conn = $this->branch->establishConnection('w');
|
2012-11-09 03:37:15 +01:00
|
|
|
|
|
|
|
$this->lintCommit = null;
|
Provide a rough, unstable API for reporting coverage into Diffusion
Summary:
Ref T4994. This stuff works:
- You can dump a blob of coverage information into `diffusion.updatecoverage`. This wipes existing coverage information and replaces it.
- It shows up when viewing files.
- It shows up when viewing commits.
This stuff does not work:
- When viewing files, the Javascript hover interaction isn't tied in yet.
- We always show this information, even if you're behind the commit where it was generated.
- You can't do incremental updates.
- There's no aggregation at the file (this file has 90% coverage), diff (the changes in this commit are 90% covered), or directory (the code in this directory has 90% coverage) levels yet.
- This is probably not the final form of the UI, storage, or API, so you should expect occasional changes over time. I've marked the method as "Unstable" for now.
Test Plan:
- Ran `save_lint.php` to check for collateral damage; it worked fine.
- Ran `save_lint.php` on a new branch to check creation.
- Published some fake coverage information.
- Viewed an affected commit.
- Viewed an affected file.
{F151915}
{F151916}
Reviewers: chad, btrahan
Reviewed By: btrahan
Subscribers: jhurwitz, epriestley, zeeg
Maniphest Tasks: T5044, T4994
Differential Revision: https://secure.phabricator.com/D9022
2014-05-18 01:10:54 +02:00
|
|
|
if (!$this->all) {
|
2012-11-09 03:37:15 +01:00
|
|
|
$this->lintCommit = $this->branch->getLintCommit();
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($this->lintCommit) {
|
|
|
|
try {
|
2013-03-01 04:29:25 +01:00
|
|
|
$commit = $this->lintCommit;
|
|
|
|
if ($this->svnRoot) {
|
|
|
|
$commit = $api->getCanonicalRevisionName('@'.$commit);
|
|
|
|
}
|
|
|
|
$all_files = $api->getChangedFiles($commit);
|
2012-11-09 03:37:15 +01:00
|
|
|
} catch (ArcanistCapabilityNotSupportedException $ex) {
|
|
|
|
$this->lintCommit = null;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
Provide a rough, unstable API for reporting coverage into Diffusion
Summary:
Ref T4994. This stuff works:
- You can dump a blob of coverage information into `diffusion.updatecoverage`. This wipes existing coverage information and replaces it.
- It shows up when viewing files.
- It shows up when viewing commits.
This stuff does not work:
- When viewing files, the Javascript hover interaction isn't tied in yet.
- We always show this information, even if you're behind the commit where it was generated.
- You can't do incremental updates.
- There's no aggregation at the file (this file has 90% coverage), diff (the changes in this commit are 90% covered), or directory (the code in this directory has 90% coverage) levels yet.
- This is probably not the final form of the UI, storage, or API, so you should expect occasional changes over time. I've marked the method as "Unstable" for now.
Test Plan:
- Ran `save_lint.php` to check for collateral damage; it worked fine.
- Ran `save_lint.php` on a new branch to check creation.
- Published some fake coverage information.
- Viewed an affected commit.
- Viewed an affected file.
{F151915}
{F151916}
Reviewers: chad, btrahan
Reviewed By: btrahan
Subscribers: jhurwitz, epriestley, zeeg
Maniphest Tasks: T5044, T4994
Differential Revision: https://secure.phabricator.com/D9022
2014-05-18 01:10:54 +02:00
|
|
|
|
2012-11-09 03:37:15 +01:00
|
|
|
if (!$this->lintCommit) {
|
|
|
|
$where = ($this->svnRoot
|
|
|
|
? qsprintf($this->conn, 'AND path LIKE %>', $this->svnRoot.'/')
|
|
|
|
: '');
|
|
|
|
queryfx(
|
|
|
|
$this->conn,
|
|
|
|
'DELETE FROM %T WHERE branchID = %d %Q',
|
|
|
|
PhabricatorRepository::TABLE_LINTMESSAGE,
|
|
|
|
$this->branch->getID(),
|
|
|
|
$where);
|
|
|
|
$all_files = $api->getAllFiles();
|
|
|
|
}
|
|
|
|
|
|
|
|
$count = 0;
|
|
|
|
|
|
|
|
$files = array();
|
|
|
|
foreach ($all_files as $file => $val) {
|
|
|
|
$count++;
|
|
|
|
if (!$this->lintCommit) {
|
|
|
|
$file = $val;
|
|
|
|
} else {
|
|
|
|
$this->deletes[] = $this->svnRoot.'/'.$file;
|
|
|
|
if ($val & ArcanistRepositoryAPI::FLAG_DELETED) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
$files[$file] = $file;
|
|
|
|
|
|
|
|
if (count($files) >= $this->chunkSize) {
|
|
|
|
$this->runArcLint($files);
|
|
|
|
$files = array();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
$this->runArcLint($files);
|
|
|
|
$this->saveLintMessages();
|
2013-03-05 01:22:30 +01:00
|
|
|
|
|
|
|
$this->lintCommit = $api->getUnderlyingWorkingCopyRevision();
|
|
|
|
$this->branch->setLintCommit($this->lintCommit);
|
2012-11-09 03:37:15 +01:00
|
|
|
$this->branch->save();
|
|
|
|
|
2013-03-05 01:22:30 +01:00
|
|
|
if ($this->blame) {
|
|
|
|
$this->blameAuthors();
|
|
|
|
$this->blame = array();
|
|
|
|
}
|
|
|
|
|
2012-11-09 03:37:15 +01:00
|
|
|
return $count;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
private function runArcLint(array $files) {
|
|
|
|
if (!$files) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
echo '.';
|
|
|
|
try {
|
|
|
|
$future = new ExecFuture(
|
|
|
|
'%C lint --severity %s --output json %Ls',
|
|
|
|
$this->arc,
|
|
|
|
$this->severity,
|
|
|
|
$files);
|
|
|
|
|
|
|
|
foreach (new LinesOfALargeExecFuture($future) as $json) {
|
2015-05-05 12:20:11 +02:00
|
|
|
$paths = null;
|
|
|
|
try {
|
|
|
|
$paths = phutil_json_decode($json);
|
|
|
|
} catch (PhutilJSONParserException $ex) {
|
2015-05-22 09:27:56 +02:00
|
|
|
fprintf(STDERR, pht('Invalid JSON: %s', $json)."\n");
|
2012-11-09 03:37:15 +01:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
foreach ($paths as $path => $messages) {
|
|
|
|
if (!isset($files[$path])) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
foreach ($messages as $message) {
|
2013-03-05 01:22:30 +01:00
|
|
|
$line = idx($message, 'line', 0);
|
|
|
|
|
2012-11-09 03:37:15 +01:00
|
|
|
$this->inserts[] = qsprintf(
|
|
|
|
$this->conn,
|
|
|
|
'(%d, %s, %d, %s, %s, %s, %s)',
|
|
|
|
$this->branch->getID(),
|
|
|
|
$this->svnRoot.'/'.$path,
|
2013-03-05 01:22:30 +01:00
|
|
|
$line,
|
2012-11-09 03:37:15 +01:00
|
|
|
idx($message, 'code', ''),
|
|
|
|
idx($message, 'severity', ''),
|
|
|
|
idx($message, 'name', ''),
|
|
|
|
idx($message, 'description', ''));
|
2013-03-05 01:22:30 +01:00
|
|
|
|
|
|
|
if ($line && $this->needsBlame) {
|
|
|
|
$this->blame[$path][$line] = true;
|
|
|
|
}
|
2012-11-09 03:37:15 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
if (count($this->deletes) >= 1024 || count($this->inserts) >= 256) {
|
2013-03-05 01:22:30 +01:00
|
|
|
$this->saveLintMessages();
|
2012-11-09 03:37:15 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
} catch (Exception $ex) {
|
|
|
|
fprintf(STDERR, $ex->getMessage()."\n");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
private function saveLintMessages() {
|
|
|
|
$this->conn->openTransaction();
|
|
|
|
|
|
|
|
foreach (array_chunk($this->deletes, 1024) as $paths) {
|
|
|
|
queryfx(
|
|
|
|
$this->conn,
|
|
|
|
'DELETE FROM %T WHERE branchID = %d AND path IN (%Ls)',
|
|
|
|
PhabricatorRepository::TABLE_LINTMESSAGE,
|
|
|
|
$this->branch->getID(),
|
|
|
|
$paths);
|
|
|
|
}
|
|
|
|
|
|
|
|
foreach (array_chunk($this->inserts, 256) as $values) {
|
|
|
|
queryfx(
|
|
|
|
$this->conn,
|
|
|
|
'INSERT INTO %T
|
|
|
|
(branchID, path, line, code, severity, name, description)
|
2018-11-15 14:53:34 +01:00
|
|
|
VALUES %LQ',
|
2012-11-09 03:37:15 +01:00
|
|
|
PhabricatorRepository::TABLE_LINTMESSAGE,
|
2018-11-15 14:53:34 +01:00
|
|
|
$values);
|
2012-11-09 03:37:15 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
$this->conn->saveTransaction();
|
2013-03-05 01:22:30 +01:00
|
|
|
|
|
|
|
$this->deletes = array();
|
|
|
|
$this->inserts = array();
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
private function blameAuthors() {
|
2013-09-26 01:54:48 +02:00
|
|
|
$repository = id(new PhabricatorRepositoryQuery())
|
|
|
|
->setViewer(PhabricatorUser::getOmnipotentUser())
|
|
|
|
->withIDs(array($this->branch->getRepositoryID()))
|
|
|
|
->executeOne();
|
2013-03-05 01:22:30 +01:00
|
|
|
|
|
|
|
$queries = array();
|
|
|
|
$futures = array();
|
|
|
|
foreach ($this->blame as $path => $lines) {
|
|
|
|
$drequest = DiffusionRequest::newFromDictionary(array(
|
2013-05-15 00:32:19 +02:00
|
|
|
'user' => PhabricatorUser::getOmnipotentUser(),
|
2013-03-05 01:22:30 +01:00
|
|
|
'repository' => $repository,
|
|
|
|
'branch' => $this->branch->getName(),
|
|
|
|
'path' => $path,
|
|
|
|
'commit' => $this->lintCommit,
|
|
|
|
));
|
2016-01-06 15:15:25 +01:00
|
|
|
|
|
|
|
// TODO: Restore blame information / generally fix this workflow.
|
|
|
|
|
|
|
|
$query = DiffusionFileContentQuery::newFromDiffusionRequest($drequest);
|
2013-03-05 01:22:30 +01:00
|
|
|
$queries[$path] = $query;
|
2016-08-26 18:37:53 +02:00
|
|
|
$futures[$path] = new ImmediateFuture($query->executeInline());
|
2013-03-05 01:22:30 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
$authors = array();
|
|
|
|
|
2014-12-30 13:13:38 +01:00
|
|
|
$futures = id(new FutureIterator($futures))
|
|
|
|
->limit(8);
|
|
|
|
foreach ($futures as $path => $future) {
|
2013-03-05 01:22:30 +01:00
|
|
|
$queries[$path]->loadFileContentFromFuture($future);
|
|
|
|
list(, $rev_list, $blame_dict) = $queries[$path]->getBlameData();
|
|
|
|
foreach (array_keys($this->blame[$path]) as $line) {
|
|
|
|
$commit_identifier = $rev_list[$line - 1];
|
|
|
|
$author = idx($blame_dict[$commit_identifier], 'authorPHID');
|
|
|
|
if ($author) {
|
|
|
|
$authors[$author][$path][] = $line;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($authors) {
|
|
|
|
$this->conn->openTransaction();
|
|
|
|
|
|
|
|
foreach ($authors as $author => $paths) {
|
|
|
|
$where = array();
|
|
|
|
foreach ($paths as $path => $lines) {
|
|
|
|
$where[] = qsprintf(
|
|
|
|
$this->conn,
|
|
|
|
'(path = %s AND line IN (%Ld))',
|
|
|
|
$this->svnRoot.'/'.$path,
|
|
|
|
$lines);
|
|
|
|
}
|
|
|
|
queryfx(
|
|
|
|
$this->conn,
|
2018-11-15 14:53:34 +01:00
|
|
|
'UPDATE %T SET authorPHID = %s WHERE %LO',
|
2013-03-05 01:22:30 +01:00
|
|
|
PhabricatorRepository::TABLE_LINTMESSAGE,
|
|
|
|
$author,
|
2018-11-15 14:53:34 +01:00
|
|
|
$where);
|
2013-03-05 01:22:30 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
$this->conn->saveTransaction();
|
|
|
|
}
|
2012-11-09 03:37:15 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
}
|