mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-09 16:32:39 +01:00
Skip loading transaction handles in an old migration
Summary: Ref T13305. See that task for discussion. This old migration may indirectly cause search index worker tasks to queue by loading handles. They'll fail since we later added `dateCreated` to the worker task table. Use `needHandles(false)` (since we don't use them) to disable loading handles and avoid the problem. Test Plan: - Ran `bin/storage upgrade -f` on an older instance (late 2016) and hit this issue. - Applied the patch, got a clean migration to modernity. Reviewers: amckinley Reviewed By: amckinley Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13305 Differential Revision: https://secure.phabricator.com/D20570
This commit is contained in:
parent
bab35f28e4
commit
aba7c98bae
1 changed files with 1 additions and 0 deletions
|
@ -26,6 +26,7 @@ foreach (new LiskMigrationIterator($table) as $task) {
|
|||
$xactions = id(new ManiphestTransactionQuery())
|
||||
->setViewer($viewer)
|
||||
->withObjectPHIDs(array($task->getPHID()))
|
||||
->needHandles(false)
|
||||
->withTransactionTypes(
|
||||
array(
|
||||
$type_merge,
|
||||
|
|
Loading…
Reference in a new issue