Improve page titles for menu items that render in-context content

Summary: Ref T12174. Dashboards and "Home" currently use the page title "Configure Menu". Give them more appropriate titles instead.

Test Plan: Viewed dashboards, Home. Saw relevant page titles.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12174

Differential Revision: https://secure.phabricator.com/D17281

src/applications/search/engine/PhabricatorProfileMenuEngine.php

@@ -214,6 +214,9 @@ abstract class PhabricatorProfileMenuEngine extends Phobject {
           }
         }
       }
+      $page_title = pht('Configure Menu');
+    } else {
+      $page_title = $selected_item->getDisplayName();
     }
 
     switch ($item_action) {
@@ -293,10 +296,8 @@ abstract class PhabricatorProfileMenuEngine extends Phobject {
 
     $crumbs->setBorder(true);
 
-    // TODO: This title is not correct when viewing items.
-
     $page = $controller->newPage()
-      ->setTitle(pht('Configure Menu'))
+      ->setTitle($page_title)
       ->setCrumbs($crumbs)
       ->appendChild($content);