1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/differential
epriestley 06fc82a3ee Mark reviewers as "commented" when they leave a comment
Summary:
Ref T2222. This requires one new trick:

  - When merging edge transactions which both add/update an edge, the Editor gets to control how the edge data is merged.

Specifically, we pick the "strongest" state to keep, so "accept + comment" leaves you with an accept instead of a comment.

Test Plan: Accepted, commented on, and comment + accepted revisions. Added some debugging dumps to verify that the merging was getting hit and working correctly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8340
2014-02-25 12:37:11 -08:00
..
__tests__ Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
application Add a "Pro" version of the Differential comment save controller 2014-02-24 15:57:26 -08:00
capability Allow "Default View" policies to be set to Public 2013-10-09 15:06:18 -07:00
conduit Remove "dateCommitted" field from DifferentialRevision 2014-02-25 12:36:14 -08:00
config Add a config flag to treat "Accepted" revisions as "Closed" 2013-11-25 17:40:01 -08:00
constants Mark reviewers as "commented" when they leave a comment 2014-02-25 12:37:11 -08:00
controller Implement Accept/Reject in ApplicationTransactions, approximately 2014-02-25 12:36:39 -08:00
customfield Separate reading object values out of didSetObject() in CustomField 2014-02-21 14:44:01 -08:00
doorkeeper Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
editor Mark reviewers as "commented" when they leave a comment 2014-02-25 12:37:11 -08:00
event Make event-triggered actions more aware of application access 2013-10-21 17:00:50 -07:00
exception Delete license headers from files 2012-11-05 11:16:51 -08:00
field Fix (?) an issue with CCs not being written into commit messages properly 2014-02-21 12:56:38 -08:00
garbagecollector Complete modularization of the GC daemon 2014-01-15 10:02:31 -08:00
landing Add Disabled mode to landing revision ui 2014-01-30 09:07:50 -08:00
lipsum Add a "default view" policy to Differential 2013-10-09 13:58:00 -07:00
mail Add a "Pro" version of the Differential comment save controller 2014-02-24 15:57:26 -08:00
parser Make Differential inline comment rendering more consistent and somewhat more modern 2014-02-21 11:52:03 -08:00
phid Remove many redundant implementations of canLoadNamedObject() 2013-12-18 12:00:01 -08:00
query Don't issue a bazillion queries to load Differential object lists 2014-02-18 17:57:45 -08:00
remarkup Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
render Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
search Migrate Differential comments to ApplicationTransactions 2014-02-12 14:34:48 -08:00
storage Update overall revision status after reviewers change 2014-02-25 12:36:49 -08:00
view Make Differential inline comment rendering more consistent and somewhat more modern 2014-02-21 11:52:03 -08:00
DifferentialGetWorkingCopy.php Semi-fix git cloning for non-bare repos for landing 2013-12-30 15:22:32 -08:00
DifferentialTasksAttacher.php Delete license headers from files 2012-11-05 11:16:51 -08:00