1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/differential/constants
epriestley 06fc82a3ee Mark reviewers as "commented" when they leave a comment
Summary:
Ref T2222. This requires one new trick:

  - When merging edge transactions which both add/update an edge, the Editor gets to control how the edge data is merged.

Specifically, we pick the "strongest" state to keep, so "accept + comment" leaves you with an accept instead of a comment.

Test Plan: Accepted, commented on, and comment + accepted revisions. Added some debugging dumps to verify that the merging was getting hit and working correctly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8340
2014-02-25 12:37:11 -08:00
..
DifferentialAction.php Fix double-rendering of inline comments in mail 2014-02-13 15:00:29 -08:00
DifferentialChangeType.php PHT's for Differential. 2013-01-24 10:46:47 -08:00
DifferentialLintStatus.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialMailPhase.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialReviewerStatus.php Mark reviewers as "commented" when they leave a comment 2014-02-25 12:37:11 -08:00
DifferentialRevisionControlSystem.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialRevisionStatus.php Add a config flag to treat "Accepted" revisions as "Closed" 2013-11-25 17:40:01 -08:00
DifferentialUnitStatus.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialUnitTestResult.php Delete license headers from files 2012-11-05 11:16:51 -08:00