revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-21 09:48:47 +02:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 1bb306348c Fix infinite loop in renderAccessDenied() 
Summary:
Fixes T8727. When I added `setParentQuery()`, I increased the cache hit rate but also accidentally propagated policy exception settings.

Instead, make the policy exception beahvior explicit: no exceptions should be raised when querying handles.

Test Plan: Will test production.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8727

Differential Revision: https://secure.phabricator.com/D13489
2015-06-30 11:42:31 -07:00
..
almanac Fix Alamanc service paging 2015-06-26 15:45:43 -07:00
aphlict Extend from Phobject 2015-06-15 18:02:27 +10:00
arcanist/conduit Mark "arcanist.projectinfo" as deprecated 2015-05-25 22:52:41 +10:00
audit Change text ADD_CC and REMOVE_CC actions 2015-06-16 15:32:52 -07:00
auth Use PhutilInvalidStateException 2015-06-18 07:09:02 +10:00
base Allow the omnipotent viewer to see objects in uninstalled applications 2015-06-27 04:26:38 -07:00
cache Extend from Phobject 2015-06-15 18:02:27 +10:00
calendar Events should offer Spaces as the view policy options 2015-06-27 10:26:24 -07:00
celerity Remove some unused properties 2015-06-17 20:41:52 +10:00
chatlog phtize all the things 2015-05-22 21:16:39 +10:00
conduit Clarify that 'order' is an optional parameter in Conduit API methods 2015-06-18 13:05:44 -07:00
config Modularize Aphront "sites" 2015-06-29 14:04:48 -07:00
conpherence Conpherence - move crumb-based room edit to widget; other cleanup 2015-06-25 15:59:52 -07:00
console Truncate large strings in DarkConsole 2015-06-18 13:05:32 -07:00
countdown Show when objects have a non-default policy 2015-06-22 11:46:59 -07:00
daemon Execute Maniphest batch edits in the background with a web UI progress bar 2015-06-23 13:36:16 -07:00
dashboard Use PhutilInvalidStateException 2015-06-18 07:09:02 +10:00
differential Carefully avoid the harbormaster/differential race 2015-06-25 10:05:37 -07:00
diffusion Support Spaces in Diffusion 2015-06-24 10:56:46 -07:00
diviner Remove duplicated duplicated words 2015-06-27 08:43:44 -07:00
doorkeeper Extend from Phobject 2015-06-15 18:02:27 +10:00
draft/storage Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
drydock Show when objects have a non-default policy 2015-06-22 11:46:59 -07:00
fact Add a bunch of tests for subclass implementations 2015-06-15 18:13:27 +10:00
feed Cache remarkup engines in Feed 2015-06-30 11:19:58 -07:00
files Remove duplicated duplicated words 2015-06-27 08:43:44 -07:00
flag Extend from Phobject 2015-06-15 18:02:27 +10:00
fund Add a "template" parameter to application default policies 2015-06-11 13:25:30 -07:00
harbormaster Don't try to strlen() an array 2015-06-25 16:18:16 -07:00
help Use __CLASS__ instead of hard-coding class names 2015-05-14 07:21:13 +10:00
herald Change text ADD_CC and REMOVE_CC actions 2015-06-16 15:32:52 -07:00
home phtize all the things 2015-05-22 21:16:39 +10:00
legalpad Show when objects have a non-default policy 2015-06-22 11:46:59 -07:00
lipsum Extend from Phobject 2015-06-15 18:02:27 +10:00
macro Support Spaces in Pholio 2015-06-10 15:52:49 -07:00
mailinglists/storage Put PhabricatorMetaMTAMailingList back to keep bin/storage adjust happy for now 2015-06-03 18:51:40 -07:00
maniphest Execute Maniphest batch edits in the background with a web UI progress bar 2015-06-23 13:36:16 -07:00
meta Add a bunch of tests for subclass implementations 2015-06-15 18:13:27 +10:00
metamta Fix GC threshold for mail to be 90 days instead of 0 seconds 2015-06-28 07:39:36 -07:00
multimeter Provide general documentation on how to use perfomance tools 2015-06-20 05:30:17 -07:00
notification Desktop Notification support 2015-06-22 13:11:37 -07:00
nuance Show when objects have a non-default policy 2015-06-22 11:46:59 -07:00
oauthserver Extend from Phobject 2015-06-15 18:02:27 +10:00
owners Make owners typeahead mostly reasonable 2015-06-18 17:16:37 -07:00
passphrase Show when objects have a non-default policy 2015-06-22 11:46:59 -07:00
paste Show when objects have a non-default policy 2015-06-22 11:46:59 -07:00
people Dramatically increase cache hit rate for feed 2015-06-30 11:19:41 -07:00
phame Modularize Aphront "sites" 2015-06-29 14:04:48 -07:00
phid Fix infinite loop in renderAccessDenied() 2015-06-30 11:42:31 -07:00
phlux Transactions - make implementing TYPE_XXXX_POLICY transactions optional 2015-05-19 12:58:18 -07:00
pholio Implemented Mentionable interface in Pholio 2015-06-23 10:05:45 -07:00
phortune Add a bunch of tests for subclass implementations 2015-06-15 18:13:27 +10:00
phpast Mark some strings for translation 2015-06-09 23:06:52 +10:00
phragment Mark some strings for translation 2015-06-09 23:06:52 +10:00
phrequent phtize all the things 2015-05-22 21:16:39 +10:00
phriction Phriction - improve workflow for when user entered slug needs to be normalized. 2015-06-16 15:33:53 -07:00
policy Show when objects have a non-default policy 2015-06-22 11:46:59 -07:00
ponder Extend from Phobject 2015-06-15 18:02:27 +10:00
project Don't try to load profile images for projects with no profile image 2015-06-30 11:19:24 -07:00
releeph Dramatically limit the range of failures which can cause duplicate mail 2015-06-16 16:43:24 -07:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Remove duplicated duplicated words 2015-06-27 08:43:44 -07:00
search Refactor Calendar Search, and implement Projects on events 2015-06-22 13:27:37 -07:00
settings Desktop Notification support 2015-06-22 13:11:37 -07:00
slowvote Show when objects have a non-default policy 2015-06-22 11:46:59 -07:00
spaces Dramatically increase cache hit rate for feed 2015-06-30 11:19:41 -07:00
subscriptions Don't require missing fields be present in order to subscribe to an object 2015-06-30 11:19:16 -07:00
support/application
system Extend from Phobject 2015-06-15 18:02:27 +10:00
tokens phtize all the things 2015-05-22 21:16:39 +10:00
transactions Modernize transaction comment editor 2015-06-29 11:30:27 -07:00
typeahead Extend from Phobject 2015-06-15 18:02:27 +10:00
uiexample Extend from Phobject 2015-06-15 18:02:27 +10:00
xhprof Remove backticks from SQL statements 2015-06-15 07:38:28 +10:00