revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 15:52:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 20ce1a905f Replace AphrontUsageException with AphrontMalformedRequestException 
Summary:
Ref T1806. Ref T7173. Context here is that I want to fix "you can not log in to this instance" being a confusing mess with an opaque error. To do this without hacks, I want to:

  - clean up some exception handling behavior (this diff);
  - modularize exception handling (next diff);
  - replace confusing, over-general exceptions with tailored ones in the Phacility cluster, using the new modular stuff.

This cleans up an awkward "AphrontUsageException" which does some weird stuff right now. In particular, it is extensible and extended in one place in Diffusion, but that extension is meaningless.

Realign this as "AphrontMalformedRequestException", which is a better description of what it is and does: raises errors before we can get as far as normal routing and site handling.

Test Plan: Hit some of these exceptions, saw the expected "abandon all hope" error page.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T1806, T7173

Differential Revision: https://secure.phabricator.com/D14047
2015-09-03 10:04:17 -07:00
..
almanac Fix issue with almanac service type map keying 2015-07-07 13:21:04 -07:00
aphlict Return $this from setter methods 2015-07-06 22:53:43 +10:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Modernize Audit search engine 2015-08-31 10:17:54 -07:00
auth Use phutil_hashes_are_identical() when comparing hashes in Phabricator 2015-09-01 15:52:44 -07:00
badges Correct link in Badges email 2015-08-20 14:49:57 -07:00
base Allow Controllers to return a wider range of "response-like" objects 2015-09-01 15:52:52 -07:00
cache Extend from Phobject 2015-06-15 18:02:27 +10:00
calendar Calendar list objects that are ghost events should link to a ghost event, not the parent 2015-08-03 07:01:42 -07:00
celerity Push construction of routing maps into Sites 2015-08-31 04:01:01 -07:00
chatlog Update Chatlog for handleRequest 2015-07-31 09:14:44 -07:00
conduit Use phutil_hashes_are_identical() when comparing hashes in Phabricator 2015-09-01 15:52:44 -07:00
config Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
conpherence Update Conpherence layout for logged out view 2015-08-29 08:29:53 -07:00
console Push construction of routing maps into Sites 2015-08-31 04:01:01 -07:00
countdown Simplify Countdown mailtags 2015-08-17 10:08:52 -07:00
daemon Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
dashboard Fix possible recursive embeds in Dashboard text panels 2015-08-26 17:59:47 -07:00
differential Remove leftover code for "postponed" lint and unit status 2015-08-29 22:19:28 +10:00
diffusion Replace AphrontUsageException with AphrontMalformedRequestException 2015-09-03 10:04:17 -07:00
diviner Fix an issue with ClassMap handling of DivinerAtomizers 2015-08-15 06:59:18 -07:00
doorkeeper Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
draft/storage Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
drydock Fix issues where Drydock queries didn't work correctly with empty arrays 2015-08-24 21:23:04 +10:00
fact Update Facts for handleRequest 2015-07-27 09:12:35 -07:00
feed Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
files Push construction of routing maps into Sites 2015-08-31 04:01:01 -07:00
flag Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
fund Update Fund for handleProcess 2015-07-29 16:58:48 -07:00
harbormaster Remove leftover code for "postponed" lint and unit status 2015-08-29 22:19:28 +10:00
help Update Help for handleRequest 2015-08-01 15:40:03 -07:00
herald Add basic support for Herald outbound rules 2015-08-15 10:54:33 -07:00
home Modernize Audit search engine 2015-08-31 10:17:54 -07:00
legalpad Tune document details in Legalpad 2015-08-23 08:31:47 -07:00
lipsum Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
macro Fix Macro active query 2015-08-16 17:50:23 -07:00
mailinglists/storage Put PhabricatorMetaMTAMailingList back to keep bin/storage adjust happy for now 2015-06-03 18:51:40 -07:00
maniphest Use pink for "Unbreak Now" priority instead of indigo 2015-08-21 08:04:37 -07:00
meta Update Meta for handleRequest 2015-08-10 09:08:33 -07:00
metamta Use phutil_hashes_are_identical() when comparing hashes in Phabricator 2015-09-01 15:52:44 -07:00
multimeter Merge branch 'master' into redesign-2015 2015-06-20 06:10:54 -07:00
notification Update Notifications for handleRequest 2015-08-04 09:32:56 -07:00
nuance Add very basic routing to Nuance 2015-08-24 09:21:56 -07:00
oauthserver [Redesign] PhabricatorApplicationSearchResultView 2015-06-19 11:46:20 +01:00
owners Fix an issue with "packages(...)" in typeaheads 2015-09-01 15:35:25 -07:00
passphrase Various linter fixes 2015-08-11 22:36:55 +10:00
paste Add application search for Paste status 2015-08-08 09:46:21 -07:00
people Use phutil_hashes_are_identical() when comparing hashes in Phabricator 2015-09-01 15:52:44 -07:00
phame Push construction of routing maps into Sites 2015-08-31 04:01:01 -07:00
phid Use PhutilClassMapQuery 2015-07-07 22:51:57 +10:00
phlux Transactions - make implementing TYPE_XXXX_POLICY transactions optional 2015-05-19 12:58:18 -07:00
pholio Make "Add Subscribers" and "Remove Subscribers" Herald actions modular 2015-08-03 14:33:22 -07:00
phortune Add a "Printable Version" link to Phortune invoices 2015-09-03 10:03:50 -07:00
phpast Update XHPhast for handleRequest 2015-08-04 09:33:13 -07:00
phragment Mark some strings for translation 2015-06-09 23:06:52 +10:00
phrequent [Redesign] PhabricatorApplicationSearchResultView 2015-06-19 11:46:20 +01:00
phriction Modularize "Send an Email" Herald actions 2015-08-03 14:33:23 -07:00
phurl Fix missing mailtags in PHUrl 2015-07-24 21:30:16 -07:00
policy Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
ponder Show "Login to Answer" in Ponder if viewer is logged out 2015-08-31 09:14:11 -07:00
project Modernize Audit search engine 2015-08-31 10:17:54 -07:00
releeph Update Releeph for handleRequest 2015-08-29 08:33:25 -07:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Modernize Audit search engine 2015-08-31 10:17:54 -07:00
search Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
settings Use phutil_hashes_are_identical() when comparing hashes in Phabricator 2015-09-01 15:52:44 -07:00
slowvote Add mail/feed to Slowvote 2015-08-01 15:41:08 -07:00
spaces Group and order Herald fields 2015-07-16 14:13:13 -07:00
subscriptions Share target filtering code in HeraldAction 2015-08-03 14:34:37 -07:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Extend from Phobject 2015-06-15 18:02:27 +10:00
tokens Badges v0.1 2015-07-22 13:37:20 -07:00
transactions Allow transaction publishers to pass binary data to workers 2015-08-22 15:14:05 -07:00
typeahead Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
uiexample Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
xhprof Update XHProf for handleRequest 2015-08-01 15:41:57 -07:00