revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-18 18:51:12 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
Andre Klapper af300016b6 Fix exception trying to rename user to their previous username 
Summary:
When trying to rename a user, properly handle when the new username is the old username to avoid an exception.

```
EXCEPTION: (PhabricatorApplicationTransactionNoEffectException) Transactions have no effect:
  - Transaction (of type "user.rename") has no effect. at [<phorge>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:2823]
```

Closes T15795

Test Plan:
* As an admin, go to `/people/manage/123/` and select `Change Username`. Use the old username as the new username and select `Rename User`. Without the patch, get an exception. With the patch, get a proper error message within the dialog, as if you tried to set the new username to an empty string.
* As an admin, go to `/people/create/`, select `Create Standard User`, and successfully create a new user account.
* In an anonymous browser window, go to `/auth/start/`, click `Register New Account`, and successfully create a new user account.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15795

Differential Revision: https://we.phorge.it/D25601
2024-05-07 16:21:00 +02:00
..
almanac Fix PHP 8.1 "strlen(null)" exception for "/bin/almanac register" without parameter 2024-04-17 13:12:16 +02:00
aphlict Fix PHP 8.1 "strlen(null)" exception for "/bin/aphlict notify" without parameter 2024-04-17 13:11:07 +02:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Allow to uninstall (hide) Audit application 2024-02-12 12:10:06 +01:00
auth Fix PHP 8.1 "strlen(null)" exceptions adding an OAuth provider 2024-05-03 15:10:19 +02:00
badges Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
base Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
cache Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock" pathways 2022-05-03 15:57:15 -07:00
calendar Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
celerity Improve remarkup codeblock syntax highlighting when using Dark Mode 2024-03-03 15:58:03 +01:00
conduit Fix PHP 8.1 "strlen(null)" exception for "/bin/conduit call" without parameter 2024-04-17 13:07:30 +02:00
config Fix setup check for gzip request mangling being sent as GET 2024-04-02 21:49:00 +03:00
conpherence Improve messages when no image formats are supported (due to GD not installed) 2024-02-13 17:06:57 +01:00
console log deprecation events in Dark Console 2023-08-31 08:18:28 -07:00
countdown Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
daemon Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
dashboard Fix exception for anonymous viewers on dashboard query panels with user-specific data 2024-04-26 12:54:35 +02:00
differential Use predictable filenames when downloading raw diffs from a revision 2024-03-07 00:03:27 +08:00
diffusion Update URI in bugtraq.logregex description 2024-05-01 11:42:26 +02:00
diviner Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
doorkeeper Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
draft/storage Save drafts for inline comments currently being edited 2020-05-04 13:19:42 -07:00
drydock Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
fact Facts: Fix displaying charts for anonymous users 2024-05-05 17:35:35 +02:00
favorites Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
feed Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
files Drag & Drop Task Cover Image: also attach 2024-04-29 17:34:40 +02:00
flag Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
fund Deprecate Fund and Phortune prototype applications 2024-02-06 09:16:19 +01:00
guides Remove product literal strings in "pht()", part 5 2022-04-25 12:22:27 -07:00
harbormaster Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
help Tokenize external editor links so they can be safely materialized on the client 2020-04-19 09:02:49 -07:00
herald Fix PHP 8.1 "strlen(null)" exception for "/bin/herald test" without parameter 2024-04-17 13:08:05 +02:00
home Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Home page 2023-05-01 15:37:56 +02:00
legalpad Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
maniphest Convert "Page Size" field in Maniphest Advanced Search to PhabricatorSearchIntField 2024-05-02 10:16:14 +02:00
meta Fix important regression in search engine 2024-03-26 07:30:10 +01:00
metamta Fix PHP 8.1 "strlen(null)" exception when received email lacks From header 2024-03-31 15:21:11 +02:00
multimeter Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page 2023-05-29 12:35:54 +02:00
notification Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
nuance Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter 2024-04-17 00:35:44 +02:00
oauthserver Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
owners Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
packages Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
passphrase Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
paste Fix PHP 8.1 "strlen(null)" exception in PhabricatorPasteLanguageTransaction.php 2024-05-02 10:28:08 +02:00
people Fix exception trying to rename user to their previous username 2024-05-07 16:21:00 +02:00
phame Improve messages when no image formats are supported (due to GD not installed) 2024-02-13 17:06:57 +01:00
phid Correct docs of PhabricatorPHIDType::getAllTypesForApplication() 2024-04-08 13:14:01 +02:00
phlux Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
pholio Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
phortune Improve messages when no image formats are supported (due to GD not installed) 2024-02-13 17:06:57 +01:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phrequent Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
phriction Fix an instance of strlen(null) 2024-02-23 17:06:26 +02:00
phurl Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
policy Fix the whitespace issue in the message "Access Denied: Restricted File" 2024-05-05 14:00:26 +03:00
ponder Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
project Reports: Remove unused variable 2024-05-01 11:44:27 +02:00
remarkup Generate file attachment transactions for explicit Remarkup attachments on common edit pathways 2022-05-19 13:21:04 -07:00
repository fix PHP 8 "strlen(null)" when moving paths with missing options 2024-02-12 11:05:31 +01:00
search Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter 2024-04-17 00:40:29 +02:00
settings Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
slowvote Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
spaces Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
subscriptions Remove product literal strings in "pht()", part 24 2022-04-25 16:46:26 -07:00
support/application
system Show Deprecation Warnings as Setup Warnings 2023-12-08 17:55:18 +02:00
tokens Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
transactions Fix exception accessing a non-existing EditEngine 2024-04-26 14:33:29 +02:00
typeahead Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
uiexample Implements copy button in clone repo modal 2024-02-15 19:38:39 +01:00
xhprof Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00