mirror of
https://we.phorge.it/source/phorge.git
synced 2025-01-18 18:51:12 +01:00
0e53f91c97
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. This patch also fixes another similar strlen() occurrence in the same source file. ``` ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/herald/management/HeraldTestManagementWorkflow.php:33] ``` Test Plan: Run `../phorge/bin/herald test`: Get no `strlen()` error anymore but only expected output `Usage Exception: Specify an object to test rules for with "--object".` Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25586 |
||
|---|---|---|
| .. | ||
| action | ||
| adapter | ||
| application | ||
| capability | ||
| config | ||
| contentsource | ||
| controller | ||
| edge | ||
| editor | ||
| engine | ||
| engineextension | ||
| field | ||
| garbagecollector | ||
| group | ||
| management | ||
| phid | ||
| query | ||
| remarkup | ||
| state | ||
| storage | ||
| typeahead | ||
| value | ||
| view | ||
| worker | ||
| xaction | ||