1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 11:42:42 +01:00
phorge-phorge/src/applications/differential
epriestley c9d3fb2ac5 Fix the incorrect link target for "Create Revision" as a Menu Item
Summary:
Depends on D20359. Fixes T12098. When you add a new "Form" item and pick "Create Revision", you currently get a bad link. This is because Differential is kind of special and the form isn't usable directly, even though Differential does use EditEngine.

Allow EditEngine to specify a different create URI, then specify the web UI paste-a-diff flow to fix this.

Test Plan:
  - Added "Create Revision" to a portal, clicked it, was sensibly put on the diff flow.
  - Grepped for `getCreateURI()`, the only other real use case is to render the "Create X" dropdowns in the upper right.
    - Clicked one of those, still worked great.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T12098

Differential Revision: https://secure.phabricator.com/D20360
2019-04-02 15:21:59 -07:00
..
__tests__ Put some whitespace behaviors back, but only for "diff alignment", not display 2019-02-19 13:11:50 -08:00
application Support export of revisions to Excel/CSV/JSON/etc 2018-10-11 13:34:33 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Define Differential email action in terms of EditEngine 2017-01-02 13:25:45 -08:00
conduit Remove "Large Changes" documentation and make some minor behavioral improvements 2018-04-05 06:40:46 -07:00
config Remove all whitespace options/configuration everywhere 2019-02-19 13:09:29 -08:00
constants Add some more UI reminder text about draft revisions 2018-03-08 12:07:40 -08:00
controller Fix a stray "%Q" warning when hiding/showing inline comments 2019-02-25 13:51:09 -08:00
customfield Tailor the "no reviewers on this revision" warnings to handle the case where all reviewers have resigned 2018-11-28 13:50:29 -08:00
doorkeeper Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
edge Update parent/child revision timeline messages to use modern language ("parent revision") 2018-07-13 09:02:10 -07:00
editor Fix the incorrect link target for "Create Revision" as a Menu Item 2019-04-02 15:21:59 -07:00
engine Add a warning to revision timelines when changes land with ongoing or failed builds 2019-03-06 06:32:12 -08:00
engineextension Add a "commits" attachment to "differential.diff.search" for retrieving local commit information 2018-04-19 17:25:06 -07:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
field Move misplaced validation for ambiguous fields in "Test Plan" to the right place 2017-06-30 06:36:05 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
harbormaster Don't try to publish build results to bare diffs 2019-02-13 12:19:29 -08:00
herald Add "Revision test plan" as a Herald field; remove test plan from the "Revision summary" field 2018-08-29 14:17:38 -07:00
lipsum Fix Lipsum generators for Differential Revisions and Pastes 2018-07-23 15:05:51 -05:00
mail Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
management When showing a diff-of-diffs, hide files which didn't get any more changes and have no inlines 2018-05-16 17:18:53 -07:00
parser Tweak some display behaviors for indent indicators 2019-02-19 15:34:30 -08:00
phid Make all revision status readers explicitly read modern or legacy status 2017-08-11 17:22:22 -07:00
query Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Correct a case where a single-hunk diff may incorrectly be identified as multi-hunk by the Scope engine 2019-04-01 14:55:11 -07:00
search Reduce the amount of boilerplate that implementing FerretInterface requires 2017-09-07 13:23:31 -07:00
storage Implement Build Plan "Hold Drafts" behavior 2019-03-06 06:27:49 -08:00
typeahead Fix spelling 2017-10-09 10:48:04 -07:00
view Remove all whitespace options/configuration everywhere 2019-02-19 13:09:29 -08:00
xaction Add a warning to revision timelines when changes land with ongoing or failed builds 2019-03-06 06:32:12 -08:00
DifferentialGetWorkingCopy.php Extend from Phobject 2015-06-15 18:02:27 +10:00