mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-03 12:12:43 +01:00
7e46812344
Summary: Ref T13258. The general idea here is "if arc land prompted you and you hit 'y', you get a warning about it on the timeline". This is similar to the existing warning about landing revisions in the wrong state and hitting "y" to get through that. See D18808, previously. These warnings make it easier to catch process issues at a glance, especially because the overall build status is now more complicated (and may legally include some failures on tests which are marked as unimportant). The transaction stores which builds had problems, but I'm not doing anything to render that for now. I think you can usually figure it out from the UI already; if not, we could refine this. Test Plan: - Used `bin/differential attach-commit` to trigger extraction/attachment. - Attached a commit to a revision with various build states, and various build plan "Warn When Landing" flags. - Got sensible warnings and non-warnings based on "Warn When Landing" setting. {F6251631} Reviewers: amckinley Reviewed By: amckinley Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13258 Differential Revision: https://secure.phabricator.com/D20239 |
||
|---|---|---|
| .. | ||
| DifferentialRevisionAbandonTransaction.php | ||
| DifferentialRevisionAcceptTransaction.php | ||
| DifferentialRevisionActionTransaction.php | ||
| DifferentialRevisionBuildableTransaction.php | ||
| DifferentialRevisionCloseTransaction.php | ||
| DifferentialRevisionCommandeerTransaction.php | ||
| DifferentialRevisionHoldDraftTransaction.php | ||
| DifferentialRevisionInlineTransaction.php | ||
| DifferentialRevisionPlanChangesTransaction.php | ||
| DifferentialRevisionReclaimTransaction.php | ||
| DifferentialRevisionRejectTransaction.php | ||
| DifferentialRevisionReopenTransaction.php | ||
| DifferentialRevisionRepositoryTransaction.php | ||
| DifferentialRevisionRequestReviewTransaction.php | ||
| DifferentialRevisionResignTransaction.php | ||
| DifferentialRevisionReviewersTransaction.php | ||
| DifferentialRevisionReviewTransaction.php | ||
| DifferentialRevisionStatusTransaction.php | ||
| DifferentialRevisionSummaryTransaction.php | ||
| DifferentialRevisionTestPlanTransaction.php | ||
| DifferentialRevisionTitleTransaction.php | ||
| DifferentialRevisionTransactionType.php | ||
| DifferentialRevisionUpdateTransaction.php | ||
| DifferentialRevisionVoidTransaction.php | ||
| DifferentialRevisionWrongBuildsTransaction.php | ||
| DifferentialRevisionWrongStateTransaction.php | ||