epriestley 31bd3679f0 Skip loading attached objects for files when we know the file is visible ... Summary: Depends on D19222. Ref T13106. We currently execute an edge query (and possibly an object query) when loading builtin files, but this is never necessary because we know these files are always visible. Instead, skip this logic for builtin files and profile image files; these files have global visibility and will never get a different policy result because of file attachment information. (In theory, we could additionally skip this for files with the most open visibility policy or some other trivially visible policy like the user's PHID, but we do actually care about the attachment data some of the time.) Test Plan: Saw queries drop from 151 to 145 on local test page. Checked file attachment data in Files, saw it still working correctly. Maniphest Tasks: T13106 Differential Revision: https://secure.phabricator.com/D19223		2018-03-14 12:36:46 -07:00
..
almanac	Purge ssh-auth key cache after trust/untrust	2018-02-09 14:58:45 -08:00
aphlict	Discard stdout/stderr from the aphlict subprocess when running in daemon (normal) mode	2016-11-13 16:43:42 -08:00
arcanist/conduit
audit	Make sure auditors are attached to commits on new pathways	2018-02-09 17:09:00 -08:00
auth	Include OAuth targets in "form-action" Content-Security-Policy	2018-02-28 19:28:35 -08:00
badges	Use object PHIDs for "Thread-Topic" headers in mail	2018-02-08 06:21:00 -08:00
base	Never generate file download forms which point to the CDN domain, tighten "form-action" CSP	2018-02-28 17:20:12 -08:00
cache	Add "persistence" types (data, cache, or index) to tables, and tweak what "storage dump" dumps	2017-10-04 12:09:33 -07:00
calendar	Explicitly add rel="noreferrer" to all external links	2018-02-17 17:46:11 -08:00
celerity	Emit a "Content-Security-Policy" HTTP header	2018-02-27 10:17:30 -08:00
chatlog	Remove empty implementations of describeAutomaticCapabilities()	2016-11-09 15:24:22 -08:00
conduit	Add a bin/conduit call support binary	2018-02-05 12:20:49 -08:00
config	Issue setup guidance recommending MySQLi and MySQL Native Driver	2018-03-13 12:38:09 -07:00
conpherence	Read lock all transaction edits	2018-02-10 20:07:46 -08:00
console	Fix the DarkConsole inline error log stack trace expansion behavior for Content-Security-Policy	2018-03-13 16:45:20 -07:00
countdown	Use object PHIDs for "Thread-Topic" headers in mail	2018-02-08 06:21:00 -08:00
daemon	Add a "lock log" for debugging where locks are being held	2018-03-05 17:55:34 -08:00
dashboard	Make dashboard arrange actions (move, add, remove) work again after read locking from "chaos reduction"	2018-02-20 17:23:24 -08:00
differential	Allow custom actions in Differential to explicitly override "accept" stickiness	2018-03-12 17:10:43 -07:00
diffusion	Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose repositories in Owners	2018-03-07 20:57:24 -08:00
diviner	Fix a constant typo in Diviner ("DECLARATAION" -> "TION")	2017-03-04 09:54:10 -08:00
doorkeeper	Allow Doorkeeper references to have multiple display variations (full, short, etc.)	2018-03-13 11:29:52 -07:00
draft/storage	When purging drafts after a transaction edit, purge all drafts	2018-02-11 06:01:09 -08:00
drydock	Render Drydock logs in text from "bin/drydock lease"; in HTML in web views	2018-02-15 17:25:34 -08:00
fact	Fix some of the most obvious bugs in fact generation from Maniphest tasks	2018-02-19 12:07:28 -08:00
favorites	Add some style to label in Favorites Menu	2017-02-01 07:20:31 -08:00
feed	Fix a minor/harmless race with feed publishers in certain draft states	2018-01-04 08:14:55 -08:00
files	Skip loading attached objects for files when we know the file is visible	2018-03-14 12:36:46 -07:00
flag	Remove counts from home navigation	2017-01-21 13:55:40 -08:00
fund	Use object PHIDs for "Thread-Topic" headers in mail	2018-02-08 06:21:00 -08:00
guides	Make "simple" a "button type", not a "color"	2017-05-30 17:59:37 -07:00
harbormaster	Add a UI element for reviewing older generations of Harbormaster builds	2018-03-13 16:15:11 -07:00
help	Redesign header menus and search	2017-01-17 12:13:06 -08:00
herald	Provide a more tailored error message when a Herald rule fails because of PCRE limits	2018-03-06 12:18:58 -08:00
home	Update menu item names for Applications -> Favorites	2017-09-05 19:05:03 -07:00
legalpad	Use object PHIDs for "Thread-Topic" headers in mail	2018-02-08 06:21:00 -08:00
lipsum	Add "--force" and "--quickly" flags to bin/lipsum	2017-02-27 09:09:41 -08:00
macro	Use "-dispose background" to improve reassembly of GIFs with transparency	2018-03-13 09:19:53 -07:00
maniphest	Hide "abraham landed Dxyz irresponsibly" stories from feed	2018-03-06 17:48:03 -08:00
meta	Rename "QuickSearch" Engine/EngineExtension to "Datasource"	2018-02-14 18:03:03 -08:00
metamta	Add some delivery diagnostic headers to outbound mail	2018-02-22 12:47:20 -08:00
multimeter
notification	Make "No Notifications" setting less broad, and fix a bug with default display behavior	2017-09-13 15:32:46 -07:00
nuance	Explicitly add rel="noreferrer" to all external links	2018-02-17 17:46:11 -08:00
oauthserver	Remove client OAuth redirect code which was only partially cleaned up	2018-03-06 20:41:13 -08:00
owners	Before anyone notices, break the API	2018-03-09 12:21:18 -08:00
packages	Fixing copy/paste mistake	2017-04-19 15:48:59 -07:00
passphrase	Fix spelling	2017-10-09 10:48:04 -07:00
paste	Move Paste line range reading code into AphrontRequest	2018-03-01 11:15:06 -08:00
people	Reduce the cost of generating default user profile images	2018-03-01 16:53:17 -08:00
phame	Use object PHIDs for "Thread-Topic" headers in mail	2018-02-08 06:21:00 -08:00
phid	Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self-actor, self-mention	2018-02-06 04:04:52 -08:00
phlux	Update Phlux edit UI	2017-09-07 12:47:36 -07:00
pholio	Remove all "originalTitle"/"originalName" fields from objects	2018-02-08 06:22:03 -08:00
phortune	Include OAuth targets in "form-action" Content-Security-Policy	2018-02-28 19:28:35 -08:00
phpast
phragment	Remove PhabricatorFile::buildFromFileDataOrHash()	2017-04-04 16:18:00 -07:00
phrequent	Fix spelling	2017-10-09 10:48:04 -07:00
phriction	Hide "abraham landed Dxyz irresponsibly" stories from feed	2018-03-06 17:48:03 -08:00
phurl	Explicitly add rel="noreferrer" to all external links	2018-02-17 17:46:11 -08:00
policy	Fix spelling	2017-10-09 10:48:04 -07:00
ponder	Make Facts more modern, DRY, and dimensional	2018-02-19 12:05:19 -08:00
project	Bulk load builtin project default profile images	2018-03-14 12:35:15 -07:00
releeph	Mostly modularize the Differential "update" transaction	2018-03-06 09:10:32 -08:00
remarkup/conduit
repository	Support repository query by short name in Diffusion	2018-03-08 10:55:24 -08:00
search	Never generate file download forms which point to the CDN domain, tighten "form-action" CSP	2018-02-28 17:20:12 -08:00
settings	Make the filetree view width sticky across show/hide and reload	2018-02-22 13:47:41 -08:00
slowvote	Use object PHIDs for "Thread-Topic" headers in mail	2018-02-08 06:21:00 -08:00
spaces	Add more mail stamps: tasks, subscribers, projects, spaces	2018-02-06 04:05:46 -08:00
subscriptions	When computing the "Subscribers" policy, use materialized membership	2018-03-13 08:30:03 -07:00
support/application	Implement the getName method in PhabricatorApplication subclasses	2014-07-23 23:52:50 +10:00
system	Dynamically composite favicons from customizable sources	2018-03-12 15:28:41 -07:00
tokens	Property list view on Diffusion commits should show build status but not Subscriptions, Projects, or Tokens	2017-12-01 18:16:26 +00:00
transactions	Raise a warning when mentioning a user in a comment on a draft revision	2018-03-12 17:03:14 -07:00
typeahead	Fix documentation behaviors for the new proxy functions for custom datasource fields	2018-02-22 13:01:02 -08:00
uiexample	Reduce the cost of generating default user profile images	2018-03-01 16:53:17 -08:00
xhprof	Allow XHProf profiles to be drag-and-dropped to upload them	2017-02-23 11:16:19 -08:00