1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/differential
epriestley f1222f956a Correctly clear draft markers when deleting an inline comment
Summary:
Fixes T8917. Prior to T2618, deleting inlines prompted users, then really deleted the rows.

After T2618, we delete immediately and offer "Undo". However, some interactions with drafts were missed, and we were only clearing the "this revision has a draft" flag on one of the delete pathways (when you delete all the comment text, then save the comment).

Make both the "Delete" action and the "Delete All Comment Text + Save" workflows do the same thing: mark the row as deleted, and clear any relevant drafts.

Test Plan:
  - Made an inline comment on a clean revision with no "draft comments" marker in the list view.
  - Used "delete" to delete it.
  - After applying the patch, verified that no "draft commetns" marker appears in the list view.
  - Used Delete and Edit + Remove Text + Save to delete comments in Differential and Diffusion.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T8917

Differential Revision: https://secure.phabricator.com/D13665
2015-07-21 11:36:46 -07:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
application Show when objects have a non-default policy 2015-06-22 11:46:59 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Generate mail command documentation from active commands 2015-04-01 11:51:47 -07:00
conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
config Separate "Revision" and "Diff" fields in Differential 2015-06-16 08:53:40 -07:00
constants [Redesign] Add color to diff Table of Contents 2015-07-01 11:33:31 -07:00
controller Correctly clear draft markers when deleting an inline comment 2015-07-21 11:36:46 -07:00
customfield Fix a bad method call which slipped by 2015-06-23 17:11:59 -07:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Don't write inverse edges for DifferentialRevisionHasReviewerEdgeType 2015-01-04 10:07:56 +11:00
editor Carefully avoid the harbormaster/differential race 2015-06-25 10:05:37 -07:00
event Remove implode_selected_handle_links() 2015-03-31 05:48:20 -07:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
garbagecollector Complete modularization of the GC daemon 2014-01-15 10:02:31 -08:00
herald Group and order Herald fields 2015-07-16 14:13:13 -07:00
landing Extend from Phobject 2015-06-15 18:02:27 +10:00
lipsum phtize all the things 2015-05-22 21:16:39 +10:00
mail phtize all the things 2015-05-22 21:16:39 +10:00
management Remove break from hunk migration 2015-06-15 08:32:08 +10:00
parser Return $this from setter methods 2015-07-06 22:53:43 +10:00
phid Separate handle "status" and "availability" 2015-05-14 11:14:44 -07:00
query Merge branch 'master' into redesign-2015 2015-06-22 12:26:41 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Extend from Phobject 2015-06-15 18:02:27 +10:00
search phtize all the things 2015-05-22 21:16:39 +10:00
storage Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
view [Redesign] Add color to diff Table of Contents 2015-07-01 11:33:31 -07:00
DifferentialGetWorkingCopy.php Extend from Phobject 2015-06-15 18:02:27 +10:00