revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 3ea47d967a Allow monogrammed objects to be parsed from the arc command line in "Reviewers" and similar fields 
Summary:
Ref T10939. This allows the CLI to parse reviewers and subscribers like this:

```Reviewers: epriestley, O123 Some Package Name```

The rule goes:

  - If a reviewer or subscriber starts with a monogram (like `X111`), just look that up and ignore everything until the next comma.
  - Otherwise, split it on spaces and look up each part.

This means that these are valid:

```
alincoln htaft
alincoln, htaft
#a #b epriestley
O123 Some Package, epriestley, #b
```

I think the only real downside is that this:

```
O123 Some Package epriestley
```

...ignores the "epriestley" part. However, I don't expect users to be typing package monograms manually -- they just need to be representable by `arc land` and `arc diff --edit` and such. Those flows will always add commas and make the parse unambiguous.

Test Plan:
  - Added test coverage.
  - `amend --show`'d a revision with a package subscriber (this isn't currently possible to produce using the web UI, it came from a future change) and saw `Subscribers: O123 package name, usera, userb`.
  - Updated a revision with a package subscriber.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15911
2016-05-13 17:18:35 -07:00
..
almanac Make repository daemon locks more granular and forgiving 2016-05-13 05:17:27 -07:00
aphlict Fix bad variable causing aphlict to fail to start with no "logs" config 2016-04-24 11:20:42 -07:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Modularize content sources 2016-03-26 11:59:45 -07:00
auth When a user tries to regsiter while logged in, just send them home 2016-04-16 19:15:15 -07:00
badges Fix header in Badges 2016-04-13 20:44:43 -07:00
base Split Repository EditEngine form into smaller pages 2016-05-02 08:28:38 -07:00
cache Automatically sever databases after prolonged unreachability 2016-04-11 08:43:52 -07:00
calendar Calendar event list items 'Attending:' field should only show users who have confirmed attendance 2016-04-21 11:06:49 -07:00
celerity Generate syntax highlighting CSS from a reusable map 2016-05-05 02:50:48 -07:00
chatlog Update chatlog to newPage() 2016-04-02 13:20:55 -07:00
conduit Paramater type inheritence fix 2016-05-11 18:21:14 +00:00
config Remove metamta.differential.unified-comment-context and explain it in ExtraConfigSetupCheck 2016-05-11 06:47:58 -07:00
conpherence Allow users to be banished from Conpherence rooms 2016-04-15 14:57:29 -07:00
console Separate external editor integration from callsigns 2016-01-04 06:54:01 -08:00
countdown Support sorting countdowns by end date 2016-04-07 12:37:55 -07:00
daemon Fail explicitly instead of continuing with a warning if "phd.user" is misconfigured 2016-04-15 14:09:13 -07:00
dashboard Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
differential Allow monogrammed objects to be parsed from the arc command line in "Reviewers" and similar fields 2016-05-13 17:18:35 -07:00
diffusion Fix an issue with URI index updates from the daemons 2016-05-13 06:51:31 -07:00
diviner Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
doorkeeper Bridge GitHub users into Phabricator and attribute actions to them 2016-03-28 13:10:32 -07:00
draft/storage Fix EditEngine preview/draft for first comment on a task you didn't create 2015-12-05 09:57:45 -08:00
drydock Add icons to the new repository edit nav 2016-05-03 08:01:18 -07:00
fact Update Facts for newPage 2016-04-03 15:07:52 -07:00
feed Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
files Add "wide" remarkup image support for Documents 2016-05-03 17:27:30 -07:00
flag Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
fund Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
harbormaster Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
help Update Help for newPage 2016-04-05 07:26:31 -07:00
herald Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
home Update Home for newPage 2016-04-05 13:53:54 -07:00
legalpad Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
lipsum Modularize content sources 2016-03-26 11:59:45 -07:00
macro Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
maniphest Fix errant rules for associating projects when dragging tasks within a milestone column 2016-05-03 07:59:05 -07:00
meta Give application actors in feed reasonable icons 2016-04-20 14:38:55 -07:00
metamta Highlight inline diff context in HTML mail 2016-05-05 11:13:27 -07:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Support Aphlict clustering 2016-04-14 13:26:30 -07:00
nuance Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
oauthserver Make OAuth scope handling more flexible 2016-04-05 13:53:33 -07:00
owners Allow monogrammed objects to be parsed from the arc command line in "Reviewers" and similar fields 2016-05-13 17:18:35 -07:00
passphrase Fill in new URI credential edit web UI interfaces 2016-05-02 04:26:13 -07:00
paste Add badges.edit and badges.search to Conduit API 2016-04-05 16:25:55 -07:00
people Allow public users to make intracluster API requests 2016-04-13 12:51:16 -07:00
phame Update EditEngine for two column 2016-03-28 09:18:55 -07:00
phid Allow monogrammed objects to be parsed from the arc command line in "Reviewers" and similar fields 2016-05-13 17:18:35 -07:00
phlux Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
pholio Fix two issues with Remarkup in Pholio 2016-04-25 08:16:23 -07:00
phortune Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Moderize Phragment 2016-04-02 14:24:40 +00:00
phrequent Add a Phrequent curtain extension 2016-03-10 18:45:04 -08:00
phriction Fix Phriction link syntax a little more 2016-04-21 10:29:08 -07:00
phurl Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
policy Simplify locking of Almanac cluster services 2016-02-25 03:38:39 -08:00
ponder Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
project Fix errant rules for associating projects when dragging tasks within a milestone column 2016-05-03 07:59:05 -07:00
releeph Update Releeph to new UI 2016-04-05 13:16:10 -07:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Don't trigger audits for archived packages 2016-05-13 06:49:42 -07:00
search Add an edge table to the search database 2016-04-26 11:26:26 -07:00
settings Allow users to set a line-height in their monospaced font preference 2016-05-13 05:10:27 -07:00
slowvote Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
spaces Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
subscriptions Allow stacked comment actions to be explicitly ordered 2016-04-06 09:15:27 -07:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Automatically degrade to read-only mode when unable to connect to the master 2016-04-10 12:20:13 -07:00
tokens Update Tokens for newPage 2016-04-02 13:22:24 -07:00
transactions Fix an issue with TextAreaEditField affecting Paste 2016-05-11 15:35:17 -07:00
typeahead Update typeahead for new UI 2016-04-04 12:45:56 -07:00
uiexample Fixing UI Example that use badge qualities 2016-04-15 11:05:45 -07:00
xhprof Update XHProf for newPage 2016-04-04 08:40:49 -07:00