1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 22:40:55 +01:00
phorge-phorge/src/applications
grglr 3f3304fd61 Differential whitespace mode IGNORE ALL now shows correct indentation
Summary:
Fixed buggy and incomplete logic for handling IGNORE ALL mode properly.
A subparser is used to parse the non-ws-ignoring changeset while a
ws-ignoring changeset is handed off to the original parser.  At a later
step, the original parser queries the subparser for its lines of text
(which are formatted properly due to being in non-ws-ignoring mode) and
uses them to replace the text in the ws-ignoring diff.

Task ID: 549940

Test Plan:
-turn off caching temporarily (the cached view is still indented
improperly)
-visit http://phabricator.dev1943.facebook.com/D242591
-note aligned, but not completely highlighted, indentation right above the
comments complaining about
indentation issues

Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
Commenters: epriestley
CC: aran, epriestley, grglr
Differential Revision: 174
2011-04-28 16:10:59 -07:00
..
auth Don't reveal oauth application token information 2011-04-14 13:32:49 -07:00
base [phabricator] Add mysql slave and read-only database connections 2011-04-28 15:27:19 -07:00
conduit Enable differential.find handle empty input. 2011-04-26 23:59:40 -07:00
daemon/controller Prevent a race in Phabricator workers 2011-04-14 12:09:56 -07:00
differential Differential whitespace mode IGNORE ALL now shows correct indentation 2011-04-28 16:10:59 -07:00
diffusion Display file name in <title> for easier browsing of code 2011-04-21 17:22:47 -07:00
directory Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
draft/storage Revision comment drafts. 2011-02-05 16:57:21 -08:00
files Image macros for Phabricator! 2011-04-13 20:08:13 -07:00
herald Added a link to the actual object in Herald transcript. 2011-04-12 11:35:26 -07:00
maniphest Removed extra space from Maniphest email subject line. 2011-04-11 12:47:10 -07:00
metamta Fix 'Transcript' links in Differential 2011-04-08 01:10:05 -07:00
owners Removing reordering code that wasn't needed 2011-04-20 17:07:46 -07:00
people Fix systemAgent stuff. 2011-04-12 19:00:54 -07:00
phid Added commit information to 'getrevision' conduit call. 2011-04-25 15:32:33 -07:00
preferences/controller Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
project Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
repository Allow GitCommitChangeParser to parse 'T' (type change) messages in 2011-04-14 14:16:53 -07:00
search Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
status/base Add /status/ 2011-04-08 11:13:51 -07:00
typeahead/controller Basic create_user script plus rough system agent support. 2011-04-12 18:34:53 -07:00
uiexample Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
xhpastview Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
xhprof Lint fluff. 2011-02-06 12:58:01 -08:00