1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-25 15:00:58 +01:00
phorge-phorge/src/applications/differential
grglr 3f3304fd61 Differential whitespace mode IGNORE ALL now shows correct indentation
Summary:
Fixed buggy and incomplete logic for handling IGNORE ALL mode properly.
A subparser is used to parse the non-ws-ignoring changeset while a
ws-ignoring changeset is handed off to the original parser.  At a later
step, the original parser queries the subparser for its lines of text
(which are formatted properly due to being in non-ws-ignoring mode) and
uses them to replace the text in the ws-ignoring diff.

Task ID: 549940

Test Plan:
-turn off caching temporarily (the cached view is still indented
improperly)
-visit http://phabricator.dev1943.facebook.com/D242591
-note aligned, but not completely highlighted, indentation right above the
comments complaining about
indentation issues

Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
Commenters: epriestley
CC: aran, epriestley, grglr
Differential Revision: 174
2011-04-28 16:10:59 -07:00
..
constants Implemented "Plan Changes" action for differential. 2011-04-13 16:58:22 -07:00
controller Merge branch 'master' of github.com:facebook/phabricator 2011-04-28 14:45:30 -07:00
data Differential Updates View 2011-04-28 14:40:41 -07:00
editor Tasks can be defined in the commit message (Phabricator part). 2011-04-22 18:40:16 -07:00
mail Don't send a blank "COMMITS" field for mark-committed revisions. 2011-04-10 14:36:04 -07:00
parser Differential whitespace mode IGNORE ALL now shows correct indentation 2011-04-28 16:10:59 -07:00
storage Differential Updates View 2011-04-28 14:40:41 -07:00
tasks Enable updating task->revision assoc 2011-04-26 19:14:47 -07:00
view Modify whitespace default implementation 2011-04-28 09:22:02 -07:00