revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 3fda965288 When multiple web hosts are in service, don't require setup warnings to be dismissed on each one 
Summary:
Fixes T10876. Currently, we can end up with a setup warning banner sticking on each web device, since the state is stored in local cache.

Instead:

  - When we actually run the setup checks, save the current state in the database.
  - Before we show a cached banner, make sure the database still says the checks are a problem.

This could lead to some inconsistencies if setup checks legitimately pass on some hosts but not on others. For example, if you have `git` installed on one machine but not on another, we may raise a setup warning ("No Git Binary!") about it on one host only.

For now, assume users have their operational environments in some sort of reasonable shape and can install the same stuff everywhere. In the future, we could split the issues into "global" and "per-host" issues if we run into problems with this.

Test Plan:
This is somewhat tricky to test locally since you really need multiple webservers to test it properly, but I:

  - Created some setup issues, saw banner.
  - Ignored/cleared them, saw banner go away.
  - Verified database cache writes were occurring properly.

Then I sort of faked it like this:

  - Created a setup issue.
  - Manually set the database cache value to `[]` ("no issues").
  - Reloaded page.
  - No more banner.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10876

Differential Revision: https://secure.phabricator.com/D15802
2016-04-26 10:03:45 -07:00
..
almanac Document how to register cluster devices with Almanac 2016-04-25 14:58:58 -07:00
aphlict Fix bad variable causing aphlict to fail to start with no "logs" config 2016-04-24 11:20:42 -07:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Modularize content sources 2016-03-26 11:59:45 -07:00
auth When a user tries to regsiter while logged in, just send them home 2016-04-16 19:15:15 -07:00
badges Fix header in Badges 2016-04-13 20:44:43 -07:00
base Convert every two-column application except Maniphest to curtain views 2016-03-06 10:44:07 -08:00
cache Automatically sever databases after prolonged unreachability 2016-04-11 08:43:52 -07:00
calendar Calendar event list items 'Attending:' field should only show users who have confirmed attendance 2016-04-21 11:06:49 -07:00
celerity Don't cache resources we can't generate properly 2016-04-21 11:56:54 -07:00
chatlog Update chatlog to newPage() 2016-04-02 13:20:55 -07:00
conduit Formally deprecate owners.query Conduit API method 2016-04-20 09:04:45 -07:00
config When multiple web hosts are in service, don't require setup warnings to be dismissed on each one 2016-04-26 10:03:45 -07:00
conpherence Allow users to be banished from Conpherence rooms 2016-04-15 14:57:29 -07:00
console Separate external editor integration from callsigns 2016-01-04 06:54:01 -08:00
countdown Support sorting countdowns by end date 2016-04-07 12:37:55 -07:00
daemon Fail explicitly instead of continuing with a warning if "phd.user" is misconfigured 2016-04-15 14:09:13 -07:00
dashboard Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
differential Parse Tags in commits message for revisions 2016-04-20 01:46:17 +00:00
diffusion Port "Staging Area" repository section to new management UI 2016-04-26 08:11:53 -07:00
diviner Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
doorkeeper Bridge GitHub users into Phabricator and attribute actions to them 2016-03-28 13:10:32 -07:00
draft/storage Fix EditEngine preview/draft for first comment on a task you didn't create 2015-12-05 09:57:45 -08:00
drydock Update Drydock remaining pages to new UI 2016-04-05 07:25:43 -07:00
fact Update Facts for newPage 2016-04-03 15:07:52 -07:00
feed Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
files Improve consistency of file access policies, particularly for LFS 2016-04-22 08:12:08 -07:00
flag Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
fund Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
harbormaster Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
help Update Help for newPage 2016-04-05 07:26:31 -07:00
herald Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
home Update Home for newPage 2016-04-05 13:53:54 -07:00
legalpad Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
lipsum Modularize content sources 2016-03-26 11:59:45 -07:00
macro Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
maniphest Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
meta Give application actors in feed reasonable icons 2016-04-20 14:38:55 -07:00
metamta Update MetaMTA to new UI 2016-04-05 07:26:46 -07:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Support Aphlict clustering 2016-04-14 13:26:30 -07:00
nuance Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
oauthserver Make OAuth scope handling more flexible 2016-04-05 13:53:33 -07:00
owners Formally deprecate owners.query Conduit API method 2016-04-20 09:04:45 -07:00
passphrase Use monospaced font in Passphrase "Reveal Secret" dialog 2016-04-14 13:09:52 -07:00
paste Add badges.edit and badges.search to Conduit API 2016-04-05 16:25:55 -07:00
people Allow public users to make intracluster API requests 2016-04-13 12:51:16 -07:00
phame Update EditEngine for two column 2016-03-28 09:18:55 -07:00
phid Bridge GitHub users into Phabricator and attribute actions to them 2016-03-28 13:10:32 -07:00
phlux Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
pholio Fix two issues with Remarkup in Pholio 2016-04-25 08:16:23 -07:00
phortune Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Moderize Phragment 2016-04-02 14:24:40 +00:00
phrequent Add a Phrequent curtain extension 2016-03-10 18:45:04 -08:00
phriction Fix Phriction link syntax a little more 2016-04-21 10:29:08 -07:00
phurl Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
policy Simplify locking of Almanac cluster services 2016-02-25 03:38:39 -08:00
ponder Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
project Convert Project Pages to new UI 2016-04-14 18:26:43 +00:00
releeph Update Releeph to new UI 2016-04-05 13:16:10 -07:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Fix two minor formatting issues with bin/repository move-paths 2016-04-25 12:29:15 -07:00
search Formally deprecate owners.query Conduit API method 2016-04-20 09:04:45 -07:00
settings Complete modernization of Aphlict configuration 2016-04-14 04:57:00 -07:00
slowvote Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
spaces Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
subscriptions Allow stacked comment actions to be explicitly ordered 2016-04-06 09:15:27 -07:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Automatically degrade to read-only mode when unable to connect to the master 2016-04-10 12:20:13 -07:00
tokens Update Tokens for newPage 2016-04-02 13:22:24 -07:00
transactions Reduce strength of Herald and user subscription stories 2016-04-20 14:40:49 -07:00
typeahead Update typeahead for new UI 2016-04-04 12:45:56 -07:00
uiexample Fixing UI Example that use badge qualities 2016-04-15 11:05:45 -07:00
xhprof Update XHProf for newPage 2016-04-04 08:40:49 -07:00