mirror of
https://we.phorge.it/source/phorge.git
synced 2025-01-24 21:48:21 +01:00
4a3481a493
Summary:
See PHI1232, which describes a reasonable use case for wanting information about the "draft" ("Hold as Draft / Do Not Auto-Promote") flag.
Also, flesh out "testPlan" and "summary". It's possible these "blob of remarkup" fields might have metadata some day (e.g., a rendered version or a list of PHIDs or something), but we could add more keys, and we already have some other transactions which work like this.
Test Plan: Used "transaction.search" to fetch these transaction types, saw type information and metadata.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20507
69 lines
1.7 KiB
PHP
69 lines
1.7 KiB
PHP
<?php
|
|
|
|
final class DifferentialRevisionTitleTransaction
|
|
extends DifferentialRevisionTransactionType {
|
|
|
|
const TRANSACTIONTYPE = 'differential.revision.title';
|
|
const EDITKEY = 'title';
|
|
|
|
public function generateOldValue($object) {
|
|
return $object->getTitle();
|
|
}
|
|
|
|
public function applyInternalEffects($object, $value) {
|
|
$object->setTitle($value);
|
|
}
|
|
|
|
public function getTitle() {
|
|
return pht(
|
|
'%s retitled this revision from %s to %s.',
|
|
$this->renderAuthor(),
|
|
$this->renderOldValue(),
|
|
$this->renderNewValue());
|
|
}
|
|
|
|
public function getTitleForFeed() {
|
|
return pht(
|
|
'%s retitled %s from %s to %s.',
|
|
$this->renderAuthor(),
|
|
$this->renderObject(),
|
|
$this->renderOldValue(),
|
|
$this->renderNewValue());
|
|
}
|
|
|
|
public function validateTransactions($object, array $xactions) {
|
|
$errors = array();
|
|
|
|
if ($this->isEmptyTextTransaction($object->getTitle(), $xactions)) {
|
|
$errors[] = $this->newRequiredError(
|
|
pht('Revisions must have a title.'));
|
|
}
|
|
|
|
$max_length = $object->getColumnMaximumByteLength('title');
|
|
foreach ($xactions as $xaction) {
|
|
$new_value = $xaction->getNewValue();
|
|
$new_length = strlen($new_value);
|
|
if ($new_length > $max_length) {
|
|
$errors[] = $this->newInvalidError(
|
|
pht(
|
|
'Revision title is too long: the maximum length of a '.
|
|
'revision title is 255 bytes.'),
|
|
$xaction);
|
|
}
|
|
}
|
|
|
|
return $errors;
|
|
}
|
|
|
|
public function getTransactionTypeForConduit($xaction) {
|
|
return 'title';
|
|
}
|
|
|
|
public function getFieldValuesForConduit($xaction, $data) {
|
|
return array(
|
|
'old' => $xaction->getOldValue(),
|
|
'new' => $xaction->getNewValue(),
|
|
);
|
|
}
|
|
|
|
}
|