mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 11:22:40 +01:00
fc893658b8
Summary: Adds a `MenuName` method to applications that `ProfileMenuItem` uses instead of the application name if set. This improves the home/menu/new user experience at little cost. Also renamed the label from Applications to Favorites, since this menu gets altered to provide more than just applications. This also allows instances to set back to Maniphest if they so choose. Overall I think this direction resolves 95% of my concerns, with maybe a small potential downside which I don't really anticipate. We already name Dashboard panels by their object, and that hasn't really caused confusion. I think these links are similar. I click 'Tasks' and get presented a list of my tasks from Maniphest. Test Plan: Review each of the name changes as a default new install and a modified install. Reviewers: epriestley, amckinley Reviewed By: epriestley Spies: Korvin Differential Revision: https://secure.phabricator.com/D18524
150 lines
4.2 KiB
PHP
150 lines
4.2 KiB
PHP
<?php
|
|
|
|
final class PhabricatorDifferentialApplication extends PhabricatorApplication {
|
|
|
|
public function getBaseURI() {
|
|
return '/differential/';
|
|
}
|
|
|
|
public function getName() {
|
|
return pht('Differential');
|
|
}
|
|
|
|
public function getMenuName() {
|
|
return pht('Code Review');
|
|
}
|
|
|
|
public function getShortDescription() {
|
|
return pht('Pre-Commit Review');
|
|
}
|
|
|
|
public function getIcon() {
|
|
return 'fa-cog';
|
|
}
|
|
|
|
public function isPinnedByDefault(PhabricatorUser $viewer) {
|
|
return true;
|
|
}
|
|
|
|
public function getHelpDocumentationArticles(PhabricatorUser $viewer) {
|
|
return array(
|
|
array(
|
|
'name' => pht('Differential User Guide'),
|
|
'href' => PhabricatorEnv::getDoclink('Differential User Guide'),
|
|
),
|
|
);
|
|
}
|
|
|
|
public function getFactObjectsForAnalysis() {
|
|
return array(
|
|
new DifferentialRevision(),
|
|
);
|
|
}
|
|
|
|
public function getTitleGlyph() {
|
|
return "\xE2\x9A\x99";
|
|
}
|
|
|
|
public function getOverview() {
|
|
return pht(
|
|
'Differential is a **code review application** which allows '.
|
|
'engineers to review, discuss and approve changes to software.');
|
|
}
|
|
|
|
public function getRoutes() {
|
|
return array(
|
|
'/D(?P<id>[1-9]\d*)' => 'DifferentialRevisionViewController',
|
|
'/differential/' => array(
|
|
'(?:query/(?P<queryKey>[^/]+)/)?'
|
|
=> 'DifferentialRevisionListController',
|
|
'diff/' => array(
|
|
'(?P<id>[1-9]\d*)/' => 'DifferentialDiffViewController',
|
|
'create/' => 'DifferentialDiffCreateController',
|
|
),
|
|
'changeset/' => 'DifferentialChangesetViewController',
|
|
'revision/' => array(
|
|
$this->getEditRoutePattern('edit/')
|
|
=> 'DifferentialRevisionEditController',
|
|
$this->getEditRoutePattern('attach/(?P<diffID>[^/]+)/to/')
|
|
=> 'DifferentialRevisionEditController',
|
|
'closedetails/(?P<phid>[^/]+)/'
|
|
=> 'DifferentialRevisionCloseDetailsController',
|
|
'update/(?P<revisionID>[1-9]\d*)/'
|
|
=> 'DifferentialDiffCreateController',
|
|
'operation/(?P<id>[1-9]\d*)/'
|
|
=> 'DifferentialRevisionOperationController',
|
|
'inlines/(?P<id>[1-9]\d*)/'
|
|
=> 'DifferentialRevisionInlinesController',
|
|
),
|
|
'comment/' => array(
|
|
'preview/(?P<id>[1-9]\d*)/' => 'DifferentialCommentPreviewController',
|
|
'save/(?P<id>[1-9]\d*)/' => 'DifferentialCommentSaveController',
|
|
'inline/' => array(
|
|
'preview/(?P<id>[1-9]\d*)/'
|
|
=> 'DifferentialInlineCommentPreviewController',
|
|
'edit/(?P<id>[1-9]\d*)/'
|
|
=> 'DifferentialInlineCommentEditController',
|
|
),
|
|
),
|
|
'preview/' => 'PhabricatorMarkupPreviewController',
|
|
),
|
|
);
|
|
}
|
|
|
|
public function getApplicationOrder() {
|
|
return 0.100;
|
|
}
|
|
|
|
public function getRemarkupRules() {
|
|
return array(
|
|
new DifferentialRemarkupRule(),
|
|
);
|
|
}
|
|
|
|
public function supportsEmailIntegration() {
|
|
return true;
|
|
}
|
|
|
|
public function getAppEmailBlurb() {
|
|
return pht(
|
|
'Send email to these addresses to create revisions. The body of the '.
|
|
'message and / or one or more attachments should be the output of a '.
|
|
'"diff" command. %s',
|
|
phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $this->getInboundEmailSupportLink(),
|
|
),
|
|
pht('Learn More')));
|
|
}
|
|
|
|
protected function getCustomCapabilities() {
|
|
return array(
|
|
DifferentialDefaultViewCapability::CAPABILITY => array(
|
|
'caption' => pht('Default view policy for newly created revisions.'),
|
|
'template' => DifferentialRevisionPHIDType::TYPECONST,
|
|
'capability' => PhabricatorPolicyCapability::CAN_VIEW,
|
|
),
|
|
);
|
|
}
|
|
|
|
public function getMailCommandObjects() {
|
|
return array(
|
|
'revision' => array(
|
|
'name' => pht('Email Commands: Revisions'),
|
|
'header' => pht('Interacting with Differential Revisions'),
|
|
'object' => new DifferentialRevision(),
|
|
'summary' => pht(
|
|
'This page documents the commands you can use to interact with '.
|
|
'revisions in Differential.'),
|
|
),
|
|
);
|
|
}
|
|
|
|
public function getApplicationSearchDocumentTypes() {
|
|
return array(
|
|
DifferentialRevisionPHIDType::TYPECONST,
|
|
);
|
|
}
|
|
|
|
}
|