revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
Alex Wyler 5fabda2a6d Check for null, strictly, in maniphest.update param validation 
Summary:
If the first non-null entry in the params array is falsey, the request bombs.

Something like {"id":279,"projectPHIDs":[],"status":"0","ownerPHID":"PHID-USER-on3xxsnaljmfn36d4b7a"}

Test Plan:
Before:

  echo '{"id":279,"projectPHIDs":[],"status":"0","ownerPHID":"PHID-USER-cj3cpuh7oorbmnn2pl5g"}' | arc call-conduit maniphest.update
  {"error":"ERR-NO-EFFECT","errorMessage":"ERR-NO-EFFECT: Update has no effect.","response":null}

After:

  echo '{"id":279,"projectPHIDs":[],"status":"0","ownerPHID":"PHID-USER-cj3cpuh7oorbmnn2pl5g"}' | arc call-conduit maniphest.update
  {"error":null,"errorMessage":null,"response":{"id":"279","phid":"PHID-TASK-lbwcq3pmur2c5fuqqhlx"...

Reviewers: garoevans, epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8391
2014-03-04 11:42:18 -08:00
..
arcanist/conduit Move Conduit methods inside applications 2012-12-21 12:21:59 -08:00
audit Various linter fixes. 2014-02-26 12:44:58 -08:00
auth Automatically verify the setup account's email address 2014-02-27 15:16:04 -08:00
base Various linter fixes. 2014-02-26 12:44:58 -08:00
cache Minor, mark SERIALIZATION_PHP fields as BINARY in Lisk 2014-02-23 16:35:51 -08:00
calendar Fix calendar display on profile. 2014-02-25 13:43:31 -08:00
chatlog Various linter fixes. 2014-02-26 12:44:58 -08:00
conduit Truncate Conduit 'clientDescription' so we don't overflow the column 2014-02-25 12:35:03 -08:00
config Use CustomField, not AuxiliaryField, to power RevisionView 2014-02-27 11:06:14 -08:00
conpherence Fix some issues where Conpherence would make to many draft requests 2014-03-01 11:23:08 -08:00
countdown [Countdown] fix undefined variable errors 2014-02-05 05:33:31 -08:00
daemon Do not perform write in PhabricatorDaemonLogQuery by default 2014-01-21 14:04:12 -08:00
dashboard Add edit/view plumbing for dashboards and panels 2014-02-03 10:52:15 -08:00
differential Clean up some Differential behaviors 2014-03-03 08:36:40 -08:00
diffusion Produce a more tailored checkout URI for Subversion 2014-02-28 13:04:41 -08:00
diviner Various linter fixes. 2014-02-26 12:44:58 -08:00
doorkeeper Move PhabricatorTagView to PHUITagView 2014-01-14 14:09:52 -08:00
draft/storage Differential - add DifferentialDraft to track whether revisions have draft feedback or not 2014-02-18 16:25:16 -08:00
drydock Various linter fixes. 2014-02-26 12:44:58 -08:00
fact Extend all "ManagementWorkflow" classes from a base class 2013-12-27 13:15:40 -08:00
feed Various linter fixes. 2014-02-26 12:44:58 -08:00
files Convert Phabricator to handle "%s" / "%B" properly 2014-02-23 16:20:46 -08:00
flag Various linter fixes. 2014-02-26 12:44:58 -08:00
harbormaster Add test coverage that our definition of BMP agrees with MySQL 2014-02-23 16:20:38 -08:00
help/controller Make Differential views capability-sensitive 2013-09-26 18:45:04 -07:00
herald Various linter fixes. 2014-02-26 12:44:58 -08:00
home Hide upload JS stuff if user isn't logged in 2014-02-21 13:04:23 -08:00
legalpad Update overall revision status after reviewers change 2014-02-25 12:36:49 -08:00
lipsum Extend all "ManagementWorkflow" classes from a base class 2013-12-27 13:15:40 -08:00
macro Various linter fixes. 2014-02-26 12:44:58 -08:00
mailinglists Simplify PHUIObjectBoxViews handling of Save and Error states 2014-01-10 09:17:37 -08:00
maniphest Check for null, strictly, in maniphest.update param validation 2014-03-04 11:42:18 -08:00
meta Various linter fixes. 2014-02-26 12:44:58 -08:00
metamta Clean up some Differential behaviors 2014-03-03 08:36:40 -08:00
notification Add a "Send Test Notification" button to make testing the server easier 2014-02-17 16:00:33 -08:00
nuance Various linter fixes. 2014-02-26 12:44:58 -08:00
oauthserver Initialize used variable 2013-07-09 21:55:27 -07:00
owners Various linter fixes. 2014-02-26 12:44:58 -08:00
passphrase Passphrase - added "looked at secret" transaction. 2014-02-25 14:58:30 -08:00
paste Update overall revision status after reviewers change 2014-02-25 12:36:49 -08:00
people Implement detail views for many Differential fields on ApplicationTransactions 2014-02-26 14:46:18 -08:00
phame Simplify PHUIObjectBoxViews handling of Save and Error states 2014-01-10 09:17:37 -08:00
phid Provide result type information in tokenizers 2014-02-14 10:23:56 -08:00
phlux Allow CustomField to provide ApplicationTransaction change details 2014-02-21 11:53:04 -08:00
pholio Various linter fixes. 2014-02-26 12:44:58 -08:00
phortune Provide convenience method addTextCrumb() to PhabricatorCrumbsView 2013-12-18 17:47:34 -08:00
phpast Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
phragment Various linter fixes. 2014-02-26 12:44:58 -08:00
phrequent Various linter fixes. 2014-02-26 12:44:58 -08:00
phriction Various linter fixes. 2014-02-26 12:44:58 -08:00
policy Various linter fixes. 2014-02-26 12:44:58 -08:00
ponder Various linter fixes. 2014-02-26 12:44:58 -08:00
project Workboards - add transactions for column changes 2014-03-03 15:58:00 -08:00
releeph Use CustomField, not AuxiliaryField, to power RevisionView 2014-02-27 11:06:14 -08:00
remarkup/conduit Support processing Remarkup in bulk with remarkup.processbulk Conduit method 2013-11-02 16:30:11 -07:00
repository Produce a more tailored checkout URI for Subversion 2014-02-28 13:04:41 -08:00
search Various linter fixes. 2014-02-26 12:44:58 -08:00
settings There should be no spaces before closing parenthesis in calls. 2014-02-26 12:49:33 -08:00
slowvote Various linter fixes. 2014-02-26 12:44:58 -08:00
subscriptions Various linter fixes. 2014-02-26 12:44:58 -08:00
system Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
tokens Wrap the feed text rendering stuff with htmlspecialchars_decode 2014-02-03 17:05:30 -08:00
transactions Workboards - add transactions for column changes 2014-03-03 15:58:00 -08:00
typeahead Various linter fixes. 2014-02-26 12:44:58 -08:00
uiexample PHUITimelineView 2014-02-12 09:02:05 -08:00
xhprof Use JSON, not PHP serialization, for XHProf profiles. 2014-02-24 04:16:52 -08:00