1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/maniphest
Alex Wyler 5fabda2a6d Check for null, strictly, in maniphest.update param validation
Summary:
If the first non-null entry in the params array is falsey, the request bombs.

Something like {"id":279,"projectPHIDs":[],"status":"0","ownerPHID":"PHID-USER-on3xxsnaljmfn36d4b7a"}

Test Plan:
Before:

  echo '{"id":279,"projectPHIDs":[],"status":"0","ownerPHID":"PHID-USER-cj3cpuh7oorbmnn2pl5g"}' | arc call-conduit maniphest.update
  {"error":"ERR-NO-EFFECT","errorMessage":"ERR-NO-EFFECT: Update has no effect.","response":null}

After:

  echo '{"id":279,"projectPHIDs":[],"status":"0","ownerPHID":"PHID-USER-cj3cpuh7oorbmnn2pl5g"}' | arc call-conduit maniphest.update
  {"error":null,"errorMessage":null,"response":{"id":"279","phid":"PHID-TASK-lbwcq3pmur2c5fuqqhlx"...

Reviewers: garoevans, epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8391
2014-03-04 11:42:18 -08:00
..
application Various linter fixes. 2014-02-26 12:44:58 -08:00
capability Add capabilities for editing task triage details (priority, assignee, etc) 2013-10-21 16:59:06 -07:00
conduit Check for null, strictly, in maniphest.update param validation 2014-03-04 11:42:18 -08:00
config Convert maniphest to use standard fields 2013-09-19 11:56:15 -07:00
constants Move many task status hardcodes into ManiphestTaskStatus 2014-02-17 15:59:31 -08:00
controller Maniphest - move subpriority edits to be transaction powered 2014-02-27 09:39:59 -08:00
editor Workboards - add transactions for column changes 2014-03-03 15:58:00 -08:00
event ProjectView improvements 2014-02-13 14:36:49 -08:00
export Implemented support for different export formats. 2013-04-11 11:27:36 -07:00
field Move many task status hardcodes into ManiphestTaskStatus 2014-02-17 15:59:31 -08:00
lipsum Move many task status hardcodes into ManiphestTaskStatus 2014-02-17 15:59:31 -08:00
mail Move many task status hardcodes into ManiphestTaskStatus 2014-02-17 15:59:31 -08:00
phid Move many task status hardcodes into ManiphestTaskStatus 2014-02-17 15:59:31 -08:00
query Move many task status hardcodes into ManiphestTaskStatus 2014-02-17 15:59:31 -08:00
remarkup Remove obsolete/deprecated withTaskIDs() / withTaskPHIDs() 2013-09-10 15:34:04 -07:00
search Use ApplicationTransactions/CustomField to power Differential global search 2014-02-26 11:18:06 -08:00
storage Workboards - add transactions for column changes 2014-03-03 15:58:00 -08:00
view Bump number of visible Maniphest tags to 4 (from 2) 2014-02-13 10:05:47 -08:00