1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/maniphest/conduit
Alex Wyler 5fabda2a6d Check for null, strictly, in maniphest.update param validation
Summary:
If the first non-null entry in the params array is falsey, the request bombs.

Something like {"id":279,"projectPHIDs":[],"status":"0","ownerPHID":"PHID-USER-on3xxsnaljmfn36d4b7a"}

Test Plan:
Before:

  echo '{"id":279,"projectPHIDs":[],"status":"0","ownerPHID":"PHID-USER-cj3cpuh7oorbmnn2pl5g"}' | arc call-conduit maniphest.update
  {"error":"ERR-NO-EFFECT","errorMessage":"ERR-NO-EFFECT: Update has no effect.","response":null}

After:

  echo '{"id":279,"projectPHIDs":[],"status":"0","ownerPHID":"PHID-USER-cj3cpuh7oorbmnn2pl5g"}' | arc call-conduit maniphest.update
  {"error":null,"errorMessage":null,"response":{"id":"279","phid":"PHID-TASK-lbwcq3pmur2c5fuqqhlx"...

Reviewers: garoevans, epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8391
2014-03-04 11:42:18 -08:00
..
ConduitAPI_maniphest_createtask_Method.php Add defualt view and default edit policies for tasks 2013-10-09 13:53:17 -07:00
ConduitAPI_maniphest_find_Method.php Move Conduit methods inside applications 2012-12-21 12:21:59 -08:00
ConduitAPI_maniphest_gettasktransactions_Method.php Use ManiphestTransactionQuery directly in maniphest.gettasktransactions 2013-09-23 14:30:54 -07:00
ConduitAPI_maniphest_info_Method.php Use ManiphestTaskQuery in nearly all interfaces 2013-09-25 13:44:14 -07:00
ConduitAPI_maniphest_Method.php Move many task status hardcodes into ManiphestTaskStatus 2014-02-17 15:59:31 -08:00
ConduitAPI_maniphest_query_Method.php Remove obsolete/deprecated withTaskIDs() / withTaskPHIDs() 2013-09-10 15:34:04 -07:00
ConduitAPI_maniphest_update_Method.php Check for null, strictly, in maniphest.update param validation 2014-03-04 11:42:18 -08:00