1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 11:42:42 +01:00
phorge-phorge/src/applications/settings/controller
epriestley e5a1681903 Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles").
Summary:
See downstream <https://phabricator.wikimedia.org/T902>. Currently, timezones are rendered with their raw internal names (like `America/Los_Angeles`) which include underscores.

Replacing underscores with spaces is a more human-readable (and perhaps meaningfully better for things like screen readers, although this is pure speculation).

There's some vague argument against this, like "administrators may need to set a raw internal value in `phabricator.timezone` and this could mislead them", but we already give a pretty good error message if you do this and could improve hinting if necessary.

Test Plan: Viewed timezone list in {nav Settings} and the timezone "reconcile" dialog, saw a more-readable "Los Angeles".

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20559
2019-05-30 15:03:11 -07:00
..
PhabricatorSettingsAdjustController.php Use transactions to apply Ajax settings mutations 2016-06-05 08:48:43 -07:00
PhabricatorSettingsIssueController.php Raise an "Account Setup Issue" if your primary address is unverified 2017-02-13 10:41:32 -08:00
PhabricatorSettingsListController.php Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
PhabricatorSettingsMainController.php Add icons to Settings 2019-01-23 13:41:41 -08:00
PhabricatorSettingsTimezoneController.php Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles"). 2019-05-30 15:03:11 -07:00