1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 01:32:42 +01:00
phorge-phorge/src/applications/harbormaster
epriestley 6f508a2258 Update buildable containerPHIDs in a proper way via BuildWorker rather than via sneaky uncoordinated write
Summary:
Depends on D19065. Ref T13054. Instead of just updating `containerPHID` and hoping for the best, queue a proper BuildWorker to process a "your container has changed, update it" message.

We also need to remove a (superfluous) `withContainerPHIDs()` when loading active diffs for a revision.

Test Plan:
  - Without daemons, created a revision and saw builds stick in "preparing" with no container PHID, but also stay in draft mode.
  - With daemons, saw builds actually build and get the right container PHID.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13054

Differential Revision: https://secure.phabricator.com/D19066
2018-02-12 12:18:52 -08:00
..
__tests__ Add "Autoplans" to Harbormaster 2015-06-21 09:04:21 -07:00
application Integrate Harbormaster with Buildkite 2017-01-31 09:19:43 -08:00
artifact Allow "harbormaster.createartifact" to decode raw HTTP parameter types of artifact properties 2016-11-17 08:03:01 -08:00
autoplan Give "Arcanist Client Results" a more clear name 2015-09-09 19:18:08 -07:00
capability Add spelling TODOs 2017-10-09 11:56:53 -07:00
conduit Make Harbormaster buildable status more of a nice flexible map and less of a bunch of switch statements 2018-02-12 12:18:06 -08:00
constants Start buildables in "PREPARING", move them to "BUILDING" after builds queue 2018-02-12 12:18:29 -08:00
controller Start buildables in "PREPARING", move them to "BUILDING" after builds queue 2018-02-12 12:18:29 -08:00
customfield Allow "Wait for Message" to be unset on build plans 2016-11-22 14:02:37 -08:00
editor Update EditEngine for two column 2016-03-28 09:18:55 -07:00
engine Update buildable containerPHIDs in a proper way via BuildWorker rather than via sneaky uncoordinated write 2018-02-12 12:18:52 -08:00
engineextension Subsume 'harbormaster.querybuilds' with a modern search API method 2016-07-31 21:44:22 +00:00
event Make Harbormaster buildable status more of a nice flexible map and less of a bunch of switch statements 2018-02-12 12:18:06 -08:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
future Allow Harbormaster to run commands on Drydock working copies 2015-09-25 10:43:32 -07:00
herald Don't run Herald build and mail rules when they don't make sense 2017-10-27 08:44:12 -07:00
interface Navigage Buildkite builds with more nuance 2017-01-31 17:26:45 -08:00
management Start buildables in "PREPARING", move them to "BUILDING" after builds queue 2018-02-12 12:18:29 -08:00
phid Update Buildable search in Harbormaster 2016-02-27 07:13:10 -08:00
query Make Harbormaster buildable status more of a nice flexible map and less of a bunch of switch statements 2018-02-12 12:18:06 -08:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
step Navigage Buildkite builds with more nuance 2017-01-31 17:26:45 -08:00
stepgroup Fix 4 typos in code 2017-04-07 04:09:56 -07:00
storage Start buildables in "PREPARING", move them to "BUILDING" after builds queue 2018-02-12 12:18:29 -08:00
typeahead Search builds based on who kicked them off 2016-07-31 20:54:44 +00:00
view Search and Replace calls to setShade 2017-05-22 18:59:53 +00:00
worker Start buildables in "PREPARING", move them to "BUILDING" after builds queue 2018-02-12 12:18:29 -08:00