1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 15:52:41 +01:00
phorge-phorge/src/applications
epriestley 70fd96037b Consolidate user editing code
Summary:
  - We currently have some bugs in account creation due to nontransactional user/email editing.
    - We save $user, then try to save $email. This may fail for various reasons, commonly because the email isn't unique.
    - This leaves us with a $user with no email.
  - Also, logging of edits is somewhat inconsistent across various edit mechanisms.
  - Move all editing to a `PhabricatorUserEditor` class.
  - Handle some broken-data cases more gracefully.

Test Plan:
  - Created and edited a user with `accountadmin`.
  - Created a user with `add_user.php`
  - Created and edited a user with People editor.
  - Created a user with OAuth.
  - Edited user information via Settings.
  - Tried to create an OAuth user with a duplicate email address, got a proper error.
  - Tried to create a user via People with a duplicate email address, got a proper error.

Reviewers: btrahan, vrana, jungejason

Reviewed By: btrahan

CC: tberman, aran

Maniphest Tasks: T1184

Differential Revision: https://secure.phabricator.com/D2569
2012-05-25 07:30:44 -07:00
..
audit When a user resigns from a commit they have authority over auditing projects for, write resign explicitly 2012-05-07 18:37:04 -07:00
auth Consolidate user editing code 2012-05-25 07:30:44 -07:00
base Allow installs to require email verification 2012-05-21 12:47:38 -07:00
calendar Don't mix different users on the same line in Calendar 2012-05-21 14:25:26 -07:00
chatlog Add pagers to server clients and client authorizations in OAuth Server GUI 2012-04-04 17:51:16 -07:00
conduit Consolidate user editing code 2012-05-25 07:30:44 -07:00
countdown Add "final" to more classes 2012-03-13 11:18:11 -07:00
daemon Reorder the daemon console's display of the panels 2012-04-18 13:47:08 -07:00
differential Display author of last manual diff in summary and test plan comments 2012-05-24 15:38:45 -07:00
diffusion Show the difference between a committer and an author 2012-05-23 08:34:54 -07:00
directory/controller Hard-code and unify "more applications" in Phabricator 2012-04-28 07:17:38 -07:00
draft/storage Add "final" to more classes 2012-03-13 11:18:11 -07:00
drydock More Drydock Stuff 2012-03-26 20:54:26 -07:00
feed Use "closed", not "committed", in Differential 2012-04-23 17:40:57 -07:00
files Minor, fix a documentation link (thanks, @ipalaus!). 2012-05-22 05:59:40 -07:00
flag Use assert_instances_of() everywhere but Differential and Diffusion 2012-04-03 14:53:20 -07:00
harbormaster/storage Remove PHID database, add Harbormaster database 2012-05-20 14:46:01 -07:00
help/controller Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
herald Display Browse in Diffusion and Open in Editor links in commit detail 2012-04-10 09:54:38 -07:00
maniphest Allow users to specify whether Maniphest custom fields should be copied or not when creating a "Similar Task" 2012-05-07 13:38:27 -07:00
markup Don't process links in Remarkup literal block 2012-04-18 10:48:20 -07:00
metamta Prevent loops in received mail 2012-05-22 06:02:05 -07:00
notifications/controller Make Aphlict client somewhat more approachable 2012-03-06 20:14:03 -08:00
oauthserver Add pagers to server clients and client authorizations in OAuth Server GUI 2012-04-04 17:51:16 -07:00
owners Fix diffusion browse links in the owner's tool 2012-05-20 11:30:01 -07:00
paste Display author in paste detail 2012-04-18 11:46:59 -07:00
people Consolidate user editing code 2012-05-25 07:30:44 -07:00
phame Phame - use post title for the actual web page title 2012-05-01 11:50:51 +02:00
phid Minor, remove getEmail() since D2494 removed these methods. 2012-05-24 15:37:33 -07:00
phortune For discussion -- Stripe integration 2012-04-04 16:09:29 -07:00
phriction Phriction - lock down /project/ wiki docs 2012-05-20 08:54:25 -07:00
policy Improve Policy options 2012-04-17 07:52:10 -07:00
project Use a disk-based default avatar, not a database-based one 2012-04-27 17:44:10 -07:00
repository Fix repository interactions for SVN repositories using the SVN protocol with SASL 2012-05-23 12:37:43 -07:00
search Increase result set to 100 from 25 for "attach" dialog 2012-05-20 14:56:04 -07:00
slowvote Use assert_instances_of() everywhere but Differential and Diffusion 2012-04-03 14:53:20 -07:00
status/base Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
typeahead/controller Allow projects to own packages 2012-04-03 16:20:07 -07:00
uiexample Use head_key() and last_key() to explicitly communicate intent 2012-04-09 11:08:59 -07:00
xhpastview Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
xhprof Make XHProf easier for me to use with other users 2012-05-21 12:47:29 -07:00