Andre Klapper ff7be2cf14 Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest() ... Summary: The expression `$all_tags[$tag]['count']` does not do anything. Reading the surrounding code, intention is to display a "Common" section on `/settings/panel/emailpreferences/` listing MailTags defined by at least two different applications. (This is currently not the case anyway as Phorge prefixes all MailTags with their corresponding application but might be a future use case.) This change fixes the logic accordingly. Closes T15874 Test Plan: Apply the patch; replace the value of a random `const MAILTAG_*` line in the codebase with the value of another random `const MAILTAG_*` line in the codebase to make it "common", now see that `/settings/panel/emailpreferences/` displays this MailTag in a "Common" section on top of the options. Reviewers: O1 Blessed Committers, speck Reviewed By: O1 Blessed Committers, speck Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15874 Differential Revision: https://we.phorge.it/D25727		2024-07-10 08:38:33 +02:00
..
action	Simplify implementation of "SysetemAction->getSystemActionConstant()"	2019-07-19 15:45:37 -07:00
application	Replace old hard-coded URI-based "changes saved" jank with new overgeneralized cookie-based "changes saved" jank	2020-04-19 09:04:31 -07:00
controller	Adjust message in timezone conflict form	2023-11-10 09:03:30 +00:00
editor	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
panel	Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest()	2024-07-10 08:38:33 +02:00
panelgroup	Expand "Settings" UI to full-width	2019-01-23 13:40:34 -08:00
phid	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
query	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
setting	PHP 8 and Diviner Technical Documentation	2023-08-18 15:38:16 -07:00
storage	Correct overbroad automatic capability grant of global settings objects	2022-05-09 15:10:50 -07:00