1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/applications/differential
epriestley 8a5def8e0a Remove legacy transaction editor "getDisableEmail()" method
Summary:
Ref T13042. This is a very, very old policy-violating option from yesteryear which supported build systems publishing updates by adding comments to revisions, without sending email about it.

Harbormaster has served this role for a long time and this is policy-violating in the general case (it allows attackers to act in secret).

Test Plan: Grepped for affected symbols.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13042

Differential Revision: https://secure.phabricator.com/D18881
2018-01-19 13:23:06 -08:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
application Update menu item names for Applications -> Favorites 2017-09-05 19:05:03 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Define Differential email action in terms of EditEngine 2017-01-02 13:25:45 -08:00
conduit Remove legacy transaction editor "getDisableEmail()" method 2018-01-19 13:23:06 -08:00
config Add yaml files to differential.whitespace-matters 2017-11-15 11:57:11 -08:00
constants Include "Draft" revisions in Differential legacy status queries 2017-11-07 15:35:33 -08:00
controller Fix spelling 2017-10-09 10:48:04 -07:00
customfield Allow revisions to be held as drafts, even after builds finish 2017-10-31 09:39:32 -07:00
doorkeeper Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator 2017-08-09 11:04:52 -07:00
edge Provide revision parent/child edges in edge.search, and more information in differential.revision.search 2017-11-07 15:34:31 -08:00
editor Denormalize added and removed line counts for the current diff onto revisions 2017-12-18 09:17:55 -08:00
engine Add an explicit warning in the Differential transaction log when users skip review 2017-11-30 11:03:55 -08:00
engineextension Provide a "Reviewers" attachment to "differential.revision.search" 2017-04-06 14:46:39 -07:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
field Move misplaced validation for ambiguous fields in "Test Plan" to the right place 2017-06-30 06:36:05 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
herald Don't run Herald build rules when Differential revisions are updated automatically 2017-10-31 11:36:04 -07:00
lipsum Rename "getReviewerStatus()" to "getReviewers()" 2017-03-20 17:11:40 -07:00
mail Rename "needReviewerStatus()" into "needReviewers()" 2017-03-20 16:46:16 -07:00
management Support storage of Differential hunk data in Files 2017-09-11 16:09:02 -07:00
parser Return transactions from "differential.parsecommitmessage" 2017-10-30 15:15:42 -07:00
phid Make all revision status readers explicitly read modern or legacy status 2017-08-11 17:22:22 -07:00
query Refine bucketing and display rules for voided "Accepts" in Differential 2017-11-07 15:35:11 -08:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Add aural "+" and "-" hints to unified diffs for users who use screenreaders 2017-10-20 11:09:46 -07:00
search Reduce the amount of boilerplate that implementing FerretInterface requires 2017-09-07 13:23:31 -07:00
storage Always show "X requested review" in mail to stop some undraft mail from being dropped 2018-01-04 08:14:31 -08:00
typeahead Fix spelling 2017-10-09 10:48:04 -07:00
view Warn and prevent 1-up/2-up switch in Differential if the user is editing an inline 2017-11-15 10:02:48 -08:00
xaction Execute Herald again after promoting revisions out of the "Draft" state 2017-12-05 12:13:56 -08:00
DifferentialGetWorkingCopy.php Extend from Phobject 2015-06-15 18:02:27 +10:00