1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-13 12:54:53 +01:00
phorge-phorge/src/applications
Valerio Bozzolan 903d71e67d Workboard: Milestone Name easily editable (instead of surfing 3 pages)
Summary:
After this change, a new input field "Milestone Name" appears in the "Edit" menu of a Milestone:

| Before    | After     |
|-----------|-----------|
| {F314008} | {F314005} |

So you can quickly change the name of your Milestones, from a Workboard.

Before this change, from a Workboard, this was the way to rename a Milestone:

1. click on the Milestone name (yes, that is a link)
2. click on Manage
3. click on Edit Details
4. rename
5. Save
6. Manually visit again the Project's Workboard

After this change, from a Workboard, you just need to:

1. click on Milestone > Edit
2. click on Edit Column
3. rename
4. Save

Example usage:

{F314015}

This does not change the level of permissions needed: if you have not enough
permissions to see or edit a Milestone, you cannot access this feature indeed.

In short, this is just a frontend change, keeping current policies as-is.

Closes T15143

Test Plan:
Create a Project or use an existing editable one.

Create a Milestone called "Test Milestone". You can create Milestones visiting the Project's menu {nav icon=sitemap,name=Subprojects > icon=plus,name=Create next milestone}

Visit the Project's Workboard. Find the column "Test Milestone". Click the Edit button on a Milestone, and:

- try to save another name: it must work
- try to save an empty name: nice error message shown
- try to save both the score points and the name: it must work
- try to save "FOO" as Points: you still see the error message

Also:

- do the same for the Backlog column: it still works (name still allowed to be empty)
- do the same for a "normal" Column (not the Backlog): it still work (name still __not__ allowed to be empty)

Reviewers: O1 Blessed Committers, Cigaryno, 20after4, waldyrious

Reviewed By: O1 Blessed Committers, Cigaryno, 20after4, waldyrious

Subscribers: waldyrious, brennen, aklapper, 20after4, speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15143

Differential Revision: https://we.phorge.it/D25066
2023-09-25 08:17:51 +02:00
..
almanac
aphlict Aphlict - search for default config in the right place 2023-07-24 00:42:06 -07:00
arcanist/conduit
audit Correct spelling mistake in PhabricatorAuditEditor 2023-05-30 10:43:40 +02:00
auth Fix PHP 8.1 auth view strlen(null) error 2023-09-11 11:57:35 +01:00
badges
base Fix PHP 8.1 "strlen(null)" exception which blocks rendering most applications' Configure pages 2023-05-08 13:23:31 +02:00
cache
calendar Fix PHP 8.1 "strlen(null)" exceptions importing ICS file into calendar 2023-08-19 10:09:49 +02:00
celerity Teach ./bin/celerity about sprite maps 2023-06-03 09:57:05 -07:00
chatlog
conduit Fix arc patch PHP 8.1 strlen(null) error 2023-07-29 17:36:13 +01:00
config Fix a PHP 8.1 deprecated use of strlen with a NULL argument 2023-08-18 09:20:36 +02:00
conpherence Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Conpherence page 2023-04-30 18:24:49 +02:00
console log deprecation events in Dark Console 2023-08-31 08:18:28 -07:00
countdown Dashboards: add capability who can create Dashboards 2023-06-19 12:12:22 +02:00
daemon Rebrand: Add "path" entries to PlatformSymbols 2023-08-18 02:00:41 -07:00
dashboard Various PHP 8.1 strlen(null) fixes for Dashboard Panels 2023-09-05 17:33:11 +01:00
differential Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector() 2023-08-12 08:39:36 +01:00
diffusion Implement ferret engine in typeahead datasource query for repos 2023-09-04 09:48:41 +02:00
diviner Fix Diviner strlen(null) error when clicking on a link 2023-09-06 12:23:42 +01:00
doorkeeper
draft/storage
drydock
fact
favorites
feed
files Fix PHP 8.1 strlen(null) error in PhabricatorFile::newChunkedFile() 2023-07-17 14:24:41 +01:00
flag
fund
guides
harbormaster Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster 2023-08-11 21:01:39 +02:00
help
herald Work around exception in Herald transcript of old tasks: Call to a member function getAppliedTransactionPHIDs() on bool 2023-06-12 21:49:14 +02:00
home Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Home page 2023-05-01 15:37:56 +02:00
legalpad Fix PHP 8.1 "strlen(null)" exceptions which block rendering Legalpad signatures 2023-05-19 17:01:53 +02:00
lipsum
macro Fix PHP 8.1 "ltrim(null)" exception which blocks rendering first Meme comment 2023-06-10 18:41:00 +02:00
maniphest Fix PHP 8.1 "strlen(null)" exception listing >100 task search results 2023-08-16 10:58:08 +02:00
meta Fix PHP 8.1 "ltrim(null)" exception which blocks rendering five applications' Configure pages 2023-05-08 14:33:43 +02:00
metamta Rebrand: Add "path" entries to PlatformSymbols 2023-08-18 02:00:41 -07:00
multimeter Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page 2023-05-29 12:35:54 +02:00
notification Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument 2023-08-18 09:20:03 +02:00
nuance
oauthserver
owners Fix PHP 8.1 "strlen(null)" and preg_match() exceptions which block rendering "Browse Subscribers" overlay dialog 2023-05-12 12:02:15 +02:00
packages
passphrase Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential 2023-08-11 20:56:49 +02:00
paste Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit paste.create 2023-08-18 09:48:41 +02:00
people Fix PHP 8.1 substr(null) in People > Activity Logs 2023-07-17 14:23:30 +01:00
phame Fix typo "this this server" 2023-08-17 17:46:11 +02:00
phid
phlux
pholio Fix Pholio RuntimeException: Undefined variable $dictionary (when adding an empty Inline Comment) 2023-06-19 14:13:36 +02:00
phortune Fix typo in PhortuneMerchant.php 2023-05-30 12:00:51 +02:00
phpast
phrequent
phriction Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in Conduit 2023-08-18 09:50:19 +02:00
phurl
policy
ponder Ponder: strike code of resolved questions in query results 2023-03-27 20:55:18 +02:00
project Workboard: Milestone Name easily editable (instead of surfing 3 pages) 2023-09-25 08:17:51 +02:00
remarkup
repository Implement ferret engine in typeahead datasource query for repos 2023-09-04 09:48:41 +02:00
search Various PHP 8.1 strlen(null) fixes for Dashboard Panels 2023-09-05 17:33:11 +01:00
settings PHP 8 and Diviner Technical Documentation 2023-08-18 15:38:16 -07:00
slowvote Update Slowvote poll status to use sensible string constants 2022-05-27 10:15:01 -07:00
spaces Fix PHP 8.1 "strlen(null)" exception which blocks Space creation 2023-05-06 04:05:37 +02:00
subscriptions
support/application
system Fix information page about Read-only status 2023-03-25 12:06:35 +01:00
tokens
transactions Fix call to undefined method PhutilJSON::encodeAsObject() 2023-09-02 11:13:06 +02:00
typeahead Fix PHP 8.1 null parameter exceptions which block rendering the "Browse Projects" overlay dialog 2023-05-20 17:48:53 +02:00
uiexample
xhprof