mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-22 18:28:47 +02:00
90d0f8ac6c
Summary: Ref PHI174. This reverts most of these changes: -37843127e9
/ D18481 -94cad30ac3
/ D18474 -12ae08b6b1
/ D18473 -0a01334172
/ D18462 -ac91ab1ef9
/ D18452 These changes made the Diffusion blame view very similar to GitHub's blame view. See D18452 for a before/after of the bulk of these changes; the other revisions are bugfixes. I think this was generally a step backward, and not motivated by solving a specific problem. I've found the new UI less usable than the old one, and at least one install (see PHI174) also has. In particular, the revision/commit titles are very bulky and not terribly useful; the date column also isn't terribly useful; the "age" color actually IS pretty useful and was heavily de-emphasized. I've kept one bugfix here (missing `'a'` tag type) and kept the upgraded icon for "Skip Past This Commit". I'm going to follow this up with some additional changes: - Show a small author profile icon, similar to GitHub, to address PHI174 more directly. - Try a zebra-stripe on blocks of rows to make it more clear where changes affected by a particular commit begin and end. - Try a hue shift, not just a brightness/saturation shift, to make the "age" color more distinct. - Try computing colors as even steps, not based purely on age. Currently, if a file has one long-distant commit and several recent commits, all the recent ones show up as very bright green. I think this would probably be more useful if they were distributed more evenly across the available color bands. Test Plan: Viewed blame views in Diffusion, saw a more compact UI similar to the old UI. {F5251019} Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D18746
92 lines
1.6 KiB
CSS
92 lines
1.6 KiB
CSS
/**
|
|
* @provides diffusion-source-css
|
|
*/
|
|
|
|
.diffusion-source {
|
|
width: 100%;
|
|
background: {$page.content};
|
|
overflow: hidden;
|
|
}
|
|
|
|
.device-phone .diffusion-source-wrap {
|
|
overflow: scroll;
|
|
-webkit-overflow-scrolling: touch;
|
|
}
|
|
|
|
.diffusion-source tr.phabricator-source-highlight {
|
|
background: {$sh-yellowbackground};
|
|
}
|
|
|
|
.diffusion-source th {
|
|
text-align: right;
|
|
vertical-align: top;
|
|
background: {$lightgreybackground};
|
|
color: {$bluetext};
|
|
border-right: 1px solid {$thinblueborder};
|
|
}
|
|
|
|
.diffusion-source td {
|
|
vertical-align: top;
|
|
white-space: pre-wrap;
|
|
padding-top: 1px;
|
|
padding-bottom: 1px;
|
|
padding-left: 8px;
|
|
width: 100%;
|
|
word-break: break-all;
|
|
}
|
|
|
|
.device .diffusion-source td {
|
|
word-break: normal;
|
|
white-space: nowrap;
|
|
}
|
|
|
|
.diffusion-browse-type-form {
|
|
float: right;
|
|
}
|
|
|
|
.diffusion-blame-link,
|
|
.diffusion-rev-link {
|
|
white-space: nowrap;
|
|
}
|
|
|
|
.diffusion-blame-link {
|
|
min-width: 28px;
|
|
}
|
|
|
|
.diffusion-source th.diffusion-rev-link {
|
|
text-align: left;
|
|
min-width: 130px;
|
|
}
|
|
|
|
.diffusion-blame-link a,
|
|
.diffusion-rev-link a,
|
|
.diffusion-line-link a {
|
|
color: {$darkbluetext};
|
|
}
|
|
|
|
.diffusion-rev-link a,
|
|
.diffusion-rev-link span {
|
|
margin: 2px 8px 0;
|
|
display: inline-block;
|
|
}
|
|
|
|
.diffusion-rev-link span {
|
|
margin-right: -4px;
|
|
margin-left: -4px;
|
|
color: {$lightgreytext};
|
|
}
|
|
|
|
.diffusion-blame-link a,
|
|
.diffusion-line-link a {
|
|
/* Give the user a larger click target. */
|
|
display: block;
|
|
padding: 2px 8px;
|
|
}
|
|
|
|
.diffusion-line-link {
|
|
-moz-user-select: -moz-none;
|
|
-khtml-user-select: none;
|
|
-webkit-user-select: none;
|
|
-ms-user-select: none;
|
|
user-select: none;
|
|
}
|