1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
phorge-phorge/webroot/rsrc/js/application
epriestley 9a8eb4026e Make race condition window for Conpherence smaller and rarer
Summary:
Ref T6713. This isn't very clean, and primarily unblocks D11143.

After D11143, I have a reliable local race where I submit, get a notification immediately, then get a double update (form submission + notification-triggered update).

Instead, make the notification updates wait for form submissions.

This doesn't resolve the race completely. The notification updates don't block chat submission (only the other way around), so if you're really fast you can submit at the same time someone else sends chat and race. But this fixes the most glaring issue.

The overall structure here is still pretty shaky but I tried to improve things a little, at least.

Test Plan: Chatted with myself, saw 0 races instead of 100% races.

Reviewers: btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T6713

Differential Revision: https://secure.phabricator.com/D11277
2015-01-08 09:44:02 -08:00
..
aphlict Implement more correct white-icon menu behavior 2014-12-10 16:26:40 -08:00
auth Add Persona auth provider 2013-10-14 14:34:57 -07:00
config Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
conpherence Make race condition window for Conpherence smaller and rarer 2015-01-08 09:44:02 -08:00
countdown Define JavaScript functions before they are used 2014-12-30 02:53:32 -08:00
dashboard Fix various spelling mistakes 2014-07-13 00:45:33 +10:00
differential Define diff as a local variable 2014-12-30 02:58:51 -08:00
diffusion Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
doorkeeper Various linter fixes. 2014-02-26 12:44:58 -08:00
files Various linter fixes. 2014-02-26 12:44:58 -08:00
herald T5015, Allow Herald rules for Maniphest to act on task status changes 2014-11-12 12:55:24 -08:00
maniphest Fix str being defined as a global variable 2014-12-30 02:57:53 -08:00
owners Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
passphrase Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
phame Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
pholio Fix next_src being defined as a global variable 2014-12-30 02:56:50 -08:00
phortune Define JavaScript functions before they are used 2014-12-30 02:53:32 -08:00
policy Mostly modernize the policy control typeahead 2014-07-17 15:56:20 -07:00
ponder Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
projects Workboards - on edit, remove a task if no longer associated with workboard 2015-01-06 13:28:35 -08:00
releeph Remove @group annotations 2014-07-10 08:12:48 +10:00
repository Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
search Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
slowvote Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
transactions Transactions - change show all key from "~" to "@" 2014-12-12 11:23:56 -08:00
uiexample Use window.confirm instead of confirm 2014-12-30 02:55:12 -08:00