1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-13 07:18:35 +01:00
phorge-phorge/src/view/phui
epriestley 9ad9ac9be6 On Dashboard tab panels in edit mode, make the "Tab Name" and the "Dropdown Edit Caret" into different links
Summary:
Ref T13272. In edit mode, tab panels now have a dropdown menu. However, this sort of overrlaps with the actual action of clicking the tab to select it.

Separate these into different click targets so that "select tab X" and "open dropdown menu for X" are different operations.

This is more work than it appears because:

  - We have an "action icon" already, used when you put a dashboard on a portal/home to create an "Edit" link. It makes sense to attach dropdowns to this, but it has some hard-coded stuff.
  - In applications with a "Create <thing>" in the crumbs (like Maniphest), we may use a dropdown menu if there are multiple create forms available. However, this menu renders in a weird way by reading all the properties out of an actual "View" object and building something else.
  - The "list of tabs" stuff shares code with different "list of tabs" navigation used by Diffusion and Instances.

..but I think I fixed everything and didn't break anything.

Test Plan:
  - Clicked "select tab" and "open dropdown menu" as separate actions.
  - Viewed Diffusion, Maniphest with multiple create forms, Instances.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13272

Differential Revision: https://secure.phabricator.com/D20396
2019-04-12 06:08:32 -07:00
..
__tests__ Ensure that PHUIInvisibleCharacterTestCase is compatible with PHP 5.3 2016-11-15 14:46:22 -08:00
calendar Fix errors found by PHPStan 2017-02-18 09:24:56 +00:00
PHUI.php Remove unused call to phui-text 2016-01-29 12:41:04 -08:00
PHUIActionPanelView.php Add setImage to PHUIActionPanelView 2017-07-30 13:20:26 -07:00
PHUIBadgeBoxView.php PHUIBadgeMiniView 2015-07-10 10:49:28 -07:00
PHUIBadgeMiniView.php Converting badge quality property from color to an integer representation for later sorting purposes 2016-03-30 17:28:34 -07:00
PHUIBadgeView.php Links on badge card should be accessible 2016-04-15 07:55:31 -07:00
PHUIBigInfoView.php Add a UIExamples page for PHUIBigInfoView 2017-08-07 15:58:49 -07:00
PHUIBoxView.php Add basic grey and blue styles for PHUIBoxView 2016-01-21 07:14:39 -08:00
PHUIButtonBarView.php Move simple buttons, bar to own CSS file 2017-06-01 16:52:00 -07:00
PHUIButtonView.php Allow Phriction document edits to be saved as drafts 2018-09-12 13:30:40 -07:00
PHUICMSView.php Rough in Guides Application 2016-08-17 10:14:05 -07:00
PHUICrumbsView.php On Dashboard tab panels in edit mode, make the "Tab Name" and the "Dropdown Edit Caret" into different links 2019-04-12 06:08:32 -07:00
PHUICrumbView.php Allow navigation breadcrumbs to be marked as "always visible" so they show up on phones 2018-05-09 13:21:47 -07:00
PHUIDocumentSummaryView.php Add a Read More link to PHUIDocumentSummaryView 2015-12-19 12:49:23 -08:00
PHUIDocumentView.php Layout Phriction actions without floats, to avoid conflicts with floating content 2018-09-10 11:19:53 -07:00
PHUIFeedStoryView.php Update notification UI a little 2017-08-28 14:52:52 -07:00
PHUIHeaderView.php Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults 2018-04-27 16:56:11 -07:00
PHUIHeadThingView.php Fix specifications of some "Visual Only" elements 2019-02-13 12:26:28 -08:00
PHUIHovercardView.php Separate button CSS classes 2017-06-05 20:14:34 +00:00
PHUIIconCircleView.php Try layering state icons on PHUICircleIconView 2017-05-26 13:55:42 -07:00
PHUIIconView.php When an edit overrides an object lock, note it in the transaction record 2019-02-09 06:10:07 -08:00
PHUIImageMaskView.php Fix AphrontTagView visibility 2015-01-14 06:54:39 +11:00
PHUIInfoView.php Add CSRF to SMS challenges, and pave the way for more MFA types (including Duo) 2019-01-24 15:10:57 -08:00
PHUIInvisibleCharacterView.php Added initial class for displaying invisible chars 2016-09-12 21:57:01 -04:00
PHUILeftRightView.php Rudamentary PHUILeftRightView 2017-07-10 18:19:57 -07:00
PHUIListItemView.php On Dashboard tab panels in edit mode, make the "Tab Name" and the "Dropdown Edit Caret" into different links 2019-04-12 06:08:32 -07:00
PHUIListView.php Improve handle loading semantics for tokenizers 2015-04-02 13:42:01 -07:00
PHUIObjectBoxView.php Fix comment box borders in timelines after Phriction commenting 2018-09-19 13:56:58 -07:00
PHUIObjectItemListView.php Provide a clearer UI for "view all results" in partial result panels 2019-03-25 14:35:08 -07:00
PHUIObjectItemView.php Make the "Install Dashboard" flow smoother 2019-04-09 13:34:09 -07:00
PHUIPagerView.php Fix a couple more "URI->alter()" callsites in paging code 2019-02-16 07:28:35 -08:00
PHUIPinboardItemView.php Convert all calls to 'IconFont' to just 'Icon' 2016-01-27 20:59:27 -08:00
PHUIPinboardView.php [Redesign] Center Pinboard Items 2015-05-31 14:28:16 -07:00
PHUIPropertyGroupView.php PHUIPropertyListView 2013-10-11 07:53:56 -07:00
PHUIPropertyListView.php Disambiguate isEmpty() 2016-01-31 15:20:04 -08:00
PHUIRemarkupPreviewPanel.php Rename "PHUIDocumentViewPro" to "PHUIDocumentView" 2018-08-28 14:53:07 -07:00
PHUISegmentBarSegmentView.php Add a basic progress bar for milestones 2016-02-08 18:50:22 -08:00
PHUISegmentBarView.php First cut of progress bars (PHUISegmentBarView) 2016-02-08 15:28:09 -08:00
PHUIStatusItemView.php Update Calendar for PHUITwoColumnView 2016-03-02 18:12:42 -08:00
PHUIStatusListView.php Fix AphrontTagView visibility 2015-01-14 06:54:39 +11:00
PHUITabGroupView.php Remove old ObjectBox tab cruft 2016-06-30 18:50:25 -07:00
PHUITabView.php Build that thing someone posted a screenshot of on Facebook 2016-07-01 04:36:24 -07:00
PHUITagView.php Clarify that a PHUITagView API argument is boolean, not a value in "millimeters" 2018-03-16 13:11:06 -07:00
PHUITimelineEventView.php Fix specifications of some "Visual Only" elements 2019-02-13 12:26:28 -08:00
PHUITimelineView.php Clean up a couple more URI alter() calls 2019-02-15 14:07:17 -08:00
PHUITwoColumnView.php Update EditEngine pages to take a page header separate 2017-09-05 20:07:11 -07:00
PHUIWorkboardView.php Only prevent drag-scroll in the Y direction on workboards 2016-02-08 10:05:39 -08:00
PHUIWorkpanelView.php Expand scope of addActionItem in PHUIHeaderView 2016-03-04 18:35:05 -08:00