1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-13 00:56:15 +01:00
phorge-phorge/src/applications/differential
epriestley 36df39761e Create revisions into "Draft", publish them when builds finish
Summary:
Ref T2543. This doesn't stand alone since mail still goes out normally, but gets this piece working: new revisions start as "Draft", then after updates if there are no builds they go into "Needs Review".

This should work in general because builds update revisions when they complete, to publish a "Harbormaster finished build yada yada" transaction. So either we'll un-draft immediately, or un-draft after the last build finishes.

I'll hold this until the mail and some other stuff (like UI hints) are in slightly better shape since I think it's probably too rough on its own.

Test Plan: Created revisions locally, saw them un-draft after builds.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18628
2017-09-21 07:21:21 -07:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
application Update menu item names for Applications -> Favorites 2017-09-05 19:05:03 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Define Differential email action in terms of EditEngine 2017-01-02 13:25:45 -08:00
conduit Make legacy revision statuses from "differential.query" have type "string" again 2017-08-29 13:05:02 -07:00
config Convert "enum" and "string" config options to new modular option types 2017-06-27 12:13:15 -07:00
constants Add a "Draft" state for revisions, and action bucket support 2017-09-18 14:01:00 -07:00
controller Update major RefCursor callsites to work properly with RefPosition 2017-09-15 10:21:32 -07:00
customfield Prepare revision mail for the "Draft" status 2017-09-21 07:21:07 -07:00
doorkeeper Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator 2017-08-09 11:04:52 -07:00
edge Expose the commit/task/revision relationship edges to "edge.search" 2017-04-02 19:49:55 -07:00
editor Create revisions into "Draft", publish them when builds finish 2017-09-21 07:21:21 -07:00
engine Make yellow "draft" bubbles more generic 2017-01-13 09:02:19 -08:00
engineextension Provide a "Reviewers" attachment to "differential.revision.search" 2017-04-06 14:46:39 -07:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
field Move misplaced validation for ambiguous fields in "Test Plan" to the right place 2017-06-30 06:36:05 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
herald Fix "Author's projects" Herald rules for revisions and diffs 2017-09-15 17:59:49 -07:00
lipsum Rename "getReviewerStatus()" to "getReviewers()" 2017-03-20 17:11:40 -07:00
mail Rename "needReviewerStatus()" into "needReviewers()" 2017-03-20 16:46:16 -07:00
management Support storage of Differential hunk data in Files 2017-09-11 16:09:02 -07:00
parser Build a page for viewing all inline comments 2017-06-12 11:31:20 -07:00
phid Make all revision status readers explicitly read modern or legacy status 2017-08-11 17:22:22 -07:00
query Add a "Draft" state for revisions, and action bucket support 2017-09-18 14:01:00 -07:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Correct the generation of "<th />" IDs on left-hand-side of image changesets 2017-05-17 06:26:45 -07:00
search Reduce the amount of boilerplate that implementing FerretInterface requires 2017-09-07 13:23:31 -07:00
storage Prepare revision mail for the "Draft" status 2017-09-21 07:21:07 -07:00
typeahead Add a Differential revision status tokenizer datasource 2017-08-11 13:35:15 -07:00
view Remove a debugging "echo" that crept in in dccd799b 2017-08-11 05:50:43 -07:00
xaction Align most revision actions to the new "Draft" state 2017-09-21 07:20:48 -07:00
DifferentialGetWorkingCopy.php Extend from Phobject 2015-06-15 18:02:27 +10:00