1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications
Bob Trahan a81072046a Conpherence - fix policy bug on comments with files in rooms
Summary: Fixes T7840. Add some unit tests. One explicitly covers the case in T7840. Other cases are "base" cases for rooms and threads, plus the version if T7840 for a thread, where a policy exception should be thrown.

Test Plan: `arc unit` and was able to successfully add a file to a conpherence room i did not have edit permissions on

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7840

Differential Revision: https://secure.phabricator.com/D12443
2015-04-16 16:15:36 -07:00
..
almanac Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
aphlict/management Create the Aphlict PID directory 2015-02-28 21:53:10 +11:00
arcanist/conduit Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
audit Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
auth Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
base Remove getPagingColumn() / getReversePaging() 2015-04-13 11:58:32 -07:00
cache Fix two minor issues 2015-04-13 11:11:18 -07:00
calendar Clean up some more handle callsites 2015-04-09 16:15:13 -07:00
celerity Move base drop shadow into CelerityResourceTransformer 2015-04-14 09:48:59 -07:00
chatlog Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
conduit Drive conduit result ordering through Query order specifications 2015-04-13 11:58:37 -07:00
config Remove getPagingColumn() / getReversePaging() 2015-04-13 11:58:32 -07:00
conpherence Conpherence - fix policy bug on comments with files in rooms 2015-04-16 16:15:36 -07:00
console Revert "Minor change to suppress linter warning" 2015-04-07 09:05:31 +10:00
countdown Convert all tokenizers to take token/scalar inputs 2015-03-31 14:10:55 -07:00
daemon Fix two minor issues 2015-04-13 11:11:18 -07:00
dashboard Remove Controller->getHandle() and Controller->loadHandles() 2015-03-31 05:48:20 -07:00
differential Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
diffusion Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
diviner Add setEpoch for PHUIHeaderView, use in all Documents 2015-04-12 18:08:09 -07:00
doorkeeper Add "phabricator.silent" for stopping all outbound events from an install 2015-03-18 07:09:43 -07:00
draft/storage Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
drydock Allow applications to have multiple "help" menu items 2015-04-01 11:51:48 -07:00
fact Modernize Fact a bit 2015-03-03 13:48:30 -08:00
feed Replace getPagingValue() with cursor methods 2015-04-13 11:58:38 -07:00
files Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
flag Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
fund Subclass most ReplyHandlers from TransactionReplyHandler 2015-04-01 08:39:50 -07:00
harbormaster Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
help Allow applications to have multiple "help" menu items 2015-04-01 11:51:48 -07:00
herald Remove Herald rule edit log 2015-04-11 08:50:50 -07:00
home Allow applications to have multiple "help" menu items 2015-04-01 11:51:48 -07:00
legalpad Add setEpoch for PHUIHeaderView, use in all Documents 2015-04-12 18:08:09 -07:00
lipsum Minor tidying of lipsum generate workflow 2015-03-01 09:41:52 +11:00
macro Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
mailinglists Improve granluarity and defaults of security.allow-outbound-http 2015-03-23 10:44:03 -07:00
maniphest Replace getPagingValue() with cursor methods 2015-04-13 11:58:38 -07:00
meta Fix a fatal on the application list 2015-04-13 14:51:00 -07:00
metamta Remove trivial implementations of getPagingColumn() 2015-04-13 11:58:19 -07:00
notification Replace getPagingValue() with cursor methods 2015-04-13 11:58:38 -07:00
nuance Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
oauthserver Allow applications to have multiple "help" menu items 2015-04-01 11:51:48 -07:00
owners Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
passphrase Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
paste Add Mailtags to Paste 2015-04-13 15:30:59 -07:00
people Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
phame Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
phid Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
phlux Modernize Feed and Phlux ordering/paging 2015-04-13 11:58:22 -07:00
pholio Expose all application mail receivers 2015-04-01 11:52:02 -07:00
phortune Make taller tables the default for AphrontTableView 2015-04-08 08:38:15 -07:00
phpast Use PhutilXHPASTBinary methods 2015-02-03 06:59:16 +11:00
phragment Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
phrequent Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
phriction Move ToC in Phriction to it's own column 2015-04-14 16:02:30 -07:00
policy Fix some odd looking arrays 2015-04-05 22:29:39 +10:00
ponder Provide "builtin" high-level result orders 2015-04-13 11:58:34 -07:00
project Replace getPagingValue() with cursor methods 2015-04-13 11:58:38 -07:00
releeph Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
remarkup/conduit Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
repository Fix nonstandard specification of a constant 2015-04-14 14:44:21 -07:00
search T7827: Boost Elasticsearch results on title match. 2015-04-16 07:43:40 -07:00
settings Remove monospaced font preference global defaults 2015-04-06 08:08:53 -07:00
slowvote Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
subscriptions Implement a "!subscribe" mail command 2015-04-01 11:51:52 -07:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Fix visibility of PhutilArgumentWorkflow::didConstruct methods 2015-01-16 07:42:07 +11:00
tokens Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
transactions Conpherence - turn on mentions interface for Conpherence rooms / messages 2015-04-13 18:12:48 -07:00
typeahead Typeahead - filter typeaheads that the viewer can't see in typeahead debug tool 2015-04-06 15:24:58 -07:00
uiexample Add ability to have tooltips on buttons 2015-03-26 11:09:20 -07:00
xhprof Set device true on all XHProf pages 2015-03-05 08:45:51 -08:00